)]}'
{"keystoneclient/shell.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"78516ac1baec9989041899902b76f8cb78260bcc","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            subparser.add_argument(\u0027-h\u0027, \u0027--help\u0027, action\u003d\u0027help\u0027,"},{"line_number":300,"context_line":"                                   help\u003dargparse.SUPPRESS)"},{"line_number":301,"context_line":"            self.subcommands[command] \u003d subparser"},{"line_number":302,"context_line":"            group\u003dsubparser.add_argument_group(\u0027Arguments\u0027, None)"},{"line_number":303,"context_line":"            for (args, kwargs) in arguments:"},{"line_number":304,"context_line":"                group.add_argument(*args, **kwargs)"},{"line_number":305,"context_line":"            subparser.set_defaults(func\u003dcallback)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FeiU%3D","line":302,"updated":"2013-05-08 14:45:51.000000000","message":"I assume this is doing nothing more than changing the display from \"Optional arguments\" to \"Arguments\"? If so, I think that\u0027s fine, but they are still technically optional arguments in the sense that they are --options with \u003darguments\n\nYou may also want to contribute the a similar change to openstackclient","commit_id":"a976aa2686d2c1bfe79222c44374befa5b8ff966"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cfa3958d69363020052ce738553405e66001e6d1","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            subparser.add_argument(\u0027-h\u0027, \u0027--help\u0027, action\u003d\u0027help\u0027,"},{"line_number":300,"context_line":"                                   help\u003dargparse.SUPPRESS)"},{"line_number":301,"context_line":"            self.subcommands[command] \u003d subparser"},{"line_number":302,"context_line":"            group \u003d subparser.add_argument_group(\u0027Arguments\u0027, None)"},{"line_number":303,"context_line":"            for (args, kwargs) in arguments:"},{"line_number":304,"context_line":"                group.add_argument(*args, **kwargs)"},{"line_number":305,"context_line":"            subparser.set_defaults(func\u003dcallback)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2F4xc%3D","line":302,"updated":"2013-05-20 22:50:09.000000000","message":"use named arguments for named parameters, so this should be:\n\n group \u003d subparser.add_argument_group(title\u003d\u0027Arguments\u0027)\n\n(None is the default for the description)","commit_id":"8a7431eb9f74c243ccd6a1536f0cc74ef720ddf2"}],"keystoneclient/v2_0/shell.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"78516ac1baec9989041899902b76f8cb78260bcc","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cuser-name\u003e\u0027, required\u003dTrue,"},{"line_number":59,"context_line":"           help\u003d\u0027New user name (must be unique) (required)\u0027)"},{"line_number":60,"context_line":"@utils.arg(\u0027--tenant-id\u0027, metavar\u003d\u0027\u003ctenant-id\u003e\u0027,"},{"line_number":61,"context_line":"           help\u003d\u0027New user default tenant\u0027)"},{"line_number":62,"context_line":"@utils.arg(\u0027--tenant_id\u0027, help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FsKg%3D","line":59,"updated":"2013-05-08 14:45:51.000000000","message":"marking options like this is completely redundant with required\u003dTrue and I\u0027d strongly suggest undoing this change as it just creates unnecessary maintenance overhead moving forward","commit_id":"a976aa2686d2c1bfe79222c44374befa5b8ff966"}]}