)]}'
{"keystoneclient/tests/functional/v3/test_federation.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c00b6ab493f5b6829f2bc71c83aae4e9017394bc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        self._delete_idp_list()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def _delete_idp(self, idp_id):"},{"line_number":30,"context_line":"        self.client.federation.identity_providers.delete(idp_id)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _delete_idp_list(self):"},{"line_number":33,"context_line":"        for idp in self.idp_list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_50834998","line":30,"updated":"2016-03-28 14:18:27.000000000","message":"Do we want to add some error handling here to make sure the list was actually cleaned up?","commit_id":"f7a61272a0d558ba90731d31bbd1abbf5fdf33de"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"56ab7124d2d3c9291cc652269555f12b95217a5c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        self._delete_idp_list()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def _delete_idp(self, idp_id):"},{"line_number":30,"context_line":"        self.client.federation.identity_providers.delete(idp_id)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _delete_idp_list(self):"},{"line_number":33,"context_line":"        for idp in self.idp_list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_672c3cac","line":30,"in_reply_to":"da0c15f0_50834998","updated":"2016-03-28 17:16:05.000000000","message":"would make sense if we had a fallback option here, right? have any suggestions? Right now it is relying on the client to fail and display an error message when running the tests","commit_id":"f7a61272a0d558ba90731d31bbd1abbf5fdf33de"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c00b6ab493f5b6829f2bc71c83aae4e9017394bc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertEqual([], idp.remote_ids)"},{"line_number":44,"context_line":"        self.assertFalse(idp.enabled)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        # Create an enabled identity provider"},{"line_number":47,"context_line":"        idp_id \u003d uuid.uuid4().hex"},{"line_number":48,"context_line":"        idp \u003d self.client.federation.identity_providers.create("},{"line_number":49,"context_line":"            id\u003didp_id, enabled\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_904b2187","line":46,"updated":"2016-03-28 14:18:27.000000000","message":"This could be it\u0027s own test case.","commit_id":"f7a61272a0d558ba90731d31bbd1abbf5fdf33de"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"56ab7124d2d3c9291cc652269555f12b95217a5c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertEqual([], idp.remote_ids)"},{"line_number":44,"context_line":"        self.assertFalse(idp.enabled)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        # Create an enabled identity provider"},{"line_number":47,"context_line":"        idp_id \u003d uuid.uuid4().hex"},{"line_number":48,"context_line":"        idp \u003d self.client.federation.identity_providers.create("},{"line_number":49,"context_line":"            id\u003didp_id, enabled\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_2709a432","line":46,"in_reply_to":"da0c15f0_904b2187","updated":"2016-03-28 17:16:05.000000000","message":"Done","commit_id":"f7a61272a0d558ba90731d31bbd1abbf5fdf33de"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c00b6ab493f5b6829f2bc71c83aae4e9017394bc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.assertEqual([], idp.remote_ids)"},{"line_number":54,"context_line":"        self.assertTrue(idp.enabled)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # Create an enabled identity provider with remote IDs"},{"line_number":57,"context_line":"        idp_id \u003d uuid.uuid4().hex"},{"line_number":58,"context_line":"        remote_ids \u003d [uuid.uuid4().hex, uuid.uuid4().hex]"},{"line_number":59,"context_line":"        idp \u003d self.client.federation.identity_providers.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_b048e588","line":56,"updated":"2016-03-28 14:18:27.000000000","message":"This could be it\u0027s own test case.","commit_id":"f7a61272a0d558ba90731d31bbd1abbf5fdf33de"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"56ab7124d2d3c9291cc652269555f12b95217a5c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.assertEqual([], idp.remote_ids)"},{"line_number":54,"context_line":"        self.assertTrue(idp.enabled)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # Create an enabled identity provider with remote IDs"},{"line_number":57,"context_line":"        idp_id \u003d uuid.uuid4().hex"},{"line_number":58,"context_line":"        remote_ids \u003d [uuid.uuid4().hex, uuid.uuid4().hex]"},{"line_number":59,"context_line":"        idp \u003d self.client.federation.identity_providers.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_d2fea404","line":56,"in_reply_to":"da0c15f0_b048e588","updated":"2016-03-28 17:16:05.000000000","message":"Done","commit_id":"f7a61272a0d558ba90731d31bbd1abbf5fdf33de"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c00b6ab493f5b6829f2bc71c83aae4e9017394bc","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        list_after \u003d self.client.federation.identity_providers.list()"},{"line_number":81,"context_line":"        list_after_length \u003d len(list_after)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.assertEqual(list_before_length + 2, list_after_length)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_idp_get(self):"},{"line_number":86,"context_line":"        idp_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_ab0d1439","line":83,"updated":"2016-03-28 14:18:27.000000000","message":"Could this be simplified to: \n\n    self.assertEqual(2, list_after_length)\n\nIs there ever a time when the assertion needs to be dynamic?","commit_id":"f7a61272a0d558ba90731d31bbd1abbf5fdf33de"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"56ab7124d2d3c9291cc652269555f12b95217a5c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        list_after \u003d self.client.federation.identity_providers.list()"},{"line_number":81,"context_line":"        list_after_length \u003d len(list_after)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.assertEqual(list_before_length + 2, list_after_length)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_idp_get(self):"},{"line_number":86,"context_line":"        idp_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_323e00b9","line":83,"in_reply_to":"da0c15f0_ab0d1439","updated":"2016-03-28 17:16:05.000000000","message":"for most of cases, no... but we can\u0027t make assumptions about the environment where the tests are running (won\u0027t be always a fresh devstack setup), that\u0027s the reason to have the check like this","commit_id":"f7a61272a0d558ba90731d31bbd1abbf5fdf33de"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c00b6ab493f5b6829f2bc71c83aae4e9017394bc","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.assertEqual(list_before_length + 2, list_after_length)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_idp_get(self):"},{"line_number":86,"context_line":"        idp_id \u003d uuid.uuid4().hex"},{"line_number":87,"context_line":"        remote_ids \u003d [uuid.uuid4().hex, uuid.uuid4().hex]"},{"line_number":88,"context_line":"        idp_create \u003d self.client.federation.identity_providers.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_cb2168a1","line":85,"updated":"2016-03-28 14:18:27.000000000","message":"Nice test.","commit_id":"f7a61272a0d558ba90731d31bbd1abbf5fdf33de"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c00b6ab493f5b6829f2bc71c83aae4e9017394bc","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.assertRaises("},{"line_number":110,"context_line":"            http.NotFound,"},{"line_number":111,"context_line":"            self.client.federation.identity_providers.get,"},{"line_number":112,"context_line":"            idp_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_6b513c0e","line":112,"updated":"2016-03-28 14:18:27.000000000","message":"We could add another assertion here checking that we don\u0027t get idp_id back when we list the Identity Providers from keystone.","commit_id":"f7a61272a0d558ba90731d31bbd1abbf5fdf33de"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"56ab7124d2d3c9291cc652269555f12b95217a5c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.assertRaises("},{"line_number":110,"context_line":"            http.NotFound,"},{"line_number":111,"context_line":"            self.client.federation.identity_providers.get,"},{"line_number":112,"context_line":"            idp_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_126e5cc9","line":112,"in_reply_to":"da0c15f0_6b513c0e","updated":"2016-03-28 17:16:05.000000000","message":"Done","commit_id":"f7a61272a0d558ba90731d31bbd1abbf5fdf33de"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"821394907cd5b13f7004d0d9e58b5241b283a363","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import uuid"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from keystoneauth1.exceptions import http"},{"line_number":16,"context_line":"from keystoneclient.tests.functional import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class TestIdentityProviders(base.V3ClientTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_82561fcc","line":16,"updated":"2016-04-19 14:18:06.000000000","message":"this is from the project so should be in a separate section.","commit_id":"6488f9952272650cedc41d0c1f19738f6df726d8"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"06bab75d05d7a5b7701b1cfe70cd2af1a7aa0561","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import uuid"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from keystoneauth1.exceptions import http"},{"line_number":16,"context_line":"from keystoneclient.tests.functional import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class TestIdentityProviders(base.V3ClientTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_c44b112a","line":16,"in_reply_to":"1a122d0e_82561fcc","updated":"2016-04-25 19:36:16.000000000","message":"Done","commit_id":"6488f9952272650cedc41d0c1f19738f6df726d8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"821394907cd5b13f7004d0d9e58b5241b283a363","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    def test_idp_create(self):"},{"line_number":22,"context_line":"        idp_id \u003d uuid.uuid4().hex"},{"line_number":23,"context_line":"        # Create an identity provider just passing an ID"},{"line_number":24,"context_line":"        idp \u003d self.client.federation.identity_providers.create(id\u003didp_id)"},{"line_number":25,"context_line":"        self.addCleanup("},{"line_number":26,"context_line":"            self.client.federation.identity_providers.delete, idp_id)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_a2c99b5b","line":24,"updated":"2016-04-19 14:18:06.000000000","message":"According to the docs this function doesn\u0027t return anything - http://docs.openstack.org/developer/python-keystoneclient/api/keystoneclient.v3.contrib.federation.html#keystoneclient.v3.contrib.federation.identity_providers.IdentityProviderManager.create","commit_id":"6488f9952272650cedc41d0c1f19738f6df726d8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"821394907cd5b13f7004d0d9e58b5241b283a363","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        # Create an identity provider just passing an ID"},{"line_number":24,"context_line":"        idp \u003d self.client.federation.identity_providers.create(id\u003didp_id)"},{"line_number":25,"context_line":"        self.addCleanup("},{"line_number":26,"context_line":"            self.client.federation.identity_providers.delete, idp_id)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        self.assertEqual(idp_id, idp.id)"},{"line_number":29,"context_line":"        self.assertEqual([], idp.remote_ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_625dc378","line":26,"updated":"2016-04-19 14:18:06.000000000","message":"According to the docs the argument to identity_providers.delete is \"an object with identity_provider_id stored inside\", not a str.","commit_id":"6488f9952272650cedc41d0c1f19738f6df726d8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"821394907cd5b13f7004d0d9e58b5241b283a363","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        idp_id \u003d uuid.uuid4().hex"},{"line_number":47,"context_line":"        remote_ids \u003d [uuid.uuid4().hex, uuid.uuid4().hex]"},{"line_number":48,"context_line":"        idp \u003d self.client.federation.identity_providers.create("},{"line_number":49,"context_line":"            id\u003didp_id, enabled\u003dTrue, remote_ids\u003dremote_ids)"},{"line_number":50,"context_line":"        self.addCleanup("},{"line_number":51,"context_line":"            self.client.federation.identity_providers.delete, idp_id)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_22190bd8","line":49,"updated":"2016-04-19 14:18:06.000000000","message":"According to the docs the only argument to identity_providers.create is the id.\n\nhttp://docs.openstack.org/developer/python-keystoneclient/api/keystoneclient.v3.contrib.federation.html#keystoneclient.v3.contrib.federation.identity_providers.IdentityProviderManager.delete","commit_id":"6488f9952272650cedc41d0c1f19738f6df726d8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"821394907cd5b13f7004d0d9e58b5241b283a363","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                self.client.federation.identity_providers.delete, idp_id)"},{"line_number":65,"context_line":"            idp_ids.append(idp_id)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        idp_list \u003d self.client.federation.identity_providers.list()"},{"line_number":68,"context_line":"        fetched_ids \u003d [fetched_idp.id for fetched_idp in idp_list]"},{"line_number":69,"context_line":"        for idp_id in idp_ids:"},{"line_number":70,"context_line":"            self.assertIn(idp_id, fetched_ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_0205ef12","line":67,"updated":"2016-04-19 14:18:06.000000000","message":"According to the docs, list doesn\u0027t return anything.\n\nhttp://docs.openstack.org/developer/python-keystoneclient/api/keystoneclient.v3.contrib.federation.html#keystoneclient.v3.contrib.federation.identity_providers.IdentityProviderManager.list","commit_id":"6488f9952272650cedc41d0c1f19738f6df726d8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"821394907cd5b13f7004d0d9e58b5241b283a363","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self.addCleanup("},{"line_number":78,"context_line":"            self.client.federation.identity_providers.delete, idp_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        idp_get \u003d self.client.federation.identity_providers.get(idp_id)"},{"line_number":81,"context_line":"        self.assertEqual(idp_create.id, idp_get.id)"},{"line_number":82,"context_line":"        self.assertEqual(idp_create.enabled, idp_get.enabled)"},{"line_number":83,"context_line":"        self.assertIn(idp_create.remote_ids[0], idp_get.remote_ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_02804f8a","line":80,"updated":"2016-04-19 14:18:06.000000000","message":"According to the docs the argument to identity_providers.get is \"an object with identity_provider_id stored inside.\"\n\nhttp://docs.openstack.org/developer/python-keystoneclient/api/keystoneclient.v3.contrib.federation.html#keystoneclient.v3.contrib.federation.identity_providers.IdentityProviderManager.get","commit_id":"6488f9952272650cedc41d0c1f19738f6df726d8"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e2952206ef9d08145564507b31115636287e6e83","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                self.client.federation.identity_providers.delete, idp_id)"},{"line_number":66,"context_line":"            idp_ids.append(idp_id)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        idp_list \u003d self.client.federation.identity_providers.list()"},{"line_number":69,"context_line":"        fetched_ids \u003d [fetched_idp.id for fetched_idp in idp_list]"},{"line_number":70,"context_line":"        for idp_id in idp_ids:"},{"line_number":71,"context_line":"            self.assertIn(idp_id, fetched_ids)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_8c07cd80","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":16},"updated":"2016-05-03 06:06:41.000000000","message":"assert the size of idp_list","commit_id":"f663c66c103b44c9d1b2b94f46f753e8db73804d"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"07b7be1df46229feccf8f2a2174931e07a96aae5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                self.client.federation.identity_providers.delete, idp_id)"},{"line_number":66,"context_line":"            idp_ids.append(idp_id)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        idp_list \u003d self.client.federation.identity_providers.list()"},{"line_number":69,"context_line":"        fetched_ids \u003d [fetched_idp.id for fetched_idp in idp_list]"},{"line_number":70,"context_line":"        for idp_id in idp_ids:"},{"line_number":71,"context_line":"            self.assertIn(idp_id, fetched_ids)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_958d092d","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":16},"in_reply_to":"1a122d0e_8c07cd80","updated":"2016-05-03 11:59:46.000000000","message":"I chose to not assert the size because we might be running in a non clear devstack env, so we would need to fetch the size before and assert the difference after the new ones.","commit_id":"f663c66c103b44c9d1b2b94f46f753e8db73804d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"a941c7a01a7aff8109f98d496ac575fa153c7e9d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                self.client.federation.identity_providers.delete, idp_id)"},{"line_number":66,"context_line":"            idp_ids.append(idp_id)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        idp_list \u003d self.client.federation.identity_providers.list()"},{"line_number":69,"context_line":"        fetched_ids \u003d [fetched_idp.id for fetched_idp in idp_list]"},{"line_number":70,"context_line":"        for idp_id in idp_ids:"},{"line_number":71,"context_line":"            self.assertIn(idp_id, fetched_ids)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_2a09cb31","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":16},"in_reply_to":"1a122d0e_958d092d","updated":"2016-05-05 13:44:56.000000000","message":"I agree that asserting length could cause tests to break for unrelated reasons.","commit_id":"f663c66c103b44c9d1b2b94f46f753e8db73804d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"a941c7a01a7aff8109f98d496ac575fa153c7e9d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            self.client.federation.identity_providers.delete, idp_id)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        idp_get \u003d self.client.federation.identity_providers.get(idp_id)"},{"line_number":82,"context_line":"        self.assertEqual(idp_create.id, idp_get.id)"},{"line_number":83,"context_line":"        self.assertEqual(idp_create.enabled, idp_get.enabled)"},{"line_number":84,"context_line":"        self.assertIn(idp_create.remote_ids[0], idp_get.remote_ids)"},{"line_number":85,"context_line":"        self.assertIn(idp_create.remote_ids[1], idp_get.remote_ids)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_9bbaef09","line":82,"updated":"2016-05-05 13:44:56.000000000","message":"Instead of all of these assertions is it would be nice idp_create could be compared against idp_get, but i\u0027m not sure that the magic methods have been implemented.","commit_id":"f663c66c103b44c9d1b2b94f46f753e8db73804d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"a941c7a01a7aff8109f98d496ac575fa153c7e9d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.client.federation.identity_providers.get,"},{"line_number":101,"context_line":"            idp_id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Should not be present in the identity provider list"},{"line_number":104,"context_line":"        idp_list \u003d self.client.federation.identity_providers.list()"},{"line_number":105,"context_line":"        fetched_ids \u003d [fetched_idp.id for fetched_idp in idp_list]"},{"line_number":106,"context_line":"        self.assertNotIn(idp_id, fetched_ids)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_9b166ff0","line":103,"updated":"2016-05-05 13:44:56.000000000","message":"This part of the test is probably overkill. We don\u0027t really need to test that get and list get their data from the same place.","commit_id":"f663c66c103b44c9d1b2b94f46f753e8db73804d"}]}