)]}'
{"id":"openstack%2Fpython-keystoneclient~30174","triplet_id":"openstack%2Fpython-keystoneclient~master~I1fe2c9e5cdf275df2047018368da2e4b3d2d6de2","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1183072","hashtags":[],"change_id":"I1fe2c9e5cdf275df2047018368da2e4b3d2d6de2","subject":"Fix optional keyring support, add basic keyring tests","status":"MERGED","created":"2013-05-22 22:10:34.000000000","updated":"2013-06-13 08:08:22.000000000","submitted":"2013-06-13 08:08:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":30,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b2e9e81a2dc97dd60008c719acd867517087378b","_number":30174,"virtual_id_number":30174,"owner":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-06-13 08:08:22.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2013-06-11 00:09:39.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":1,"date":"2013-06-13 07:24:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":2,"date":"2013-06-10 18:36:46.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":1,"date":"2013-06-11 00:12:13.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"date":"2013-06-10 18:36:46.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-24 16:35:19.000000000","updated_by":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"reviewer":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"state":"REVIEWER"},{"updated":"2013-05-28 22:31:23.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-06-03 20:31:46.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2013-06-03 20:31:57.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2013-06-10 18:36:46.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2013-06-11 00:12:13.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2013-06-13 07:24:57.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2013-06-13 08:08:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6d0b5f334855457f32dc5e5de2e6e982c252a0d5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-22 23:01:36.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30174/1/check/gate-python-keystoneclient-requirements/26 : SUCCESS in 4s\n- http://logs.openstack.org/30174/1/check/gate-python-keystoneclient-pep8/1084 : SUCCESS in 48s\n- http://docs-draft.openstack.org/30174/1/check/gate-python-keystoneclient-docs/935/doc/build/html/ : SUCCESS in 54s\n- http://logs.openstack.org/30174/1/check/gate-python-keystoneclient-python26/1008 : SUCCESS in 58s\n- http://logs.openstack.org/30174/1/check/gate-python-keystoneclient-python27/1011 : SUCCESS in 55s\n- http://logs.openstack.org/30174/1/check/gate-tempest-devstack-vm-full/17868 : SUCCESS in 50m 03s\n- http://logs.openstack.org/30174/1/check/gate-tempest-devstack-vm-postgres-full/17578 : FAILURE in 44m 57s (non-voting)\n- http://logs.openstack.org/30174/1/check/gate-tempest-devstack-vm-quantum/24582 : SUCCESS in 22m 01s\n- http://logs.openstack.org/30174/1/check/gate-grenade-devstack-vm/5371 : FAILURE in 11m 21s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"ca047de247104fda1fe0f939cea49f94013a3664","author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"date":"2013-05-24 16:35:19.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"4b2566b731a1a9315be79c0fcedf5899a0829ad2","author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"date":"2013-05-24 19:21:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"845eccc4839dbb257c45241016a442f8c830be41","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-24 20:11:28.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30174/2/check/gate-python-keystoneclient-pep8/1087 : SUCCESS in 50s\n- http://docs-draft.openstack.org/30174/2/check/gate-python-keystoneclient-docs/938/doc/build/html/ : SUCCESS in 47s\n- http://logs.openstack.org/30174/2/check/gate-python-keystoneclient-python26/1011 : SUCCESS in 1m 00s\n- http://logs.openstack.org/30174/2/check/gate-python-keystoneclient-python27/1014 : SUCCESS in 57s\n- http://logs.openstack.org/30174/2/check/gate-tempest-devstack-vm-full/18420 : SUCCESS in 49m 50s\n- http://logs.openstack.org/30174/2/check/gate-tempest-devstack-vm-postgres-full/18130 : FAILURE in 44m 58s (non-voting)\n- http://logs.openstack.org/30174/2/check/gate-tempest-devstack-vm-quantum/25200 : SUCCESS in 20m 43s\n- http://logs.openstack.org/30174/2/check/gate-grenade-devstack-vm/5874 : FAILURE in 17m 07s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"85fcd7d6b01cf6191469fd68c874cbf99a48b22e","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-05-30 04:22:44.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nnits","accounts_in_message":[],"_revision_number":2},{"id":"09a4d0c47f1a5235e2d3efafe3c522e9fac30da0","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-05-30 17:33:48.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(6 inline comments)\n\nvery much agree with Jamie","accounts_in_message":[],"_revision_number":2},{"id":"092854155fd41098dd9030c6103a20fc22be33ca","author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"date":"2013-05-30 19:03:10.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2283e5c901ec45295a9c53e408b1bbc97881ba72","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-05-30 19:19:10.000000000","message":"Patch Set 3:\n\nLooks good.  A note to reviewers to make sure that the test actually gets executed before approving, as it checks for keyring being installed and opts out if it is not.  This means that the tests may not be executed via Jenkins.","accounts_in_message":[],"_revision_number":3},{"id":"2549d268cad0093b9ee90482ba8fdad4d48ac18c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-30 19:48:48.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/30174/3/check/gate-python-keystoneclient-pep8/1119 : SUCCESS in 51s\n- http://docs-draft.openstack.org/30174/3/check/gate-python-keystoneclient-docs/970/doc/build/html/ : SUCCESS in 1m 02s\n- http://logs.openstack.org/30174/3/check/gate-python-keystoneclient-python26/1043 : SUCCESS in 1m 05s\n- http://logs.openstack.org/30174/3/check/gate-python-keystoneclient-python27/1046 : SUCCESS in 1m 00s\n- http://logs.openstack.org/30174/3/check/gate-tempest-devstack-vm-full/19476 : SUCCESS in 43m 53s\n- http://logs.openstack.org/30174/3/check/gate-tempest-devstack-vm-postgres-full/19184 : FAILURE in 45m 19s (non-voting)\n- http://logs.openstack.org/30174/3/check/gate-tempest-devstack-vm-quantum/26392 : FAILURE in 25m 09s\n- http://logs.openstack.org/30174/3/check/gate-grenade-devstack-vm/6890 : SUCCESS in 13m 37s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"5ba051b20f566cb314c952c1c8fd3d60c0007f5d","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-05-31 18:56:41.000000000","message":"Patch Set 3:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":3},{"id":"dd6da03b087ab04eb7de3ecedf9c053da64e9460","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-31 19:48:34.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/30174/3/check/gate-python-keystoneclient-pep8/1134 : FAILURE in 49s\n- http://docs-draft.openstack.org/30174/3/check/gate-python-keystoneclient-docs/985/doc/build/html/ : SUCCESS in 53s\n- http://logs.openstack.org/30174/3/check/gate-python-keystoneclient-python26/1058 : SUCCESS in 57s\n- http://logs.openstack.org/30174/3/check/gate-python-keystoneclient-python27/1061 : SUCCESS in 52s\n- http://logs.openstack.org/30174/3/check/gate-tempest-devstack-vm-full/19801 : SUCCESS in 40m 41s\n- http://logs.openstack.org/30174/3/check/gate-tempest-devstack-vm-postgres-full/19508 : FAILURE in 51m 37s (non-voting)\n- http://logs.openstack.org/30174/3/check/gate-tempest-devstack-vm-quantum/26762 : SUCCESS in 20m 37s\n- http://logs.openstack.org/30174/3/check/gate-grenade-devstack-vm/7203 : SUCCESS in 13m 33s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"0375ee1abd1fb57c2a941132bfdd81af609d0724","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-05-31 20:03:45.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nrun  flake8\n./build/lib/keystoneclient/shell.py:206:19: E702 multiple statements on one line (semicolon)\n        import pdb; pdb.break();\n                  ^\n./build/lib/keystoneclient/shell.py:206:30: E901 SyntaxError: invalid syntax\n        import pdb; pdb.break();\n                             ^\nDebugging needs to be removed","accounts_in_message":[],"_revision_number":3},{"id":"6d1122966887a5fbb7013a73422bddf90efd3914","author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"date":"2013-05-31 20:45:35.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f197b1ffb1ce104ed873e24be2165af50425d618","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-31 21:37:53.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/30174/4/check/gate-python-keystoneclient-pep8/1136 : SUCCESS in 47s\n- http://docs-draft.openstack.org/30174/4/check/gate-python-keystoneclient-docs/987/doc/build/html/ : SUCCESS in 52s\n- http://logs.openstack.org/30174/4/check/gate-python-keystoneclient-python26/1060 : SUCCESS in 58s\n- http://logs.openstack.org/30174/4/check/gate-python-keystoneclient-python27/1063 : SUCCESS in 53s\n- http://logs.openstack.org/30174/4/check/gate-tempest-devstack-vm-full/19824 : SUCCESS in 47m 13s\n- http://logs.openstack.org/30174/4/check/gate-tempest-devstack-vm-postgres-full/19531 : FAILURE in 52m 06s (non-voting)\n- http://logs.openstack.org/30174/4/check/gate-tempest-devstack-vm-quantum/26786 : FAILURE in 44m 12s\n- http://logs.openstack.org/30174/4/check/gate-grenade-devstack-vm/7220 : SUCCESS in 14m 20s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"57d81d3db05f077c027bebd70a1e7b606327b5e0","author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"date":"2013-05-31 21:47:56.000000000","message":"Patch Set 4:\n\nrecheck bug 1182679","accounts_in_message":[],"_revision_number":4},{"id":"46c67344c4eb4aa2929541e5fad1ffc12e3dce27","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-31 22:34:22.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30174/4/check/gate-python-keystoneclient-pep8/1137 : SUCCESS in 48s\n- http://docs-draft.openstack.org/30174/4/check/gate-python-keystoneclient-docs/988/doc/build/html/ : SUCCESS in 52s\n- http://logs.openstack.org/30174/4/check/gate-python-keystoneclient-python26/1061 : SUCCESS in 59s\n- http://logs.openstack.org/30174/4/check/gate-python-keystoneclient-python27/1064 : SUCCESS in 55s\n- http://logs.openstack.org/30174/4/check/gate-tempest-devstack-vm-full/19834 : SUCCESS in 46m 15s\n- http://logs.openstack.org/30174/4/check/gate-tempest-devstack-vm-postgres-full/19541 : FAILURE in 45m 49s (non-voting)\n- http://logs.openstack.org/30174/4/check/gate-tempest-devstack-vm-quantum/26797 : SUCCESS in 18m 46s\n- http://logs.openstack.org/30174/4/check/gate-grenade-devstack-vm/7229 : SUCCESS in 14m 17s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"377762db97448caa787ab2c23a777605e96b5f3e","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-05-31 23:38:33.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"1a0a569c9590158cac796bd71945f3e3ff8ad100","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-06-03 00:16:14.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(6 inline comments)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"7ee0b38f6fdaa98146a1f58991bddafb03086c8c","author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"date":"2013-06-03 14:35:20.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"d1c611842c71b16ac52c195daef576de642895cf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-03 15:24:06.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30174/5/check/gate-python-keystoneclient-pep8/1149 : SUCCESS in 56s\n- http://docs-draft.openstack.org/30174/5/check/gate-python-keystoneclient-docs/1000/doc/build/html/ : SUCCESS in 57s\n- http://logs.openstack.org/30174/5/check/gate-python-keystoneclient-python26/1073 : SUCCESS in 1m 02s\n- http://logs.openstack.org/30174/5/check/gate-python-keystoneclient-python27/1076 : SUCCESS in 57s\n- http://logs.openstack.org/30174/5/check/gate-tempest-devstack-vm-full/20069 : SUCCESS in 48m 35s\n- http://logs.openstack.org/30174/5/check/gate-tempest-devstack-vm-postgres-full/19776 : FAILURE in 47m 42s (non-voting)\n- http://logs.openstack.org/30174/5/check/gate-tempest-devstack-vm-quantum/27069 : SUCCESS in 20m 27s\n- http://logs.openstack.org/30174/5/check/gate-grenade-devstack-vm/7451 : SUCCESS in 13m 14s (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"101682d43bb434214e46c7a32b4b086bf4b24062","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-06-03 16:07:50.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"fe92c861f828cb1f60a560e4cd776f7679ab9910","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-06-04 04:22:18.000000000","message":"Patch Set 5: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"cd7e1e2cdfc4f6856345d313da401cf9a6d5e071","author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"date":"2013-06-04 15:45:03.000000000","message":"Patch Set 5: (3 inline comments)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"e17d44f97e3339a4940ac4169a4024f366b2f366","author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"date":"2013-06-04 15:45:29.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"ef2cecc54dedd8575bcf9f4337170ae381810730","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-04 16:49:23.000000000","message":"Patch Set 6: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/30174/6/check/gate-python-keystoneclient-pep8/1160 : FAILURE in 1m 01s\n- http://docs-draft.openstack.org/30174/6/check/gate-python-keystoneclient-docs/1011/doc/build/html/ : SUCCESS in 1m 21s\n- http://logs.openstack.org/30174/6/check/gate-python-keystoneclient-python26/1084 : SUCCESS in 2m 09s\n- http://logs.openstack.org/30174/6/check/gate-python-keystoneclient-python27/1087 : SUCCESS in 1m 12s\n- http://logs.openstack.org/30174/6/check/gate-tempest-devstack-vm-full/20383 : SUCCESS in 49m 44s\n- http://logs.openstack.org/30174/6/check/gate-tempest-devstack-vm-postgres-full/20090 : FAILURE in 56m 56s (non-voting)\n- http://logs.openstack.org/30174/6/check/gate-tempest-devstack-vm-quantum/27411 : FAILURE in 28m 52s\n- http://logs.openstack.org/30174/6/check/gate-grenade-devstack-vm/7746 : SUCCESS in 16m 48s (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"123d991dc6baf55a34670391a900f516351de14d","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-06-04 23:54:45.000000000","message":"Patch Set 5: (2 inline comments)\n\nHonestly for the tests this is probably overly pedantic.","accounts_in_message":[],"_revision_number":5},{"id":"2bf73d08c9a18d831f362a67b2693c562f5f4914","author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"date":"2013-06-05 14:13:51.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"78ee9ea296e7fb77cd77e626f62fe3ff5456e7f9","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-06-05 14:31:11.000000000","message":"Patch Set 7: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"c2af4a751fb8422308099933c73c1b261b5b52f3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-05 15:03:35.000000000","message":"Patch Set 7: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/30174/7/check/gate-python-keystoneclient-pep8/1162 : FAILURE in 1m 12s\n- http://docs-draft.openstack.org/30174/7/check/gate-python-keystoneclient-docs/1013/doc/build/html/ : SUCCESS in 1m 08s\n- http://logs.openstack.org/30174/7/check/gate-python-keystoneclient-python26/1086 : SUCCESS in 1m 26s\n- http://logs.openstack.org/30174/7/check/gate-python-keystoneclient-python27/1089 : SUCCESS in 1m 01s\n- http://logs.openstack.org/30174/7/check/gate-tempest-devstack-vm-full/20723 : SUCCESS in 43m 40s\n- http://logs.openstack.org/30174/7/check/gate-tempest-devstack-vm-postgres-full/20430 : SUCCESS in 49m 05s (non-voting)\n- http://logs.openstack.org/30174/7/check/gate-tempest-devstack-vm-quantum/27780 : SUCCESS in 19m 26s\n- http://logs.openstack.org/30174/7/check/gate-grenade-devstack-vm/8073 : FAILURE in 17m 16s (non-voting)\n","accounts_in_message":[],"_revision_number":7},{"id":"28fb7be4b26a8d32e9e8175a0a2a9e0ff9732636","author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"date":"2013-06-06 18:28:36.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"ee01a57294bf042e010e1ac4741d84a1b0400cdc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-06 19:23:30.000000000","message":"Patch Set 8: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30174/8/check/gate-python-keystoneclient-pep8/1170 : SUCCESS in 1m 02s\n- http://docs-draft.openstack.org/30174/8/check/gate-python-keystoneclient-docs/1021/doc/build/html/ : SUCCESS in 1m 09s\n- http://logs.openstack.org/30174/8/check/gate-python-keystoneclient-python26/1094 : SUCCESS in 2m 26s\n- http://logs.openstack.org/30174/8/check/gate-python-keystoneclient-python27/1097 : SUCCESS in 1m 49s\n- http://logs.openstack.org/30174/8/check/gate-tempest-devstack-vm-full/21143 : SUCCESS in 44m 24s\n- http://logs.openstack.org/30174/8/check/gate-tempest-devstack-vm-postgres-full/20850 : SUCCESS in 54m 24s (non-voting)\n- http://logs.openstack.org/30174/8/check/gate-tempest-devstack-vm-quantum/28235 : SUCCESS in 21m 59s\n- http://logs.openstack.org/30174/8/check/gate-grenade-devstack-vm/8462 : SUCCESS in 16m 37s (non-voting)\n","accounts_in_message":[],"_revision_number":8},{"id":"baa9cc9d7791caa92c171b3443a20a225c4748ab","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-06-06 23:54:28.000000000","message":"Patch Set 8: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":8},{"id":"58f8639d7b9f2f51267a9d9a5b40db36cf2536a4","author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"date":"2013-06-07 18:29:53.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"3de2da67c3a54691f59dae4b2cf2f88b15ecc877","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-07 19:18:40.000000000","message":"Patch Set 9: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30174/9/check/gate-python-keystoneclient-pep8/1173 : SUCCESS in 52s\n- http://docs-draft.openstack.org/30174/9/check/gate-python-keystoneclient-docs/1024/doc/build/html/ : SUCCESS in 57s\n- http://logs.openstack.org/30174/9/check/gate-python-keystoneclient-python26/1097 : SUCCESS in 1m 53s\n- http://logs.openstack.org/30174/9/check/gate-python-keystoneclient-python27/1100 : SUCCESS in 57s\n- http://logs.openstack.org/30174/9/check/gate-tempest-devstack-vm-full/21502 : SUCCESS in 48m 13s\n- http://logs.openstack.org/30174/9/check/gate-tempest-devstack-vm-postgres-full/21209 : SUCCESS in 43m 16s\n- http://logs.openstack.org/30174/9/check/gate-tempest-devstack-vm-quantum/28635 : SUCCESS in 17m 01s\n- http://logs.openstack.org/30174/9/check/gate-grenade-devstack-vm/8778 : FAILURE in 16m 43s (non-voting)\n","accounts_in_message":[],"_revision_number":9},{"id":"8e9f40322637863c03f9710500ee02e79d6d0e70","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-06-08 02:51:26.000000000","message":"Patch Set 9: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":9},{"id":"619169c26dcb483b16d08918c970269b4e895a17","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-06-09 16:51:59.000000000","message":"Patch Set 9: I would prefer that you didn\u0027t merge this\n\n(4 inline comments)\n\na few nits, otherwise looks good.","accounts_in_message":[],"_revision_number":9},{"id":"8b11188013c80b7067504d4bfbc1b8ba4c3d6ac3","author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"date":"2013-06-10 15:35:22.000000000","message":"Patch Set 9: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":9},{"id":"2c03241d3e2f4dc866e831a87629af98371f2a75","author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"date":"2013-06-10 17:18:04.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"d9f3b93d66c9b48c42ab6c8a12d9443e0d5d52cc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-10 18:21:54.000000000","message":"Patch Set 10: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30174/10/check/gate-python-keystoneclient-pep8/1183 : SUCCESS in 1m 12s\n- http://docs-draft.openstack.org/30174/10/check/gate-python-keystoneclient-docs/1034/doc/build/html/ : SUCCESS in 1m 14s\n- http://logs.openstack.org/30174/10/check/gate-python-keystoneclient-python26/1107 : SUCCESS in 2m 10s\n- http://logs.openstack.org/30174/10/check/gate-python-keystoneclient-python27/1110 : SUCCESS in 56s\n- http://logs.openstack.org/30174/10/check/gate-tempest-devstack-vm-full/21968 : SUCCESS in 44m 58s\n- http://logs.openstack.org/30174/10/check/gate-tempest-devstack-vm-postgres-full/21675 : SUCCESS in 56m 07s\n- http://logs.openstack.org/30174/10/check/gate-tempest-devstack-vm-quantum/29180 : SUCCESS in 18m 55s\n- http://logs.openstack.org/30174/10/check/gate-grenade-devstack-vm/9157 : SUCCESS in 14m 17s (non-voting)\n","accounts_in_message":[],"_revision_number":10},{"id":"6d3d356a09061503e3a791f394f3ebebe56bd525","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-06-10 18:36:46.000000000","message":"Patch Set 10: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":10},{"id":"fb98aa440b779ba6db07d066808dcc2aa2107177","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-06-11 00:09:39.000000000","message":"Patch Set 10: Looks good to me (core reviewer)\n\nmy comments were addressed. Thanks!","accounts_in_message":[],"_revision_number":10},{"id":"56a26d73e72b8a1c98623e78660712158a6bbd24","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-06-11 00:12:13.000000000","message":"Patch Set 10: Approved\n\nI think everyone else\u0027s comments were addressed, too.","accounts_in_message":[],"_revision_number":10},{"id":"ce2e8132c0d0c1d6a60a90baa9623092fcaa2e66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-11 00:12:15.000000000","message":"Patch Set 10: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":10},{"id":"cd1da6a4e8189d7cdcdcb80b8d8bf96df6a98c68","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-11 01:45:11.000000000","message":"Patch Set 10: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://docs-draft.openstack.org/30174/10/gate/gate-python-keystoneclient-docs/1040/doc/build/html/ : SUCCESS in 1m 14s\n- http://logs.openstack.org/30174/10/gate/gate-python-keystoneclient-pep8/1189 : SUCCESS in 1m 08s\n- http://logs.openstack.org/30174/10/gate/gate-python-keystoneclient-python26/1113 : SUCCESS in 1m 46s\n- http://logs.openstack.org/30174/10/gate/gate-python-keystoneclient-python27/1116 : SUCCESS in 1m 11s\n- http://logs.openstack.org/30174/10/gate/gate-tempest-devstack-vm-full/22089 : SUCCESS in 46m 37s\n- http://logs.openstack.org/30174/10/gate/gate-tempest-devstack-vm-postgres-full/21796 : SUCCESS in 46m 54s\n- http://logs.openstack.org/30174/10/gate/gate-tempest-devstack-vm-quantum/29314 : FAILURE in 26m 58s\n- http://logs.openstack.org/30174/10/gate/gate-grenade-devstack-vm/9261 : SUCCESS in 15m 36s (non-voting)\n","accounts_in_message":[],"_revision_number":10},{"id":"8b6cffcf687ddb4518f6487b5306000225d2cda4","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-06-13 07:24:57.000000000","message":"Patch Set 10: Looks good to me, but someone else must approve\n\nreverify bug 1181567","accounts_in_message":[],"_revision_number":10},{"id":"ec184d7e30d5f6d6e319dafb9e82b7a6329dbc55","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-13 07:25:03.000000000","message":"Patch Set 10: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":10},{"id":"ac21e38c392321cf75e3f72708892371785089b9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-13 08:08:22.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":10},{"id":"3baa753018e0ed3d426ce7df0f5852dd8c7eb402","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-13 08:08:22.000000000","message":"Patch Set 10: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/30174/10/gate/gate-python-keystoneclient-docs/1059/doc/build/html/ : SUCCESS in 55s\n- http://logs.openstack.org/30174/10/gate/gate-python-keystoneclient-pep8/1208 : SUCCESS in 48s\n- http://logs.openstack.org/30174/10/gate/gate-python-keystoneclient-python26/1132 : SUCCESS in 1m 11s\n- http://logs.openstack.org/30174/10/gate/gate-python-keystoneclient-python27/1135 : SUCCESS in 54s\n- http://logs.openstack.org/30174/10/gate/gate-tempest-devstack-vm-full/22906 : SUCCESS in 40m 09s\n- http://logs.openstack.org/30174/10/gate/gate-tempest-devstack-vm-postgres-full/22613 : SUCCESS in 43m 08s\n- http://logs.openstack.org/30174/10/gate/gate-tempest-devstack-vm-quantum/30210 : SUCCESS in 21m 25s\n- http://logs.openstack.org/30174/10/gate/gate-grenade-devstack-vm/9999 : SUCCESS in 15m 43s (non-voting)\n","accounts_in_message":[],"_revision_number":10}],"current_revision_number":10,"current_revision":"68eed64a02bea4a3adb4c8761f8d8bc4f55e5ecd","revisions":{"2f5b73c95367818eda73c15996a54d3141b8c799":{"kind":"REWORK","_number":1,"created":"2013-05-22 22:10:34.000000000","uploader":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"ref":"refs/changes/74/30174/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/74/30174/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/1"}}},"commit":{"parents":[{"commit":"34f93f3abc4fbc7b04510e783ec410aee8bef26b","subject":"Merge \"Only add logging handlers if there currently aren\u0027t any\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/34f93f3abc4fbc7b04510e783ec410aee8bef26b"}]}],"author":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-22 21:00:53.000000000","tz":-240},"committer":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-22 21:52:41.000000000","tz":-240},"subject":"Fix optional keyring support, add basic keyring tests","message":"Fix optional keyring support, add basic keyring tests\n\nCommit 06d9437e8388b369546d760607f17cb5022750e9 made using a keyring\noptional by adding a function to handle the imports. The problem is that\nimport needs to be available at a global level for it to be usable in\nother parts of the code.\n\nA couple of global variables are used to store the references.\n\nFixing the imports isn\u0027t enough to get keyring support working because\nin get_auth_ref_from_keyring() the wrong token was being used when\nevaluating token expiration. It was using the token already in the\nHTTPClient object and not the one returned from the keyring.\n\nSome simple tests were added to prevent future regressions. nose was\nadded to tools/test-requires because these tests will be skipped if\nthe keyring or pickle packages are not installed.\n\nChange-Id: I1fe2c9e5cdf275df2047018368da2e4b3d2d6de2\nFixes: bug #1183072\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2f5b73c95367818eda73c15996a54d3141b8c799"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2f5b73c95367818eda73c15996a54d3141b8c799"}]},"branch":"refs/heads/master"},"c4d2130c2fa75a1d316efb488b1bf9f0aada4ac7":{"kind":"REWORK","_number":2,"created":"2013-05-24 19:21:25.000000000","uploader":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"ref":"refs/changes/74/30174/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/74/30174/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/2"}}},"commit":{"parents":[{"commit":"17db3b2d17e5aa40e96759b150b3597c6ce5faf4","subject":"Merge \"Default signing_dir to secure temp dir (bug 1181157)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/17db3b2d17e5aa40e96759b150b3597c6ce5faf4"}]}],"author":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-22 21:00:53.000000000","tz":-240},"committer":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-24 19:20:28.000000000","tz":-240},"subject":"Fix optional keyring support, add basic keyring tests","message":"Fix optional keyring support, add basic keyring tests\n\nCommit 06d9437e8388b369546d760607f17cb5022750e9 made using a keyring\noptional by adding a function to handle the imports. The problem is that\nimport needs to be available at a global level for it to be usable in\nother parts of the code.\n\nA couple of global variables are used to store the references.\n\nFixing the imports isn\u0027t enough to get keyring support working because\nin get_auth_ref_from_keyring() the wrong token was being used when\nevaluating token expiration. It was using the token already in the\nHTTPClient object and not the one returned from the keyring.\n\nSome simple tests were added to prevent future regressions. These\ntests will be skipped if the keyring or pickle packages are not\ninstalled.\n\nChange-Id: I1fe2c9e5cdf275df2047018368da2e4b3d2d6de2\nFixes: bug #1183072\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c4d2130c2fa75a1d316efb488b1bf9f0aada4ac7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c4d2130c2fa75a1d316efb488b1bf9f0aada4ac7"}]},"branch":"refs/heads/master"},"2dd19dddb67cfe2d8be715d977f07a5007645a21":{"kind":"REWORK","_number":3,"created":"2013-05-30 19:03:10.000000000","uploader":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"ref":"refs/changes/74/30174/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/74/30174/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/3"}}},"commit":{"parents":[{"commit":"111e7304f5bc9e7a2c726084038b5f8692ec940a","subject":"Merge \"Check Expiry\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/111e7304f5bc9e7a2c726084038b5f8692ec940a"}]}],"author":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-22 21:00:53.000000000","tz":-240},"committer":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-30 18:10:24.000000000","tz":-240},"subject":"Fix optional keyring support, add basic keyring tests","message":"Fix optional keyring support, add basic keyring tests\n\nCommit 06d9437e8388b369546d760607f17cb5022750e9 made using a keyring\noptional by adding a function to handle the imports. The problem is that\nimport needs to be available at a global level for it to be usable in\nother parts of the code.\n\nThe function is replaced by a top-level try/except.\n\nFixing the imports isn\u0027t enough to get keyring support working because\nin get_auth_ref_from_keyring() the wrong token was being used when\nevaluating token expiration. It was using the token already in the\nHTTPClient object and not the one returned from the keyring.\n\nSome simple tests were added to prevent future regressions. These\ntests will be skipped if the keyring or pickle packages are not\ninstalled.\n\nChange-Id: I1fe2c9e5cdf275df2047018368da2e4b3d2d6de2\nFixes: bug #1183072\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2dd19dddb67cfe2d8be715d977f07a5007645a21"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2dd19dddb67cfe2d8be715d977f07a5007645a21"}]},"branch":"refs/heads/master"},"ef1ffb5b76a92bb778b053de6b57c68f62dd3141":{"kind":"REWORK","_number":4,"created":"2013-05-31 20:45:35.000000000","uploader":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"ref":"refs/changes/74/30174/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/74/30174/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/4"}}},"commit":{"parents":[{"commit":"6753889314c3b7aed9ff9f032cc7483005b68dcf","subject":"Merge \"Enumerate ignored flake8 rules\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6753889314c3b7aed9ff9f032cc7483005b68dcf"}]}],"author":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-22 21:00:53.000000000","tz":-240},"committer":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-31 20:44:36.000000000","tz":-240},"subject":"Fix optional keyring support, add basic keyring tests","message":"Fix optional keyring support, add basic keyring tests\n\nCommit 06d9437e8388b369546d760607f17cb5022750e9 made using a keyring\noptional by adding a function to handle the imports. The problem is that\nimport needs to be available at a global level for it to be usable in\nother parts of the code.\n\nThe function is replaced by a top-level try/except.\n\nFixing the imports isn\u0027t enough to get keyring support working because\nin get_auth_ref_from_keyring() the wrong token was being used when\nevaluating token expiration. It was using the token already in the\nHTTPClient object and not the one returned from the keyring.\n\nSome simple tests were added to prevent future regressions. These\ntests will be skipped if the keyring or pickle packages are not\ninstalled.\n\nChange-Id: I1fe2c9e5cdf275df2047018368da2e4b3d2d6de2\nFixes: bug #1183072\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ef1ffb5b76a92bb778b053de6b57c68f62dd3141"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ef1ffb5b76a92bb778b053de6b57c68f62dd3141"}]},"branch":"refs/heads/master"},"e528c23775e59f27a1e8b1ef54a823910e8f37f9":{"kind":"REWORK","_number":5,"created":"2013-06-03 14:35:20.000000000","uploader":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"ref":"refs/changes/74/30174/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/74/30174/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/5"}}},"commit":{"parents":[{"commit":"6753889314c3b7aed9ff9f032cc7483005b68dcf","subject":"Merge \"Enumerate ignored flake8 rules\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6753889314c3b7aed9ff9f032cc7483005b68dcf"}]}],"author":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-22 21:00:53.000000000","tz":-240},"committer":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-06-03 14:35:08.000000000","tz":-240},"subject":"Fix optional keyring support, add basic keyring tests","message":"Fix optional keyring support, add basic keyring tests\n\nCommit 06d9437e8388b369546d760607f17cb5022750e9 made using a keyring\noptional by adding a function to handle the imports. The problem is that\nimport needs to be available at a global level for it to be usable in\nother parts of the code.\n\nThe function is replaced by a top-level try/except.\n\nFixing the imports isn\u0027t enough to get keyring support working because\nin get_auth_ref_from_keyring() the wrong token was being used when\nevaluating token expiration. It was using the token already in the\nHTTPClient object and not the one returned from the keyring.\n\nSome simple tests were added to prevent future regressions. These\ntests will be skipped if the keyring or pickle packages are not\ninstalled.\n\nChange-Id: I1fe2c9e5cdf275df2047018368da2e4b3d2d6de2\nFixes: bug #1183072\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e528c23775e59f27a1e8b1ef54a823910e8f37f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e528c23775e59f27a1e8b1ef54a823910e8f37f9"}]},"branch":"refs/heads/master"},"7d5702a09d5e4b005d5ec7441f5b21ca59a2a1e2":{"kind":"REWORK","_number":6,"created":"2013-06-04 15:45:29.000000000","uploader":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"ref":"refs/changes/74/30174/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/74/30174/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/6"}}},"commit":{"parents":[{"commit":"4b90bc5c314fa52ece212451fbfec7ba7eced3b1","subject":"Merge \"Fix unused imports(flake8 F401, F999)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/4b90bc5c314fa52ece212451fbfec7ba7eced3b1"}]}],"author":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-22 21:00:53.000000000","tz":-240},"committer":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-06-04 15:42:18.000000000","tz":-240},"subject":"Fix optional keyring support, add basic keyring tests","message":"Fix optional keyring support, add basic keyring tests\n\nCommit 06d9437e8388b369546d760607f17cb5022750e9 made using a keyring\noptional by adding a function to handle the imports. The problem is that\nimport needs to be available at a global level for it to be usable in\nother parts of the code.\n\nThe function is replaced by a top-level try/except.\n\nFixing the imports isn\u0027t enough to get keyring support working because\nin get_auth_ref_from_keyring() the wrong token was being used when\nevaluating token expiration. It was using the token already in the\nHTTPClient object and not the one returned from the keyring.\n\nSome simple tests were added to prevent future regressions. These\ntests will be skipped if the keyring or pickle packages are not\ninstalled.\n\nChange-Id: I1fe2c9e5cdf275df2047018368da2e4b3d2d6de2\nFixes: bug #1183072\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/7d5702a09d5e4b005d5ec7441f5b21ca59a2a1e2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/7d5702a09d5e4b005d5ec7441f5b21ca59a2a1e2"}]},"branch":"refs/heads/master"},"3f9755b02e39dadbc8597deaf29e2422f9e7b3b4":{"kind":"REWORK","_number":7,"created":"2013-06-05 14:13:51.000000000","uploader":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"ref":"refs/changes/74/30174/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/74/30174/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/7"}}},"commit":{"parents":[{"commit":"4b90bc5c314fa52ece212451fbfec7ba7eced3b1","subject":"Merge \"Fix unused imports(flake8 F401, F999)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/4b90bc5c314fa52ece212451fbfec7ba7eced3b1"}]}],"author":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-22 21:00:53.000000000","tz":-240},"committer":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-06-05 14:13:40.000000000","tz":-240},"subject":"Fix optional keyring support, add basic keyring tests","message":"Fix optional keyring support, add basic keyring tests\n\nCommit 06d9437e8388b369546d760607f17cb5022750e9 made using a keyring\noptional by adding a function to handle the imports. The problem is that\nimport needs to be available at a global level for it to be usable in\nother parts of the code.\n\nThe function is replaced by a top-level try/except.\n\nFixing the imports isn\u0027t enough to get keyring support working because\nin get_auth_ref_from_keyring() the wrong token was being used when\nevaluating token expiration. It was using the token already in the\nHTTPClient object and not the one returned from the keyring.\n\nSome simple tests were added to prevent future regressions. These\ntests will be skipped if the keyring or pickle packages are not\ninstalled.\n\nChange-Id: I1fe2c9e5cdf275df2047018368da2e4b3d2d6de2\nFixes: bug #1183072\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3f9755b02e39dadbc8597deaf29e2422f9e7b3b4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3f9755b02e39dadbc8597deaf29e2422f9e7b3b4"}]},"branch":"refs/heads/master"},"459103b8cd9c22ed2ed9a59c235e865065401056":{"kind":"REWORK","_number":8,"created":"2013-06-06 18:28:36.000000000","uploader":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"ref":"refs/changes/74/30174/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/74/30174/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/8"}}},"commit":{"parents":[{"commit":"2ec2e7ee31a9a7305d524bceaf2c10f89ef27f02","subject":"Merge \"Add find() method to CrudManager\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2ec2e7ee31a9a7305d524bceaf2c10f89ef27f02"}]}],"author":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-22 21:00:53.000000000","tz":-240},"committer":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-06-06 18:28:07.000000000","tz":-240},"subject":"Fix optional keyring support, add basic keyring tests","message":"Fix optional keyring support, add basic keyring tests\n\nCommit 06d9437e8388b369546d760607f17cb5022750e9 made using a keyring\noptional by adding a function to handle the imports. The problem is that\nimport needs to be available at a global level for it to be usable in\nother parts of the code.\n\nThe function is replaced by a top-level try/except.\n\nFixing the imports isn\u0027t enough to get keyring support working because\nin get_auth_ref_from_keyring() the wrong token was being used when\nevaluating token expiration. It was using the token already in the\nHTTPClient object and not the one returned from the keyring.\n\nSome simple tests were added to prevent future regressions. These\ntests will be skipped if the keyring or pickle packages are not\ninstalled.\n\nChange-Id: I1fe2c9e5cdf275df2047018368da2e4b3d2d6de2\nFixes: bug #1183072\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/459103b8cd9c22ed2ed9a59c235e865065401056"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/459103b8cd9c22ed2ed9a59c235e865065401056"}]},"branch":"refs/heads/master"},"f87b2f8ade2f434b91c72d6da230839d11fd630f":{"kind":"REWORK","_number":9,"created":"2013-06-07 18:29:53.000000000","uploader":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"ref":"refs/changes/74/30174/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/74/30174/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/9"}}},"commit":{"parents":[{"commit":"2ec2e7ee31a9a7305d524bceaf2c10f89ef27f02","subject":"Merge \"Add find() method to CrudManager\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2ec2e7ee31a9a7305d524bceaf2c10f89ef27f02"}]}],"author":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-22 21:00:53.000000000","tz":-240},"committer":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-06-07 02:35:38.000000000","tz":-240},"subject":"Fix optional keyring support, add basic keyring tests","message":"Fix optional keyring support, add basic keyring tests\n\nCommit 06d9437e8388b369546d760607f17cb5022750e9 made using a keyring\noptional by adding a function to handle the imports. The problem is that\nimport needs to be available at a global level for it to be usable in\nother parts of the code.\n\nThe function is replaced by a top-level try/except.\n\nFixing the imports isn\u0027t enough to get keyring support working because\nin get_auth_ref_from_keyring() the wrong token was being used when\nevaluating token expiration. It was using the token already in the\nHTTPClient object and not the one returned from the keyring.\n\nSome simple tests were added to prevent future regressions. These\ntests will be skipped if the keyring or pickle packages are not\ninstalled.\n\nChange-Id: I1fe2c9e5cdf275df2047018368da2e4b3d2d6de2\nFixes: bug #1183072\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f87b2f8ade2f434b91c72d6da230839d11fd630f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f87b2f8ade2f434b91c72d6da230839d11fd630f"}]},"branch":"refs/heads/master"},"68eed64a02bea4a3adb4c8761f8d8bc4f55e5ecd":{"kind":"REWORK","_number":10,"created":"2013-06-10 17:18:04.000000000","uploader":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"ref":"refs/changes/74/30174/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/74/30174/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/74/30174/10"}}},"commit":{"parents":[{"commit":"2ec2e7ee31a9a7305d524bceaf2c10f89ef27f02","subject":"Merge \"Add find() method to CrudManager\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2ec2e7ee31a9a7305d524bceaf2c10f89ef27f02"}]}],"author":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-05-22 21:00:53.000000000","tz":-240},"committer":{"name":"Rob Crittenden","email":"rcritten@redhat.com","date":"2013-06-10 15:40:12.000000000","tz":-240},"subject":"Fix optional keyring support, add basic keyring tests","message":"Fix optional keyring support, add basic keyring tests\n\nCommit 06d9437e8388b369546d760607f17cb5022750e9 made using a keyring\noptional by adding a function to handle the imports. The problem is that\nimport needs to be available at a global level for it to be usable in\nother parts of the code.\n\nThe function is replaced by a top-level try/except.\n\nFixing the imports isn\u0027t enough to get keyring support working because\nin get_auth_ref_from_keyring() the wrong token was being used when\nevaluating token expiration. It was using the token already in the\nHTTPClient object and not the one returned from the keyring.\n\nSome simple tests were added to prevent future regressions. These\ntests will be skipped if the keyring or pickle packages are not\ninstalled.\n\nChange-Id: I1fe2c9e5cdf275df2047018368da2e4b3d2d6de2\nFixes: bug #1183072\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/68eed64a02bea4a3adb4c8761f8d8bc4f55e5ecd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/68eed64a02bea4a3adb4c8761f8d8bc4f55e5ecd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}