)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"85c1fa950e93bf57b76835fc9fafe085170f6f1a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"1. Change the codes in keystoneclient/middleware/auth_token.py to use name \u0027memcached_servers\u0027"},{"line_number":17,"context_line":"2. Due to the changes made in #1, need to change the corresponding testing codes"},{"line_number":18,"context_line":"in Keystoneclient/tests/test_auth_token_middleware.py"},{"line_number":19,"context_line":"3. Change the relevant document in keystoneclient/doc/source/middlewarearchitecture.rst"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I93ca0aa368f95a3ccf6de6984262057e61f75ffe"},{"line_number":22,"context_line":"Fixes: Bug 1172793"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAPX%2F%2Fudk%3D","line":19,"updated":"2013-06-11 20:49:10.000000000","message":"commit messages explain \"why\" not \"what\" -- remove this list","commit_id":"2ab2ec0d72297eb76ef10e81b7665a5c3282f421"}],"keystoneclient/middleware/auth_token.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"00318bf78e370b277c356d8e38f823099dd661c5","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        elif \u0027memcache_servers\u0027 in self.conf:"},{"line_number":373,"context_line":"            memcache_servers \u003d self.conf[\u0027memcache_servers\u0027]"},{"line_number":374,"context_line":"        else:"},{"line_number":375,"context_line":"            memcache_servers \u003d self._conf_get(\u0027memcached_servers\u0027)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        if cache and env.get(cache, None) is not None:"},{"line_number":378,"context_line":"            # use the cache from the upstream filter"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2FueQ%3D","line":375,"updated":"2013-06-11 20:48:24.000000000","message":"oslo should handle all this for you... you should just have to get the newly defined variable and oslo will deliver the value of a deprecated config if that\u0027s set instead... so, undo all this and just add the \u0027d\u0027","commit_id":"2ab2ec0d72297eb76ef10e81b7665a5c3282f421"}],"tests/test_auth_token_middleware.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e2b2f74d032af52f67fbf85670fd620e8e3109c2","unresolved":false,"context_lines":[{"line_number":806,"context_line":"            \u0027admin_token\u0027: \u0027admin_token1\u0027,"},{"line_number":807,"context_line":"            \u0027auth_host\u0027: \u0027keystone.example.com\u0027,"},{"line_number":808,"context_line":"            \u0027auth_port\u0027: 1234,"},{"line_number":809,"context_line":"            \u0027memcached_servers\u0027: \u0027localhost:11211\u0027,"},{"line_number":810,"context_line":"        }"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"        auth_token.AuthProtocol(FakeApp(), conf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2F63M%3D","line":809,"updated":"2013-06-06 00:15:38.000000000","message":"shouldn\u0027t all these old tests continue to work without change?","commit_id":"2ab2ec0d72297eb76ef10e81b7665a5c3282f421"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6b77466e11e5c0f627b80242ea248aaf0e063351","unresolved":false,"context_lines":[{"line_number":806,"context_line":"            \u0027admin_token\u0027: \u0027admin_token1\u0027,"},{"line_number":807,"context_line":"            \u0027auth_host\u0027: \u0027keystone.example.com\u0027,"},{"line_number":808,"context_line":"            \u0027auth_port\u0027: 1234,"},{"line_number":809,"context_line":"            \u0027memcached_servers\u0027: \u0027localhost:11211\u0027,"},{"line_number":810,"context_line":"        }"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"        auth_token.AuthProtocol(FakeApp(), conf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2Fz%2F0%3D","line":809,"in_reply_to":"AAAAPX%2F%2F1Co%3D","updated":"2013-06-09 17:02:10.000000000","message":"how about add a test that uses the old name to ensure that it still works?","commit_id":"2ab2ec0d72297eb76ef10e81b7665a5c3282f421"},{"author":{"_account_id":7302,"name":"xingzhou","email":"xingzhou@cn.ibm.com","username":"xingzhou"},"change_message_id":"8a99400d5af63ac907e3ab9198ff2d4154a58807","unresolved":false,"context_lines":[{"line_number":806,"context_line":"            \u0027admin_token\u0027: \u0027admin_token1\u0027,"},{"line_number":807,"context_line":"            \u0027auth_host\u0027: \u0027keystone.example.com\u0027,"},{"line_number":808,"context_line":"            \u0027auth_port\u0027: 1234,"},{"line_number":809,"context_line":"            \u0027memcached_servers\u0027: \u0027localhost:11211\u0027,"},{"line_number":810,"context_line":"        }"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"        auth_token.AuthProtocol(FakeApp(), conf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2F1Co%3D","line":809,"in_reply_to":"AAAAPX%2F%2F63M%3D","updated":"2013-06-08 07:25:41.000000000","message":"yes, all the old \"memcache_servers\" can work as before, but to suggest use the new opt name, I would like to change the opt names in the testing to \"memchached_servers\"","commit_id":"2ab2ec0d72297eb76ef10e81b7665a5c3282f421"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"00318bf78e370b277c356d8e38f823099dd661c5","unresolved":false,"context_lines":[{"line_number":806,"context_line":"            \u0027admin_token\u0027: \u0027admin_token1\u0027,"},{"line_number":807,"context_line":"            \u0027auth_host\u0027: \u0027keystone.example.com\u0027,"},{"line_number":808,"context_line":"            \u0027auth_port\u0027: 1234,"},{"line_number":809,"context_line":"            \u0027memcached_servers\u0027: \u0027localhost:11211\u0027,"},{"line_number":810,"context_line":"        }"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"        auth_token.AuthProtocol(FakeApp(), conf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2Fud8%3D","line":809,"in_reply_to":"AAAAPX%2F%2Fz%2F0%3D","updated":"2013-06-11 20:48:24.000000000","message":"i\u0027d consider a new test optional, because all you\u0027re testing is oslo... but +1 for the changes that have already been made here","commit_id":"2ab2ec0d72297eb76ef10e81b7665a5c3282f421"}]}