)]}'
{"keystoneclient/contrib/auth/v3/oidc.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"0f34948c9fbd817b26259061809d881506fc5a72","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                      example: https://localhost/oidc/token"},{"line_number":177,"context_line":"        :type access_token_endpoint: string"},{"line_number":178,"context_line":"        \"\"\""},{"line_number":179,"context_line":"        op_response \u003d session.post(self.access_token_endpoint,"},{"line_number":180,"context_line":"                                   requests_auth\u003dclient_auth,"},{"line_number":181,"context_line":"                                   data\u003dpayload,"},{"line_number":182,"context_line":"                                   authenticated\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_7c5e9746","side":"PARENT","line":179,"range":{"start_line":179,"start_character":35,"end_line":179,"end_character":61},"updated":"2016-05-18 10:59:31.000000000","message":"An alternative could be just use \"access_token_endpoint\" parameter here","commit_id":"05b04513c5f968e0bac49dea4f823eafa310c7ca"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"c854cbdb9d5238fec25a5f77b6fa701b669c3443","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                      example: https://localhost/oidc/token"},{"line_number":177,"context_line":"        :type access_token_endpoint: string"},{"line_number":178,"context_line":"        \"\"\""},{"line_number":179,"context_line":"        op_response \u003d session.post(self.access_token_endpoint,"},{"line_number":180,"context_line":"                                   requests_auth\u003dclient_auth,"},{"line_number":181,"context_line":"                                   data\u003dpayload,"},{"line_number":182,"context_line":"                                   authenticated\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_f778e0fa","side":"PARENT","line":179,"range":{"start_line":179,"start_character":35,"end_line":179,"end_character":61},"in_reply_to":"bab6814e_7c5e9746","updated":"2016-05-18 11:08:56.000000000","message":"Yes, but IMO this is error prone. Upon creation of the object, the access token is already set as an attribute (by the parent federated.FederatedBaseAuth class). I do not see why we would need to pass it in every call. If so, why are we setting the attribute?","commit_id":"05b04513c5f968e0bac49dea4f823eafa310c7ca"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"f07226eb1e841f47f5c1916e0fbe600165642a23","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                      example: https://localhost/oidc/token"},{"line_number":177,"context_line":"        :type access_token_endpoint: string"},{"line_number":178,"context_line":"        \"\"\""},{"line_number":179,"context_line":"        op_response \u003d session.post(self.access_token_endpoint,"},{"line_number":180,"context_line":"                                   requests_auth\u003dclient_auth,"},{"line_number":181,"context_line":"                                   data\u003dpayload,"},{"line_number":182,"context_line":"                                   authenticated\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_a9956041","side":"PARENT","line":179,"range":{"start_line":179,"start_character":35,"end_line":179,"end_character":61},"in_reply_to":"bab6814e_f778e0fa","updated":"2016-05-18 11:23:09.000000000","message":"Makes sense .. I was also wondering about the tests in test_auth_oidc.py, but this will work for them as well, as they properly create an oidc plugin in their setup","commit_id":"05b04513c5f968e0bac49dea4f823eafa310c7ca"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"0f34948c9fbd817b26259061809d881506fc5a72","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                                   protocols/oidc/auth"},{"line_number":206,"context_line":"        :type federated_auth_url: string"},{"line_number":207,"context_line":"        \"\"\""},{"line_number":208,"context_line":"        auth_response \u003d session.post(self.federated_token_url,"},{"line_number":209,"context_line":"                                     headers\u003dheaders,"},{"line_number":210,"context_line":"                                     authenticated\u003dFalse)"},{"line_number":211,"context_line":"        return auth_response"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_fc30c709","side":"PARENT","line":208,"range":{"start_line":208,"start_character":37,"end_line":208,"end_character":61},"updated":"2016-05-18 10:59:31.000000000","message":"Same as above","commit_id":"05b04513c5f968e0bac49dea4f823eafa310c7ca"}],"keystoneclient/tests/unit/v3/test_auth_oidc.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"0f34948c9fbd817b26259061809d881506fc5a72","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        res \u003d self.oidcplugin._get_access_token(self.session,"},{"line_number":145,"context_line":"                                                client_auth,"},{"line_number":146,"context_line":"                                                payload,"},{"line_number":147,"context_line":"                                                self.ACCESS_TOKEN_ENDPOINT)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # Verify the request matches the expected structure"},{"line_number":150,"context_line":"        self.assertEqual(self.ACCESS_TOKEN_ENDPOINT, res.request.url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_bc063f1e","side":"PARENT","line":147,"range":{"start_line":147,"start_character":48,"end_line":147,"end_character":74},"updated":"2016-05-18 10:59:31.000000000","message":"_get_access_token needs this info, isn\u0027t it better to just use the provided parameter in _get_access_token method ?","commit_id":"05b04513c5f968e0bac49dea4f823eafa310c7ca"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"0f34948c9fbd817b26259061809d881506fc5a72","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        headers \u003d {\u0027Authorization\u0027: \u0027Bearer \u0027 + access_token}"},{"line_number":166,"context_line":"        res \u003d self.oidcplugin._get_keystone_token(self.session,"},{"line_number":167,"context_line":"                                                  headers,"},{"line_number":168,"context_line":"                                                  self.FEDERATION_AUTH_URL)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Verify the request matches the expected structure"},{"line_number":171,"context_line":"        self.assertEqual(self.FEDERATION_AUTH_URL, res.request.url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_9c037b0f","side":"PARENT","line":168,"range":{"start_line":168,"start_character":50,"end_line":168,"end_character":74},"updated":"2016-05-18 10:59:31.000000000","message":"Same here","commit_id":"05b04513c5f968e0bac49dea4f823eafa310c7ca"}]}