)]}'
{"id":"openstack%2Fpython-keystoneclient~317966","triplet_id":"openstack%2Fpython-keystoneclient~master~I18a5632cf3967228214aa99ec6d07d9bfcab09d8","project":"openstack/python-keystoneclient","branch":"master","topic":"oidctoken","hashtags":[],"change_id":"I18a5632cf3967228214aa99ec6d07d9bfcab09d8","subject":"Remove unused parameters in OidcPassword methods","status":"ABANDONED","created":"2016-05-18 10:32:46.000000000","updated":"2016-05-19 14:45:36.000000000","total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e87bf9ad607db7a301ee7218209d325a78ad3598","_number":317966,"virtual_id_number":317966,"owner":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2016-05-19 09:32:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-05-19 08:18:14.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-18 11:23:09.000000000","updated_by":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"reviewer":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"state":"REVIEWER"},{"updated":"2016-05-19 09:32:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6a4c87394f66fc0734a1a0231a5c055f345afa09","author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"date":"2016-05-18 10:32:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"92d2eb362b496fca68efbcd4198ebd82303c0a5f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-18 10:32:56.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"b728f7f42169e922004a9d0ece103b730e98ebaf","author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"date":"2016-05-18 10:52:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0f34948c9fbd817b26259061809d881506fc5a72","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2016-05-18 10:59:31.000000000","message":"Patch Set 2: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"c854cbdb9d5238fec25a5f77b6fa701b669c3443","author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"date":"2016-05-18 11:08:56.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f07226eb1e841f47f5c1916e0fbe600165642a23","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2016-05-18 11:23:09.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"96935b6335465cb353ee27fd2aa047aa0363918a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-18 12:28:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/66/317966/2/check/gate-python-keystoneclient-docs/1780e7d//doc/build/html/ : SUCCESS in 1m 47s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/66/317966/2/check/gate-python-keystoneclient-pep8/d963992/ : SUCCESS in 2m 56s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/66/317966/2/check/gate-python-keystoneclient-python27/593d837/ : SUCCESS in 2m 10s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/66/317966/2/check/gate-python-keystoneclient-python34/ffbe1e7/ : SUCCESS in 4m 54s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/66/317966/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/d4f29db/ : SUCCESS in 58m 30s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/66/317966/2/check/gate-keystoneclient-dsvm-functional/a2d04d3/ : SUCCESS in 18m 40s","accounts_in_message":[],"_revision_number":2},{"id":"ce6f3ad66b0a8d0556c16070e770a69597da5351","author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"date":"2016-05-19 08:18:14.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"c5b8e152864a3b10a5cea56212e0a412127f9593","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-19 09:32:58.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/66/317966/3/check/gate-python-keystoneclient-docs/2a96b87//doc/build/html/ : SUCCESS in 6m 17s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/66/317966/3/check/gate-python-keystoneclient-pep8/2b3bbfa/ : SUCCESS in 6m 15s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/66/317966/3/check/gate-python-keystoneclient-python27/064de92/ : SUCCESS in 6m 22s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/66/317966/3/check/gate-python-keystoneclient-python34/3dbce4b/ : SUCCESS in 8m 35s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/66/317966/3/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/1a75ce0/ : SUCCESS in 1h 09m 09s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/66/317966/3/check/gate-keystoneclient-dsvm-functional/dc5b04d/ : FAILURE in 11m 04s","accounts_in_message":[],"_revision_number":3},{"id":"971c83896f131842ae0eb84c16e2a80cb4147dd1","author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"date":"2016-05-19 14:45:36.000000000","message":"Abandoned\n\nChanges for auth plugins are done in keystoneauth, and the changes are already there.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"bd698003e610e4ce6bbb6c36cac2dcd416b7c1bf","revisions":{"3edb5d8d21ee5f572af5a2c9ae16cfa7e006b3f0":{"kind":"REWORK","_number":1,"created":"2016-05-18 10:32:46.000000000","uploader":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"ref":"refs/changes/66/317966/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/66/317966/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/317966/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/317966/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/317966/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/317966/1"}}},"commit":{"parents":[{"commit":"f24d41ba8f4ef5132bccf4dbb8eb23ada58bb04f","subject":"Let OidcPassword accept scope parameters as kwargs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f24d41ba8f4ef5132bccf4dbb8eb23ada58bb04f"}]}],"author":{"name":"Alvaro Lopez Garcia","email":"aloga@ifca.unican.es","date":"2016-05-18 07:36:19.000000000","tz":120},"committer":{"name":"Alvaro Lopez Garcia","email":"aloga@ifca.unican.es","date":"2016-05-18 08:47:17.000000000","tz":120},"subject":"Remove unused parameters in OidcPassword methods","message":"Remove unused parameters in OidcPassword methods\n\nSome methods from OidcPassword accepted a parameter to indicate the URL\nwhere a request was to be made:\n\n- _get_keystone_token accepted federated_token_url, the URL for\n  federated authentication.\n- _get_access_token accepted access_token_endpoint, the URL used to get\n  an oidc access token.\n\nHowever, they were using the object attribute self.access_token_endpoint\nand the property self.federated_token_url, therefore they were\ncompletely ignored. This changes remoes them.\n\nChange-Id: I18a5632cf3967228214aa99ec6d07d9bfcab09d8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3edb5d8d21ee5f572af5a2c9ae16cfa7e006b3f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3edb5d8d21ee5f572af5a2c9ae16cfa7e006b3f0"}]},"branch":"refs/heads/master"},"914d7fe3772a5f85e5bdeac493dde289d60461a9":{"kind":"REWORK","_number":2,"created":"2016-05-18 10:52:57.000000000","uploader":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"ref":"refs/changes/66/317966/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/66/317966/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/317966/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/317966/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/317966/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/317966/2"}}},"commit":{"parents":[{"commit":"05b04513c5f968e0bac49dea4f823eafa310c7ca","subject":"Let OidcPassword accept scope parameters as kwargs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/05b04513c5f968e0bac49dea4f823eafa310c7ca"}]}],"author":{"name":"Alvaro Lopez Garcia","email":"aloga@ifca.unican.es","date":"2016-05-18 07:36:19.000000000","tz":120},"committer":{"name":"Alvaro Lopez Garcia","email":"aloga@ifca.unican.es","date":"2016-05-18 10:52:26.000000000","tz":120},"subject":"Remove unused parameters in OidcPassword methods","message":"Remove unused parameters in OidcPassword methods\n\nSome methods from OidcPassword accepted a parameter to indicate the URL\nwhere a request was to be made:\n\n- _get_keystone_token accepted federated_token_url, the URL for\n  federated authentication.\n- _get_access_token accepted access_token_endpoint, the URL used to get\n  an oidc access token.\n\nHowever, they were using the object attribute self.access_token_endpoint\nand the property self.federated_token_url, therefore they were\ncompletely ignored. This changes remoes them.\n\nChange-Id: I18a5632cf3967228214aa99ec6d07d9bfcab09d8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/914d7fe3772a5f85e5bdeac493dde289d60461a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/914d7fe3772a5f85e5bdeac493dde289d60461a9"}]},"branch":"refs/heads/master"},"bd698003e610e4ce6bbb6c36cac2dcd416b7c1bf":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2016-05-19 08:18:14.000000000","uploader":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"ref":"refs/changes/66/317966/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/66/317966/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/317966/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/317966/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/317966/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/317966/3"}}},"commit":{"parents":[{"commit":"eb66c791d8c0c72345e073b714a572c6ff72e89a","subject":"Let OidcPassword accept scope parameters as kwargs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/eb66c791d8c0c72345e073b714a572c6ff72e89a"}]}],"author":{"name":"Alvaro Lopez Garcia","email":"aloga@ifca.unican.es","date":"2016-05-18 07:36:19.000000000","tz":120},"committer":{"name":"Alvaro Lopez Garcia","email":"aloga@ifca.unican.es","date":"2016-05-19 08:17:31.000000000","tz":120},"subject":"Remove unused parameters in OidcPassword methods","message":"Remove unused parameters in OidcPassword methods\n\nSome methods from OidcPassword accepted a parameter to indicate the URL\nwhere a request was to be made:\n\n- _get_keystone_token accepted federated_token_url, the URL for\n  federated authentication.\n- _get_access_token accepted access_token_endpoint, the URL used to get\n  an oidc access token.\n\nHowever, they were using the object attribute self.access_token_endpoint\nand the property self.federated_token_url, therefore they were\ncompletely ignored. This changes remoes them.\n\nChange-Id: I18a5632cf3967228214aa99ec6d07d9bfcab09d8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/bd698003e610e4ce6bbb6c36cac2dcd416b7c1bf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/bd698003e610e4ce6bbb6c36cac2dcd416b7c1bf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}