)]}'
{"id":"openstack%2Fpython-keystoneclient~32825","triplet_id":"openstack%2Fpython-keystoneclient~master~Iba33b11e77b9910211983aa725c69d3886e1c7a7","project":"openstack/python-keystoneclient","branch":"master","topic":"nowebob","hashtags":[],"change_id":"Iba33b11e77b9910211983aa725c69d3886e1c7a7","subject":"Drop webob from auth_token.py","status":"MERGED","created":"2013-06-13 03:30:26.000000000","updated":"2013-08-01 23:37:19.000000000","submitted":"2013-08-01 23:37:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":21,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f43a0db5987675039efc722f633374d627c130d9","_number":32825,"virtual_id_number":32825,"owner":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2013-08-01 23:37:19.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":2,"date":"2013-07-27 20:09:25.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2013-08-01 21:09:36.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"date":"2013-07-27 20:09:25.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":1,"date":"2013-08-01 21:09:36.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-06-24 22:36:24.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2013-07-09 16:06:21.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-07-27 20:09:25.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2013-08-01 21:09:36.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2013-08-01 23:37:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5e0e099142dfc54bff843f92e14a6fb6d054a9fb","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-06-13 03:48:21.000000000","message":"Patch Set 1:\n\nHonestly I am not 100% certain that I\u0027m doing the right thing here in case for HEAD (I hope that eventlet drops the body, but not sure it works properly for simplistic list-of-strings bodies). I know it works in Apache and mod_python.","accounts_in_message":[],"_revision_number":1},{"id":"8330645e7af487711be25caf129a2175d15c62af","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-13 04:22:40.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/32825/1/check/gate-python-keystoneclient-pep8/1207 : SUCCESS in 1m 05s\n- http://docs-draft.openstack.org/32825/1/check/gate-python-keystoneclient-docs/1058/doc/build/html/ : SUCCESS in 57s\n- http://logs.openstack.org/32825/1/check/gate-python-keystoneclient-python26/1131 : SUCCESS in 1m 51s\n- http://logs.openstack.org/32825/1/check/gate-python-keystoneclient-python27/1134 : SUCCESS in 1m 00s\n- http://logs.openstack.org/32825/1/check/gate-tempest-devstack-vm-full/22836 : SUCCESS in 49m 41s\n- http://logs.openstack.org/32825/1/check/gate-tempest-devstack-vm-postgres-full/22543 : SUCCESS in 51m 01s\n- http://logs.openstack.org/32825/1/check/gate-tempest-devstack-vm-quantum/30136 : SUCCESS in 17m 11s\n- http://logs.openstack.org/32825/1/check/gate-grenade-devstack-vm/9941 : FAILURE in 17m 02s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"3818fbb24c52af75d6559fd2130ee9b51e03c526","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-06-14 18:23:28.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\ni wouldn\u0027t expect eventlet to do anything automatically in the case of a HEAD call, but this code also looks equivalent to the previous behavior (so I doubt you\u0027re introducing any new issues?).","accounts_in_message":[],"_revision_number":1},{"id":"ae10a68b3cfacf25722aee38ed5791dbc8998f18","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-06-17 16:19:36.000000000","message":"Patch Set 1: Work In Progress\n\nI think Dolph is right, eventlet expects empty bodies from WSGI apps (and middleware, I would imagine). Taking WIP while I investigate.","accounts_in_message":[],"_revision_number":1},{"id":"82774a5c33ab2b642089397ba0b2ea70ed0546a3","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-06-20 22:04:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"253fcad749bbe294e9b689fc88dfa66099ee468a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-20 23:09:30.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/32825/2/check/gate-python-keystoneclient-pep8/1242 : SUCCESS in 51s\n- http://docs-draft.openstack.org/32825/2/check/gate-python-keystoneclient-docs/1093/doc/build/html/ : SUCCESS in 1m 03s\n- http://logs.openstack.org/32825/2/check/gate-python-keystoneclient-python26/1166 : SUCCESS in 1m 50s\n- http://logs.openstack.org/32825/2/check/gate-python-keystoneclient-python27/1169 : SUCCESS in 1m 04s\n- http://logs.openstack.org/32825/2/check/gate-tempest-devstack-vm-full/25164 : SUCCESS in 52m 14s\n- http://logs.openstack.org/32825/2/check/gate-tempest-devstack-vm-postgres-full/24870 : SUCCESS in 54m 57s\n- http://logs.openstack.org/32825/2/check/gate-tempest-devstack-vm-quantum/32689 : SUCCESS in 23m 59s\n- http://logs.openstack.org/32825/2/check/gate-grenade-devstack-vm/11896 : FAILURE in 40m 02s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"4ecffa7ee6e7b0a794329b326191ae73bbc8c61a","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-06-23 16:01:05.000000000","message":"Patch Set 2:\n\nI\u0027d rather see this discussed in a bug report.","accounts_in_message":[],"_revision_number":2},{"id":"42e91fa3d066f835e1feac17991308b74d283af8","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-06-23 16:03:43.000000000","message":"Patch Set 2:\n\nI don\u0027t see WebOb included in keystoneclient requirements.txt, so should it not have been used?","accounts_in_message":[],"_revision_number":2},{"id":"b6d15cf0ada56c82d899c647ea9c421c40ef8811","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-06-25 00:14:00.000000000","message":"Patch Set 2:\n\nWell, maybe the missing requirement was a problem, but I fixed it now, right?\n\nIn Fedora we do not use the requirements.txt as such. Still, pulling in the webob everywhere is an extra we could live without.","accounts_in_message":[],"_revision_number":2},{"id":"0869d2a6db6c48df93f40651f57f44de6bd8c36a","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-06-26 04:02:06.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nThere is probably some unit tests to add here, FYI the coverage goes down from 86% to 83% with your patch http://pastie.org/private/xih6gmyzbswvvupnkcvba","accounts_in_message":[],"_revision_number":2},{"id":"4a6610d6d95dfdffa936a9ec38f4a6e3863dd562","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-06-27 19:43:18.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"87f4cd069af88fee1186686be7248cd7bfbed1df","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-06-27 20:09:50.000000000","message":"Patch Set 2: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"100111b02b539d171d9264d0e878acf49e321003","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-06-27 20:13:20.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"6e1c3bc3c7642678f446988a1060204c550200da","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-06-28 15:07:00.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"7f13afea83d99b36ec750b7b1e82da9e247ef744","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-07-02 21:08:00.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f949f4fc119927bc308a34093a0ff2b523f9c305","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-02 21:09:52.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"d58d8b1e989f00e1b3bfa42df0fa9c32096bcdca","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-07-02 21:13:48.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"5a3488e2fc010735e064c2bd6e8edca2b1e63804","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-02 22:19:45.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/32825/4/check/gate-python-keystoneclient-pep8/1283 : FAILURE in 2m 07s\n- http://docs-draft.openstack.org/32825/4/check/gate-python-keystoneclient-docs/1134/doc/build/html/ : SUCCESS in 2m 09s\n- http://logs.openstack.org/32825/4/check/gate-python-keystoneclient-python26/1207 : SUCCESS in 2m 34s\n- http://logs.openstack.org/32825/4/check/gate-python-keystoneclient-python27/1210 : SUCCESS in 2m 04s\n- http://logs.openstack.org/32825/4/check/gate-tempest-devstack-vm-full/27989 : SUCCESS in 1h 01m 23s\n- http://logs.openstack.org/32825/4/check/gate-tempest-devstack-vm-postgres-full/27695 : SUCCESS in 58m 14s\n- http://logs.openstack.org/32825/4/check/gate-tempest-devstack-vm-quantum/35844 : SUCCESS in 24m 50s\n- http://logs.openstack.org/32825/4/check/gate-grenade-devstack-vm/14379 : FAILURE in 28m 08s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"bc5fa1dab8d47fd5e30d3346bda0c8a0c4766eaf","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-07-03 00:16:47.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"b3aa8d04412297f8e1f6e682ce25042726d3ee03","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-07-03 00:16:53.000000000","message":"Patch Set 5:\n\nNew patchset patch-id matches previous patchset, but whitespace content has changed.","accounts_in_message":[],"_revision_number":5},{"id":"dcb4219cf07d9a15b5f8384b3caa701b5a592851","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-03 01:17:20.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/32825/5/check/gate-python-keystoneclient-pep8/1286 : SUCCESS in 49s\n- http://docs-draft.openstack.org/32825/5/check/gate-python-keystoneclient-docs/1137/doc/build/html/ : SUCCESS in 55s\n- http://logs.openstack.org/32825/5/check/gate-python-keystoneclient-python26/1210 : SUCCESS in 1m 26s\n- http://logs.openstack.org/32825/5/check/gate-python-keystoneclient-python27/1213 : SUCCESS in 1m 14s\n- http://logs.openstack.org/32825/5/check/gate-tempest-devstack-vm-full/28088 : SUCCESS in 45m 03s\n- http://logs.openstack.org/32825/5/check/gate-tempest-devstack-vm-postgres-full/27794 : SUCCESS in 45m 03s\n- http://logs.openstack.org/32825/5/check/gate-tempest-devstack-vm-quantum/35948 : SUCCESS in 20m 46s\n- http://logs.openstack.org/32825/5/check/gate-grenade-devstack-vm/14473 : FAILURE in 27m 32s (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"957c0d649ed20bd0b8435fd8b540b32ba59fd4e8","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-07-08 16:01:09.000000000","message":"Patch Set 5: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"4a51f7b43ee949342b0cb49c68ac95607e82ab70","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-07-08 19:55:40.000000000","message":"Patch Set 5: (3 inline comments)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"96781a53ae299b1ae18e40c64a3527386a01ae70","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-07-08 21:36:58.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"8ef70a71afc37d798505d33417ca9266aa37fc3e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-08 22:30:46.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/32825/6/check/gate-python-keystoneclient-pep8/1312 : SUCCESS in 58s\n- http://docs-draft.openstack.org/32825/6/check/gate-python-keystoneclient-docs/1163/doc/build/html/ : SUCCESS in 1m 06s\n- http://logs.openstack.org/32825/6/check/gate-python-keystoneclient-python26/1236 : SUCCESS in 2m 09s\n- http://logs.openstack.org/32825/6/check/gate-python-keystoneclient-python27/1239 : SUCCESS in 1m 04s\n- http://logs.openstack.org/32825/6/check/gate-tempest-devstack-vm-full/29427 : SUCCESS in 53m 29s\n- http://logs.openstack.org/32825/6/check/gate-tempest-devstack-vm-postgres-full/29133 : SUCCESS in 46m 25s\n- http://logs.openstack.org/32825/6/check/gate-tempest-devstack-vm-neutron/536 : SUCCESS in 16m 24s\n- http://logs.openstack.org/32825/6/check/gate-grenade-devstack-vm/15659 : FAILURE in 10m 45s (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"2928e202d7a6f5560bc902a47913130800515322","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-07-09 16:05:18.000000000","message":"Patch Set 5: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"f76cd9975d87b7a93685e3dd2c7e641b63dd8987","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-07-09 16:06:21.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"dc158ff04f649a1b1514a3964a174a5295485a24","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-07-21 14:58:05.000000000","message":"Patch Set 6: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nalso, seems like there should be a test for handling of a HEAD request if there isn\u0027t one already.","accounts_in_message":[],"_revision_number":6},{"id":"fc3919f928879ccd9e2f984e36da7e716ec3fd49","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-07-25 04:46:24.000000000","message":"Patch Set 6: (1 inline comment)\n\nBrant, I don\u0027t have a lot of freedom here. From looking at Chmouel\u0027s paste, it appears that coverage simply undercounts something, and becomes more precises with my patch for some reason... I added a few debug points which weren\u0027t reached in the original, but not reflected in the coverage line numbers and percentage. Still, Chmouel said no drop in coverage or highway. What am I to do?\n\nStill, honestly, even if coverage counted right, I would cause a slight drop, and you\u0027re certainly right about HEAD. I think I had an early test with it, but in all the tug-o-war, I dropped it once I got my percentage. I added the test for HEAD specificially.","accounts_in_message":[],"_revision_number":6},{"id":"bb3508f43fb1061708d007f07f74b21cc6f34038","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-07-25 04:56:35.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"f8fea8edb379161187cc56be258f09eb7173ece3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-25 05:54:26.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25/32825/7/check/gate-python-keystoneclient-pep8/1430 : SUCCESS in 57s\n- http://docs-draft.openstack.org/25/32825/7/check/gate-python-keystoneclient-docs/1281/doc/build/html/ : SUCCESS in 1m 17s\n- http://logs.openstack.org/25/32825/7/check/gate-python-keystoneclient-python26/1335 : SUCCESS in 2m 01s\n- http://logs.openstack.org/25/32825/7/check/gate-python-keystoneclient-python27/1357 : SUCCESS in 59s\n- http://logs.openstack.org/25/32825/7/check/gate-tempest-devstack-vm-full/35376 : SUCCESS in 57m 47s\n- http://logs.openstack.org/25/32825/7/check/gate-tempest-devstack-vm-cells-full/2767 : FAILURE in 15m 26s (non-voting)\n- http://logs.openstack.org/25/32825/7/check/gate-tempest-devstack-vm-testr-full/1600 : FAILURE in 28m 30s (non-voting)\n- http://logs.openstack.org/25/32825/7/check/gate-tempest-devstack-vm-postgres-full/35064 : SUCCESS in 51m 05s\n- http://logs.openstack.org/25/32825/7/check/gate-tempest-devstack-vm-neutron/7326 : FAILURE in 22m 41s (non-voting)\n- http://logs.openstack.org/25/32825/7/check/gate-grenade-devstack-vm/20984 : SUCCESS in 21m 53s\n","accounts_in_message":[],"_revision_number":7},{"id":"fbefd74f28718e417c9eceb5abe57eab78f7d86e","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-07-26 19:52:52.000000000","message":"Patch Set 7:\n\nPete Zaitcev - regarding the question about coverage change -- I assume that Chmouel was trying to figure out why the coverage dropped. Which I think is an interesting question. You\u0027ve provided an explanation, so assuming Chmouel is reasonable, I hope he\u0027s OK with the change.","accounts_in_message":[],"_revision_number":7},{"id":"357bec2173e1f1742b97298dd421d413a13b1e08","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-07-26 19:58:40.000000000","message":"Patch Set 7: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"e9dbe845f6b53b82f700830f268dc845e735bd2d","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-07-26 20:42:51.000000000","message":"Patch Set 7: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"e11c839721484eefa3d64cf7c8b3ff849454c4c1","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-07-26 21:01:44.000000000","message":"Patch Set 7: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"c634ee4998e5b4c92f3a85828a5dc0ed51ab0268","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-07-27 04:24:15.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"af9364c588dcca2f9a06e4160768f448462a99a2","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2013-07-27 04:24:27.000000000","message":"Patch Set 7: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"b6fcaa12cdc70fe36cee85ce95a3cebf179ec1df","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-27 05:19:40.000000000","message":"Patch Set 8: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25/32825/8/check/gate-python-keystoneclient-pep8/1468 : SUCCESS in 52s\n- http://docs-draft.openstack.org/25/32825/8/check/gate-python-keystoneclient-docs/1319/doc/build/html/ : SUCCESS in 1m 02s\n- http://logs.openstack.org/25/32825/8/check/gate-python-keystoneclient-python26/1382 : SUCCESS in 1m 53s\n- http://logs.openstack.org/25/32825/8/check/gate-python-keystoneclient-python27/1395 : SUCCESS in 55s\n- http://logs.openstack.org/25/32825/8/check/gate-tempest-devstack-vm-full/36391 : SUCCESS in 53m 45s\n- http://logs.openstack.org/25/32825/8/check/gate-tempest-devstack-vm-cells-full/3395 : FAILURE in 19m 10s (non-voting)\n- http://logs.openstack.org/25/32825/8/check/gate-tempest-devstack-vm-testr-full/2219 : FAILURE in 35m 50s (non-voting)\n- http://logs.openstack.org/25/32825/8/check/gate-tempest-devstack-vm-postgres-full/36068 : SUCCESS in 54m 10s\n- http://logs.openstack.org/25/32825/8/check/gate-tempest-devstack-vm-neutron/8430 : SUCCESS in 26m 29s (non-voting)\n- http://logs.openstack.org/25/32825/8/check/gate-grenade-devstack-vm/21869 : SUCCESS in 25m 40s\n","accounts_in_message":[],"_revision_number":8},{"id":"4f5d1e228e79d95c8410b200ce600c24688ff53b","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-07-27 20:09:25.000000000","message":"Patch Set 8: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":8},{"id":"df21d67c0c84c7b217fb5c65202288f9e2a1d007","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-08-01 21:09:36.000000000","message":"Patch Set 8: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":8},{"id":"da920334afda392ce3aae56d0587d50990c4a918","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-01 21:09:38.000000000","message":"Patch Set 8: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":8},{"id":"b0304dc7224dffaba1584534d29b1d8b12680b29","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-01 23:37:19.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":8},{"id":"32015aa4b66731ff8cf3a1691ba816066535e7ba","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-01 23:37:19.000000000","message":"Patch Set 8: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/25/32825/8/gate/gate-python-keystoneclient-docs/88f23cb/doc/build/html/ : SUCCESS in 58s\n- http://logs.openstack.org/25/32825/8/gate/gate-python-keystoneclient-pep8/7f7c974 : SUCCESS in 1m 02s\n- http://logs.openstack.org/25/32825/8/gate/gate-python-keystoneclient-python26/75d5597 : SUCCESS in 1m 47s\n- http://logs.openstack.org/25/32825/8/gate/gate-python-keystoneclient-python27/5625537 : SUCCESS in 1m 01s\n- http://logs.openstack.org/25/32825/8/gate/gate-tempest-devstack-vm-full/4b02816 : SUCCESS in 45m 34s\n- http://logs.openstack.org/25/32825/8/gate/gate-tempest-devstack-vm-postgres-full/9d0a6dd : SUCCESS in 45m 04s\n- http://logs.openstack.org/25/32825/8/gate/gate-tempest-devstack-vm-neutron/1d42171 : FAILURE in 9m 39s (non-voting)\n- http://logs.openstack.org/25/32825/8/gate/gate-grenade-devstack-vm/cb5a27a : SUCCESS in 23m 10s\n","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"9833226f7e5c86277e703adfd0a2c75c601769b6","revisions":{"b97245edaec95805f7f44a3bc16112e7bddc2716":{"kind":"REWORK","_number":1,"created":"2013-06-13 03:30:26.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/25/32825/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/25/32825/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/1"}}},"commit":{"parents":[{"commit":"76daaffd870166ff8070a6d56835fc4a25f0a1fb","subject":"Merge \"Allow keystoneclient to work with older keystone installs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/76daaffd870166ff8070a6d56835fc4a25f0a1fb"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-06-13 03:23:21.000000000","tz":-360},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-06-13 03:23:21.000000000","tz":-360},"subject":"Drop webob from auth_token.py","message":"Drop webob from auth_token.py\n\nThis came up as a packaging problem. Now that Swift does not need\npython-webob RPM, some sites install a proxy node without. Fine,\nwe add the proper webob dependency to the python-keystoneclient.\nBut then there\u0027s a mess with parallel installs, and we end patching\nsetup.py and diverge from upstream.\n\nBut come to think of it, isn\u0027t it a miracle that this works in\nthe first place? The auth_token invokes WebOb, and then lets lose\nwith the results inside of a server that does not have WebOb.\n\nIt seems like it may be better just stick to WSGI protocol by\nsmall amount of hand-rolled code and drop WebOb altogether.\n\nNote that we keep WebOb in the testing code. The fix is purely\nabout the stuff that runs inside a WSGI server.\n\nChange-Id: Iba33b11e77b9910211983aa725c69d3886e1c7a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b97245edaec95805f7f44a3bc16112e7bddc2716"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b97245edaec95805f7f44a3bc16112e7bddc2716"}]},"branch":"refs/heads/master"},"c02cda1b9463980f1a8a361aa1f3c38e29b56447":{"kind":"REWORK","_number":2,"created":"2013-06-20 22:04:47.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/25/32825/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/25/32825/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/2"}}},"commit":{"parents":[{"commit":"abe6781913a7a4e376c0798e2e962ef16e9a48e6","subject":"Change memcache config entry name in Keystone to be consistent with Oslo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/abe6781913a7a4e376c0798e2e962ef16e9a48e6"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-06-20 22:03:11.000000000","tz":-360},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-06-20 22:03:11.000000000","tz":-360},"subject":"Drop webob from auth_token.py","message":"Drop webob from auth_token.py\n\nThis came up as a packaging problem. Now that Swift does not need\npython-webob RPM, some sites install a proxy node without. Fine,\nwe add the proper webob dependency to the python-keystoneclient.\nBut then there\u0027s a mess with parallel installs, and we end patching\nsetup.py and diverge from upstream.\n\nIt may be better just stick to WSGI protocol by small amount of\nhand-rolled code and drop WebOb altogether.\n\nNote that we keep WebOb in the testing code. The fix is purely\nabout the stuff that runs inside a WSGI server.\n\nChange-Id: Iba33b11e77b9910211983aa725c69d3886e1c7a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c02cda1b9463980f1a8a361aa1f3c38e29b56447"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c02cda1b9463980f1a8a361aa1f3c38e29b56447"}]},"branch":"refs/heads/master"},"28ad354815e62060434c21b360b7101afb18491d":{"kind":"REWORK","_number":3,"created":"2013-07-02 21:08:00.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/25/32825/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/25/32825/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/3"}}},"commit":{"parents":[{"commit":"9ee038fc65a439d16d949e56efa65b147b9b8923","subject":"Merge \"Fix and enable H401\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9ee038fc65a439d16d949e56efa65b147b9b8923"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-07-02 21:01:33.000000000","tz":-360},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-07-02 21:01:33.000000000","tz":-360},"subject":"Drop webob from auth_token.py","message":"Drop webob from auth_token.py\n\nThis came up as a packaging problem in Fedora. Now that Swift does\nnot need python-webob RPM, some sites install a proxy node without.\nWe add the proper webob dependency to the python-keystoneclient.\nStill, in the face of parallel installs, and we end patching\nsetup.py and diverge from upstream, and we do not like it.\n\nIt may be better just stick to WSGI protocol by small amount of\nhand-rolled code and drop WebOb altogether.\n\nNote that we keep WebOb in the testing code. The fix is purely\nabout the stuff that runs inside a WSGI server. Therefore,\nrequirements.txt continues having no WebOb (apparently, was\nforgotten before), but test-requirements.txt keeps WebOb in,\nand this patch changes nothing.\n\nInitial version of this patch produced an inexplicable drop in\ntesting coverage and Chmouel put his foot down on it. We were\nunable to figure out why the drop happened. Most likely coverage\nsimply lied about the previous percentages and getting rid of\nimport webob permitted it a better analysis. So, we add some\nunrelated tests to bump coverage percentages up.\n\nChange-Id: Iba33b11e77b9910211983aa725c69d3886e1c7a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/28ad354815e62060434c21b360b7101afb18491d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/28ad354815e62060434c21b360b7101afb18491d"}]},"branch":"refs/heads/master"},"76f24cff94968be4897a0927593ccbc8a5d3b8a0":{"kind":"REWORK","_number":4,"created":"2013-07-02 21:13:48.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/25/32825/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/25/32825/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/4"}}},"commit":{"parents":[{"commit":"9ee038fc65a439d16d949e56efa65b147b9b8923","subject":"Merge \"Fix and enable H401\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9ee038fc65a439d16d949e56efa65b147b9b8923"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-07-02 21:12:48.000000000","tz":-360},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-07-02 21:12:48.000000000","tz":-360},"subject":"Drop webob from auth_token.py","message":"Drop webob from auth_token.py\n\nThis came up as a packaging problem in Fedora. Now that Swift does\nnot need python-webob RPM, some sites install a proxy node without.\nWe add the proper webob dependency to the python-keystoneclient.\nStill, in the face of parallel installs, and we end patching\nsetup.py and diverge from upstream, and we do not like it.\n\nIt may be better just stick to WSGI protocol by small amount of\nhand-rolled code and drop WebOb altogether.\n\nNote that we keep WebOb in the testing code. The fix is purely\nabout the stuff that runs inside a WSGI server. Therefore,\nrequirements.txt continues having no WebOb (apparently, was\nforgotten before), but test-requirements.txt keeps WebOb in,\nand this patch changes nothing.\n\nInitial version of this patch produced an inexplicable drop in\ntesting coverage and Chmouel put his foot down on it. We were\nunable to figure out why the drop happened. Most likely coverage\nsimply lied about the previous percentages and getting rid of\nimport webob permitted it a better analysis. So, we add some\nunrelated tests to bump coverage percentages up.\n\nChange-Id: Iba33b11e77b9910211983aa725c69d3886e1c7a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/76f24cff94968be4897a0927593ccbc8a5d3b8a0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/76f24cff94968be4897a0927593ccbc8a5d3b8a0"}]},"branch":"refs/heads/master"},"38264fe995298fd29aeabebecd598d62807b326f":{"kind":"REWORK","_number":5,"created":"2013-07-03 00:16:47.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/25/32825/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/25/32825/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/5"}}},"commit":{"parents":[{"commit":"9ee038fc65a439d16d949e56efa65b147b9b8923","subject":"Merge \"Fix and enable H401\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9ee038fc65a439d16d949e56efa65b147b9b8923"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-07-03 00:13:03.000000000","tz":-360},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-07-03 00:13:03.000000000","tz":-360},"subject":"Drop webob from auth_token.py","message":"Drop webob from auth_token.py\n\nThis came up as a packaging problem in Fedora. Now that Swift does\nnot need python-webob RPM, some sites install a proxy node without.\nWe add the proper webob dependency to the python-keystoneclient.\nStill, in the face of parallel installs, and we end patching\nsetup.py and diverge from upstream, and we do not like it.\n\nIt may be better just stick to WSGI protocol by small amount of\nhand-rolled code and drop WebOb altogether.\n\nNote that we keep WebOb in the testing code. The fix is purely\nabout the stuff that runs inside a WSGI server. Therefore,\nrequirements.txt continues having no WebOb (apparently, was\nforgotten before), but test-requirements.txt keeps WebOb in,\nand this patch changes nothing.\n\nInitial version of this patch produced an inexplicable drop in\ntesting coverage and Chmouel put his foot down on it. We were\nunable to figure out why the drop happened. Most likely coverage\nsimply lied about the previous percentages and getting rid of\nimport webob permitted it a better analysis. So, we add some\nunrelated tests to bump coverage percentages up.\n\nChange-Id: Iba33b11e77b9910211983aa725c69d3886e1c7a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/38264fe995298fd29aeabebecd598d62807b326f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/38264fe995298fd29aeabebecd598d62807b326f"}]},"branch":"refs/heads/master"},"35e03d0014626b499b6864f956b772e7cb38e77a":{"kind":"REWORK","_number":6,"created":"2013-07-08 21:36:58.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/25/32825/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/25/32825/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/6"}}},"commit":{"parents":[{"commit":"6139663e09c52c19fa218a220a5d44733e641966","subject":"Flake8 should ignore build folder","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6139663e09c52c19fa218a220a5d44733e641966"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-07-08 21:35:52.000000000","tz":-360},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-07-08 21:35:52.000000000","tz":-360},"subject":"Drop webob from auth_token.py","message":"Drop webob from auth_token.py\n\nThis came up as a packaging problem in Fedora. Now that Swift does\nnot need python-webob RPM, some sites install a proxy node without.\nWe add the proper webob dependency to the python-keystoneclient.\nStill, in the face of parallel installs, and we end patching\nsetup.py and diverge from upstream, and we do not like it.\n\nIt may be better just stick to WSGI protocol by small amount of\nhand-rolled code and drop WebOb altogether.\n\nNote that we keep WebOb in the testing code. The fix is purely\nabout the stuff that runs inside a WSGI server. Therefore,\nrequirements.txt continues having no WebOb (apparently, was\nforgotten before), but test-requirements.txt keeps WebOb in,\nand this patch changes nothing.\n\nInitial version of this patch produced an inexplicable drop in\ntesting coverage and Chmouel put his foot down on it. We were\nunable to figure out why the drop happened. Most likely coverage\nsimply lied about the previous percentages and getting rid of\nimport webob permitted it a better analysis. So, we add some\nunrelated tests to bump coverage percentages up.\n\nThis version also adds comments rather than docstrings, because\nthey need to source as context.\n\nChange-Id: Iba33b11e77b9910211983aa725c69d3886e1c7a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/35e03d0014626b499b6864f956b772e7cb38e77a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/35e03d0014626b499b6864f956b772e7cb38e77a"}]},"branch":"refs/heads/master"},"a8162b75538f20d203d171d428c7f88c34b382cd":{"kind":"REWORK","_number":7,"created":"2013-07-25 04:56:35.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/25/32825/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/25/32825/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/7"}}},"commit":{"parents":[{"commit":"fd8f05350b7bf07d8505100d400ca77892236ed9","subject":"Merge \"Use ServiceCatalog.factory, the object has no __init__\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fd8f05350b7bf07d8505100d400ca77892236ed9"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-07-25 04:53:30.000000000","tz":-360},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-07-25 04:53:30.000000000","tz":-360},"subject":"Drop webob from auth_token.py","message":"Drop webob from auth_token.py\n\nThis came up as a packaging problem in Fedora. Now that Swift does\nnot need python-webob RPM, some sites install a proxy node without.\nWe add the proper webob dependency to the python-keystoneclient.\nStill, in the face of parallel installs, and we end patching\nsetup.py and diverge from upstream, and we do not like it.\n\nIt may be better just stick to WSGI protocol by small amount of\nhand-rolled code and drop WebOb altogether.\n\nNote that we keep WebOb in the testing code. The fix is purely\nabout the stuff that runs inside a WSGI server. Therefore,\nrequirements.txt continues having no WebOb (apparently, was\nforgotten before), but test-requirements.txt keeps WebOb in,\nand this patch changes nothing.\n\nInitial version of this patch produced an inexplicable drop in\ntesting coverage and Chmouel put his foot down on it. We were\nunable to figure out why the drop happened. Most likely coverage\nsimply lied about the previous percentages and getting rid of\nimport webob permitted it a better analysis. So, we add some\nunrelated tests to bump coverage percentages up.\n\nOf course we add a useful test too.\n\nThis version also adds comments rather than docstrings, because\nthey need to source as context.\n\nChange-Id: Iba33b11e77b9910211983aa725c69d3886e1c7a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a8162b75538f20d203d171d428c7f88c34b382cd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a8162b75538f20d203d171d428c7f88c34b382cd"}]},"branch":"refs/heads/master"},"9833226f7e5c86277e703adfd0a2c75c601769b6":{"kind":"REWORK","_number":8,"created":"2013-07-27 04:24:15.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/25/32825/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/25/32825/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/25/32825/8"}}},"commit":{"parents":[{"commit":"fd8f05350b7bf07d8505100d400ca77892236ed9","subject":"Merge \"Use ServiceCatalog.factory, the object has no __init__\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fd8f05350b7bf07d8505100d400ca77892236ed9"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-07-27 04:21:10.000000000","tz":-360},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2013-07-27 04:21:10.000000000","tz":-360},"subject":"Drop webob from auth_token.py","message":"Drop webob from auth_token.py\n\nThis came up as a packaging problem in Fedora. Now that Swift does\nnot need python-webob RPM, some sites install a proxy node without.\nWe add the proper webob dependency to the python-keystoneclient.\nStill, in the face of parallel installs, and we end patching\nsetup.py and diverge from upstream, and we do not like it.\n\nIt may be better just stick to WSGI protocol by small amount of\nhand-rolled code and drop WebOb altogether.\n\nNote that we keep WebOb in the testing code. The fix is purely\nabout the stuff that runs inside a WSGI server. Therefore,\nrequirements.txt continues having no WebOb (apparently, was\nforgotten before), but test-requirements.txt keeps WebOb in,\nand this patch changes nothing.\n\nInitial version of this patch produced an inexplicable drop in\ntesting coverage and Chmouel put his foot down on it. We were\nunable to figure out why the drop happened. Most likely coverage\nsimply lied about the previous percentages and getting rid of\nimport webob permitted it a better analysis. So, we add some\nunrelated tests to bump coverage percentages up.\n\nOf course we add a targeted test for the new code too. For that\none to work, we change how set_middleware() treats its fake_http\nargument.\n\nThis version also adds comments rather than docstrings, because\nthey need to source as context.\n\nChange-Id: Iba33b11e77b9910211983aa725c69d3886e1c7a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9833226f7e5c86277e703adfd0a2c75c601769b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9833226f7e5c86277e703adfd0a2c75c601769b6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}