)]}'
{"id":"openstack%2Fpython-keystoneclient~331629","triplet_id":"openstack%2Fpython-keystoneclient~master~I78e62fbd877ba32744fa3587ad2eb497bfb79fc2","project":"openstack/python-keystoneclient","branch":"master","topic":"domain-python-docs","hashtags":[],"change_id":"I78e62fbd877ba32744fa3587ad2eb497bfb79fc2","subject":"Improve docs for v3 domains","status":"MERGED","created":"2016-06-20 11:26:42.000000000","updated":"2016-08-19 13:22:31.000000000","submitted":"2016-06-20 16:03:36.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c24c509a68549c25752625437d0541cd01f58b21","_number":331629,"virtual_id_number":331629,"owner":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2016-08-19 13:22:31.000000000","post_submit":true,"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},{"value":2,"date":"2016-06-20 16:03:36.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"all":[{"value":0,"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-06-20 13:37:38.000000000","_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":2,"date":"2016-06-20 14:26:59.000000000","_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"all":[{"value":0,"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":1,"date":"2016-06-20 14:26:59.000000000","_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-20 13:37:38.000000000","updated_by":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"reviewer":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"state":"REVIEWER"},{"updated":"2016-06-20 14:26:59.000000000","updated_by":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"reviewer":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"state":"REVIEWER"},{"updated":"2016-06-20 16:03:36.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5b69660e0d995ba1c7a7a1cc0f63406810318baf","author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"date":"2016-06-20 11:26:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"197819669db570f732a067a99ebc5241c6c27af8","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2016-06-20 11:34:36.000000000","message":"Patch Set 1: Code-Review-1\n\nThis is looking awesome. My only suggestion is to rebase this on master, and then rebase the tests on this, so we make sure the docs come first logically","accounts_in_message":[],"_revision_number":1},{"id":"bfa8a9a7022ca6a5381be5817dec1c399a090bd7","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2016-06-20 11:37:07.000000000","message":"Patch Set 1:\n\nTo do that, while in this branch, run \u0027git rebase -i master\u0027 and remove \u0027Add domain functional tests\u0027 commit. Then go to tests\u0027 branch and run \u0027git rebase -i domain-python-docs\u0027.","accounts_in_message":[],"_revision_number":1},{"id":"4a878ba8995fe2ccdfaad97d13b1c59222914930","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2016-06-20 11:58:01.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nNisha, the git log is like that:\n\ncommit e2bcf604c4b8b43b586c29931a91beebf702941c\nAuthor: Nisha Yadav \u003cynisha11@gmail.com\u003e\nDate:   Mon Jun 20 16:53:08 2016 +0530\n\n    Improve docs for v3 domains\n    \n    In preparation to add functional tests for v3 domains, this change\n    proposes to detail the method docs, because the tests need to be\n    based on them.\n    \n    Change-Id: I78e62fbd877ba32744fa3587ad2eb497bfb79fc2\n\ncommit e2368b0f8b7aa845cf8d8c60720d91ee416f7c12\nAuthor: Nisha Yadav \u003cynisha11@gmail.com\u003e\nDate:   Tue Jun 14 21:47:07 2016 +0530\n\n    Add domain functional tests\n    \n    Adds functional tests for domains. For now, the tests are created under\n    a single class. Once we have a gate that runs against LDAP,\n    we will create a class that only contains readonly tests and\n    a tox call for it (e.g tox -e functional-readonly).\n    \n    Change-Id: I74bff2728c09e6aafaced97a7836f51e58a81786\n\nyou need to invert the order where the commits appear, so the tests comes *after* the docs addition, you can do that just like Samuel suggested or via a rebase in this change branch:\n\n  $ git rebase -i HEAD~2\n\nThere, you invert the commits order and save the changes. Then you do a regular `git review`.","accounts_in_message":[],"_revision_number":1},{"id":"59957a135111ad15014f3c2aa0cf64b7db041052","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2016-06-20 12:04:25.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6710ee77ee60d44661315282f16a9af115947ec2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 12:18:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/29/331629/1/check/gate-python-keystoneclient-docs/a74e867//doc/build/html/ : SUCCESS in 4m 56s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/29/331629/1/check/gate-python-keystoneclient-pep8/876a222/ : SUCCESS in 3m 08s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/29/331629/1/check/gate-python-keystoneclient-python27/f66c5e9/ : SUCCESS in 2m 39s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/29/331629/1/check/gate-python-keystoneclient-python34/6b4675f/ : SUCCESS in 5m 52s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/29/331629/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/2fdc96c/ : SUCCESS in 48m 31s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/29/331629/1/check/gate-keystoneclient-dsvm-functional/d63d818/ : SUCCESS in 12m 44s","accounts_in_message":[],"_revision_number":1},{"id":"1234547d5b77678aafe569e77f7e15d650dbe08d","author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"date":"2016-06-20 13:35:19.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":1},{"id":"22024e098bdcdc8086ce2e9bde25ef18aca2c22d","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2016-06-20 13:37:38.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks! LGTM","accounts_in_message":[],"_revision_number":2},{"id":"2fab86104f64111925b2f79fc2191a813c2a836d","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2016-06-20 14:26:59.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"05dae4657c90e1a49706a7d0e3cbdc28a38fa5c6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 15:00:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/29/331629/2/check/gate-python-keystoneclient-docs/0ac3983//doc/build/html/ : SUCCESS in 3m 36s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/29/331629/2/check/gate-python-keystoneclient-pep8/883c80f/ : SUCCESS in 3m 07s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/29/331629/2/check/gate-python-keystoneclient-python27/76c69ec/ : SUCCESS in 2m 25s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/29/331629/2/check/gate-python-keystoneclient-python34/d71ecf9/ : SUCCESS in 3m 40s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/29/331629/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/d40b428/ : SUCCESS in 1h 05m 11s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/29/331629/2/check/gate-keystoneclient-dsvm-functional/9de4317/ : SUCCESS in 24m 39s","accounts_in_message":[],"_revision_number":2},{"id":"ee7c10196e7685495334b0e28437eaf2596cba06","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 15:00:12.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"0f0f793b10c6b3e726e694ea07bec02799285c30","date":"2016-06-20 16:03:36.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"68c14d8b34bb97937a83d4c78c87a9e9d82703cf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 16:03:36.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/29/331629/2/gate/gate-python-keystoneclient-docs/ea74397//doc/build/html/ : SUCCESS in 2m 57s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/29/331629/2/gate/gate-python-keystoneclient-pep8/1451769/ : SUCCESS in 5m 13s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/29/331629/2/gate/gate-python-keystoneclient-python27/4867278/ : SUCCESS in 6m 35s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/29/331629/2/gate/gate-python-keystoneclient-python34/008205a/ : SUCCESS in 6m 06s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/29/331629/2/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/aa810b5/ : SUCCESS in 1h 03m 08s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/29/331629/2/gate/gate-keystoneclient-dsvm-functional/13debd8/ : SUCCESS in 22m 10s","accounts_in_message":[],"_revision_number":2},{"id":"e2bbd82bb37424771cd7abbda1c37c312fb67736","author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"date":"2016-08-19 13:22:31.000000000","message":"Patch Set 2:\n\nA nit left by this patch has been addressed here, https://review.openstack.org/#/c/357867/","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"79db63ef1166afb2df2d08a6df0055d4eaaa7e48","revisions":{"e2bcf604c4b8b43b586c29931a91beebf702941c":{"kind":"REWORK","_number":1,"created":"2016-06-20 11:26:42.000000000","uploader":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"ref":"refs/changes/29/331629/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/29/331629/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/331629/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/331629/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/331629/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/331629/1"}}},"commit":{"parents":[{"commit":"e2368b0f8b7aa845cf8d8c60720d91ee416f7c12","subject":"Add domain functional tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e2368b0f8b7aa845cf8d8c60720d91ee416f7c12"}]}],"author":{"name":"Nisha Yadav","email":"ynisha11@gmail.com","date":"2016-06-20 11:23:08.000000000","tz":330},"committer":{"name":"Nisha Yadav","email":"ynisha11@gmail.com","date":"2016-06-20 11:23:08.000000000","tz":330},"subject":"Improve docs for v3 domains","message":"Improve docs for v3 domains\n\nIn preparation to add functional tests for v3 domains, this change\nproposes to detail the method docs, because the tests need to be\nbased on them.\n\nChange-Id: I78e62fbd877ba32744fa3587ad2eb497bfb79fc2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e2bcf604c4b8b43b586c29931a91beebf702941c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e2bcf604c4b8b43b586c29931a91beebf702941c"}]},"branch":"refs/heads/master"},"79db63ef1166afb2df2d08a6df0055d4eaaa7e48":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2016-06-20 13:35:19.000000000","uploader":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"ref":"refs/changes/29/331629/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/29/331629/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/331629/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/331629/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/331629/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/331629/2"}}},"commit":{"parents":[{"commit":"3113aee3da1c531f0a553534742f9d59d7200332","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3113aee3da1c531f0a553534742f9d59d7200332"}]}],"author":{"name":"Nisha Yadav","email":"ynisha11@gmail.com","date":"2016-06-20 11:23:08.000000000","tz":330},"committer":{"name":"Nisha Yadav","email":"ynisha11@gmail.com","date":"2016-06-20 13:35:19.000000000","tz":0},"subject":"Improve docs for v3 domains","message":"Improve docs for v3 domains\n\nIn preparation to add functional tests for v3 domains, this change\nproposes to detail the method docs, because the tests need to be\nbased on them.\n\nChange-Id: I78e62fbd877ba32744fa3587ad2eb497bfb79fc2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/79db63ef1166afb2df2d08a6df0055d4eaaa7e48"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/79db63ef1166afb2df2d08a6df0055d4eaaa7e48"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}