)]}'
{"id":"openstack%2Fpython-keystoneclient~337435","triplet_id":"openstack%2Fpython-keystoneclient~master~Iae4ce0fe84fae810711cc8c3fdb94eb9ca1d772e","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1586268","hashtags":[],"change_id":"Iae4ce0fe84fae810711cc8c3fdb94eb9ca1d772e","subject":"Add __ne__ built-in function","status":"MERGED","created":"2016-07-05 05:53:41.000000000","updated":"2016-08-11 03:55:38.000000000","submitted":"2016-08-11 03:55:38.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f59f88763fd951b35e5c07dfdb5e52f13baf733b","_number":337435,"virtual_id_number":337435,"owner":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-08-11 03:55:38.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":0,"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},{"value":2,"date":"2016-08-11 01:49:58.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":0,"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},{"value":1,"date":"2016-08-11 01:49:58.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":0,"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-05 20:16:27.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2016-08-09 02:39:30.000000000","updated_by":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"reviewer":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"state":"REVIEWER"},{"updated":"2016-08-09 13:38:15.000000000","updated_by":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"reviewer":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"state":"REVIEWER"},{"updated":"2016-08-10 14:45:26.000000000","updated_by":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"reviewer":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"state":"REVIEWER"},{"updated":"2016-08-10 15:02:42.000000000","updated_by":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"reviewer":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"state":"REVIEWER"},{"updated":"2016-08-11 01:49:58.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-08-11 03:55:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ea44fba2b6e5883e39f1cac3f928fa1d916442ab","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-07-05 05:53:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5f95783a40f94ee06bafc145f9710fb2f40e5a86","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-05 06:58:28.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/35/337435/1/check/gate-python-keystoneclient-docs/39b29ca//doc/build/html/ : SUCCESS in 1m 34s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/35/337435/1/check/gate-python-keystoneclient-pep8/d813f4c/ : FAILURE in 2m 38s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/35/337435/1/check/gate-python-keystoneclient-python27/7ab1767/ : FAILURE in 1m 49s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/35/337435/1/check/gate-python-keystoneclient-python34/72a10c9/ : FAILURE in 2m 48s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/35/337435/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/333a8af/ : SUCCESS in 1h 02m 23s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/35/337435/1/check/gate-keystoneclient-dsvm-functional/2fda539/ : SUCCESS in 22m 28s","accounts_in_message":[],"_revision_number":1},{"id":"93ceb409af2f111addd735eaf25858751397d98a","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-07-05 09:26:29.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"11a9e364dbfed3c5b211da998bcd8b335c827e7b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-05 10:55:16.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/35/337435/1/check/gate-python-keystoneclient-docs/e6531a0//doc/build/html/ : SUCCESS in 1m 38s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/35/337435/1/check/gate-python-keystoneclient-pep8/56df650/ : FAILURE in 1m 48s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/35/337435/1/check/gate-python-keystoneclient-python27/d6868af/ : FAILURE in 2m 02s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/35/337435/1/check/gate-python-keystoneclient-python34/155a4e3/ : FAILURE in 2m 47s\n- gate-python-keystoneclient-python35-nv http://logs.openstack.org/35/337435/1/check/gate-python-keystoneclient-python35-nv/149fafa/ : FAILURE in 3m 57s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/35/337435/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/56839e6/ : SUCCESS in 1h 07m 45s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/35/337435/1/check/gate-keystoneclient-dsvm-functional/b438d1b/ : SUCCESS in 21m 29s","accounts_in_message":[],"_revision_number":1},{"id":"ad4001b6282183b3bf5144d5b05064a225288108","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-07-06 07:59:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"af242cf4e4d6bebd7ac466c5547e66a5f9668b7a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-06 09:14:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/35/337435/2/check/gate-python-keystoneclient-docs/a685a5d//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/35/337435/2/check/gate-python-keystoneclient-pep8/27a21ed/ : SUCCESS in 1m 56s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/35/337435/2/check/gate-python-keystoneclient-python27/bda201f/ : SUCCESS in 6m 19s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/35/337435/2/check/gate-python-keystoneclient-python34/030e488/ : SUCCESS in 3m 13s\n- gate-python-keystoneclient-python35-nv http://logs.openstack.org/35/337435/2/check/gate-python-keystoneclient-python35-nv/fac0dff/ : SUCCESS in 3m 08s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/35/337435/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/68d7681/ : SUCCESS in 1h 06m 54s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/35/337435/2/check/gate-keystoneclient-dsvm-functional/801b12b/ : SUCCESS in 21m 14s","accounts_in_message":[],"_revision_number":2},{"id":"a035d8893538fed5ebe956bf32614849d09529fa","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2016-07-06 10:23:59.000000000","message":"Patch Set 2: Code-Review-1\n\nThis needs tests.","accounts_in_message":[],"_revision_number":2},{"id":"812712fbbc92dacc780b5477e6f23bbbda200dcc","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2016-07-06 11:04:51.000000000","message":"Patch Set 2: Code-Review-1\n\nUnderstood the reasoning behind your change, but can you provide a test case that compares two resources with !\u003d and the comparison fails without your change? This can be accomplished via a WIP [1] test.\n\n[1] http://docs.openstack.org/developer/keystone/developing.html#work-in-progress-tests","accounts_in_message":[],"_revision_number":2},{"id":"51f93eb93f8e9c4d392ba770f5108a6b21a57a15","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-07-06 11:54:56.000000000","message":"Patch Set 2:\n\nHi, Boris and Rodrigo.\n\nclass Resource(object):\n    def __init__(self, person):\n        self.person \u003d person\n\n    def __eq__(self, other):\n        return self.person \u003d\u003d other.person\n\nr1 \u003d Resource(\"test\")\nr2 \u003d Resource(\"test\")\nr3 \u003d Resource(\"test_r3\")\nr4 \u003d Resource(\"test_r4\")\n\nprint r1 !\u003d r2\nprint r1 \u003d\u003d r2\nprint r3 !\u003d r4\nprint r3 \u003d\u003d r4\n\nThe result is :\nTrue\nTrue\nTrue\nFalse\n\nWhether r1 is precisely the same to r2 or not, self.assertNotEqual(r1, r2) return true.So I think self.assertNotEqual doesn\u0027t work at all in python2 and should be modified. And I don\u0027t know what tests should we add.","accounts_in_message":[],"_revision_number":2},{"id":"9ab298672ae728d9c3165b1b3074f9a8222b4965","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2016-07-06 13:50:33.000000000","message":"Patch Set 2:\n\nthanks, makes sense. You can place the test, using the same approach of your comment, here: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/tests/unit/test_base.py\n\njust realized that we don\u0027t have the WIP decorator in keystoneclient :)","accounts_in_message":[],"_revision_number":2},{"id":"b74d9ec90d74b2419fbe83faa5e73b8466fd0e5f","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-07-14 08:10:54.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"97e8c79c2ec069fcbfea4529569afd98555461bf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-14 09:18:36.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/35/337435/3/check/gate-python-keystoneclient-docs/d92e5b3//doc/build/html/ : SUCCESS in 2m 00s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/35/337435/3/check/gate-python-keystoneclient-pep8/7afb8bb/ : SUCCESS in 2m 19s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/35/337435/3/check/gate-python-keystoneclient-python27/dd57b0b/ : SUCCESS in 2m 27s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/35/337435/3/check/gate-python-keystoneclient-python34/fed7232/ : SUCCESS in 3m 41s\n- gate-python-keystoneclient-python35-nv http://logs.openstack.org/35/337435/3/check/gate-python-keystoneclient-python35-nv/7c86cb6/ : SUCCESS in 4m 28s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/35/337435/3/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/f196577/ : SUCCESS in 1h 04m 41s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/35/337435/3/check/gate-keystoneclient-dsvm-functional/a214e2a/ : SUCCESS in 20m 34s","accounts_in_message":[],"_revision_number":3},{"id":"672d79997acdd2f2d7770127ef37262d8c1b7445","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2016-07-14 13:25:55.000000000","message":"Patch Set 3: Code-Review-1\n\nThink you need a different kind of test, the tests you\u0027ve added passes even if I remove the __ne__ code.","accounts_in_message":[],"_revision_number":3},{"id":"dd01ac20f6464a83fcca8af9cac06537023805f5","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2016-07-14 13:27:44.000000000","message":"Patch Set 3:\n\nMaybe you can try to use assertFalse and assertTrue, for example:\n\n  r1 \u003d Resource(\"test\")\n  r2 \u003d Resource(\"test\")\n  self.assertTrue(r1 \u003d\u003d r2)\n  self.assertFalse(r1 !\u003d r2)","accounts_in_message":[],"_revision_number":3},{"id":"a3b4da924b191d21e7a38f5f9b33a14871e14d54","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2016-08-03 11:52:37.000000000","message":"Patch Set 3: Code-Review-1\n\ni agree with Rodrigo\u0027s comment","accounts_in_message":[],"_revision_number":3},{"id":"1621d021e82b30ceb830c1aa8fc1c415c6182572","author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"date":"2016-08-05 02:52:26.000000000","message":"Patch Set 3: Code-Review-1\n\npls update the testcase.","accounts_in_message":[],"_revision_number":3},{"id":"35a8472242356f331f2e75f8e23e312fc2550e33","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-08-05 07:19:44.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f7a3cd7609c61042fb07df4352fa5b384f291aaf","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-08-05 07:23:40.000000000","message":"Patch Set 4:\n\n\u003e Maybe you can try to use assertFalse and assertTrue, for example:\n \u003e \n \u003e r1 \u003d Resource(\"test\")\n \u003e r2 \u003d Resource(\"test\")\n \u003e self.assertTrue(r1 \u003d\u003d r2)\n \u003e self.assertFalse(r1 !\u003d r2)\n\nThank you very much, Rodrigo.","accounts_in_message":[],"_revision_number":4},{"id":"f77a38352d98a907afa216174b0508a59592f960","author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"date":"2016-08-05 08:12:59.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)\n\nThe testcase can still pass if I revert the change in base.py. We need a testcase for bug fixing is because the testcase can show how it will fail without fix, pls update the testcase again, thanks!","accounts_in_message":[],"_revision_number":4},{"id":"43af7237a5969807b25922061c94edcdedc99fff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-05 08:42:06.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/35/337435/4/check/gate-python-keystoneclient-docs-ubuntu-xenial/21dda0a//doc/build/html/ : SUCCESS in 1m 21s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/35/337435/4/check/gate-python-keystoneclient-pep8-ubuntu-xenial/2a13416/ : SUCCESS in 2m 18s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/35/337435/4/check/gate-python-keystoneclient-python27-ubuntu-xenial/b5336d1/ : SUCCESS in 3m 10s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/35/337435/4/check/gate-python-keystoneclient-python34/0304cf8/ : SUCCESS in 3m 04s\n- gate-python-keystoneclient-python35-nv http://logs.openstack.org/35/337435/4/check/gate-python-keystoneclient-python35-nv/cccba62/ : SUCCESS in 3m 01s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/35/337435/4/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/9c9a244/ : SUCCESS in 1h 20m 13s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/35/337435/4/check/gate-keystoneclient-dsvm-functional/2c4ed4f/ : SUCCESS in 33m 03s","accounts_in_message":[],"_revision_number":4},{"id":"769106151d149a72e456e4d7f941cdbe3623195c","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-08-05 09:03:06.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"5615b757da80890215e9453fde562396da4ad956","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-08-05 09:08:42.000000000","message":"Patch Set 5:\n\n\u003e (1 comment)\n \u003e \n \u003e The testcase can still pass if I revert the change in base.py. We\n \u003e need a testcase for bug fixing is because the testcase can show how\n \u003e it will fail without fix, pls update the testcase again, thanks!\n\nThank you for review\n\n \u003e (1 comment)\n \u003e \n \u003e The testcase can still pass if I revert the change in base.py. We\n \u003e need a testcase for bug fixing is because the testcase can show how\n \u003e it will fail without fix, pls update the testcase again, thanks!\n\nThank you for review my code again and your advice. And sorry for my careless. \nI have fixed it.","accounts_in_message":[],"_revision_number":5},{"id":"4514a4948f14c77fb5f02fdf718a5bcef9d887e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-05 10:40:58.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/35/337435/5/check/gate-python-keystoneclient-docs-ubuntu-xenial/e588d9e//doc/build/html/ : SUCCESS in 1m 28s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/35/337435/5/check/gate-python-keystoneclient-pep8-ubuntu-xenial/69f516d/ : SUCCESS in 2m 44s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/35/337435/5/check/gate-python-keystoneclient-python27-ubuntu-xenial/8d43817/ : SUCCESS in 4m 31s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/35/337435/5/check/gate-python-keystoneclient-python34/339d2fa/ : SUCCESS in 1m 40s\n- gate-python-keystoneclient-python35-nv http://logs.openstack.org/35/337435/5/check/gate-python-keystoneclient-python35-nv/ff80d16/ : SUCCESS in 6m 02s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/35/337435/5/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/c9d7975/ : SUCCESS in 1h 18m 18s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/35/337435/5/check/gate-keystoneclient-dsvm-functional/e16432e/ : SUCCESS in 27m 11s","accounts_in_message":[],"_revision_number":5},{"id":"e2d877fa2d7c395ef84a636b4d79b0f76fe40b16","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2016-08-05 20:16:27.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"39be2f1a8991a489e7b8161df6a82b37cbdf0a81","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2016-08-07 15:42:05.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"075d322be87a93f4ce8b26e8feeeee53bf6d7656","author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"date":"2016-08-08 03:29:34.000000000","message":"Patch Set 5: Code-Review-1\n\n(4 comments)\n\n@yuyafei, thanks for updating the testcases, much better now, pls see the inline comments, not quite sure if this bug affects keystonclient anymore but it\u0027s nice to have imo.","accounts_in_message":[],"_revision_number":5},{"id":"eb9d8641d207d92882b66ba62b7d7378091ab8cf","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-08-08 12:12:58.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"44647e11d57c89759d61e66cd190a17710d4ec1a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-08 13:33:30.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/35/337435/6/check/gate-python-keystoneclient-docs-ubuntu-xenial/0c18196//doc/build/html/ : SUCCESS in 2m 31s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/35/337435/6/check/gate-python-keystoneclient-pep8-ubuntu-xenial/4274472/ : SUCCESS in 2m 54s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/35/337435/6/check/gate-python-keystoneclient-python27-ubuntu-xenial/502a788/ : SUCCESS in 2m 14s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/35/337435/6/check/gate-python-keystoneclient-python34/416183c/ : SUCCESS in 2m 25s\n- gate-python-keystoneclient-python35-nv http://logs.openstack.org/35/337435/6/check/gate-python-keystoneclient-python35-nv/3f9ece3/ : SUCCESS in 4m 41s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/35/337435/6/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/f615d03/ : SUCCESS in 1h 17m 00s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/35/337435/6/check/gate-keystoneclient-dsvm-functional/56b3430/ : SUCCESS in 32m 45s","accounts_in_message":[],"_revision_number":6},{"id":"139e5e929c64adfbe7ee2481fb03c516a3f487e8","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2016-08-08 18:01:32.000000000","message":"Patch Set 6: Code-Review+2\n\nlgtm, run the tests with and without your change and they don\u0027t pass without it","accounts_in_message":[],"_revision_number":6},{"id":"49e22e067ebd9740022009c3769965dea0d4baac","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2016-08-08 19:15:15.000000000","message":"Patch Set 6: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"2747baf644d7bccda72274dfafb1d0a071501283","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-08-09 00:39:44.000000000","message":"Patch Set 6:\n\n(1 comment)\n\nBoris, thank you for review code.","accounts_in_message":[],"_revision_number":6},{"id":"f004a2d9b7fadfa3ea3bb3c277126ee77703716b","author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"date":"2016-08-09 02:39:30.000000000","message":"Patch Set 6: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"b86e7b61b1213ea4173bed158e141bc343e35739","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2016-08-09 13:38:15.000000000","message":"Patch Set 6: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":6},{"id":"fac0b34d3b7a980fd55856bd187cfcf8bb79f521","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-08-10 07:01:06.000000000","message":"Patch Set 6:\n\n(2 comments)","accounts_in_message":[],"_revision_number":6},{"id":"9f07c16cf7922a8be0727a9940c3d6dce4d55ad2","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-08-10 07:01:47.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"7308c1e1359d450f134edc31ecf6b813fe479ef0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-10 08:17:07.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/35/337435/7/check/gate-python-keystoneclient-docs-ubuntu-xenial/844abef//doc/build/html/ : SUCCESS in 3m 43s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/35/337435/7/check/gate-python-keystoneclient-pep8-ubuntu-xenial/ab1ca11/ : SUCCESS in 1m 55s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/35/337435/7/check/gate-python-keystoneclient-python27-ubuntu-xenial/5828c21/ : SUCCESS in 2m 11s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/35/337435/7/check/gate-python-keystoneclient-python34/e073f07/ : SUCCESS in 3m 06s\n- gate-python-keystoneclient-python35-nv http://logs.openstack.org/35/337435/7/check/gate-python-keystoneclient-python35-nv/af32adf/ : SUCCESS in 4m 15s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/35/337435/7/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/22bc643/ : SUCCESS in 1h 13m 30s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/35/337435/7/check/gate-keystoneclient-dsvm-functional/72e0df0/ : SUCCESS in 27m 02s\n- gate-python-keystoneclient-tox-bandit-ubuntu-xenial http://logs.openstack.org/35/337435/7/check/gate-python-keystoneclient-tox-bandit-ubuntu-xenial/9261a57/ : SUCCESS in 2m 34s","accounts_in_message":[],"_revision_number":7},{"id":"d3ab274da0e0a64f0da1e8b062e8fb45c21a7834","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2016-08-10 14:45:26.000000000","message":"Patch Set 7: Code-Review+2\n\nstill lgtm","accounts_in_message":[],"_revision_number":7},{"id":"04a6ba1b1726f2ff1936097f6974975a1e37068b","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2016-08-10 15:02:42.000000000","message":"Patch Set 7: Code-Review-1\n\n(2 comments)\n\nI am good with all tests and code, but have a concern about a comment. Fix it and i\u0027ll be happy to +1.","accounts_in_message":[],"_revision_number":7},{"id":"e8491dfc57607e7b41cad2b36a034ab6466f8f05","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-08-11 01:44:47.000000000","message":"Patch Set 7:\n\n(2 comments)\n\nThank you, Boris.I have fixed it.","accounts_in_message":[],"_revision_number":7},{"id":"2e86ff8e9e7edc684d7eddf97b5e5314266662de","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2016-08-11 01:46:03.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"a72673a5ff4cef4ef0b89810671a6fa998fc023e","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-08-11 01:49:58.000000000","message":"Patch Set 8: Code-Review+2 Workflow+1\n\nboris\u0027 commented addressed and Rodrigo had a +2 here already *punt*","accounts_in_message":[],"_revision_number":8},{"id":"110e42226cdfac9e5117618d6fbc1d7b83e5b34d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-11 02:50:30.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/35/337435/8/check/gate-python-keystoneclient-docs-ubuntu-xenial/d8bc9c7//doc/build/html/ : SUCCESS in 3m 05s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/35/337435/8/check/gate-python-keystoneclient-pep8-ubuntu-xenial/6daee82/ : SUCCESS in 1m 15s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/35/337435/8/check/gate-python-keystoneclient-python27-ubuntu-xenial/91ddd06/ : SUCCESS in 3m 33s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/35/337435/8/check/gate-python-keystoneclient-python34/e2facf7/ : SUCCESS in 3m 00s\n- gate-python-keystoneclient-python35-nv http://logs.openstack.org/35/337435/8/check/gate-python-keystoneclient-python35-nv/50739fc/ : SUCCESS in 9m 34s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/35/337435/8/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/0adee07/ : SUCCESS in 1h 01m 23s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/35/337435/8/check/gate-keystoneclient-dsvm-functional/30be580/ : SUCCESS in 21m 09s\n- gate-python-keystoneclient-tox-bandit-ubuntu-xenial http://logs.openstack.org/35/337435/8/check/gate-python-keystoneclient-tox-bandit-ubuntu-xenial/8df0b16/ : SUCCESS in 6m 12s","accounts_in_message":[],"_revision_number":8},{"id":"27ac7578ed984df0d986026100bff7b7359f0354","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-11 02:50:41.000000000","message":"Patch Set 8: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":8},{"id":"1970cb1b6d41fb6d55359d45d5757139122cb840","date":"2016-08-11 03:55:38.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":8},{"id":"f544313d9928e53f0b78d866eb500ad133d67297","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-11 03:55:38.000000000","message":"Patch Set 8: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/35/337435/8/gate/gate-python-keystoneclient-docs-ubuntu-xenial/793df64//doc/build/html/ : SUCCESS in 3m 33s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/35/337435/8/gate/gate-python-keystoneclient-pep8-ubuntu-xenial/2ca9b39/ : SUCCESS in 3m 14s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/35/337435/8/gate/gate-python-keystoneclient-python27-ubuntu-xenial/50f2769/ : SUCCESS in 2m 47s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/35/337435/8/gate/gate-python-keystoneclient-python34/f9ce55f/ : SUCCESS in 2m 41s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/35/337435/8/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/d5f0e4b/ : SUCCESS in 1h 04m 42s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/35/337435/8/gate/gate-keystoneclient-dsvm-functional/53ef131/ : SUCCESS in 31m 49s\n- gate-python-keystoneclient-tox-bandit-ubuntu-xenial http://logs.openstack.org/35/337435/8/gate/gate-python-keystoneclient-tox-bandit-ubuntu-xenial/8a47701/ : SUCCESS in 2m 40s","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"ef34175095d92a117fda149ad8a2e216e3a2b78c","revisions":{"b7ce5cfb73dcb6b8ce84ef1dc298da25e1c732d2":{"kind":"REWORK","_number":1,"created":"2016-07-05 05:53:41.000000000","uploader":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"ref":"refs/changes/35/337435/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/35/337435/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/1"}}},"commit":{"parents":[{"commit":"d9bd1056323605ed64e73175ce2fcbe5982ec045","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d9bd1056323605ed64e73175ce2fcbe5982ec045"}]}],"author":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-07-05 07:21:02.000000000","tz":480},"committer":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-07-05 07:21:39.000000000","tz":480},"subject":"Add __ne__ built-in function","message":"Add __ne__ built-in function\n\nIn Python 3 __ne__ by default delegates to __eq__ and inverts the\nresult, but in Python 2 they urge you to define __ne__ when you\ndefine __eq__ for it to work properly [1].There are no implied\nrelationships among the comparison operators. The truth of x\u003d\u003dy\ndoes not imply that x!\u003dy is false. Accordingly, when defining\n__eq__(), one should also define __ne__() so that the operators\nwill behave as expected.\n[1]https://docs.python.org/2/reference/datamodel.html#object.__ne__\nAlso fixes spelling errors:resoruces.\n\nChange-Id: Iae4ce0fe84fae810711cc8c3fdb94eb9ca1d772e\nCloses-Bug: #1586268\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b7ce5cfb73dcb6b8ce84ef1dc298da25e1c732d2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b7ce5cfb73dcb6b8ce84ef1dc298da25e1c732d2"}]},"branch":"refs/heads/master"},"15f7fd88ce6f28821b5ba9604e91e44d0e018282":{"kind":"REWORK","_number":2,"created":"2016-07-06 07:59:19.000000000","uploader":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"ref":"refs/changes/35/337435/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/35/337435/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/2"}}},"commit":{"parents":[{"commit":"d9bd1056323605ed64e73175ce2fcbe5982ec045","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d9bd1056323605ed64e73175ce2fcbe5982ec045"}]}],"author":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-07-05 07:21:02.000000000","tz":480},"committer":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-07-06 09:26:17.000000000","tz":480},"subject":"Add __ne__ built-in function","message":"Add __ne__ built-in function\n\nIn Python 3 __ne__ by default delegates to __eq__ and inverts the\nresult, but in Python 2 they urge you to define __ne__ when you\ndefine __eq__ for it to work properly [1].There are no implied\nrelationships among the comparison operators. The truth of x\u003d\u003dy\ndoes not imply that x!\u003dy is false. Accordingly, when defining\n__eq__(), one should also define __ne__() so that the operators\nwill behave as expected.\n[1]https://docs.python.org/2/reference/datamodel.html#object.__ne__\nAlso fixes spelling errors:resoruces.\n\nChange-Id: Iae4ce0fe84fae810711cc8c3fdb94eb9ca1d772e\nCloses-Bug: #1586268\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/15f7fd88ce6f28821b5ba9604e91e44d0e018282"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/15f7fd88ce6f28821b5ba9604e91e44d0e018282"}]},"branch":"refs/heads/master"},"8bf0c6cc81cc35ae88eed6e906cc41fd8cce9c9a":{"kind":"REWORK","_number":3,"created":"2016-07-14 08:10:54.000000000","uploader":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"ref":"refs/changes/35/337435/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/35/337435/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/3"}}},"commit":{"parents":[{"commit":"d9bd1056323605ed64e73175ce2fcbe5982ec045","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d9bd1056323605ed64e73175ce2fcbe5982ec045"}]}],"author":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-07-05 07:21:02.000000000","tz":480},"committer":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-07-14 09:37:40.000000000","tz":480},"subject":"Add __ne__ built-in function","message":"Add __ne__ built-in function\n\nIn Python 3 __ne__ by default delegates to __eq__ and inverts the\nresult, but in Python 2 they urge you to define __ne__ when you\ndefine __eq__ for it to work properly [1].There are no implied\nrelationships among the comparison operators. The truth of x\u003d\u003dy\ndoes not imply that x!\u003dy is false. Accordingly, when defining\n__eq__(), one should also define __ne__() so that the operators\nwill behave as expected.\n[1]https://docs.python.org/2/reference/datamodel.html#object.__ne__\nAlso fixes spelling errors:resoruces.\n\nChange-Id: Iae4ce0fe84fae810711cc8c3fdb94eb9ca1d772e\nCloses-Bug: #1586268\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8bf0c6cc81cc35ae88eed6e906cc41fd8cce9c9a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8bf0c6cc81cc35ae88eed6e906cc41fd8cce9c9a"}]},"branch":"refs/heads/master"},"dc784e485839030cf5d5bc8e6e9d1acaf6eda15b":{"kind":"REWORK","_number":4,"created":"2016-08-05 07:19:44.000000000","uploader":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"ref":"refs/changes/35/337435/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/35/337435/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/4"}}},"commit":{"parents":[{"commit":"64d458fcf8c2f7eab24f0134f3c27e15c181fe15","subject":"Merge \"Follow up patch for Improve docs for v3 roles\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/64d458fcf8c2f7eab24f0134f3c27e15c181fe15"}]}],"author":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-07-05 07:21:02.000000000","tz":480},"committer":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-08-05 08:52:05.000000000","tz":480},"subject":"Add __ne__ built-in function","message":"Add __ne__ built-in function\n\nIn Python 3 __ne__ by default delegates to __eq__ and inverts the\nresult, but in Python 2 they urge you to define __ne__ when you\ndefine __eq__ for it to work properly [1].There are no implied\nrelationships among the comparison operators. The truth of x\u003d\u003dy\ndoes not imply that x!\u003dy is false. Accordingly, when defining\n__eq__(), one should also define __ne__() so that the operators\nwill behave as expected.\n[1]https://docs.python.org/2/reference/datamodel.html#object.__ne__\nAlso fixes spelling errors:resoruces.\n\nChange-Id: Iae4ce0fe84fae810711cc8c3fdb94eb9ca1d772e\nCloses-Bug: #1586268\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/dc784e485839030cf5d5bc8e6e9d1acaf6eda15b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/dc784e485839030cf5d5bc8e6e9d1acaf6eda15b"}]},"branch":"refs/heads/master"},"573790914b2dc92c942726627cd6ac7427149b14":{"kind":"REWORK","_number":5,"created":"2016-08-05 09:03:06.000000000","uploader":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"ref":"refs/changes/35/337435/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/35/337435/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/5"}}},"commit":{"parents":[{"commit":"64d458fcf8c2f7eab24f0134f3c27e15c181fe15","subject":"Merge \"Follow up patch for Improve docs for v3 roles\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/64d458fcf8c2f7eab24f0134f3c27e15c181fe15"}]}],"author":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-07-05 07:21:02.000000000","tz":480},"committer":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-08-05 10:35:46.000000000","tz":480},"subject":"Add __ne__ built-in function","message":"Add __ne__ built-in function\n\nIn Python 3 __ne__ by default delegates to __eq__ and inverts the\nresult, but in Python 2 they urge you to define __ne__ when you\ndefine __eq__ for it to work properly [1].There are no implied\nrelationships among the comparison operators. The truth of x\u003d\u003dy\ndoes not imply that x!\u003dy is false. Accordingly, when defining\n__eq__(), one should also define __ne__() so that the operators\nwill behave as expected.\n[1]https://docs.python.org/2/reference/datamodel.html#object.__ne__\nAlso fixes spelling errors:resoruces.\n\nChange-Id: Iae4ce0fe84fae810711cc8c3fdb94eb9ca1d772e\nCloses-Bug: #1586268\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/573790914b2dc92c942726627cd6ac7427149b14"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/573790914b2dc92c942726627cd6ac7427149b14"}]},"branch":"refs/heads/master"},"b52a7aa5e057a7bc01afec5dd1d65bf1dd00d74c":{"kind":"REWORK","_number":6,"created":"2016-08-08 12:12:58.000000000","uploader":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"ref":"refs/changes/35/337435/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/35/337435/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/6"}}},"commit":{"parents":[{"commit":"64d458fcf8c2f7eab24f0134f3c27e15c181fe15","subject":"Merge \"Follow up patch for Improve docs for v3 roles\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/64d458fcf8c2f7eab24f0134f3c27e15c181fe15"}]}],"author":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-07-05 07:21:02.000000000","tz":480},"committer":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-08-08 13:45:44.000000000","tz":480},"subject":"Add __ne__ built-in function","message":"Add __ne__ built-in function\n\nIn Python 3 __ne__ by default delegates to __eq__ and inverts the\nresult, but in Python 2 they urge you to define __ne__ when you\ndefine __eq__ for it to work properly [1].There are no implied\nrelationships among the comparison operators. The truth of x\u003d\u003dy\ndoes not imply that x!\u003dy is false. Accordingly, when defining\n__eq__(), one should also define __ne__() so that the operators\nwill behave as expected.\n[1]https://docs.python.org/2/reference/datamodel.html#object.__ne__\nAlso fixes spelling errors:resoruces.\n\nChange-Id: Iae4ce0fe84fae810711cc8c3fdb94eb9ca1d772e\nCloses-Bug: #1586268\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b52a7aa5e057a7bc01afec5dd1d65bf1dd00d74c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b52a7aa5e057a7bc01afec5dd1d65bf1dd00d74c"}]},"branch":"refs/heads/master"},"f8c1d295582afbbb0fc51841d0cdd1fe1bc3a6ad":{"kind":"REWORK","_number":7,"created":"2016-08-10 07:01:47.000000000","uploader":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"ref":"refs/changes/35/337435/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/35/337435/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/7"}}},"commit":{"parents":[{"commit":"64d458fcf8c2f7eab24f0134f3c27e15c181fe15","subject":"Merge \"Follow up patch for Improve docs for v3 roles\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/64d458fcf8c2f7eab24f0134f3c27e15c181fe15"}]}],"author":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-07-05 07:21:02.000000000","tz":480},"committer":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-08-10 08:35:32.000000000","tz":480},"subject":"Add __ne__ built-in function","message":"Add __ne__ built-in function\n\nIn Python 3 __ne__ by default delegates to __eq__ and inverts the\nresult, but in Python 2 they urge you to define __ne__ when you\ndefine __eq__ for it to work properly [1].There are no implied\nrelationships among the comparison operators. The truth of x\u003d\u003dy\ndoes not imply that x!\u003dy is false. Accordingly, when defining\n__eq__(), one should also define __ne__() so that the operators\nwill behave as expected.\n[1]https://docs.python.org/2/reference/datamodel.html#object.__ne__\nAlso fixes spelling errors:resoruces.\n\nChange-Id: Iae4ce0fe84fae810711cc8c3fdb94eb9ca1d772e\nCloses-Bug: #1586268\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f8c1d295582afbbb0fc51841d0cdd1fe1bc3a6ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f8c1d295582afbbb0fc51841d0cdd1fe1bc3a6ad"}]},"branch":"refs/heads/master"},"ef34175095d92a117fda149ad8a2e216e3a2b78c":{"kind":"REWORK","_number":8,"created":"2016-08-11 01:46:03.000000000","uploader":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"ref":"refs/changes/35/337435/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/35/337435/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/35/337435/8"}}},"commit":{"parents":[{"commit":"64d458fcf8c2f7eab24f0134f3c27e15c181fe15","subject":"Merge \"Follow up patch for Improve docs for v3 roles\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/64d458fcf8c2f7eab24f0134f3c27e15c181fe15"}]}],"author":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-07-05 07:21:02.000000000","tz":480},"committer":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2016-08-11 03:19:30.000000000","tz":480},"subject":"Add __ne__ built-in function","message":"Add __ne__ built-in function\n\nIn Python 3 __ne__ by default delegates to __eq__ and inverts the\nresult, but in Python 2 they urge you to define __ne__ when you\ndefine __eq__ for it to work properly [1].There are no implied\nrelationships among the comparison operators. The truth of x\u003d\u003dy\ndoes not imply that x!\u003dy is false. Accordingly, when defining\n__eq__(), one should also define __ne__() so that the operators\nwill behave as expected.\n[1]https://docs.python.org/2/reference/datamodel.html#object.__ne__\nAlso fixes spelling errors:resoruces.\n\nChange-Id: Iae4ce0fe84fae810711cc8c3fdb94eb9ca1d772e\nCloses-Bug: #1586268\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ef34175095d92a117fda149ad8a2e216e3a2b78c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ef34175095d92a117fda149ad8a2e216e3a2b78c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}