)]}'
{"id":"openstack%2Fpython-keystoneclient~347208","triplet_id":"openstack%2Fpython-keystoneclient~master~Ieaf211617c38aa0f9a38625b1009c36bd6a16fba","project":"openstack/python-keystoneclient","branch":"master","topic":"assertDictEqual-20160726","hashtags":[],"change_id":"Ieaf211617c38aa0f9a38625b1009c36bd6a16fba","subject":"Use assertEqual() instead of assertDictEqual()","status":"MERGED","created":"2016-07-26 09:16:39.000000000","updated":"2016-07-26 14:04:46.000000000","submitted":"2016-07-26 14:04:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a6e64f3bf64f4da39ac1969eb798b40b3726cbc8","_number":347208,"virtual_id_number":347208,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-07-26 14:04:46.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-07-26 12:33:06.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-07-26 09:39:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2016-07-26 12:33:06.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-26 09:39:53.000000000","updated_by":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"reviewer":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"state":"REVIEWER"},{"updated":"2016-07-26 12:33:06.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-07-26 14:04:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e8cf6b96b32defba1518c6aa949c748a16eaee58","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-07-26 09:16:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"470c4a7207a1e7ee2d14bca47a1f3ab6328a597e","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2016-07-26 09:39:53.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"411bae7ca9fd99c52e970c746b8d0f63e7728378","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-26 10:39:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/08/347208/1/check/gate-python-keystoneclient-docs-ubuntu-xenial/e5d3be4//doc/build/html/ : SUCCESS in 4m 31s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/08/347208/1/check/gate-python-keystoneclient-pep8-ubuntu-xenial/c5d4319/ : SUCCESS in 2m 14s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/08/347208/1/check/gate-python-keystoneclient-python27-ubuntu-xenial/d30bce7/ : SUCCESS in 4m 30s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/08/347208/1/check/gate-python-keystoneclient-python34/b69874b/ : SUCCESS in 4m 48s\n- gate-python-keystoneclient-python35-nv http://logs.openstack.org/08/347208/1/check/gate-python-keystoneclient-python35-nv/e4d3216/ : SUCCESS in 5m 22s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/08/347208/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/65a5633/ : SUCCESS in 1h 12m 43s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/08/347208/1/check/gate-keystoneclient-dsvm-functional/7697035/ : SUCCESS in 38m 47s","accounts_in_message":[],"_revision_number":1},{"id":"d847677c89d5a327b38013b064f240cce69e77a0","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-07-26 12:33:06.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0edfaa239828d9245b3385eead0626496d471011","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-26 12:33:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"db92b1338733bb2377a0ede26fe51ace1562fd45","date":"2016-07-26 14:04:46.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"51ced092d24798d9a4fde7168309e0e5e123d0e4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-26 14:04:46.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/08/347208/1/gate/gate-python-keystoneclient-docs-ubuntu-xenial/b1d2859//doc/build/html/ : SUCCESS in 4m 03s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/08/347208/1/gate/gate-python-keystoneclient-pep8-ubuntu-xenial/41de036/ : SUCCESS in 3m 57s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/08/347208/1/gate/gate-python-keystoneclient-python27-ubuntu-xenial/4d75611/ : SUCCESS in 2m 20s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/08/347208/1/gate/gate-python-keystoneclient-python34/71e34e4/ : SUCCESS in 2m 47s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/08/347208/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/93746e3/ : SUCCESS in 1h 29m 50s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/08/347208/1/gate/gate-keystoneclient-dsvm-functional/adb4f21/ : SUCCESS in 47m 31s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"09f47ab0ba9b0b7a7b46dbb6d60ad7f63dff7da7","revisions":{"09f47ab0ba9b0b7a7b46dbb6d60ad7f63dff7da7":{"kind":"REWORK","_number":1,"created":"2016-07-26 09:16:39.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/08/347208/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/08/347208/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/08/347208/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/08/347208/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/08/347208/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/08/347208/1"}}},"commit":{"parents":[{"commit":"39fd3a0738e06a135a02806402d09b539a585c8a","subject":"Merge \"Use the adapter instead of the client in tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/39fd3a0738e06a135a02806402d09b539a585c8a"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-07-26 09:15:22.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-07-26 09:15:22.000000000","tz":480},"subject":"Use assertEqual() instead of assertDictEqual()","message":"Use assertEqual() instead of assertDictEqual()\n\nOpenStack now has dropped support for python 2.6 and lower.\nSo we don\u0027t need to define an assertDictEqual() for python\nlower than 2.7.\n\nFurther, assertEqual() in testtools is able to handle dicts\ncomparation, just the same as assertDictEqual() in unittest2.\nSo we do\u0027t need to call assertDictEqual() for dicts any more.\n\nPlease also refer to: https://review.openstack.org/#/c/347097/\n\nChange-Id: Ieaf211617c38aa0f9a38625b1009c36bd6a16fba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/09f47ab0ba9b0b7a7b46dbb6d60ad7f63dff7da7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/09f47ab0ba9b0b7a7b46dbb6d60ad7f63dff7da7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
