)]}'
{"id":"openstack%2Fpython-keystoneclient~348464","triplet_id":"openstack%2Fpython-keystoneclient~master~I8913337a69c010d7e62e3d67156aedceb3164815","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1607436","hashtags":[],"change_id":"I8913337a69c010d7e62e3d67156aedceb3164815","subject":"Removing old-new password matches validation from keystoneclient","status":"ABANDONED","created":"2016-07-28 16:20:49.000000000","updated":"2016-07-29 21:00:54.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8f1a849a106390236cc6808413e6b915fd5195a6","_number":348464,"virtual_id_number":348464,"owner":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-07-29 21:00:37.000000000","_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2016-07-29 01:40:48.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-07-29 20:05:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-28 16:29:38.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-07-29 01:40:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-07-29 20:05:46.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"}],"messages":[{"id":"36edfa9e27e19c19142dd0edcdef71b13ff7fca4","author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"date":"2016-07-28 16:20:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9b50410fe56bec792f02b0782b5077fd71563c76","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-07-28 16:29:38.000000000","message":"Patch Set 1: Code-Review-1\n\nsee my comments in the bug report","accounts_in_message":[],"_revision_number":1},{"id":"9aa3a32c20a3ae12fdd44d81a4405d76eb8c2ab3","author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"date":"2016-07-28 17:00:06.000000000","message":"Patch Set 1:\n\n@Steve replied to you comment in the bug report. Let me know if you still disagree.","accounts_in_message":[],"_revision_number":1},{"id":"9cebaa8023fbfc10e9eab6f3816de4e3ce12a532","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-28 21:06:51.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/64/348464/1/check/gate-python-keystoneclient-docs-ubuntu-xenial/43aa99c//doc/build/html/ : SUCCESS in 2m 35s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/64/348464/1/check/gate-python-keystoneclient-pep8-ubuntu-xenial/3dcc4fb/ : SUCCESS in 2m 37s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/64/348464/1/check/gate-python-keystoneclient-python27-ubuntu-xenial/392d738/ : FAILURE in 2m 32s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/64/348464/1/check/gate-python-keystoneclient-python34/23ffd6e/ : FAILURE in 2m 31s\n- gate-python-keystoneclient-python35-nv http://logs.openstack.org/64/348464/1/check/gate-python-keystoneclient-python35-nv/dec7c56/ : FAILURE in 5m 56s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/64/348464/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/82e9357/ : SUCCESS in 1h 17m 31s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/64/348464/1/check/gate-keystoneclient-dsvm-functional/2ea0655/ : FAILURE in 41m 10s","accounts_in_message":[],"_revision_number":1},{"id":"00b7a16a992c3dba4f0901ea1a5797931f10aa7a","author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"date":"2016-07-28 22:29:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"23569fc850e1f015c54e31a41b536cbee280c4bf","author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"date":"2016-07-28 22:30:36.000000000","message":"Topic changed from (detached to bug/1607436","accounts_in_message":[],"_revision_number":2},{"id":"880c9e593cd147365cb2b0e1bca1d089cec025dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-29 01:40:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/64/348464/2/check/gate-python-keystoneclient-docs-ubuntu-xenial/f1fbd65//doc/build/html/ : SUCCESS in 2m 47s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/64/348464/2/check/gate-python-keystoneclient-pep8-ubuntu-xenial/6772f33/ : SUCCESS in 3m 10s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/64/348464/2/check/gate-python-keystoneclient-python27-ubuntu-xenial/9485840/ : SUCCESS in 3m 10s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/64/348464/2/check/gate-python-keystoneclient-python34/43046d9/ : SUCCESS in 2m 41s\n- gate-python-keystoneclient-python35-nv http://logs.openstack.org/64/348464/2/check/gate-python-keystoneclient-python35-nv/08424d3/ : SUCCESS in 4m 36s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/64/348464/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/0a0bfc8/ : SUCCESS in 1h 17m 42s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/64/348464/2/check/gate-keystoneclient-dsvm-functional/1c36a1b/ : SUCCESS in 36m 11s","accounts_in_message":[],"_revision_number":2},{"id":"1f3183a3e47953045ad5185e92c167a36760bbd6","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2016-07-29 20:05:46.000000000","message":"Patch Set 2: Code-Review-1\n\nhttps://bugs.launchpad.net/python-keystoneclient/+bug/1607436/comments/3\n\nNot sure I agree with the bug. Early validation is better, but this should be validated in BOTH the server and client.","accounts_in_message":[],"_revision_number":2},{"id":"3d2a8e47fc82e3d76b4a7949402a4b386bb9350d","author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"date":"2016-07-29 21:00:37.000000000","message":"Patch Set 2:\n\nIf it\u0027s validated at the server, then it doesn\u0027t necessarily need to be validated at the client.  However, I\u0027ll concede this one.","accounts_in_message":[],"_revision_number":2},{"id":"8f1a849a106390236cc6808413e6b915fd5195a6","author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"date":"2016-07-29 21:00:54.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e644812aa0eda9a7dfcea3f2dcfe0e84cba8bcf3","revisions":{"752d157a10070fb14aef93925b2dfd7073124a0d":{"kind":"REWORK","_number":1,"created":"2016-07-28 16:20:49.000000000","uploader":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"ref":"refs/changes/64/348464/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/64/348464/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/348464/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/348464/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/348464/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/348464/1"}}},"commit":{"parents":[{"commit":"41129c850394e97947ec374dad8e852b5e1b33b5","subject":"Merge \"Improve implied-role functional tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/41129c850394e97947ec374dad8e852b5e1b33b5"}]}],"author":{"name":"Ronald De Rose","email":"ronald.de.rose@intel.com","date":"2016-07-28 16:15:51.000000000","tz":0},"committer":{"name":"Ronald De Rose","email":"ronald.de.rose@intel.com","date":"2016-07-28 16:20:49.000000000","tz":0},"subject":"Removing old-new password matches validation from keystoneclient","message":"Removing old-new password matches validation from keystoneclient\n\nThis patches removes the check that the old password doesn\u0027t match\nnew password when updating a password in keystoneclient. With the\naddition of PCI, this check should no longer be needed and instead\nkeystoneclient can rely on keystone to perform this validaton.\n\nChange-Id: I8913337a69c010d7e62e3d67156aedceb3164815\nCloses-Bug: #1607436\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/752d157a10070fb14aef93925b2dfd7073124a0d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/752d157a10070fb14aef93925b2dfd7073124a0d"}]},"branch":"refs/heads/master"},"e644812aa0eda9a7dfcea3f2dcfe0e84cba8bcf3":{"kind":"REWORK","_number":2,"created":"2016-07-28 22:29:06.000000000","uploader":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"ref":"refs/changes/64/348464/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/64/348464/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/348464/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/348464/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/348464/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/64/348464/2"}}},"commit":{"parents":[{"commit":"41129c850394e97947ec374dad8e852b5e1b33b5","subject":"Merge \"Improve implied-role functional tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/41129c850394e97947ec374dad8e852b5e1b33b5"}]}],"author":{"name":"Ronald De Rose","email":"ronald.de.rose@intel.com","date":"2016-07-28 16:15:51.000000000","tz":0},"committer":{"name":"Ronald De Rose","email":"ronald.de.rose@intel.com","date":"2016-07-28 22:29:03.000000000","tz":0},"subject":"Removing old-new password matches validation from keystoneclient","message":"Removing old-new password matches validation from keystoneclient\n\nThis patches removes the check that the old password doesn\u0027t match\nnew password when updating a password in keystoneclient. With the\naddition of PCI, this check should no longer be needed and instead\nkeystoneclient can rely on keystone to perform this validaton.\n\nChange-Id: I8913337a69c010d7e62e3d67156aedceb3164815\nCloses-Bug: #1607436\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e644812aa0eda9a7dfcea3f2dcfe0e84cba8bcf3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e644812aa0eda9a7dfcea3f2dcfe0e84cba8bcf3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}