)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"6db77bfdf8fee71183129ecadafd727d2ba4536f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tobias Diaz \u003ctobias.diaz@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-23 17:20:00 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Catch MemoryError when logging huge responses"},{"line_number":8,"context_line":"Closes-bug: 1616105"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I8f43eee3a0b35041c6cf672e476f8151cf2f8d14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_494d556b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":45},"updated":"2016-12-02 18:21:51.000000000","message":"According to the log in the bug report, the bug is not due to logging. See my comment on the bug https://bugs.launchpad.net/python-keystoneclient/+bug/1616105/comments/10","commit_id":"e3932b58f2cec3a2d306ccf72c4a7631bc716ea7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c672af1e73867cbd43fa98fcfdc0ef5821b77f49","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-08-23 17:20:00 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Catch MemoryError when logging huge responses"},{"line_number":8,"context_line":"Closes-bug: 1616105"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I8f43eee3a0b35041c6cf672e476f8151cf2f8d14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_6a0a8f8b","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":19},"updated":"2016-08-23 15:46:47.000000000","message":"add a new line above this, as it is now, it\u0027s pat of the title","commit_id":"e3932b58f2cec3a2d306ccf72c4a7631bc716ea7"}],"keystoneclient/session.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"8900282958bc491066ab6a4b018f91c70922bba1","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        try:"},{"line_number":220,"context_line":"            text \u003d _remove_service_catalog(response.text)"},{"line_number":221,"context_line":"        except MemoryError:"},{"line_number":222,"context_line":"            text \u003d \u0027{body is to huge to show, sorry}\u0027"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        string_parts \u003d ["},{"line_number":225,"context_line":"            \u0027RESP:\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da7fb54a_aabb9374","line":222,"range":{"start_line":222,"start_character":29,"end_line":222,"end_character":31},"updated":"2016-09-02 16:13:52.000000000","message":"to -\u003e too","commit_id":"e3932b58f2cec3a2d306ccf72c4a7631bc716ea7"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"6db77bfdf8fee71183129ecadafd727d2ba4536f","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        try:"},{"line_number":220,"context_line":"            text \u003d _remove_service_catalog(response.text)"},{"line_number":221,"context_line":"        except MemoryError:"},{"line_number":222,"context_line":"            text \u003d \u0027{body is to huge to show, sorry}\u0027"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        string_parts \u003d ["},{"line_number":225,"context_line":"            \u0027RESP:\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_a92a697c","line":222,"range":{"start_line":222,"start_character":29,"end_line":222,"end_character":31},"in_reply_to":"da7fb54a_aabb9374","updated":"2016-12-02 18:21:51.000000000","message":"Is this more useful than not logging the response body (by setting text to None?","commit_id":"e3932b58f2cec3a2d306ccf72c4a7631bc716ea7"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"1e608c3975761fd9695b2b29e8288c1bfb883c8a","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    def _http_log_response(self, response, logger):"},{"line_number":216,"context_line":"        if not logger.isEnabledFor(logging.DEBUG):"},{"line_number":217,"context_line":"            return"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # NOTE(samueldmq): If the response does not provide enough info about"},{"line_number":220,"context_line":"        # the content type to decide whether it is useful and safe to log it or"},{"line_number":221,"context_line":"        # not, just do not log the body. Trying to read the response body"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_137578ca","line":218,"updated":"2017-01-03 02:27:25.000000000","message":"global?\n\n_LOG_CONTENT_TYPES \u003d set([\u0027application/json\u0027,\u0027application/text\u0027])","commit_id":"0df7705834a8d620c36ea44c397d2dae3bdb85ef"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"baa3c658013864b2c5f45b13fed6f2a3626a554c","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # anyways may result on reading a long stream of bytes and getting an"},{"line_number":223,"context_line":"        # unexpected MemoryError. See bug 1616105 for further details."},{"line_number":224,"context_line":"        content_type \u003d response.headers.get(\u0027content-type\u0027, None)"},{"line_number":225,"context_line":"        if content_type in (\u0027application/json\u0027, \u0027application/text\u0027):"},{"line_number":226,"context_line":"            text \u003d _remove_service_catalog(response.text)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            text \u003d (\u0027Omitted. Content-Type is not one of application/json \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_93cc0837","line":225,"updated":"2017-01-03 02:09:42.000000000","message":"I wonder if text/xml could make sense for other OpenStack services.","commit_id":"0df7705834a8d620c36ea44c397d2dae3bdb85ef"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"1e608c3975761fd9695b2b29e8288c1bfb883c8a","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # anyways may result on reading a long stream of bytes and getting an"},{"line_number":223,"context_line":"        # unexpected MemoryError. See bug 1616105 for further details."},{"line_number":224,"context_line":"        content_type \u003d response.headers.get(\u0027content-type\u0027, None)"},{"line_number":225,"context_line":"        if content_type in (\u0027application/json\u0027, \u0027application/text\u0027):"},{"line_number":226,"context_line":"            text \u003d _remove_service_catalog(response.text)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            text \u003d (\u0027Omitted. Content-Type is not one of application/json \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_b36d8c06","line":225,"in_reply_to":"ba5201f7_93cc0837","updated":"2017-01-03 02:27:25.000000000","message":"i think most things have disabled xml. If they want it back they can file a bug and we\u0027ll add it to the list.","commit_id":"0df7705834a8d620c36ea44c397d2dae3bdb85ef"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"1e608c3975761fd9695b2b29e8288c1bfb883c8a","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            text \u003d _remove_service_catalog(response.text)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            text \u003d (\u0027Omitted. Content-Type is not one of application/json \u0027"},{"line_number":229,"context_line":"                    \u0027or application/text.\u0027)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        string_parts \u003d ["},{"line_number":232,"context_line":"            \u0027RESP:\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_33ab5c1f","line":229,"updated":"2017-01-03 02:27:25.000000000","message":"maybe move this down and omit the body?\n\nIf content_type in _LOG_CONTENT_TYPES: \n    if response.text:\n        text \u003d _remove_service_catalog(response.text)\n        text \u003d strutils.mask_password(text)\n        string_parts.append(\u0027\\nRESP BODY: %s\\n\u0027 % text) \nelse: \n    string_parts.append(\u0027RESP BODY OMITTED\u0027)","commit_id":"0df7705834a8d620c36ea44c397d2dae3bdb85ef"}],"keystoneclient/tests/unit/test_http.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"05d8e086221fbe5b7c2d7d4eaf5abbda12c162d3","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.requests_mock.register_uri(method, url, text\u003dresponse,"},{"line_number":174,"context_line":"                                        status_code\u003dstatus_code,"},{"line_number":175,"context_line":"                                        headers\u003dheaders)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        with self.deprecations.expect_deprecations_here():"},{"line_number":178,"context_line":"            return httpclient.request(url, method, headers\u003dheaders, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_135c984a","line":175,"range":{"start_line":175,"start_character":0,"end_line":175,"end_character":40},"updated":"2017-01-03 02:29:17.000000000","message":"putting headers here and below will mean the same headers are in the request and response which seems wrong.","commit_id":"0df7705834a8d620c36ea44c397d2dae3bdb85ef"}]}
