)]}'
{"id":"openstack%2Fpython-keystoneclient~359705","triplet_id":"openstack%2Fpython-keystoneclient~master~Ic513046f8398a76c244e145d6cc3117cdf6bb4cd","project":"openstack/python-keystoneclient","branch":"master","topic":"remove2","hashtags":[],"change_id":"Ic513046f8398a76c244e145d6cc3117cdf6bb4cd","subject":"Use exceptions from Keystoneauth","status":"MERGED","created":"2016-08-24 08:52:47.000000000","updated":"2016-10-14 14:10:27.000000000","submitted":"2016-10-14 14:10:27.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d8415842be0a90e0372286a8a4985c27cf886cf5","_number":359705,"virtual_id_number":359705,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-10-14 14:10:27.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-08-24 17:13:21.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-10-14 13:24:11.000000000","_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-10-14 13:24:34.000000000","_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-24 17:13:21.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-10-14 13:24:34.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2016-10-14 14:10:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a3abd3530ecf4a0a4e79537369d1c3b2227a810d","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2016-08-24 08:52:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"73b7fab6872ebecec12c862620f54f2d12dfb666","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-24 10:03:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/05/359705/1/check/gate-python-keystoneclient-docs-ubuntu-xenial/4b513c2//doc/build/html/ : SUCCESS in 1m 33s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/05/359705/1/check/gate-python-keystoneclient-pep8-ubuntu-xenial/6eb5cde/ : SUCCESS in 2m 29s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/05/359705/1/check/gate-python-keystoneclient-python27-ubuntu-xenial/677e58c/ : SUCCESS in 2m 27s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/05/359705/1/check/gate-python-keystoneclient-python34/0ca310c/ : SUCCESS in 1m 44s\n- gate-python-keystoneclient-python35-nv http://logs.openstack.org/05/359705/1/check/gate-python-keystoneclient-python35-nv/1768557/ : SUCCESS in 4m 19s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/05/359705/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/c72382d/ : SUCCESS in 1h 06m 19s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/05/359705/1/check/gate-keystoneclient-dsvm-functional/9cfef6b/ : SUCCESS in 24m 20s\n- gate-python-keystoneclient-tox-bandit-ubuntu-xenial http://logs.openstack.org/05/359705/1/check/gate-python-keystoneclient-tox-bandit-ubuntu-xenial/cb89b46/ : SUCCESS in 1m 47s","accounts_in_message":[],"_revision_number":1},{"id":"70f89f64760e8c7afd4ae5147597f3ddfd6eabbe","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-08-24 17:13:21.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"44602cbf2d5a58aafecf5d064ae1c765803677df","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2016-09-22 13:36:21.000000000","message":"Patch Set 1: Code-Review-1\n\nMy main concern here is that this could actually lead to broken code. Someone may be catching one of these exceptions while using the lib and now they\u0027d be broke. A safer way to do this would be to also import the ksa exceptions into keystoneclient.exceptions so that code continues to work.","accounts_in_message":[],"_revision_number":1},{"id":"22159fb2ae6fb582c7e957c36c7acb60d5134c0f","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2016-10-05 21:14:18.000000000","message":"Patch Set 1:\n\n@dstanek: so for places where the code was replicated to keystoneauth the exceptions are now the same object eg [1] so the same HTTP Exceptions are raised. My intent here is that nothing should actually be changed by this patch, just that as with all other clients we should assume that keystoneauth is the owner of these exceptions. \n\nWhat it does in this series is remove the dependency on keystoneclient exceptions so that a later patch can remove those exceptions. \n\n\n[1] https://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/exceptions.py#n163","accounts_in_message":[],"_revision_number":1},{"id":"f9347a1dc4e7ca1581a002102934d37212d51e6f","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2016-10-14 13:24:11.000000000","message":"Patch Set 1: Code-Review+2\n\nI could have sworn that one of the exceptions that was changed to ksa was not actually in the keysoneclient.exceptions module, but I may have been looking at a ksc_exception line.","accounts_in_message":[],"_revision_number":1},{"id":"6401f36fd5c9c4a7780ac626684134a82aeb3001","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2016-10-14 13:24:34.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"49f4764e70defc31b8c16ab1d943267fa56c2a67","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-14 13:28:58.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"748887c22fe292ab5acffcca7b92f27168495d4e","date":"2016-10-14 14:10:27.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"7d4af8f0789ed1c8b0aa087f6b2612531488ae8e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-14 14:10:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/05/359705/1/gate/gate-python-keystoneclient-docs-ubuntu-xenial/8e71c52//doc/build/html/ : SUCCESS in 2m 45s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/05/359705/1/gate/gate-python-keystoneclient-pep8-ubuntu-xenial/5363e3d/ : SUCCESS in 1m 31s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/05/359705/1/gate/gate-python-keystoneclient-python27-ubuntu-xenial/1c161ac/ : SUCCESS in 2m 47s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/05/359705/1/gate/gate-python-keystoneclient-python34/79fdcc1/ : SUCCESS in 1m 49s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/05/359705/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/be7c62a/ : SUCCESS in 41m 16s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/05/359705/1/gate/gate-keystoneclient-dsvm-functional-ubuntu-xenial/4c20932/ : SUCCESS in 26m 37s\n- gate-python-keystoneclient-tox-bandit-ubuntu-xenial http://logs.openstack.org/05/359705/1/gate/gate-python-keystoneclient-tox-bandit-ubuntu-xenial/1580e0b/ : SUCCESS in 1m 32s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5b91fedd650613f7ba480039fca7df83c1ff6bed","revisions":{"5b91fedd650613f7ba480039fca7df83c1ff6bed":{"kind":"REWORK","_number":1,"created":"2016-08-24 08:52:47.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/05/359705/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/05/359705/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/05/359705/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/05/359705/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/05/359705/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/05/359705/1"}}},"commit":{"parents":[{"commit":"f557170404ec2b7f5c562e55ad212b6e444655c8","subject":"Use AUTH_INTERFACE object from keystoneauth","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f557170404ec2b7f5c562e55ad212b6e444655c8"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-08-24 08:33:54.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-08-24 08:52:36.000000000","tz":600},"subject":"Use exceptions from Keystoneauth","message":"Use exceptions from Keystoneauth\n\nAs keystoneclient and other services rely more on keystoneauth we should\nassume that keystoneauth is our base auth library, not keystoneclient\nand start to default to the objects provided from there. This will make\nit easier to remove these objects when the time comes.\n\nFor the session independant parts of keystoneclient we should use the\nexception names as provided by keystoneauth instead of the aliases in\nkeystoneclient.\n\nChange-Id: Ic513046f8398a76c244e145d6cc3117cdf6bb4cd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/5b91fedd650613f7ba480039fca7df83c1ff6bed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/5b91fedd650613f7ba480039fca7df83c1ff6bed"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}