)]}'
{"id":"openstack%2Fpython-keystoneclient~38784","triplet_id":"openstack%2Fpython-keystoneclient~master~I54ac9c5ba91e697004f1346a8f2d685da488992a","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1197553","hashtags":[],"change_id":"I54ac9c5ba91e697004f1346a8f2d685da488992a","subject":"Ec2Signer : Allow signature verification for older boto versions","status":"MERGED","created":"2013-07-26 10:45:24.000000000","updated":"2013-08-02 18:54:22.000000000","submitted":"2013-08-02 18:54:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7fbea96c4282b5b8df0a6939baa57c6318313efe","_number":38784,"virtual_id_number":38784,"owner":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-08-02 18:54:22.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-08-02 18:08:00.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":2,"date":"2013-08-01 21:23:54.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":1,"date":"2013-08-01 16:20:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-08-02 18:08:00.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"date":"2013-08-01 16:13:29.000000000","_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"date":"2013-08-01 21:23:54.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-31 21:14:12.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2013-08-01 16:20:32.000000000","updated_by":{"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"},"reviewer":{"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"},"state":"REVIEWER"},{"updated":"2013-08-01 21:23:54.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2013-08-02 18:08:00.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-08-02 18:54:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f9ff8718535c71f4ff293d9e6c5eefc1ec4a2f0d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-26 11:34:50.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/84/38784/1/check/gate-python-keystoneclient-pep8/1438 : SUCCESS in 58s\n- http://docs-draft.openstack.org/84/38784/1/check/gate-python-keystoneclient-docs/1289/doc/build/html/ : SUCCESS in 1m 48s\n- http://logs.openstack.org/84/38784/1/check/gate-python-keystoneclient-python26/1343 : SUCCESS in 1m 44s\n- http://logs.openstack.org/84/38784/1/check/gate-python-keystoneclient-python27/1365 : SUCCESS in 1m 02s\n- http://logs.openstack.org/84/38784/1/check/gate-tempest-devstack-vm-full/35864 : SUCCESS in 47m 40s\n- http://logs.openstack.org/84/38784/1/check/gate-tempest-devstack-vm-cells-full/3131 : FAILURE in 15m 21s (non-voting)\n- http://logs.openstack.org/84/38784/1/check/gate-tempest-devstack-vm-testr-full/1957 : FAILURE in 27m 33s (non-voting)\n- http://logs.openstack.org/84/38784/1/check/gate-tempest-devstack-vm-postgres-full/35551 : SUCCESS in 49m 21s\n- http://logs.openstack.org/84/38784/1/check/gate-tempest-devstack-vm-neutron/7885 : SUCCESS in 19m 23s (non-voting)\n- http://logs.openstack.org/84/38784/1/check/gate-grenade-devstack-vm/21425 : SUCCESS in 22m 10s\n","accounts_in_message":[],"_revision_number":1},{"id":"a217c3f3998fa1776969dc4590e6882ceefffe9c","author":{"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"},"date":"2013-07-26 11:41:19.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nThis really *is* needed.","accounts_in_message":[],"_revision_number":1},{"id":"8363175bb3ecef7c76a0c7baea6576848d0e4c8d","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-07-30 02:20:42.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"d0db756e10e29ab862a28f3d559d701c43f6c59f","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-07-31 21:14:12.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"ec1d49e198c053380f326546c52ce1df780a7488","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-08-01 16:13:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9f2f0b32033a1115e14eedc8e8dbdba9c05bd9c3","author":{"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"},"date":"2013-08-01 16:20:32.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"28fe47ff9e8bd95f1282d2a072f6b394a7ee4256","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-01 17:00:26.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/84/38784/2/check/gate-python-keystoneclient-pep8/34813ee : SUCCESS in 1m 20s\n- http://docs-draft.openstack.org/84/38784/2/check/gate-python-keystoneclient-docs/16994e4/doc/build/html/ : SUCCESS in 1m 45s\n- http://logs.openstack.org/84/38784/2/check/gate-python-keystoneclient-python26/c2f9cf4 : SUCCESS in 2m 22s\n- http://logs.openstack.org/84/38784/2/check/gate-python-keystoneclient-python27/cc11454 : SUCCESS in 1m 28s\n- http://logs.openstack.org/84/38784/2/check/gate-tempest-devstack-vm-full/06541ac : SUCCESS in 46m 50s\n- http://logs.openstack.org/84/38784/2/check/gate-tempest-devstack-vm-cells-full/0973676 : FAILURE in 34m 07s (non-voting)\n- http://logs.openstack.org/84/38784/2/check/gate-tempest-devstack-vm-testr-full/e9ee6f7 : FAILURE in 27m 22s (non-voting)\n- http://logs.openstack.org/84/38784/2/check/gate-tempest-devstack-vm-postgres-full/b96135f : SUCCESS in 45m 36s\n- http://logs.openstack.org/84/38784/2/check/gate-tempest-devstack-vm-neutron/91b42d3 : FAILURE in 8m 42s (non-voting)\n- http://logs.openstack.org/84/38784/2/check/gate-grenade-devstack-vm/7f4a334 : SUCCESS in 22m 47s\n","accounts_in_message":[],"_revision_number":2},{"id":"a38b22a5b4c9a9fc85add1b0e818868b5d118c83","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-08-01 21:23:54.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"f647072c92d990f270bd09d6e0ed69e1f16dc586","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-08-02 18:08:00.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a15d14575db7337f417d960367132876344fa933","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-02 18:08:02.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"a65aa7f8ea9de8b8e1e90ab9b8b78cc91ffe4307","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-02 18:54:22.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"77637d5db712500266f205dc0ca0b4b3cb4a0f79","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-02 18:54:22.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/84/38784/2/gate/gate-python-keystoneclient-docs/d4a264a/doc/build/html/ : SUCCESS in 1m 16s\n- http://logs.openstack.org/84/38784/2/gate/gate-python-keystoneclient-pep8/7d31f45 : SUCCESS in 1m 03s\n- http://logs.openstack.org/84/38784/2/gate/gate-python-keystoneclient-python26/1ead7df : SUCCESS in 1m 55s\n- http://logs.openstack.org/84/38784/2/gate/gate-python-keystoneclient-python27/bd65972 : SUCCESS in 1m 12s\n- http://logs.openstack.org/84/38784/2/gate/gate-tempest-devstack-vm-full/366cc9a : SUCCESS in 45m 07s\n- http://logs.openstack.org/84/38784/2/gate/gate-tempest-devstack-vm-postgres-full/0592d1b : SUCCESS in 46m 01s\n- http://logs.openstack.org/84/38784/2/gate/gate-tempest-devstack-vm-neutron/bb12a65 : SUCCESS in 20m 22s (non-voting)\n- http://logs.openstack.org/84/38784/2/gate/gate-grenade-devstack-vm/759613b : SUCCESS in 25m 34s\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fb6792ada70c3298ebae44fa26e16b0b53fcb9b7","revisions":{"3c039ea76f0fb670ddc82a5ae6a7b649a6ae19b3":{"kind":"REWORK","_number":1,"created":"2013-07-26 10:45:24.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/84/38784/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/84/38784/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/84/38784/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/84/38784/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/84/38784/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/84/38784/1"}}},"commit":{"parents":[{"commit":"fd8f05350b7bf07d8505100d400ca77892236ed9","subject":"Merge \"Use ServiceCatalog.factory, the object has no __init__\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fd8f05350b7bf07d8505100d400ca77892236ed9"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-07-26 10:42:29.000000000","tz":60},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-07-26 10:42:29.000000000","tz":60},"subject":"Ec2Signer : Allow signature verification for older boto versions","message":"Ec2Signer : Allow signature verification for older boto versions\n\nSince the fix for bug #1197553, verification for older clients (which strip the\nport when formatting the request) fails.\n\nThis conditionally reverts to the original behavior, by detecting the boto\nversion via the User-Agent header, the default behavior will be the new\nbehavior (which doesn\u0027t strip the port), but this will allow a less painful\ntransition for clients/distros to the new boto version.\n\nFixes bug #1205281\n\nChange-Id: I54ac9c5ba91e697004f1346a8f2d685da488992a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3c039ea76f0fb670ddc82a5ae6a7b649a6ae19b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3c039ea76f0fb670ddc82a5ae6a7b649a6ae19b3"}]},"branch":"refs/heads/master"},"fb6792ada70c3298ebae44fa26e16b0b53fcb9b7":{"kind":"REWORK","_number":2,"created":"2013-08-01 16:13:29.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/84/38784/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/84/38784/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/84/38784/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/84/38784/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/84/38784/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/84/38784/2"}}},"commit":{"parents":[{"commit":"262c17922ac297d7c19324337b4d78de9f4fbcd5","subject":"Correct mis-spell in comments","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/262c17922ac297d7c19324337b4d78de9f4fbcd5"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-07-26 10:42:29.000000000","tz":60},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-08-01 16:13:19.000000000","tz":60},"subject":"Ec2Signer : Allow signature verification for older boto versions","message":"Ec2Signer : Allow signature verification for older boto versions\n\nSince the fix for bug #1197553, verification for older clients (which strip the\nport when formatting the request) fails.\n\nThis conditionally reverts to the original behavior, by detecting the boto\nversion via the User-Agent header, the default behavior will be the new\nbehavior (which doesn\u0027t strip the port), but this will allow a less painful\ntransition for clients/distros to the new boto version.\n\nFixes bug #1205281\n\nChange-Id: I54ac9c5ba91e697004f1346a8f2d685da488992a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fb6792ada70c3298ebae44fa26e16b0b53fcb9b7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fb6792ada70c3298ebae44fa26e16b0b53fcb9b7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}