)]}'
{"id":"openstack%2Fpython-keystoneclient~40671","triplet_id":"openstack%2Fpython-keystoneclient~master~I3cf669b94ed77ad0cd729ead0b4162a3f1b8819f","project":"openstack/python-keystoneclient","branch":"master","topic":"fix-test_request_no_token_dummy","hashtags":[],"change_id":"I3cf669b94ed77ad0cd729ead0b4162a3f1b8819f","subject":"Fix test_request_no_token_dummy cms dependency.","status":"MERGED","created":"2013-08-07 16:28:27.000000000","updated":"2013-08-07 17:51:00.000000000","submitted":"2013-08-07 17:51:00.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"adeb74f7a969e0a3b9d6aaedd6accc720e9f82e2","_number":40671,"virtual_id_number":40671,"owner":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":2,"date":"2013-08-07 17:51:00.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"recommended":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":1,"date":"2013-08-07 16:39:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"date":"2013-08-07 16:45:06.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-08-07 16:44:19.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2013-08-07 16:41:51.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-08-07 16:44:19.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"date":"2013-08-07 16:41:51.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"date":"2013-08-07 16:39:35.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-08-07 16:39:14.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2013-08-07 16:39:35.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2013-08-07 16:41:51.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2013-08-07 16:44:19.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-08-07 17:51:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5af566294548ce522f19a3f1fbea9b2dc1452cf0","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-08-07 16:31:29.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"278784a970137c9f7247a430add7ab784ca55b7a","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2013-08-07 16:34:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"dc4af955c16093fe488d0ed1ce01a088eb669c12","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-08-07 16:34:17.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"c89341bec0a9872424c5a437717d8978423038ac","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2013-08-07 16:38:23.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3600003f8f4f78c274be35c6df7f6aad6d6a3992","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-08-07 16:39:14.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"789a89299769cbda1fddd30136300c6ce6c20ca0","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-08-07 16:41:51.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\ncan we remove other calls to cms._ensure_subprocess() ?","accounts_in_message":[],"_revision_number":3},{"id":"d921b2144c25082196640e626f009ab4cf0643d4","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-08-07 16:44:19.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"1cf39e7d39d8f4b3696c9a48c37587cd91bfd112","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-07 16:44:21.000000000","message":"Patch Set 3:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"fdea481fd4bceb0de84ece406ea6205d5435b155","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2013-08-07 16:45:06.000000000","message":"Patch Set 3:\n\nThe only other calls are in the cms module itself. The cms module ensures that it deals with the dependency properly internally. The issue here is a test needs to refer to an Exception that is pulled in by _ensure_subprocess but can\u0027t do that until after either _ensure_subprocess is called directly or as a result of a side effect through one of the cms module functions. I think being direct is preferable to relying on a side effect.","accounts_in_message":[],"_revision_number":3},{"id":"529c8b573a54e8fc7bb07aa7d295e6821b588086","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-07 17:51:00.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"b0fbd377688de75dea427ac711e5157cfa9aff7c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-07 17:51:00.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/71/40671/3/gate/gate-python-keystoneclient-docs/7676f3b/doc/build/html/ : SUCCESS in 1m 03s\n- http://logs.openstack.org/71/40671/3/gate/gate-python-keystoneclient-pep8/fd17748 : SUCCESS in 1m 00s\n- http://logs.openstack.org/71/40671/3/gate/gate-python-keystoneclient-python26/1b0712c : SUCCESS in 2m 21s\n- http://logs.openstack.org/71/40671/3/gate/gate-python-keystoneclient-python27/15aaa7a : SUCCESS in 1m 04s\n- http://logs.openstack.org/71/40671/3/gate/gate-tempest-devstack-vm-full/c4df28d : SUCCESS in 42m 48s\n- http://logs.openstack.org/71/40671/3/gate/gate-tempest-devstack-vm-postgres-full/b508bfc : SUCCESS in 58m 28s\n- http://logs.openstack.org/71/40671/3/gate/gate-tempest-devstack-vm-neutron/e4e8ee0 : SUCCESS in 18m 40s\n- http://logs.openstack.org/71/40671/3/gate/gate-grenade-devstack-vm/f0fc441 : SUCCESS in 22m 53s\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"fb7aae4e966d8bc4db75698d956a3e66cb4824ec","revisions":{"ee647a5da539867b140609d9fd497b13f31431bc":{"kind":"REWORK","_number":1,"created":"2013-08-07 16:28:27.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/71/40671/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/71/40671/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/40671/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/40671/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/40671/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/40671/1"}}},"commit":{"parents":[{"commit":"4e9af1f5a2242d7772849ba6e311bef789f9ea13","subject":"Merge \"Pass the default_project_id when managing User.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/4e9af1f5a2242d7772849ba6e311bef789f9ea13"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2013-08-07 16:24:58.000000000","tz":-420},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2013-08-07 16:24:58.000000000","tz":-420},"subject":"Fix test_request_no_token_dummy cms dependency.","message":"Fix test_request_no_token_dummy cms dependency.\n\n* tests/test_auth_token_middleware.py: test_request_no_token_dummy has a\ndependency on the keystone.common.cms module importing subprocess prior\nto running. The cms._ensure_subprocess() function does this. Call this\nfunction to ensure subprocess is imported before symbols from that\nmodule are needed.\n\nThis fix is needed because testr runs tests in non deterministic order\nwhich means that each test needs to be able to run on its own (eg in its\nown process without any other tests running first) and they need to run\nwithout interfering any other tests (each test must properly clean up\nafter itself). Prior to this commit test_request_no_token_dummy would\nfail when executed on its own.\n\nChange-Id: I3cf669b94ed77ad0cd729ead0b4162a3f1b8819f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ee647a5da539867b140609d9fd497b13f31431bc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ee647a5da539867b140609d9fd497b13f31431bc"}]},"branch":"refs/heads/master"},"31cbc551c9871051a39c927676123de186b90261":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-08-07 16:34:09.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/71/40671/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/71/40671/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/40671/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/40671/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/40671/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/40671/2"}}},"commit":{"parents":[{"commit":"4e9af1f5a2242d7772849ba6e311bef789f9ea13","subject":"Merge \"Pass the default_project_id when managing User.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/4e9af1f5a2242d7772849ba6e311bef789f9ea13"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2013-08-07 16:24:58.000000000","tz":-420},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2013-08-07 16:34:03.000000000","tz":-420},"subject":"Fix test_request_no_token_dummy cms dependency.","message":"Fix test_request_no_token_dummy cms dependency.\n\n* tests/test_auth_token_middleware.py: test_request_no_token_dummy has a\ndependency on the keystone.common.cms module importing subprocess prior\nto running. The cms._ensure_subprocess() function does this. Call this\nfunction to ensure subprocess is imported before symbols from that\nmodule are needed.\n\nThis fix is needed because testr runs tests in non deterministic order\nwhich means that each test needs to be able to run on its own (eg in its\nown process without any other tests running first) and they need to run\nwithout interfering any other tests (each test must properly clean up\nafter itself). Prior to this commit test_request_no_token_dummy would\nfail when executed on its own.\n\nCloses-Bug: #1209300\nChange-Id: I3cf669b94ed77ad0cd729ead0b4162a3f1b8819f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/31cbc551c9871051a39c927676123de186b90261"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/31cbc551c9871051a39c927676123de186b90261"}]},"branch":"refs/heads/master"},"fb7aae4e966d8bc4db75698d956a3e66cb4824ec":{"kind":"REWORK","_number":3,"created":"2013-08-07 16:38:23.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/71/40671/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/71/40671/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/40671/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/40671/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/40671/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/40671/3"}}},"commit":{"parents":[{"commit":"4e9af1f5a2242d7772849ba6e311bef789f9ea13","subject":"Merge \"Pass the default_project_id when managing User.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/4e9af1f5a2242d7772849ba6e311bef789f9ea13"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2013-08-07 16:24:58.000000000","tz":-420},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2013-08-07 16:37:07.000000000","tz":-420},"subject":"Fix test_request_no_token_dummy cms dependency.","message":"Fix test_request_no_token_dummy cms dependency.\n\n* tests/test_auth_token_middleware.py: test_request_no_token_dummy has a\ndependency on the keystone.common.cms module importing subprocess prior\nto running. The cms._ensure_subprocess() function does this. Call this\nfunction in the base test class\u0027s setUp method to ensure subprocess is\nimported before symbols from that module are needed. Doing this in the\nbase setUp will ensure that this works for any additional tests with the\nsame dependency.\n\nThis fix is needed because testr runs tests in non deterministic order\nwhich means that each test needs to be able to run on its own (eg in its\nown process without any other tests running first) and they need to run\nwithout interfering any other tests (each test must properly clean up\nafter itself). Prior to this commit test_request_no_token_dummy would\nfail when executed on its own.\n\nCloses-Bug: #1209300\nChange-Id: I3cf669b94ed77ad0cd729ead0b4162a3f1b8819f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fb7aae4e966d8bc4db75698d956a3e66cb4824ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fb7aae4e966d8bc4db75698d956a3e66cb4824ec"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}