)]}'
{"id":"openstack%2Fpython-keystoneclient~40703","triplet_id":"openstack%2Fpython-keystoneclient~master~I8460a2ee663dec8be0f339735208779a3b988040","project":"openstack/python-keystoneclient","branch":"master","topic":"bug-1195924-refactor","hashtags":[],"change_id":"I8460a2ee663dec8be0f339735208779a3b988040","subject":"Refactor for testability of an upcoming change","status":"MERGED","created":"2013-08-07 19:08:47.000000000","updated":"2013-10-07 17:17:57.000000000","submitted":"2013-10-07 17:17:57.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cfc3a53fe6e48d425e7df1fa32d380a41258d515","_number":40703,"virtual_id_number":40703,"owner":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":2,"date":"2013-10-07 17:17:57.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-10-07 16:45:52.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},{"value":2,"date":"2013-10-02 01:28:14.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":1,"date":"2013-10-01 18:08:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":1,"date":"2013-10-01 16:00:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-10-07 16:45:52.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},{"value":0,"date":"2013-10-02 01:28:14.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-08-16 20:16:37.000000000","updated_by":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"reviewer":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"state":"REVIEWER"},{"updated":"2013-09-27 19:39:37.000000000","updated_by":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"reviewer":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"state":"REVIEWER"},{"updated":"2013-09-30 14:59:02.000000000","updated_by":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"reviewer":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"state":"REVIEWER"},{"updated":"2013-10-01 16:00:27.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2013-10-01 18:08:29.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2013-10-02 01:28:14.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2013-10-07 16:45:52.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-10-07 17:17:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b93202b0ce9d12a4bc0e466c5909568e982fc74f","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2013-08-07 19:13:22.000000000","message":"Patch Set 1:\n\nPlease refer https://review.openstack.org/#/c/35403 for some context.","accounts_in_message":[],"_revision_number":1},{"id":"6846a42d8595c30ef6f2f029c2239df0369684c1","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2013-08-07 19:20:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2169a3c5ccd777ac3c660462a2d8303460c62f32","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2013-08-07 19:22:02.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b6ba062a30c271ca1f8f300831e6e302079a58af","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-07 20:40:07.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/03/40703/3/check/gate-python-keystoneclient-pep8/e26d42b : SUCCESS in 1m 20s\n- http://docs-draft.openstack.org/03/40703/3/check/gate-python-keystoneclient-docs/7499f10/doc/build/html/ : SUCCESS in 1m 21s\n- http://logs.openstack.org/03/40703/3/check/gate-python-keystoneclient-python26/60e370e : SUCCESS in 1m 44s\n- http://logs.openstack.org/03/40703/3/check/gate-python-keystoneclient-python27/c216813 : SUCCESS in 1m 11s\n- http://logs.openstack.org/03/40703/3/check/gate-tempest-devstack-vm-full/186d3e7 : SUCCESS in 45m 01s\n- http://logs.openstack.org/03/40703/3/check/gate-tempest-devstack-vm-cells-full/536d515 : FAILURE in 11m 23s (non-voting)\n- http://logs.openstack.org/03/40703/3/check/gate-tempest-devstack-vm-testr-full/ff7e235 : FAILURE in 26m 52s (non-voting)\n- http://logs.openstack.org/03/40703/3/check/gate-tempest-devstack-vm-postgres-full/e187e35 : SUCCESS in 47m 01s\n- http://logs.openstack.org/03/40703/3/check/gate-tempest-devstack-vm-neutron/e4c4135 : SUCCESS in 22m 07s\n- http://logs.openstack.org/03/40703/3/check/gate-grenade-devstack-vm/db97d4a : SUCCESS in 24m 36s\n","accounts_in_message":[],"_revision_number":3},{"id":"bb0a0705370a0a14cf230a12cfaaf89841f58baf","author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"date":"2013-08-09 19:36:59.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"976f5656d7892e8e8d4cb2b06feb1f2a463e511e","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-08-15 15:27:30.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nthank you for breaking this down!","accounts_in_message":[],"_revision_number":3},{"id":"36dd69c5686e74ea76144d01e46b8b5bf4b1993c","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-08-16 05:17:13.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"481fe4fd6ed8f34d0507092f0168c933c0d32648","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2013-08-16 18:19:43.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"98b4769488110cac519f7a3455c6fd50f5b065a8","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2013-08-16 18:38:26.000000000","message":"Patch Set 4:\n\nanother MP ( https://review.openstack.org/#/c/35403/14 ) depends on this. (no change in this PS, just an update to the PS13 of the dependent commit changed this MP to PS4)","accounts_in_message":[],"_revision_number":4},{"id":"e70b43598f1b79065668b0ebeba10aa70c835183","author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"date":"2013-08-16 20:16:37.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"ee5f372869324f5dd9f62e4726ca47c22f8fffea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-16 21:47:41.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/03/40703/4/check/gate-python-keystoneclient-pep8/4c87503 : FAILURE in 4m 37s\n- http://docs-draft.openstack.org/03/40703/4/check/gate-python-keystoneclient-docs/4c5fad4/doc/build/html/ : SUCCESS in 4m 53s\n- http://logs.openstack.org/03/40703/4/check/gate-python-keystoneclient-python26/08521cc : SUCCESS in 2m 28s\n- http://logs.openstack.org/03/40703/4/check/gate-python-keystoneclient-python27/f066087 : SUCCESS in 3m 59s\n- http://logs.openstack.org/03/40703/4/check/gate-python-keystoneclient-python33/53c85d0 : FAILURE in 25s (non-voting)\n- http://logs.openstack.org/03/40703/4/check/gate-tempest-devstack-vm-full/49c2f09 : SUCCESS in 51m 16s\n- http://logs.openstack.org/03/40703/4/check/gate-tempest-devstack-vm-cells-full/48ed57a : FAILURE in 14m 16s (non-voting)\n- http://logs.openstack.org/03/40703/4/check/gate-tempest-devstack-vm-testr-full/0d63ad2 : FAILURE in 29m 30s (non-voting)\n- http://logs.openstack.org/03/40703/4/check/gate-tempest-devstack-vm-postgres-full/968925c : SUCCESS in 47m 22s\n- http://logs.openstack.org/03/40703/4/check/gate-tempest-devstack-vm-neutron/7a1f152 : SUCCESS in 24m 39s\n- http://logs.openstack.org/03/40703/4/check/gate-grenade-devstack-vm/d0908a9 : SUCCESS in 23m 50s\n","accounts_in_message":[],"_revision_number":4},{"id":"5cfcc3ced09046c86e8eea9e5d863b363069f4d5","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-08-24 06:03:03.000000000","message":"Patch Set 4:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":4},{"id":"a57286d2b8646c3d1b585045fdf1c64ebab800b7","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-08-24 06:03:03.000000000","message":"Patch Set 4: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":4},{"id":"aff6ffd2ead3e9ae4fcd222d46655b7fe404cbf8","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2013-08-30 18:06:25.000000000","message":"Patch Set 4: Restored","accounts_in_message":[],"_revision_number":4},{"id":"e88df43d57190ebedd4bf4d8a51b91da0b239f1e","author":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"date":"2013-08-30 18:09:59.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"ef8c5195edf7a364a149a982f5c29ae9eaad6d1a","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2013-08-30 18:15:08.000000000","message":"Patch Set 4:\n\n@Bryan: Can you please add tests to this or change the commit message as deemed appropriate to you? Either works for me.","accounts_in_message":[],"_revision_number":4},{"id":"cbdb05d9c996a19fa50e0f92ed113d697ebb81d1","author":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"date":"2013-08-30 18:20:48.000000000","message":"Patch Set 5:\n\n@nikhil: I didn\u0027t include the tests here because they were failing on my machine and really only make sense in the context of the fix that depends on this refactor. I\u0027ll note that in the commit message.","accounts_in_message":[],"_revision_number":5},{"id":"dcc120db48febda6cb33663159baa87d78588920","author":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"date":"2013-08-30 18:23:35.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"61a94a42c3b910949f4fb811afa22b2369815e66","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-08-30 18:23:41.000000000","message":"Patch Set 6:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":6},{"id":"09a18840130ffd371059a4b8eb5348dab52f20e6","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2013-08-30 18:30:44.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\nnice, lgtm","accounts_in_message":[],"_revision_number":6},{"id":"99872b9f6343b5367f5fbb544df483b2e28f8b68","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-30 18:49:31.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/03/40703/6/check/gate-python-keystoneclient-pep8/196d017 : SUCCESS in 1m 29s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/03/40703/6/check/gate-python-keystoneclient-docs/55bcb47/doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/03/40703/6/check/gate-python-keystoneclient-python26/3b6aa2c : SUCCESS in 1m 14s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/03/40703/6/check/gate-python-keystoneclient-python27/a626b3a : SUCCESS in 1m 35s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/03/40703/6/check/gate-python-keystoneclient-python33/03cc0b3 : FAILURE in 18s (non-voting)\n- gate-tempest-devstack-vm-full http://logs.openstack.org/03/40703/6/check/gate-tempest-devstack-vm-full/2e62373 : SUCCESS in 24m 59s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/03/40703/6/check/gate-tempest-devstack-vm-postgres-full/725225b : SUCCESS in 25m 53s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/03/40703/6/check/gate-tempest-devstack-vm-neutron/54e7e69 : SUCCESS in 16m 24s\n- gate-grenade-devstack-vm http://logs.openstack.org/03/40703/6/check/gate-grenade-devstack-vm/fdc901d : SUCCESS in 20m 23s\n","accounts_in_message":[],"_revision_number":6},{"id":"acd76680494ed0c6f1380af9af13385d28ca8b53","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-08-30 21:19:16.000000000","message":"Patch Set 6: I would prefer that you didn\u0027t merge this\n\nsuggest add tests for the new functions.","accounts_in_message":[],"_revision_number":6},{"id":"198320ba0a0385eb19b62bbe61621c911e31710c","author":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"date":"2013-09-03 13:36:02.000000000","message":"Patch Set 6:\n\nI added back the dependency on this patch from the child patch so we have that recorded now. Sorry for losing track of that.\n\n@Brant: The fix that depends on this refactor has a fairly comprehensive test suite associated with the confirm_token_not_expired() function. Normally I\u0027d agree that we should add tests here so no change goes untested, however the complexities of timezones make this function as it is currently written (before the upcoming fix) very fragile. Basically, the tests would work as long as the machine running them is set to UTC. In other words, the tests would fail for any developer who\u0027s machine is not in UTC time. The patch that depends on this refactor corrects this problem both for testing \u0026 for production use.\n\nThis refactor was originally part of the patch containing the fix but it was later suggested we split out the refactor to its own patch.","accounts_in_message":[],"_revision_number":6},{"id":"af10dd3a8f29711f522531054ac3b9261ffb8cfe","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-09-06 15:47:52.000000000","message":"Patch Set 6:\n\nThe tests that should be added are:\n\n 1) that _token_is_v2() is true if given a v2 token\n 2) that _token_is_v2() is False if given a v3 token\n 3) that _token_is_v3() is true if given a v3 token\n 4) that _token_is_v3() is False if given a v2 token\n\nI\u0027m OK with the tests for the timestamp/UTC stuff going in the other submission.","accounts_in_message":[],"_revision_number":6},{"id":"5aef081f7021fd496803be32b3f040d28cff83fb","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2013-09-06 17:49:43.000000000","message":"Patch Set 6:\n\nAgree, we should really get this patch moving. The following one breaks keystoneclient and is kind of a big deal.","accounts_in_message":[],"_revision_number":6},{"id":"1c4b021e067353737ac77755dbde421043f5444d","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-09-14 06:03:04.000000000","message":"Patch Set 6:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":6},{"id":"c7e8c1e40d171fb31c8e8f2a79f83b6b36103ca4","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-09-14 06:03:04.000000000","message":"Patch Set 6: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":6},{"id":"2266bd0a8f4fdb7ab9da37f1ac0ef641b1b4b41a","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2013-09-17 17:52:10.000000000","message":"Patch Set 6: Restored","accounts_in_message":[],"_revision_number":6},{"id":"767a4fb1d0c0fe75a70847f6c5d0b5a9404a2782","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-09-25 06:03:04.000000000","message":"Patch Set 6:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":6},{"id":"f6d06426c6f5300ab31b4abb50a98da4506dd31c","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-09-25 06:03:04.000000000","message":"Patch Set 6: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":6},{"id":"72bb8310b954ad3f89991458dec3adae5a6d41ee","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2013-09-27 15:56:27.000000000","message":"Patch Set 6: Restored","accounts_in_message":[],"_revision_number":6},{"id":"a72e453c3664dc9ec05e72f1c73a1532b68f52b1","author":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"date":"2013-09-27 17:54:39.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"b51b000f8a1b5ef8006a132211fbc6f6bca4493e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-09-27 18:42:25.000000000","message":"Patch Set 7: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/03/40703/7/check/gate-python-keystoneclient-pep8/e4f3bbc : SUCCESS in 1m 14s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/03/40703/7/check/gate-python-keystoneclient-docs/53d6190/doc/build/html/ : SUCCESS in 1m 02s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/03/40703/7/check/gate-python-keystoneclient-python26/3472573 : SUCCESS in 51s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/03/40703/7/check/gate-python-keystoneclient-python27/e3f01fa : SUCCESS in 50s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/03/40703/7/check/gate-python-keystoneclient-python33/73fab46 : FAILURE in 20s (non-voting)\n- gate-tempest-devstack-vm-full http://logs.openstack.org/03/40703/7/check/gate-tempest-devstack-vm-full/86c8245 : SUCCESS in 37m 47s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/03/40703/7/check/gate-tempest-devstack-vm-postgres-full/4bbb16c : SUCCESS in 31m 33s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/03/40703/7/check/gate-tempest-devstack-vm-neutron/d5fe57c : FAILURE in 28m 17s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/03/40703/7/check/gate-tempest-devstack-vm-large-ops/e2ab9c8 : SUCCESS in 11m 12s\n- gate-grenade-devstack-vm http://logs.openstack.org/03/40703/7/check/gate-grenade-devstack-vm/d56ed75 : SUCCESS in 30m 33s\n","accounts_in_message":[],"_revision_number":7},{"id":"fee7f4b9ff33c6e782748fb7ea12734927ca06d8","author":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"date":"2013-09-27 19:39:37.000000000","message":"Patch Set 7:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":7},{"id":"2226227b9447da44b2dc51cb36568c46bc878554","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-09-27 21:11:38.000000000","message":"Patch Set 7:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/03/40703/7/check/gate-python-keystoneclient-pep8/5c65cfa : SUCCESS in 53s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/03/40703/7/check/gate-python-keystoneclient-docs/27da1c2/doc/build/html/ : SUCCESS in 59s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/03/40703/7/check/gate-python-keystoneclient-python26/0223abc : SUCCESS in 53s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/03/40703/7/check/gate-python-keystoneclient-python27/98d39e5 : SUCCESS in 49s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/03/40703/7/check/gate-python-keystoneclient-python33/c76ca9b : FAILURE in 19s (non-voting)\n- check-tempest-devstack-vm-full http://logs.openstack.org/03/40703/7/check/check-tempest-devstack-vm-full/1489745 : SUCCESS in 35m 53s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/03/40703/7/check/check-tempest-devstack-vm-postgres-full/86796c5 : SUCCESS in 35m 16s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/03/40703/7/check/check-tempest-devstack-vm-neutron/ecd30ce : FAILURE in 24m 46s\n- check-tempest-devstack-vm-large-ops http://logs.openstack.org/03/40703/7/check/check-tempest-devstack-vm-large-ops/4b324df : FAILURE in 14m 53s\n- check-grenade-devstack-vm http://logs.openstack.org/03/40703/7/check/check-grenade-devstack-vm/2c2b86b : SUCCESS in 30m 42s\n","accounts_in_message":[],"_revision_number":7},{"id":"d364870fd5cd96a665a590e9cba173cfae6d5d4b","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-09-30 14:59:02.000000000","message":"Patch Set 7:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":7},{"id":"4eca210142858e07f5a264488337d853adbc7d77","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-09-30 15:37:56.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/03/40703/7/check/gate-python-keystoneclient-pep8/d6cabd0 : SUCCESS in 57s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/03/40703/7/check/gate-python-keystoneclient-docs/f909437/doc/build/html/ : SUCCESS in 54s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/03/40703/7/check/gate-python-keystoneclient-python26/04808b3 : SUCCESS in 1m 03s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/03/40703/7/check/gate-python-keystoneclient-python27/dd72155 : SUCCESS in 56s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/03/40703/7/check/gate-python-keystoneclient-python33/f077ca7 : FAILURE in 19s (non-voting)\n- check-tempest-devstack-vm-full http://logs.openstack.org/03/40703/7/check/check-tempest-devstack-vm-full/3de8ddd : SUCCESS in 29m 45s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/03/40703/7/check/check-tempest-devstack-vm-postgres-full/f53b0df : SUCCESS in 38m 05s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/03/40703/7/check/check-tempest-devstack-vm-neutron/2fc051f : SUCCESS in 20m 14s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/03/40703/7/check/gate-tempest-devstack-vm-large-ops/508ebb9 : SUCCESS in 11m 58s\n- check-grenade-devstack-vm http://logs.openstack.org/03/40703/7/check/check-grenade-devstack-vm/4814e26 : SUCCESS in 32m 02s\n","accounts_in_message":[],"_revision_number":7},{"id":"5b85ff0ed45f43c03855bb48f1ae2013cb7bc11f","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-09-30 23:03:58.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":7},{"id":"43bd2560a704c8a2a37c36c37fbb1da044537fed","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2013-10-01 12:26:42.000000000","message":"Patch Set 7: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nI would like to see the commit message update to reflect what actually changed.","accounts_in_message":[],"_revision_number":7},{"id":"3d682c4dd98f33ed596cc314a1b793414f5822f2","author":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"date":"2013-10-01 15:56:27.000000000","message":"Patch Set 7: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"14b2c5191aafe377b853aceaf498d9ea99558c67","author":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"date":"2013-10-01 15:56:41.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"80afe61501ab43bc0d7bab67885b794aa2aeb089","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-10-01 15:56:47.000000000","message":"Patch Set 8:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":8},{"id":"a4189a8bbde70a62e08cb073957f32a36bd98bbc","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2013-10-01 16:00:27.000000000","message":"Patch Set 8: Looks good to me, but someone else must approve\n\nnice!","accounts_in_message":[],"_revision_number":8},{"id":"cefe484437d872df84496fda8d873bd1906c2cfa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-01 16:42:16.000000000","message":"Patch Set 8: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/03/40703/8/check/gate-python-keystoneclient-pep8/fda0b63 : SUCCESS in 54s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/03/40703/8/check/gate-python-keystoneclient-docs/a573e79/doc/build/html/ : SUCCESS in 52s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/03/40703/8/check/gate-python-keystoneclient-python26/f98b4a2 : SUCCESS in 1m 14s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/03/40703/8/check/gate-python-keystoneclient-python27/1a9d385 : SUCCESS in 1m 28s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/03/40703/8/check/gate-python-keystoneclient-python33/3544c71 : FAILURE in 38s (non-voting)\n- check-tempest-devstack-vm-full http://logs.openstack.org/03/40703/8/check/check-tempest-devstack-vm-full/264a933 : SUCCESS in 43m 39s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/03/40703/8/check/check-tempest-devstack-vm-postgres-full/65aeac5 : SUCCESS in 33m 17s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/03/40703/8/check/check-tempest-devstack-vm-neutron/ea91d25 : SUCCESS in 21m 51s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/03/40703/8/check/gate-tempest-devstack-vm-large-ops/960f03c : SUCCESS in 13m 23s\n- check-grenade-devstack-vm http://logs.openstack.org/03/40703/8/check/check-grenade-devstack-vm/23199f0 : SUCCESS in 34m 23s\n","accounts_in_message":[],"_revision_number":8},{"id":"afd2597b1f73a0e10a5186827016d5a025069da7","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-10-01 18:08:29.000000000","message":"Patch Set 8: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":8},{"id":"82a4a4ef16a80762129e39eb674608c325d034e1","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-10-02 01:28:14.000000000","message":"Patch Set 8: Looks good to me (core reviewer)\n\nmy comments were addressed, thanks!","accounts_in_message":[],"_revision_number":8},{"id":"13d6cec90f43ceff4dab4c20812c8d481ff5aa15","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-10-07 16:45:52.000000000","message":"Patch Set 8: Looks good to me (core reviewer); Approved\n\nthanks!","accounts_in_message":[],"_revision_number":8},{"id":"0ec212b6cde801dc1c459bd36688545cd9a343d6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-07 16:45:53.000000000","message":"Patch Set 8: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":8},{"id":"93dbaf4b01ffec5e9c2b5e37e6a5f7cbbe1d1d94","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-07 17:17:57.000000000","message":"Patch Set 8: Verified\n\nBuild succeeded.\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/03/40703/8/gate/gate-python-keystoneclient-docs/a57de2b/doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/03/40703/8/gate/gate-python-keystoneclient-pep8/0b44e37 : SUCCESS in 58s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/03/40703/8/gate/gate-python-keystoneclient-python26/c0bb5bd : SUCCESS in 1m 09s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/03/40703/8/gate/gate-python-keystoneclient-python27/9fa2c3e : SUCCESS in 56s\n- gate-tempest-devstack-vm-full http://logs.openstack.org/03/40703/8/gate/gate-tempest-devstack-vm-full/eace460 : SUCCESS in 26m 27s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/03/40703/8/gate/gate-tempest-devstack-vm-postgres-full/6753afb : SUCCESS in 31m 59s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/03/40703/8/gate/gate-tempest-devstack-vm-neutron/69f51fd : SUCCESS in 17m 40s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/03/40703/8/gate/gate-tempest-devstack-vm-large-ops/a9f963f : SUCCESS in 10m 19s\n- gate-grenade-devstack-vm http://logs.openstack.org/03/40703/8/gate/gate-grenade-devstack-vm/27e180c : SUCCESS in 24m 08s\n","accounts_in_message":[],"_revision_number":8},{"id":"840d0443afa9e90d0160c93c7a6d721fd8b808bf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-07 17:17:57.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"a2e7b17810ed34719dc101f93dc480e2f9fdce6e","revisions":{"f5cf2ca9d55358ea72506465a08cdcf3f60305c6":{"kind":"REWORK","_number":1,"created":"2013-08-07 19:08:47.000000000","uploader":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"ref":"refs/changes/03/40703/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/03/40703/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/1"}}},"commit":{"parents":[{"commit":"734ef6eb83a9d9d49c181018ba63e45dbcfa1c90","subject":"auth_uri (public ep) should not default to auth_* values (admin ep)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/734ef6eb83a9d9d49c181018ba63e45dbcfa1c90"}]}],"author":{"name":"Nikhil Komawar","email":"nikhil.komawar@rackspace.com","date":"2013-08-06 20:55:08.000000000","tz":0},"committer":{"name":"Nikhil Komawar","email":"nikhil.komawar@rackspace.com","date":"2013-08-07 19:09:19.000000000","tz":0},"subject":"Refactor a method for testability.","message":"Refactor a method for testability.\n\nOne of the methods in keystoneclient/middleware/auth_token.py has been\nmoved out of the class to make it a static method and be better\ntestable. Currently, there is no need to keep it within the class.\n\nChange-Id: I8460a2ee663dec8be0f339735208779a3b988040\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f5cf2ca9d55358ea72506465a08cdcf3f60305c6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f5cf2ca9d55358ea72506465a08cdcf3f60305c6"}]},"branch":"refs/heads/master"},"e6ce8f336f0e125402169ca381d6af273f8a0f61":{"kind":"REWORK","_number":2,"created":"2013-08-07 19:20:59.000000000","uploader":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"ref":"refs/changes/03/40703/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/03/40703/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/2"}}},"commit":{"parents":[{"commit":"fb7aae4e966d8bc4db75698d956a3e66cb4824ec","subject":"Fix test_request_no_token_dummy cms dependency.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fb7aae4e966d8bc4db75698d956a3e66cb4824ec"}]}],"author":{"name":"Nikhil Komawar","email":"nikhil.komawar@rackspace.com","date":"2013-08-06 20:55:08.000000000","tz":0},"committer":{"name":"Nikhil Komawar","email":"nikhil.komawar@rackspace.com","date":"2013-08-07 19:21:39.000000000","tz":0},"subject":"Refactor a method for testability.","message":"Refactor a method for testability.\n\nOne of the methods in keystoneclient/middleware/auth_token.py has been\nmoved out of the class to make it a static method and be better\ntestable. Currently, there is no need to keep it within the class.\n\nChange-Id: I8460a2ee663dec8be0f339735208779a3b988040\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e6ce8f336f0e125402169ca381d6af273f8a0f61"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e6ce8f336f0e125402169ca381d6af273f8a0f61"}]},"branch":"refs/heads/master"},"5bc3edbb1576e1d34610b83e2a8008cb88669794":{"kind":"REWORK","_number":3,"created":"2013-08-07 19:22:02.000000000","uploader":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"ref":"refs/changes/03/40703/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/03/40703/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/3"}}},"commit":{"parents":[{"commit":"fb7aae4e966d8bc4db75698d956a3e66cb4824ec","subject":"Fix test_request_no_token_dummy cms dependency.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fb7aae4e966d8bc4db75698d956a3e66cb4824ec"}]}],"author":{"name":"Nikhil Komawar","email":"nikhil.komawar@rackspace.com","date":"2013-08-06 20:55:08.000000000","tz":0},"committer":{"name":"Nikhil Komawar","email":"nikhil.komawar@rackspace.com","date":"2013-08-07 19:22:21.000000000","tz":0},"subject":"Refactor a method for testability.","message":"Refactor a method for testability.\n\nOne of the methods in keystoneclient/middleware/auth_token.py has been\nmoved out of the class to make it a static method and be better\ntestable. Currently, there is no need to keep it within the class.\n\nChange-Id: I8460a2ee663dec8be0f339735208779a3b988040\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/5bc3edbb1576e1d34610b83e2a8008cb88669794"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/5bc3edbb1576e1d34610b83e2a8008cb88669794"}]},"branch":"refs/heads/master"},"673095f1db4eb3b6466f3b3b37e3dcd1dacad460":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2013-08-16 18:19:43.000000000","uploader":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"ref":"refs/changes/03/40703/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/03/40703/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/4"}}},"commit":{"parents":[{"commit":"dc5c33a9e52a062cd6742986f780a48ee2d6b383","subject":"Fix and enable Gating on H404","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/dc5c33a9e52a062cd6742986f780a48ee2d6b383"}]}],"author":{"name":"Nikhil Komawar","email":"nikhil.komawar@rackspace.com","date":"2013-08-06 20:55:08.000000000","tz":0},"committer":{"name":"Nikhil Komawar","email":"nikhil.komawar@rackspace.com","date":"2013-08-16 16:39:01.000000000","tz":0},"subject":"Refactor a method for testability.","message":"Refactor a method for testability.\n\nOne of the methods in keystoneclient/middleware/auth_token.py has been\nmoved out of the class to make it a static method and be better\ntestable. Currently, there is no need to keep it within the class.\n\nChange-Id: I8460a2ee663dec8be0f339735208779a3b988040\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/673095f1db4eb3b6466f3b3b37e3dcd1dacad460"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/673095f1db4eb3b6466f3b3b37e3dcd1dacad460"}]},"branch":"refs/heads/master"},"50fac4561ddcd48d2c5db63b233d92398630a147":{"kind":"REWORK","_number":5,"created":"2013-08-30 18:09:59.000000000","uploader":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"ref":"refs/changes/03/40703/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/03/40703/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/5"}}},"commit":{"parents":[{"commit":"bbcc7a7769d79b017c525d6f6c9695b633ee4ba6","subject":"Merge \"python3: Use from future import unicode_literals\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/bbcc7a7769d79b017c525d6f6c9695b633ee4ba6"}]}],"author":{"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","date":"2013-08-30 16:31:12.000000000","tz":-240},"committer":{"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","date":"2013-08-30 16:33:59.000000000","tz":-240},"subject":"Refactor a method for testability","message":"Refactor a method for testability\n\nOne of the methods in keystoneclient/middleware/auth_token.py has been\nmoved out of the class to make it a static method and be better\ntestable. Currently, there is no need to keep it within the class.\n\nChange-Id: I8460a2ee663dec8be0f339735208779a3b988040\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/50fac4561ddcd48d2c5db63b233d92398630a147"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/50fac4561ddcd48d2c5db63b233d92398630a147"}]},"branch":"refs/heads/master"},"cc32d881c01a820973f5f0abd9483376d998214b":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2013-08-30 18:23:35.000000000","uploader":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"ref":"refs/changes/03/40703/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/03/40703/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/6"}}},"commit":{"parents":[{"commit":"bbcc7a7769d79b017c525d6f6c9695b633ee4ba6","subject":"Merge \"python3: Use from future import unicode_literals\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/bbcc7a7769d79b017c525d6f6c9695b633ee4ba6"}]}],"author":{"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","date":"2013-08-30 16:31:12.000000000","tz":-240},"committer":{"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","date":"2013-08-30 18:16:28.000000000","tz":-240},"subject":"Refactor for testability of an upcoming change","message":"Refactor for testability of an upcoming change\n\nconfirm_token_not_expired() in keystoneclient/middleware/auth_token.py has\nbeen moved out of the class to make it a static method and be better\ntestable. Currently, there is no need to keep it within the class. An\nupcoming commit makes fixes that rely on this refactor to be tested.\n\nChange-Id: I8460a2ee663dec8be0f339735208779a3b988040\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/cc32d881c01a820973f5f0abd9483376d998214b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/cc32d881c01a820973f5f0abd9483376d998214b"}]},"branch":"refs/heads/master"},"983b83e53d9f108272baca77e292f0f6e65208d2":{"kind":"REWORK","_number":7,"created":"2013-09-27 17:54:39.000000000","uploader":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"ref":"refs/changes/03/40703/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/03/40703/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/7"}}},"commit":{"parents":[{"commit":"baa949017a42368ec1e92e49490086364befe5da","subject":"Fix misused assertTrue in unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/baa949017a42368ec1e92e49490086364befe5da"}]}],"author":{"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","date":"2013-08-30 16:31:12.000000000","tz":-240},"committer":{"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","date":"2013-09-27 17:52:30.000000000","tz":-240},"subject":"Refactor for testability of an upcoming change","message":"Refactor for testability of an upcoming change\n\nconfirm_token_not_expired() in keystoneclient/middleware/auth_token.py has\nbeen moved out of the class to make it a static method and be better\ntestable. Currently, there is no need to keep it within the class. An\nupcoming commit makes fixes that rely on this refactor to be tested.\n\nChange-Id: I8460a2ee663dec8be0f339735208779a3b988040\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/983b83e53d9f108272baca77e292f0f6e65208d2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/983b83e53d9f108272baca77e292f0f6e65208d2"}]},"branch":"refs/heads/master"},"a2e7b17810ed34719dc101f93dc480e2f9fdce6e":{"kind":"NO_CODE_CHANGE","_number":8,"created":"2013-10-01 15:56:41.000000000","uploader":{"_account_id":6949,"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","username":"bryan-davidson"},"ref":"refs/changes/03/40703/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/03/40703/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/03/40703/8"}}},"commit":{"parents":[{"commit":"baa949017a42368ec1e92e49490086364befe5da","subject":"Fix misused assertTrue in unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/baa949017a42368ec1e92e49490086364befe5da"}]}],"author":{"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","date":"2013-08-30 16:31:12.000000000","tz":-240},"committer":{"name":"Bryan Davidson","email":"bryan.davidson@rackspace.com","date":"2013-10-01 15:51:48.000000000","tz":-240},"subject":"Refactor for testability of an upcoming change","message":"Refactor for testability of an upcoming change\n\nconfirm_token_not_expired() in keystoneclient/middleware/auth_token.py has\nbeen moved out of the class to make it a function and be more testable.\nCurrently, there is no need to keep it within the class. An upcoming\ncommit makes fixes that rely on this refactor to be tested.\n\nChange-Id: I8460a2ee663dec8be0f339735208779a3b988040\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a2e7b17810ed34719dc101f93dc480e2f9fdce6e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a2e7b17810ed34719dc101f93dc480e2f9fdce6e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}