)]}'
{"id":"openstack%2Fpython-keystoneclient~416829","triplet_id":"openstack%2Fpython-keystoneclient~master~I14165903b46d2fc26e8c9de591917893f58516db","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1652458","hashtags":[],"change_id":"I14165903b46d2fc26e8c9de591917893f58516db","subject":"remove hacking checks from keystoneclient","status":"MERGED","created":"2017-01-05 04:55:51.000000000","updated":"2017-01-06 19:41:10.000000000","submitted":"2017-01-06 19:41:10.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6249ae2da74747158d5c46167c6d749924490d87","_number":416829,"virtual_id_number":416829,"owner":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-01-06 19:41:10.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-01-06 16:57:31.000000000","_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-01-06 16:57:31.000000000","_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-06 16:07:50.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2017-01-06 16:57:31.000000000","updated_by":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"reviewer":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"state":"REVIEWER"},{"updated":"2017-01-06 19:41:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"fdee353e8803443142223b817ea9746cab5b0af4","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-01-05 04:55:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1c6c9d372a2ce9dc2d46ebfd68fbd8ddcb67b622","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-05 05:51:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/29/416829/1/check/gate-python-keystoneclient-docs-ubuntu-xenial/2871c39//doc/build/html/ : SUCCESS in 1m 23s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/29/416829/1/check/gate-python-keystoneclient-pep8-ubuntu-xenial/5e8856c/ : SUCCESS in 1m 30s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/29/416829/1/check/gate-python-keystoneclient-python27-ubuntu-xenial/2fd9ecb/ : SUCCESS in 1m 21s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/29/416829/1/check/gate-python-keystoneclient-python35/26f6f79/ : SUCCESS in 1m 22s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/29/416829/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/c00637a/ : SUCCESS in 55m 04s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/29/416829/1/check/gate-keystoneclient-dsvm-functional-ubuntu-xenial/aaf12ea/ : SUCCESS in 17m 30s","accounts_in_message":[],"_revision_number":1},{"id":"37e1779845febe941cdfc3a52e0120c5ca921415","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2017-01-05 18:52:24.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4ff2bfd0997526fb21ef3c91a1586ec103315031","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-01-06 15:51:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"144d5ef8095537270ca8b605ad6eadb6eadb9749","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2017-01-06 16:07:50.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"af7771ae1ac06546ba107afa6b415a6442ba6154","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2017-01-06 16:46:37.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"126ba8f92355aacff1faf5db875e2e0cceb60694","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-06 16:50:24.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/29/416829/2/check/gate-python-keystoneclient-docs-ubuntu-xenial/24b9fa7//doc/build/html/ : SUCCESS in 3m 01s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/29/416829/2/check/gate-python-keystoneclient-pep8-ubuntu-xenial/0338d09/ : FAILURE in 3m 37s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/29/416829/2/check/gate-python-keystoneclient-python27-ubuntu-xenial/fe19276/ : SUCCESS in 3m 01s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/29/416829/2/check/gate-python-keystoneclient-python35/5682e19/ : SUCCESS in 2m 45s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/29/416829/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/3fd9569/ : SUCCESS in 57m 31s\n- gate-python-keystoneclient-releasenotes http://docs-draft.openstack.org/29/416829/2/check/gate-python-keystoneclient-releasenotes/e9e745e//releasenotes/build/html/ : SUCCESS in 3m 12s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/29/416829/2/check/gate-keystoneclient-dsvm-functional-ubuntu-xenial/9b3b2e4/ : SUCCESS in 18m 11s","accounts_in_message":[],"_revision_number":2},{"id":"a12673f974ccc90dc6e5aa338f5a4ab9fced14b9","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-01-06 16:56:20.000000000","message":"Patch Set 3: Published edit on patch set 2","accounts_in_message":[],"_revision_number":3},{"id":"df37dfbaa159012052db54b8bd3ad71e0af52e57","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2017-01-06 16:57:31.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nThis should be fine now","accounts_in_message":[],"_revision_number":3},{"id":"c9aea5c6e68d21ce9ab008f1ca9d22400ed325c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-06 18:45:04.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/29/416829/3/check/gate-python-keystoneclient-docs-ubuntu-xenial/06c8349//doc/build/html/ : SUCCESS in 1m 42s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/29/416829/3/check/gate-python-keystoneclient-pep8-ubuntu-xenial/199abb0/ : SUCCESS in 1m 50s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/29/416829/3/check/gate-python-keystoneclient-python27-ubuntu-xenial/573e610/ : SUCCESS in 1m 36s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/29/416829/3/check/gate-python-keystoneclient-python35/b78658f/ : SUCCESS in 3m 16s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/29/416829/3/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/f1895a1/ : SUCCESS in 1h 47m 12s\n- gate-python-keystoneclient-releasenotes http://docs-draft.openstack.org/29/416829/3/check/gate-python-keystoneclient-releasenotes/98d3a52//releasenotes/build/html/ : SUCCESS in 2m 07s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/29/416829/3/check/gate-keystoneclient-dsvm-functional-ubuntu-xenial/d983992/ : SUCCESS in 39m 31s","accounts_in_message":[],"_revision_number":3},{"id":"e6329fed67a31c395c213141d899f775cf08303e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-06 18:45:17.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"0fc33ee3587c6dbb435db3be2d66058800a77dd7","date":"2017-01-06 19:41:10.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"475439effc2f3be4e524b9a323770b5f08282e45","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-06 19:41:10.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/29/416829/3/gate/gate-python-keystoneclient-docs-ubuntu-xenial/3de31af//doc/build/html/ : SUCCESS in 2m 57s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/29/416829/3/gate/gate-python-keystoneclient-pep8-ubuntu-xenial/fde41d1/ : SUCCESS in 2m 10s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/29/416829/3/gate/gate-python-keystoneclient-python27-ubuntu-xenial/8ecb9ae/ : SUCCESS in 1m 32s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/29/416829/3/gate/gate-python-keystoneclient-python35/301ae13/ : SUCCESS in 1m 29s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/29/416829/3/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/b467dd7/ : SUCCESS in 55m 49s\n- gate-python-keystoneclient-releasenotes http://docs-draft.openstack.org/29/416829/3/gate/gate-python-keystoneclient-releasenotes/a51c720//releasenotes/build/html/ : SUCCESS in 2m 03s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/29/416829/3/gate/gate-keystoneclient-dsvm-functional-ubuntu-xenial/27943c0/ : SUCCESS in 17m 56s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ffdab4ea43389b94f3c1d1ead5d97870d7c3c311","revisions":{"31a506531adb802eaed82d9f4ca6cd4bad822840":{"kind":"REWORK","_number":1,"created":"2017-01-05 04:55:51.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/29/416829/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/29/416829/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/416829/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/416829/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/416829/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/416829/1"}}},"commit":{"parents":[{"commit":"004450040c38a0df05469b844ba30854b67aabd5","subject":"Merge \"re-work inference rule bindings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/004450040c38a0df05469b844ba30854b67aabd5"}]}],"author":{"name":"Steve Martinelli","email":"s.martinelli@gmail.com","date":"2017-01-03 14:51:55.000000000","tz":-300},"committer":{"name":"Steve Martinelli","email":"s.martinelli@gmail.com","date":"2017-01-05 04:55:30.000000000","tz":-300},"subject":"use public interfaces of pep8 for hacking","message":"use public interfaces of pep8 for hacking\n\nrather than using mock and pep8 internals, we can use\npublic interfaces of pep8 to register our custom\nhacking checks.\n\nCloses-Bug: 1652458\n\nSigned-off-by: Adam Williamson \u003cawilliam@redhat.com\u003e\n\nChange-Id: I14165903b46d2fc26e8c9de591917893f58516db\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/31a506531adb802eaed82d9f4ca6cd4bad822840"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/31a506531adb802eaed82d9f4ca6cd4bad822840"}]},"branch":"refs/heads/master"},"b7d676314594dc6d5c3a2e6db7a57b1d9849b222":{"kind":"REWORK","_number":2,"created":"2017-01-06 15:51:05.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/29/416829/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/29/416829/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/416829/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/416829/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/416829/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/416829/2"}}},"commit":{"parents":[{"commit":"004450040c38a0df05469b844ba30854b67aabd5","subject":"Merge \"re-work inference rule bindings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/004450040c38a0df05469b844ba30854b67aabd5"}]}],"author":{"name":"Steve Martinelli","email":"s.martinelli@gmail.com","date":"2017-01-03 14:51:55.000000000","tz":-300},"committer":{"name":"Steve Martinelli","email":"s.martinelli@gmail.com","date":"2017-01-06 15:48:23.000000000","tz":-300},"subject":"remove hacking checks from keystoneclient","message":"remove hacking checks from keystoneclient\n\nthe only hacking check in keystoneclient is related to\nolder versions of oslo libraries, which are no longer\nsupported by keystoneclient, for example:\n\n$ pip freeze | grep oslo.utils\noslo.utils\u003d\u003d3.18.0\n$ python\n\u003e\u003e\u003e import oslo.utils\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nImportError: No module named oslo.utils\n\u003e\u003e\u003e import oslo_utils\n\u003e\u003e\u003e\n\nLet\u0027s just remove the hacking check since theres no\nway someone could incorrectly import the older\nversions.\n\nCloses-Bug: 1652458\n\nSigned-off-by: Adam Williamson \u003cawilliam@redhat.com\u003e\n\nChange-Id: I14165903b46d2fc26e8c9de591917893f58516db\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b7d676314594dc6d5c3a2e6db7a57b1d9849b222"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b7d676314594dc6d5c3a2e6db7a57b1d9849b222"}]},"branch":"refs/heads/master"},"ffdab4ea43389b94f3c1d1ead5d97870d7c3c311":{"kind":"REWORK","_number":3,"created":"2017-01-06 16:56:20.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/29/416829/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/29/416829/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/416829/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/416829/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/416829/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/416829/3"}}},"commit":{"parents":[{"commit":"004450040c38a0df05469b844ba30854b67aabd5","subject":"Merge \"re-work inference rule bindings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/004450040c38a0df05469b844ba30854b67aabd5"}]}],"author":{"name":"Steve Martinelli","email":"s.martinelli@gmail.com","date":"2017-01-03 14:51:55.000000000","tz":-300},"committer":{"name":"Steve Martinelli","email":"s.martinelli@gmail.com","date":"2017-01-06 16:56:18.000000000","tz":0},"subject":"remove hacking checks from keystoneclient","message":"remove hacking checks from keystoneclient\n\nthe only hacking check in keystoneclient is related to\nolder versions of oslo libraries, which are no longer\nsupported by keystoneclient, for example:\n\n$ pip freeze | grep oslo.utils\noslo.utils\u003d\u003d3.18.0\n$ python\n\u003e\u003e\u003e import oslo.utils\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nImportError: No module named oslo.utils\n\u003e\u003e\u003e import oslo_utils\n\u003e\u003e\u003e\n\nLet\u0027s just remove the hacking check since theres no\nway someone could incorrectly import the older\nversions.\n\nCloses-Bug: 1652458\n\nSigned-off-by: Adam Williamson \u003cawilliam@redhat.com\u003e\n\nChange-Id: I14165903b46d2fc26e8c9de591917893f58516db\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ffdab4ea43389b94f3c1d1ead5d97870d7c3c311"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ffdab4ea43389b94f3c1d1ead5d97870d7c3c311"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}