)]}'
{"id":"openstack%2Fpython-keystoneclient~424471","triplet_id":"openstack%2Fpython-keystoneclient~master~I6c915a00fb692aac9589d0b5a0bce0bf74ef5c85","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1658639","hashtags":[],"change_id":"I6c915a00fb692aac9589d0b5a0bce0bf74ef5c85","subject":"Fix boto version strip regex","status":"ABANDONED","created":"2017-01-24 07:11:16.000000000","updated":"2017-01-27 01:59:53.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4273396de4949bdb651111bdb6332b980546405d","_number":424471,"virtual_id_number":424471,"owner":{"_account_id":24958,"name":"Maroun Maroun","email":"maroun.bassam@gmail.com","username":"maroun.bassam"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2017-01-24 12:08:35.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2017-01-24 10:04:38.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"date":"2017-01-24 14:58:56.000000000","_account_id":24958,"name":"Maroun Maroun","email":"maroun.bassam@gmail.com","username":"maroun.bassam"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2017-01-27 01:58:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":-1,"date":"2017-01-24 15:12:54.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":24958,"name":"Maroun Maroun","email":"maroun.bassam@gmail.com","username":"maroun.bassam"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":24958,"name":"Maroun Maroun","email":"maroun.bassam@gmail.com","username":"maroun.bassam"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"_account_id":24958,"name":"Maroun Maroun","email":"maroun.bassam@gmail.com","username":"maroun.bassam"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-24 10:04:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-01-24 12:08:35.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-01-24 15:12:54.000000000","updated_by":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"reviewer":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"state":"REVIEWER"},{"updated":"2017-01-27 01:58:39.000000000","updated_by":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"reviewer":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"state":"REVIEWER"}],"messages":[{"id":"1e36b8f4423d6654b507013ac2dd8cd0daf063e5","author":{"_account_id":24958,"name":"Maroun Maroun","email":"maroun.bassam@gmail.com","username":"maroun.bassam"},"date":"2017-01-24 07:11:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a60ebab5f744fe4c14237ce2e605e7106273e093","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2017-01-24 07:11:26.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"9385298555ffcc671cee663f39b86a1c7e8b6898","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2017-01-24 07:14:12.000000000","message":"Patch Set 1: Code-Review-1\n\nGood. Now could you create a unit test for the change? It should show that incorrect version of boto is no longer being detected by this regex. Have a look at tests/unit/test_ec2utils.py how test_generate_v4_port_strip is done","accounts_in_message":[],"_revision_number":1},{"id":"fdca5c7cd68d6479fbf90535e096bbb9ad2ccebd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-24 08:35:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/71/424471/1/check/gate-python-keystoneclient-docs-ubuntu-xenial/d8f1f98//doc/build/html/ : SUCCESS in 1m 43s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/71/424471/1/check/gate-python-keystoneclient-pep8-ubuntu-xenial/59e49ac/ : SUCCESS in 1m 39s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/71/424471/1/check/gate-python-keystoneclient-python27-ubuntu-xenial/196880a/ : SUCCESS in 1m 11s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/71/424471/1/check/gate-python-keystoneclient-python35/7e0c705/ : SUCCESS in 1m 58s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/71/424471/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/84647ef/ : SUCCESS in 1h 22m 58s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/424471/1/check/gate-keystoneclient-dsvm-functional-ubuntu-xenial/a1e1be7/ : SUCCESS in 16m 49s","accounts_in_message":[],"_revision_number":1},{"id":"481e2010c30a480abfb296a20958d4524bdca085","author":{"_account_id":24958,"name":"Maroun Maroun","email":"maroun.bassam@gmail.com","username":"maroun.bassam"},"date":"2017-01-24 09:06:06.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"6f38f63c8d67ec78968635f249eefab93a092966","author":{"_account_id":19790,"name":"Deepak Jon","email":"deepak.os31@yahoo.com","username":"DeepaJon"},"date":"2017-01-24 09:15:03.000000000","message":"Patch Set 2: Code-Review-1","accounts_in_message":[],"_revision_number":2},{"id":"b5a225e9b9f9910e9d3f3f10f00535f85ad2d1f6","author":{"_account_id":19790,"name":"Deepak Jon","email":"deepak.os31@yahoo.com","username":"DeepaJon"},"date":"2017-01-24 09:15:08.000000000","message":"Removed the following votes:\n\n* Code-Review-1 by Deepak Jon \u003cdeepak.kumar@nectechnologies.in\u003e\n","accounts_in_message":[],"_revision_number":2},{"id":"359de8215fcde534a6fa30cd671f1d54f8380a89","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-24 10:04:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/71/424471/2/check/gate-python-keystoneclient-docs-ubuntu-xenial/b8e2866//doc/build/html/ : SUCCESS in 1m 15s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/71/424471/2/check/gate-python-keystoneclient-pep8-ubuntu-xenial/36e986d/ : SUCCESS in 3m 14s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/71/424471/2/check/gate-python-keystoneclient-python27-ubuntu-xenial/7cc130c/ : SUCCESS in 2m 04s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/71/424471/2/check/gate-python-keystoneclient-python35/9b43b27/ : SUCCESS in 2m 11s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/71/424471/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/8fc6d2f/ : SUCCESS in 56m 04s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/424471/2/check/gate-keystoneclient-dsvm-functional-ubuntu-xenial/022930c/ : SUCCESS in 31m 16s","accounts_in_message":[],"_revision_number":2},{"id":"1d5249de058f52e8343e9343b09a8607f5f55f77","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-01-24 12:08:35.000000000","message":"Patch Set 2:\n\ni agree with Boris. Please add a new unit test, similar to [1], that checks an incorrect boto version.\n\n[1] https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/tests/unit/test_ec2utils.py#L191-L228","accounts_in_message":[],"_revision_number":2},{"id":"25d247a55f61fa1f29253e53f0abcd3796eddf27","author":{"_account_id":24958,"name":"Maroun Maroun","email":"maroun.bassam@gmail.com","username":"maroun.bassam"},"date":"2017-01-24 14:58:56.000000000","message":"Patch Set 2:\n\nI\u0027m not sure what exactly should be tested, the old version of the regex could have matched \"Boto/2?9$2\" for example. This fix assures that the string \".\" separate the numbers.\n\nWill be glad for a little guidance on the test I should do. Thanks!","accounts_in_message":[],"_revision_number":2},{"id":"cf37d2578926b1d5b82cd9cda65a66fead6af9c4","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2017-01-24 15:12:54.000000000","message":"Patch Set 2: Code-Review-1\n\n\u003e the old version of the regex could have matched \"Boto/2?9$2\" for example\n\nWhy is this bad? If you think that \"Boto/2?9$2\" could appear there, then use this value for a unit test. Or you could try value like \"2.345\".","accounts_in_message":[],"_revision_number":2},{"id":"99954da0f39de14dbe550e749c8101a9b2d86c95","author":{"_account_id":24958,"name":"Maroun Maroun","email":"maroun.bassam@gmail.com","username":"maroun.bassam"},"date":"2017-01-24 15:47:03.000000000","message":"Patch Set 2:\n\nI added a test and run \"git review\" (after rebase in order to make only one commit), I don\u0027t know what happened, but I got mail with this link: https://review.openstack.org/#/c/424700/ \n\nIs everything fine? Or I need to do something else?","accounts_in_message":[],"_revision_number":2},{"id":"182249f4d64f8cbd48f2dbde51ab8fdbcc49f7f4","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-01-24 16:01:48.000000000","message":"Patch Set 2:\n\n\u003e I added a test and run \"git review\" (after rebase in order to make\n \u003e only one commit), I don\u0027t know what happened, but I got mail with\n \u003e this link: https://review.openstack.org/#/c/424700/\n \u003e \n \u003e Is everything fine? Or I need to do something else?\n\nI\u0027ll squish the two together","accounts_in_message":[],"_revision_number":2},{"id":"76bd5a6f4e0d155afc78fbee5f2d95ed385ae4c1","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-01-24 16:04:38.000000000","message":"Patch Set 2:\n\nabandon this in favor of https://review.openstack.org/#/c/424700/ please","accounts_in_message":[],"_revision_number":2},{"id":"d1bb83a6cafdd0f5cb4f8fd13687080e8c74b519","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2017-01-27 01:58:39.000000000","message":"Patch Set 2: Code-Review-1\n\nDuplicated of https://review.openstack.org/#/c/424848/ and https://review.openstack.org/#/c/424700/","accounts_in_message":[],"_revision_number":2},{"id":"442c4374d7813103d625e5da22dcaa752c5fac01","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2017-01-27 01:59:00.000000000","message":"Abandoned\n\nAbandoning as it is duplicated patch from same author, please feel free to restore if necessary.","accounts_in_message":[],"_revision_number":2},{"id":"b3171aa4029965218e4ee1e144e1a95557faaa9a","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2017-01-27 01:59:53.000000000","message":"Patch Set 2:\n\nAbandoned in favor of https://review.openstack.org/#/c/424700/ as suggested by Steve","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"250ac6195a85c07df2bf99f55dbc7223160d9ebc","revisions":{"f0fc9016bcea95183af4ba0a2febf2b2c11c2cc7":{"kind":"REWORK","_number":1,"created":"2017-01-24 07:11:16.000000000","uploader":{"_account_id":24958,"name":"Maroun Maroun","email":"maroun.bassam@gmail.com","username":"maroun.bassam"},"ref":"refs/changes/71/424471/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/71/424471/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/424471/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/424471/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/424471/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/424471/1"}}},"commit":{"parents":[{"commit":"f9e054fd744791c5cd79a6eaa59d729d66bf34fe","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f9e054fd744791c5cd79a6eaa59d729d66bf34fe"}]}],"author":{"name":"MarounMaroun","email":"maroun.bassam@gmail.com","date":"2017-01-23 13:11:09.000000000","tz":120},"committer":{"name":"MarounMaroun","email":"maroun.bassam@gmail.com","date":"2017-01-24 07:10:15.000000000","tz":120},"subject":"Fix boto version strip regex","message":"Fix boto version strip regex\n\nChange-Id: I6c915a00fb692aac9589d0b5a0bce0bf74ef5c85\nCloses-Bug: #123456\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f0fc9016bcea95183af4ba0a2febf2b2c11c2cc7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f0fc9016bcea95183af4ba0a2febf2b2c11c2cc7"}]},"branch":"refs/heads/master"},"250ac6195a85c07df2bf99f55dbc7223160d9ebc":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-01-24 09:06:06.000000000","uploader":{"_account_id":24958,"name":"Maroun Maroun","email":"maroun.bassam@gmail.com","username":"maroun.bassam"},"ref":"refs/changes/71/424471/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/71/424471/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/424471/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/424471/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/424471/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/71/424471/2"}}},"commit":{"parents":[{"commit":"f9e054fd744791c5cd79a6eaa59d729d66bf34fe","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f9e054fd744791c5cd79a6eaa59d729d66bf34fe"}]}],"author":{"name":"MarounMaroun","email":"maroun.bassam@gmail.com","date":"2017-01-23 13:11:09.000000000","tz":120},"committer":{"name":"MarounMaroun","email":"maroun.bassam@gmail.com","date":"2017-01-24 09:05:23.000000000","tz":120},"subject":"Fix boto version strip regex","message":"Fix boto version strip regex\n\nChange-Id: I6c915a00fb692aac9589d0b5a0bce0bf74ef5c85\nCloses-Bug: #1658639\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/250ac6195a85c07df2bf99f55dbc7223160d9ebc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/250ac6195a85c07df2bf99f55dbc7223160d9ebc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}