)]}'
{"id":"openstack%2Fpython-keystoneclient~443257","triplet_id":"openstack%2Fpython-keystoneclient~master~Ic24595b6ded0306325390787e16e3962c1d120d0","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1671179","hashtags":[],"change_id":"Ic24595b6ded0306325390787e16e3962c1d120d0","subject":"Fix UserManager.get prototype to include kwargs","status":"ABANDONED","created":"2017-03-08 18:09:45.000000000","updated":"2017-03-22 08:57:22.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4596f36e72d857abd6e6d7827e3afddd32563b47","_number":443257,"virtual_id_number":443257,"owner":{"_account_id":22550,"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","username":"ynirk"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2017-03-08 19:33:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2017-03-08 18:09:58.000000000","_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"date":"2017-03-10 09:52:06.000000000","_account_id":22550,"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","username":"ynirk"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22550,"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","username":"ynirk"},{"value":-1,"date":"2017-03-09 15:12:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":-1,"date":"2017-03-09 14:53:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":22550,"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","username":"ynirk"},"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":-1,"date":"2017-03-10 14:35:18.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":22550,"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","username":"ynirk"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":22550,"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","username":"ynirk"},{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-08 18:09:58.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2017-03-08 19:33:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-03-09 14:53:13.000000000","updated_by":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"reviewer":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"state":"REVIEWER"},{"updated":"2017-03-09 15:12:50.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"}],"messages":[{"id":"7ce11113ce13c82597ecf72c478a7d825388be17","author":{"_account_id":22550,"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","username":"ynirk"},"date":"2017-03-08 18:09:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4cb002ba7011ddc3297d9b4f374ed458fe4f02c8","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2017-03-08 18:09:58.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"7ad005f81a04a77436fd00e58b67325919b4038c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-08 19:33:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/57/443257/1/check/gate-python-keystoneclient-docs-ubuntu-xenial/78a458e//doc/build/html/ : SUCCESS in 1m 58s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/57/443257/1/check/gate-python-keystoneclient-pep8-ubuntu-xenial/0b3c118/ : SUCCESS in 1m 40s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/57/443257/1/check/gate-python-keystoneclient-python27-ubuntu-xenial/a108f3a/ : SUCCESS in 2m 05s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/57/443257/1/check/gate-python-keystoneclient-python35/0cbc072/ : SUCCESS in 2m 26s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/57/443257/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/fd7622f/ : SUCCESS in 1h 23m 10s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/57/443257/1/check/gate-keystoneclient-dsvm-functional-ubuntu-xenial/d4cf2a1/ : SUCCESS in 31m 57s","accounts_in_message":[],"_revision_number":1},{"id":"c9125d4c62dced297f0ec2c21ea418cd967402d2","author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"date":"2017-03-09 14:53:13.000000000","message":"Patch Set 1: Code-Review-1\n\nSimilar issues are also present in groups, projects, and roles and should be added there too. Also this probably should have some tests.","accounts_in_message":[],"_revision_number":1},{"id":"ba76103b80e32aac8547b704fe1c0b696cd44224","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2017-03-09 15:12:50.000000000","message":"Patch Set 1: Code-Review-1\n\nTests for this would be nice. I\u0027d be fine reworking the bug description to include other entities that suffer from this same problem, then we can include more of those fixes here.","accounts_in_message":[],"_revision_number":1},{"id":"774e1081aca0380b7352821275d9a485bf2f1834","author":{"_account_id":22550,"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","username":"ynirk"},"date":"2017-03-10 09:52:06.000000000","message":"Patch Set 1:\n\nThanks for your reviews. It\u0027s my first patch attempt and I\u0027m more of an ops so I\u0027ll try to make things right.\n\nWhen you talk about entities, is it keystone entities (groups, projects, roles...) or openstack entities that could also suffer the same problem (nova, glance...) ?\n\nWhat should be the correct workflow ?\n - update the bug description to handle other keystone entities\n - write tests (numeric entities with kwargs ?)\n - patch","accounts_in_message":[],"_revision_number":1},{"id":"e7505f16eb55e6536699fd80e32eed5395b6ac3c","author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"date":"2017-03-10 14:24:03.000000000","message":"Patch Set 1:\n\n\u003e Thanks for your reviews. It\u0027s my first patch attempt and I\u0027m more\n \u003e of an ops so I\u0027ll try to make things right.\n \u003e \n \u003e When you talk about entities, is it keystone entities (groups,\n \u003e projects, roles...) or openstack entities that could also suffer\n \u003e the same problem (nova, glance...) ?\n \u003e \n \u003e What should be the correct workflow ?\n \u003e - update the bug description to handle other keystone entities\n \u003e - write tests (numeric entities with kwargs ?)\n \u003e - patch\n\nJust keystone entities (roles, groups, etc.). As for workflow, what you put sounds good, and is generally how I go about it as well (create the functionality, then test that functionality).\nFeel free to put a -1 Workflow or WIP in the commit message. That way people will know its still in progress and you can push up if you want to make sure the patch passes Jenkins or what not.","accounts_in_message":[],"_revision_number":1},{"id":"02f29de2c4529e25616ab81f3e7ebd9fe7d82e30","author":{"_account_id":22550,"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","username":"ynirk"},"date":"2017-03-10 14:35:18.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"2286f6221b9dafe10e0147befb9d9a65a05a4390","author":{"_account_id":22550,"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","username":"ynirk"},"date":"2017-03-22 08:57:13.000000000","message":"Patch Set 1:\n\nThe bug has been fixed in osc-lib here https://review.openstack.org/#/c/445679/","accounts_in_message":[],"_revision_number":1},{"id":"5ab875871f38e8e2a9e5ab5e1961b79a82a54d95","author":{"_account_id":22550,"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","username":"ynirk"},"date":"2017-03-22 08:57:22.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6fce849463a001301147f61353f4ca065b8ac7cf","revisions":{"6fce849463a001301147f61353f4ca065b8ac7cf":{"kind":"REWORK","_number":1,"created":"2017-03-08 18:09:45.000000000","uploader":{"_account_id":22550,"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","username":"ynirk"},"ref":"refs/changes/57/443257/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/57/443257/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/443257/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/443257/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/443257/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/443257/1"}}},"commit":{"parents":[{"commit":"b264c4bbc8c11b8aae0f4a8920b83d0c192c94f8","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b264c4bbc8c11b8aae0f4a8920b83d0c192c94f8"}]}],"author":{"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","date":"2017-03-08 18:08:55.000000000","tz":60},"committer":{"name":"Julien Lavesque","email":"julien.lavesque@gmail.com","date":"2017-03-08 18:08:55.000000000","tz":60},"subject":"Fix UserManager.get prototype to include kwargs","message":"Fix UserManager.get prototype to include kwargs\n\nWhen we look for a user whose username is a numeric value and we specify a\ndomain, the openstack client crashes with the following TypeError :\n\n$ openstack user show 1234 --domain Default\nget() got an unexpected keyword argument \u0027domain_id\u0027\n\nThis is due to UserManager wrong prototype not taking kwargs\nThis patch fix this bug\n\nCloses-Bug #1671179\n\nChange-Id: Ic24595b6ded0306325390787e16e3962c1d120d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6fce849463a001301147f61353f4ca065b8ac7cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6fce849463a001301147f61353f4ca065b8ac7cf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}