)]}'
{"id":"openstack%2Fpython-keystoneclient~445559","triplet_id":"openstack%2Fpython-keystoneclient~master~I1ee828215d0a0184474021d6236c2bc234af5176","project":"openstack/python-keystoneclient","branch":"master","topic":"workaround-scheme","hashtags":[],"change_id":"I1ee828215d0a0184474021d6236c2bc234af5176","subject":"Workaround for unmatching scheme in discovery","status":"ABANDONED","created":"2017-03-14 16:12:07.000000000","updated":"2017-03-15 12:27:00.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"696ac4758ee9f50ac0ae318f745a06f0becdb640","_number":445559,"virtual_id_number":445559,"owner":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":-1,"date":"2017-03-14 17:36:10.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2017-03-14 17:45:57.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":-1,"date":"2017-03-14 21:29:09.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"all":[{"date":"2017-03-14 17:32:37.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":-1,"date":"2017-03-14 16:12:26.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"date":"2017-03-14 17:41:51.000000000","_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-14 17:32:37.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-03-14 17:36:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-03-14 17:41:51.000000000","updated_by":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"reviewer":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"state":"REVIEWER"},{"updated":"2017-03-14 17:45:57.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2017-03-14 21:29:09.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"}],"messages":[{"id":"3d1b66a72fa5cb12c2b5786588a4cf298bfda523","author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"date":"2017-03-14 16:12:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"426e8b3eefb09a9e3fff15eec477b94f19a0870c","author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"date":"2017-03-14 16:12:26.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"5fa2444ddb4d4790ca7776924a26ea2ace3e36d4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-14 17:36:10.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/445559/1/check/gate-python-keystoneclient-docs-ubuntu-xenial/5fbd618//doc/build/html/ : SUCCESS in 2m 30s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/59/445559/1/check/gate-python-keystoneclient-pep8-ubuntu-xenial/a4aaf20/ : FAILURE in 3m 26s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/59/445559/1/check/gate-python-keystoneclient-python27-ubuntu-xenial/48f7448/ : FAILURE in 2m 08s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/59/445559/1/check/gate-python-keystoneclient-python35/bab3285/ : FAILURE in 2m 11s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/59/445559/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/10832b0/ : SUCCESS in 1h 22m 18s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/59/445559/1/check/gate-keystoneclient-dsvm-functional-ubuntu-xenial/b60b8c6/ : SUCCESS in 28m 55s","accounts_in_message":[],"_revision_number":1},{"id":"bd673027d89b280067e1081c37f3a67ce08684a5","author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"date":"2017-03-14 17:37:57.000000000","message":"Patch Set 1:\n\nI left this as WIP cause I want to hear what folks think of the approach. If I get a green light, then I\u0027ll add tests and fix the current issues in the gate.","accounts_in_message":[],"_revision_number":1},{"id":"b34675749b0fbcb28586221ee76614c979cc2e99","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2017-03-14 17:45:57.000000000","message":"Patch Set 1:\n\nHere\u0027s another time where we added a workaround to python-keystoneclient and it masked deployment issues which caused problems: http://lists.openstack.org/pipermail/openstack-dev/2017-February/112943.html","accounts_in_message":[],"_revision_number":1},{"id":"6ccda99e4b3477d68f4b398e02a0db1f253ed86f","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2017-03-14 21:29:09.000000000","message":"Patch Set 1: Code-Review-1\n\n1) Let\u0027s consider this part of keystoneclient dead, propose to KSA if you want to continue.\n\n2) I\u0027m not sure i would want to make it easier to work around a misconfigured openstack install. We did a few of these when keystoneclient was first doing sessions to make it easier to remove similar functionality from the clients, but now - if your deploy doesn\u0027t work with keystoneauth i would like to see that fail hard and inform the administrators they have a problem to fix. \n\nThis is not just a session problem, if anything i\u0027d like tempest or something to fail that cloud before a user ever touches it.","accounts_in_message":[],"_revision_number":1},{"id":"9a7a4beab36abd8e1c4649324bfb2bda59adb5da","author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"date":"2017-03-15 12:27:00.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2d02b3a1e789868e92ed7d849297a58e4c88980f","revisions":{"2d02b3a1e789868e92ed7d849297a58e4c88980f":{"kind":"REWORK","_number":1,"created":"2017-03-14 16:12:07.000000000","uploader":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"ref":"refs/changes/59/445559/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/59/445559/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/59/445559/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/59/445559/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/59/445559/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/59/445559/1"}}},"commit":{"parents":[{"commit":"b264c4bbc8c11b8aae0f4a8920b83d0c192c94f8","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b264c4bbc8c11b8aae0f4a8920b83d0c192c94f8"}]}],"author":{"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","date":"2017-03-14 16:04:44.000000000","tz":120},"committer":{"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","date":"2017-03-14 16:12:05.000000000","tz":120},"subject":"Workaround for unmatching scheme in discovery","message":"Workaround for unmatching scheme in discovery\n\nwhen doing keystone discovery, there are issues returning the scheme in\nspecific scenarios: e.g. when keystone is deployed behind a TLS proxy,\nand oslo.middleware\u0027s http_proxy_to_wsgi is not available.\n\nTo workaround this, we could remember the original scheme that was given\nas the auth_url, and try to use that in case the URL gotten via\ndiscovery is not working.\n\nEven though this scenario is a common misconfiguration of the\nloadbalancer and keystone. This is unfortunately a very common issue.\nSo working around this in keystoneclient seems like the best way to go,\nas it will ease the transition for moving services to use discovery and\nnot rely on versioned endpoints.\n\nThe original patch where this was discussed is this one:\nhttps://review.openstack.org/#/c/443104/\n\nChange-Id: I1ee828215d0a0184474021d6236c2bc234af5176\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2d02b3a1e789868e92ed7d849297a58e4c88980f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2d02b3a1e789868e92ed7d849297a58e4c88980f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}