)]}'
{"keystoneclient/tests/unit/apiclient/test_exceptions.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"28ce24f46b9ddf25a9d4f406042b7fb9f29f38ce","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            method,"},{"line_number":41,"context_line":"            url)"},{"line_number":42,"context_line":"        self.assertIsInstance(ex, ex_cls)"},{"line_number":43,"context_line":"        self.assertEqual("},{"line_number":44,"context_line":"            ex.message,"},{"line_number":45,"context_line":"            json_data[\"error\"][\"message\"] + \u0027 (HTTP %s)\u0027 % status_code)"},{"line_number":46,"context_line":"        self.assertEqual(ex.details, json_data[\"error\"][\"details\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_ec7fbbdd","line":43,"updated":"2017-03-21 21:19:34.000000000","message":"assertIn might be better because i\u0027m guessing the message depends on the version of an underlying library.","commit_id":"087780136f34a27942083b9a8e8879674805246f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"95931d73f8cb4afdec9f274e3a9698e7e90c8d88","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            method,"},{"line_number":41,"context_line":"            url)"},{"line_number":42,"context_line":"        self.assertIsInstance(ex, ex_cls)"},{"line_number":43,"context_line":"        self.assertEqual("},{"line_number":44,"context_line":"            ex.message,"},{"line_number":45,"context_line":"            json_data[\"error\"][\"message\"] + \u0027 (HTTP %s)\u0027 % status_code)"},{"line_number":46,"context_line":"        self.assertEqual(ex.details, json_data[\"error\"][\"details\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_5ab4dc33","line":43,"in_reply_to":"1a1ced50_3bd64ff1","updated":"2017-03-22 15:14:00.000000000","message":"JFDI","commit_id":"087780136f34a27942083b9a8e8879674805246f"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"7a88adae3409818abfe051a3db763e24759b4876","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            method,"},{"line_number":41,"context_line":"            url)"},{"line_number":42,"context_line":"        self.assertIsInstance(ex, ex_cls)"},{"line_number":43,"context_line":"        self.assertEqual("},{"line_number":44,"context_line":"            ex.message,"},{"line_number":45,"context_line":"            json_data[\"error\"][\"message\"] + \u0027 (HTTP %s)\u0027 % status_code)"},{"line_number":46,"context_line":"        self.assertEqual(ex.details, json_data[\"error\"][\"details\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_ca957a33","line":43,"in_reply_to":"1a1ced50_4367bde8","updated":"2017-03-22 01:56:18.000000000","message":"assertIn +1","commit_id":"087780136f34a27942083b9a8e8879674805246f"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"d223a8c229a2177123e074723df88ef37a041b81","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            method,"},{"line_number":41,"context_line":"            url)"},{"line_number":42,"context_line":"        self.assertIsInstance(ex, ex_cls)"},{"line_number":43,"context_line":"        self.assertEqual("},{"line_number":44,"context_line":"            ex.message,"},{"line_number":45,"context_line":"            json_data[\"error\"][\"message\"] + \u0027 (HTTP %s)\u0027 % status_code)"},{"line_number":46,"context_line":"        self.assertEqual(ex.details, json_data[\"error\"][\"details\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_3bd64ff1","line":43,"in_reply_to":"1a1ced50_ca957a33","updated":"2017-03-22 12:08:57.000000000","message":"+1:\n\n  self.assertIn(ex.message, json_data[\"error\"][\"message\"])","commit_id":"087780136f34a27942083b9a8e8879674805246f"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"0ec4eb31064b521186e6d57f2852f450e2169ed5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            method,"},{"line_number":41,"context_line":"            url)"},{"line_number":42,"context_line":"        self.assertIsInstance(ex, ex_cls)"},{"line_number":43,"context_line":"        self.assertEqual("},{"line_number":44,"context_line":"            ex.message,"},{"line_number":45,"context_line":"            json_data[\"error\"][\"message\"] + \u0027 (HTTP %s)\u0027 % status_code)"},{"line_number":46,"context_line":"        self.assertEqual(ex.details, json_data[\"error\"][\"details\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_4367bde8","line":43,"in_reply_to":"1a1ced50_ec7fbbdd","updated":"2017-03-21 22:06:15.000000000","message":"I would agree. Any reason when we don\u0027t just check if ex.message is in json_data[\u0027error\u0027][\u0027message\u0027]? I\u0027m not entirely interested in the that library adds. Otherwise we\u0027ll have the error again in the future.","commit_id":"087780136f34a27942083b9a8e8879674805246f"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"77cb3b50625f34faffe1fc2699c370f278ecf927","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            method,"},{"line_number":41,"context_line":"            url)"},{"line_number":42,"context_line":"        self.assertIsInstance(ex, ex_cls)"},{"line_number":43,"context_line":"        self.assertIn(ex.message, json_data[\"error\"][\"message\"])"},{"line_number":44,"context_line":"        self.assertEqual(ex.details, json_data[\"error\"][\"details\"])"},{"line_number":45,"context_line":"        self.assertEqual(ex.method, method)"},{"line_number":46,"context_line":"        self.assertEqual(ex.url, url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_b3cdfb32","line":43,"range":{"start_line":43,"start_character":22,"end_line":43,"end_character":64},"updated":"2017-03-22 16:09:13.000000000","message":"Hi Steve,\n\nThanks for taking this patch forward.\n\nThis should be self.assertIn(expected, actual):\n\nself.assertIn(json_data[\"error\"][\"message\"], ex.message)","commit_id":"afb2fa04f5819027638be770ceb6918547b58c59"}],"keystoneclient/tests/unit/test_http.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"0ec4eb31064b521186e6d57f2852f450e2169ed5","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                cl.get(\u0027/hi\u0027)"},{"line_number":98,"context_line":"        except exceptions.BadRequest as exc:"},{"line_number":99,"context_line":"            exc_raised \u003d True"},{"line_number":100,"context_line":"            self.assertEqual(exc.message, \"Error message string (HTTP 400)\")"},{"line_number":101,"context_line":"        self.assertTrue(exc_raised, \u0027Exception not raised.\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_post(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_835d3517","line":100,"updated":"2017-03-21 22:06:15.000000000","message":"safe","commit_id":"087780136f34a27942083b9a8e8879674805246f"}]}