)]}'
{"id":"openstack%2Fpython-keystoneclient~452741","triplet_id":"openstack%2Fpython-keystoneclient~master~I18a6890935ebdbb589269379f21a0dd47d07eb3a","project":"openstack/python-keystoneclient","branch":"master","hashtags":[],"change_id":"I18a6890935ebdbb589269379f21a0dd47d07eb3a","subject":"Replace six.iteritems() with .items()","status":"MERGED","created":"2017-04-03 12:51:58.000000000","updated":"2017-06-13 16:45:01.000000000","submitted":"2017-06-13 16:45:01.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ae33ec841d88090d8a855d032fe95a2e7cce2376","_number":452741,"virtual_id_number":452741,"owner":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2017-06-13 16:45:01.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"recommended":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"all":[{"value":1,"date":"2017-04-19 21:38:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":2,"date":"2017-06-13 15:21:22.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-04-04 08:51:26.000000000","_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":1,"date":"2017-06-13 15:21:22.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-04-04 08:51:26.000000000","updated_by":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"reviewer":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"state":"REVIEWER"},{"updated":"2017-04-19 21:38:22.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"},{"updated":"2017-06-13 15:21:22.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-06-13 16:45:01.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"af00f77cdcb02694ddf80e52d91126e5c86b3909","author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"date":"2017-04-03 12:51:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9065742e810e5a7a1ca0f54f54f8d5d401913ed5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 13:57:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/41/452741/1/check/gate-python-keystoneclient-docs-ubuntu-xenial/796a5de//doc/build/html/ : SUCCESS in 1m 10s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/41/452741/1/check/gate-python-keystoneclient-pep8-ubuntu-xenial/b094245/ : SUCCESS in 2m 38s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/41/452741/1/check/gate-python-keystoneclient-python27-ubuntu-xenial/8eb49cf/ : SUCCESS in 2m 34s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/41/452741/1/check/gate-python-keystoneclient-python35/826e5b5/ : SUCCESS in 2m 00s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/41/452741/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/c7f8992/ : SUCCESS in 1h 04m 31s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/41/452741/1/check/gate-keystoneclient-dsvm-functional-ubuntu-xenial/77f3688/ : SUCCESS in 16m 56s","accounts_in_message":[],"_revision_number":1},{"id":"36a3df1e271ebc1de5d5ac5cb67ef42e7b30f690","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2017-04-04 08:51:26.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM, thank you for updating that","accounts_in_message":[],"_revision_number":1},{"id":"9a052a61ab915f1c54120d83fcc589b14df08868","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2017-04-19 21:38:22.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4c9b5e1bd545567487592e55dce332900ecfc49c","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-06-13 15:21:22.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"9006b873ba79644db68718129bd1519418331d3c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-13 15:22:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"043a95c711198ef7fa6efb84bc157c0fe38a91a6","date":"2017-06-13 16:45:01.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"ae33ec841d88090d8a855d032fe95a2e7cce2376","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-13 16:45:01.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/41/452741/1/gate/gate-python-keystoneclient-docs-ubuntu-xenial/8079e62//doc/build/html/ : SUCCESS in 3m 10s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/41/452741/1/gate/gate-python-keystoneclient-pep8-ubuntu-xenial/77740f6/ : SUCCESS in 3m 04s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/41/452741/1/gate/gate-python-keystoneclient-python27-ubuntu-xenial/4ca2008/ : SUCCESS in 2m 15s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/41/452741/1/gate/gate-python-keystoneclient-python35/4cb9fa4/ : SUCCESS in 1m 36s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/41/452741/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/72dc5b5/ : SUCCESS in 1h 21m 08s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/41/452741/1/gate/gate-keystoneclient-dsvm-functional-ubuntu-xenial/06f622a/ : SUCCESS in 30m 28s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"46b9e429a2cbfcd1d898616c177538a9283997d3","revisions":{"46b9e429a2cbfcd1d898616c177538a9283997d3":{"kind":"REWORK","_number":1,"created":"2017-04-03 12:51:58.000000000","uploader":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"ref":"refs/changes/41/452741/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/41/452741/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/41/452741/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/41/452741/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/41/452741/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/41/452741/1"}}},"commit":{"parents":[{"commit":"cfd33730868350cd475e45569a8c1573803a6895","subject":"Fix failing PY2 and PY3 gate jobs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/cfd33730868350cd475e45569a8c1573803a6895"}]}],"author":{"name":"M V P Nitesh","email":"m.nitesh@nectechnologies.in","date":"2017-04-03 12:50:15.000000000","tz":330},"committer":{"name":"M V P Nitesh","email":"m.nitesh@nectechnologies.in","date":"2017-04-03 12:50:52.000000000","tz":330},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using six.iteritems to achieve\niterators. We can use dict.items instead, as it will return iterators\nin PY3 as well. And dict.items/keys will more readable.\n2.In py2, the performance about list should be negligible, see the\nlink [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I18a6890935ebdbb589269379f21a0dd47d07eb3a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/46b9e429a2cbfcd1d898616c177538a9283997d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/46b9e429a2cbfcd1d898616c177538a9283997d3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}