)]}'
{"keystoneclient/v3/contrib/oauth1/access_tokens.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"db8cc5a2fc81d1b3a5363434cd7173b0415d60d6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                     resource_owner_secret\u003drequest_secret,"},{"line_number":43,"context_line":"                                     signature_method\u003doauth1.SIGNATURE_HMAC,"},{"line_number":44,"context_line":"                                     verifier\u003dverifier)"},{"line_number":45,"context_line":"        url \u003d self.client.get_endpoint(interface\u003dplugin.AUTH_INTERFACE).rstrip("},{"line_number":46,"context_line":"            \u0027/\u0027)"},{"line_number":47,"context_line":"        url, headers, body \u003d oauth_client.sign(url + endpoint,"},{"line_number":48,"context_line":"                                               http_method\u003d\u0027POST\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_a9c85e73","side":"PARENT","line":45,"updated":"2017-06-16 15:07:42.000000000","message":"It looks like using plugin.AUTH_INTERFACE is what we would want to use based on Jamie\u0027s comment here: \n\nhttps://github.com/openstack/keystoneauth/blob/5ec72ea6e4299a6e0cec0076e94a3644d05ea3b8/keystoneauth1/plugin.py#L13-L16\n\nWhen we don\u0027t specify an interface, do we always get the admin endpoint back?","commit_id":"daa99ed5fe1df548c26feff68b45bda7ac94ea25"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"db8cc5a2fc81d1b3a5363434cd7173b0415d60d6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                                     resource_owner_secret\u003drequest_secret,"},{"line_number":41,"context_line":"                                     signature_method\u003doauth1.SIGNATURE_HMAC,"},{"line_number":42,"context_line":"                                     verifier\u003dverifier)"},{"line_number":43,"context_line":"        url \u003d self.client.get_endpoint().rstrip(\u0027/\u0027)"},{"line_number":44,"context_line":"        url, headers, body \u003d oauth_client.sign(url + endpoint,"},{"line_number":45,"context_line":"                                               http_method\u003d\u0027POST\u0027)"},{"line_number":46,"context_line":"        resp, body \u003d self.client.post(endpoint, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_29aa0e84","line":43,"updated":"2017-06-16 15:07:42.000000000","message":"This seems like an important bit in order for this client to support OAUTH. We should include a comment that explains what we\u0027re doing and why.","commit_id":"6a8e84148e2262dde80a9c0b67f12b2c341c09d9"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f834ae659b362ca45e956cdfd1f3d86c975f2387","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                     resource_owner_secret\u003drequest_secret,"},{"line_number":43,"context_line":"                                     signature_method\u003doauth1.SIGNATURE_HMAC,"},{"line_number":44,"context_line":"                                     verifier\u003dverifier)"},{"line_number":45,"context_line":"        url \u003d self.client.get_endpoint(interface\u003dplugin.AUTH_INTERFACE).rstrip("},{"line_number":46,"context_line":"            \u0027/\u0027)"},{"line_number":47,"context_line":"        url, headers, body \u003d oauth_client.sign(url + endpoint,"},{"line_number":48,"context_line":"                                               http_method\u003d\u0027POST\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_2fab2775","side":"PARENT","line":45,"updated":"2017-06-27 20:19:08.000000000","message":"I have a question about this in patch set 3.","commit_id":"daa99ed5fe1df548c26feff68b45bda7ac94ea25"}],"keystoneclient/v3/contrib/oauth1/request_tokens.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b4b41c1ebfe2b77975f2d20748ab0db74f5b80c1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                     callback_uri\u003d\"oob\")"},{"line_number":65,"context_line":"        # NOTE(rocky): currently keystone uses public endpoint URL for"},{"line_number":66,"context_line":"        # signature verification. So a public endpoint is needed here."},{"line_number":67,"context_line":"        url \u003d self.client.get_endpoint().rstrip(\"/\")"},{"line_number":68,"context_line":"        url, headers, body \u003d oauth_client.sign(url + endpoint,"},{"line_number":69,"context_line":"                                               http_method\u003d\u0027POST\u0027,"},{"line_number":70,"context_line":"                                               headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_6d5f500e","line":67,"updated":"2017-07-14 20:38:48.000000000","message":"The keystone server isn\u0027t hardcoded to use the public endpoint, it uses which ever URL the request was made with. The comment here makes it seem like the logic is hardcoded.\n\nI think we need to make sure the url + endpoint is actually the same url that the client is using.","commit_id":"1a78cc7d109408a3523b488184db64e57c21f7a6"}]}