)]}'
{"doc/source/conf.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"1290425ea0bd0e7fbabdc537c4f29e48eec24557","unresolved":false,"context_lines":[{"line_number":151,"context_line":"git_cmd \u003d [\"git\", \"log\", \"--pretty\u003dformat:\u0027%ad, commit %h\u0027\", \"--date\u003dlocal\","},{"line_number":152,"context_line":"           \"-n1\"]"},{"line_number":153,"context_line":"try:"},{"line_number":154,"context_line":"    html_last_updated_fmt \u003d subprocess.check_output(git_cmd).decode(\u0027utf-8\u0027)"},{"line_number":155,"context_line":"except Exception:"},{"line_number":156,"context_line":"    warnings.warn(\u0027Cannot get last updated time from git repository. \u0027"},{"line_number":157,"context_line":"                  \u0027Not setting \"html_last_updated_fmt\".\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_a515204b","line":154,"updated":"2017-06-05 13:47:21.000000000","message":"why is this changing Popen to .check_output?\n\nplease explain at least in the commit message as it;s not obvious\nthe commit message just says it\u0027s making it a utf-8 string","commit_id":"5c4bfc1077c7805f4ef7d91388e5c1c66440a8ec"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"1d7c6cc579f706002a55ff67b35e0247f88fab08","unresolved":false,"context_lines":[{"line_number":151,"context_line":"git_cmd \u003d [\"git\", \"log\", \"--pretty\u003dformat:\u0027%ad, commit %h\u0027\", \"--date\u003dlocal\","},{"line_number":152,"context_line":"           \"-n1\"]"},{"line_number":153,"context_line":"try:"},{"line_number":154,"context_line":"    html_last_updated_fmt \u003d subprocess.check_output(git_cmd).decode(\u0027utf-8\u0027)"},{"line_number":155,"context_line":"except Exception:"},{"line_number":156,"context_line":"    warnings.warn(\u0027Cannot get last updated time from git repository. \u0027"},{"line_number":157,"context_line":"                  \u0027Not setting \"html_last_updated_fmt\".\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_bcf52959","line":154,"in_reply_to":"df140735_a515204b","updated":"2017-06-06 01:49:18.000000000","message":"Hi Samuel,\nThanks for your comment.\n\ncheck_output() will raise CalledProcessError if the called process returns a non-zero return code.\nIt also makes the code look much better.\n\nAs your request, I\u0027ve just updated commit message.\nHave a great day ahead.","commit_id":"5c4bfc1077c7805f4ef7d91388e5c1c66440a8ec"}]}
