)]}'
{"id":"openstack%2Fpython-keystoneclient~475010","triplet_id":"openstack%2Fpython-keystoneclient~master~I38e0ac35946ee6e53128babac3ea759a380572e0","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1696111","hashtags":[],"change_id":"I38e0ac35946ee6e53128babac3ea759a380572e0","subject":"Add support for specifying role ids when creating trust","status":"MERGED","created":"2017-06-16 15:34:57.000000000","updated":"2017-06-19 22:00:03.000000000","submitted":"2017-06-19 22:00:02.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"265f94624857b357698c278a6bc596fcbdd0764f","_number":475010,"virtual_id_number":475010,"owner":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2017-06-19 22:00:02.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":25640,"name":"rocky","email":"rocky0722@163.com","username":"xuhaigang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2017-06-19 20:45:49.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-06-16 17:47:37.000000000","_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":1,"date":"2017-06-19 05:54:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25640,"name":"rocky","email":"rocky0722@163.com","username":"xuhaigang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2017-06-19 20:45:49.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":25640,"name":"rocky","email":"rocky0722@163.com","username":"xuhaigang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":25640,"name":"rocky","email":"rocky0722@163.com","username":"xuhaigang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-16 17:47:37.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2017-06-19 05:54:52.000000000","updated_by":{"_account_id":25640,"name":"rocky","email":"rocky0722@163.com","username":"xuhaigang"},"reviewer":{"_account_id":25640,"name":"rocky","email":"rocky0722@163.com","username":"xuhaigang"},"state":"REVIEWER"},{"updated":"2017-06-19 20:45:49.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-06-19 22:00:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3305d64410b981bd0da81b7d8bed7273d58b1e04","author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"date":"2017-06-16 15:34:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"71bcb8c87be3f59b31f91ffec58b511171cc0455","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-16 16:50:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/10/475010/1/check/gate-python-keystoneclient-docs-ubuntu-xenial/7752345//doc/build/html/ : SUCCESS in 1m 48s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/10/475010/1/check/gate-python-keystoneclient-pep8-ubuntu-xenial/707669a/ : SUCCESS in 2m 56s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/10/475010/1/check/gate-python-keystoneclient-python27-ubuntu-xenial/4b01bb9/ : SUCCESS in 2m 04s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/10/475010/1/check/gate-python-keystoneclient-python35/e0d3665/ : SUCCESS in 2m 08s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/10/475010/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/8be4417/ : SUCCESS in 1h 14m 20s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/10/475010/1/check/gate-keystoneclient-dsvm-functional-ubuntu-xenial/d2fb771/ : SUCCESS in 27m 07s","accounts_in_message":[],"_revision_number":1},{"id":"47fd152cf86cf1b32242fa4f4738a235b7519feb","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2017-06-16 17:47:37.000000000","message":"Patch Set 1: Code-Review+2\n\nThis looks good, but we\u0027ll need another change for python-openstackclient, right?","accounts_in_message":[],"_revision_number":1},{"id":"37514073888b6e78fb972d09f2e2f8b7fb7be9d4","author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"date":"2017-06-16 18:50:14.000000000","message":"Patch Set 1:\n\n\u003e This looks good, but we\u0027ll need another change for\n \u003e python-openstackclient, right?\n\nYes, on it.","accounts_in_message":[],"_revision_number":1},{"id":"929d0b622763c57d56c79c83cb25fe2d5ff5c32d","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-06-17 18:50:02.000000000","message":"Patch Set 1: Code-Review+1\n\nwas there a corresponding server side change to handle both role names and IDs at the same time? if not, then we may want to error out if a user supplies both names and IDs...","accounts_in_message":[],"_revision_number":1},{"id":"606612e2678a8d1fe3bb205157bd29f6497035ff","author":{"_account_id":25640,"name":"rocky","email":"rocky0722@163.com","username":"xuhaigang"},"date":"2017-06-19 05:54:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"48bbe84c37a2394c4a6a8baa6f1aa00ff4ead674","author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"date":"2017-06-19 13:44:28.000000000","message":"Patch Set 1:\n\n\u003e was there a corresponding server side change to handle both role\n \u003e names and IDs at the same time? if not, then we may want to error\n \u003e out if a user supplies both names and IDs...\n\nAccording to this piece of code it should handle both without issue https://github.com/openstack/keystone/blob/master/keystone/trust/controllers.py#L81-L95","accounts_in_message":[],"_revision_number":1},{"id":"2e0e884c4b4d612ab615d8134667214008c4a2e0","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-06-19 20:45:49.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\ncool","accounts_in_message":[],"_revision_number":1},{"id":"36cc2c068349b6ae061bbe879d4ace47d2ead49b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-19 20:45:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"63ff7ac967465b32512a2a3c700d6df71423b5df","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-19 22:00:02.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/10/475010/1/gate/gate-python-keystoneclient-docs-ubuntu-xenial/3e062f6//doc/build/html/ : SUCCESS in 1m 45s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/10/475010/1/gate/gate-python-keystoneclient-pep8-ubuntu-xenial/dd83020/ : SUCCESS in 1m 42s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/10/475010/1/gate/gate-python-keystoneclient-python27-ubuntu-xenial/ae059bb/ : SUCCESS in 1m 15s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/10/475010/1/gate/gate-python-keystoneclient-python35/cde3f35/ : SUCCESS in 1m 44s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/10/475010/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/299f62b/ : SUCCESS in 1h 12m 31s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/10/475010/1/gate/gate-keystoneclient-dsvm-functional-ubuntu-xenial/a30b368/ : SUCCESS in 23m 28s","accounts_in_message":[],"_revision_number":1},{"id":"f4b4c8ebbab67e80d6422aded2a1e5736af81a8e","date":"2017-06-19 22:00:03.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ef49844248661671063567f98016e88943955ba0","revisions":{"ef49844248661671063567f98016e88943955ba0":{"kind":"REWORK","_number":1,"created":"2017-06-16 15:34:57.000000000","uploader":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"ref":"refs/changes/10/475010/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/10/475010/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/10/475010/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/10/475010/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/10/475010/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/10/475010/1"}}},"commit":{"parents":[{"commit":"2ab7f6df1207f2da38fa893518228a695aea8ecd","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2ab7f6df1207f2da38fa893518228a695aea8ecd"}]}],"author":{"name":"Kristi Nikolla","email":"knikolla@bu.edu","date":"2017-06-16 15:30:56.000000000","tz":-240},"committer":{"name":"Kristi Nikolla","email":"knikolla@bu.edu","date":"2017-06-16 15:30:56.000000000","tz":-240},"subject":"Add support for specifying role ids when creating trust","message":"Add support for specifying role ids when creating trust\n\nChange-Id: I38e0ac35946ee6e53128babac3ea759a380572e0\nPartial-Bug: 1696111\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ef49844248661671063567f98016e88943955ba0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ef49844248661671063567f98016e88943955ba0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}