)]}'
{"id":"openstack%2Fpython-keystoneclient~491592","triplet_id":"openstack%2Fpython-keystoneclient~master~I9e691cc8b0c04992f4a8dabd67e1b413d3220d23","project":"openstack/python-keystoneclient","branch":"master","hashtags":[],"change_id":"I9e691cc8b0c04992f4a8dabd67e1b413d3220d23","subject":"Remove use of positional decorator","status":"MERGED","created":"2017-08-07 20:14:56.000000000","updated":"2017-08-16 18:56:57.000000000","submitted":"2017-08-16 18:56:57.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"921a105138546739b5a4902381865eb5b9e3ad1e","_number":491592,"virtual_id_number":491592,"owner":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":2,"date":"2017-08-16 18:56:57.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"all":[{"value":2,"date":"2017-08-07 21:16:51.000000000","_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-08-09 11:55:38.000000000","_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":1,"date":"2017-08-07 20:37:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-08-16 17:38:14.000000000","_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"date":"2017-08-09 11:56:00.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-07 20:37:50.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2017-08-07 21:16:51.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"},{"updated":"2017-08-09 11:56:00.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2017-08-16 17:38:14.000000000","updated_by":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"reviewer":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"state":"REVIEWER"},{"updated":"2017-08-16 18:56:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c34053a46f0e5a1816499bf64b80a1024c3b593a","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2017-08-07 20:14:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"551ec1c69694b0bf81ac01018731bce535e5cf94","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2017-08-07 20:37:50.000000000","message":"Patch Set 1: Code-Review+1\n\nkeystoneclient.tests.unit.v3.test_federation.IdentityProviderTests.test_positional_parameters_expect_fail and keystoneclient.tests.unit.v3.test_federation.ServiceProviderTests#test_positional_parameters_expect_fail are a little weird.  They pass, but it seems odd that they\u0027re there at all.\n\nShould this change have some kind of bug or blueprint associated with it?  Basically, backing up the commit message\u0027s assertion that \"The positional decorator results in poorly mantainable code\"?","accounts_in_message":[],"_revision_number":1},{"id":"a2f9b854aa3767c48b9a7a4d1975a21fee83ae3c","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2017-08-07 21:16:51.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3e4a2c402b31c8021c0de4faac166981f2559594","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-07 21:42:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/92/491592/1/check/gate-python-keystoneclient-docs-ubuntu-xenial/1052f22//doc/build/html/ : SUCCESS in 2m 36s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/92/491592/1/check/gate-python-keystoneclient-pep8-ubuntu-xenial/7f6d567/ : SUCCESS in 2m 33s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/92/491592/1/check/gate-python-keystoneclient-python27-ubuntu-xenial/361c26c/ : SUCCESS in 2m 25s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/92/491592/1/check/gate-python-keystoneclient-python35/75b97f9/ : SUCCESS in 2m 55s\n- gate-python-keystoneclient-requirements http://logs.openstack.org/92/491592/1/check/gate-python-keystoneclient-requirements/ec49108/ : SUCCESS in 2m 00s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/92/491592/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/efaded7/ : SUCCESS in 1h 25m 36s\n- gate-python-keystoneclient-releasenotes http://docs-draft.openstack.org/92/491592/1/check/gate-python-keystoneclient-releasenotes/2ba524d//releasenotes/build/html/ : SUCCESS in 3m 14s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/92/491592/1/check/gate-keystoneclient-dsvm-functional-ubuntu-xenial/3c47f55/ : SUCCESS in 23m 13s","accounts_in_message":[],"_revision_number":1},{"id":"87f7e5f3a9cc1089e800c87e1f3fda674226d559","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2017-08-09 11:55:38.000000000","message":"Patch Set 1: Code-Review+2\n\nAdding Jamie as a reviewer. This looks good for me.","accounts_in_message":[],"_revision_number":1},{"id":"1082ec448226513eddddef83c77fdb3aabdf7544","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2017-08-16 17:38:14.000000000","message":"Patch Set 1: Workflow+1\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-keystone/%23openstack-keystone.2017-08-16.log.html#t2017-08-16T16:50:42","accounts_in_message":[],"_revision_number":1},{"id":"65fb9fe1f53791ac46996f958133e5197376fe46","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-16 17:38:30.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"74764caf9fd0b8d39da0bb438c1e6aa1caf97929","date":"2017-08-16 18:56:57.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"921a105138546739b5a4902381865eb5b9e3ad1e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-16 18:56:57.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-docs-ubuntu-xenial http://docs-draft.openstack.org/92/491592/1/gate/gate-python-keystoneclient-docs-ubuntu-xenial/5a141d4//doc/build/html/ : SUCCESS in 3m 18s\n- gate-python-keystoneclient-pep8-ubuntu-xenial http://logs.openstack.org/92/491592/1/gate/gate-python-keystoneclient-pep8-ubuntu-xenial/a602c80/ : SUCCESS in 2m 27s\n- gate-python-keystoneclient-python27-ubuntu-xenial http://logs.openstack.org/92/491592/1/gate/gate-python-keystoneclient-python27-ubuntu-xenial/715b27b/ : SUCCESS in 2m 10s\n- gate-python-keystoneclient-python35 http://logs.openstack.org/92/491592/1/gate/gate-python-keystoneclient-python35/70f3d69/ : SUCCESS in 2m 00s\n- gate-python-keystoneclient-requirements http://logs.openstack.org/92/491592/1/gate/gate-python-keystoneclient-requirements/4a117a4/ : SUCCESS in 1m 32s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial http://logs.openstack.org/92/491592/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient-ubuntu-xenial/2120030/ : SUCCESS in 1h 16m 42s\n- gate-python-keystoneclient-releasenotes http://docs-draft.openstack.org/92/491592/1/gate/gate-python-keystoneclient-releasenotes/ef49b19//releasenotes/build/html/ : SUCCESS in 3m 20s\n- gate-keystoneclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/92/491592/1/gate/gate-keystoneclient-dsvm-functional-ubuntu-xenial/8e040e0/ : SUCCESS in 22m 39s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4a43aa02b86e3203bb6614382ef598926a1464cb","revisions":{"4a43aa02b86e3203bb6614382ef598926a1464cb":{"kind":"REWORK","_number":1,"created":"2017-08-07 20:14:56.000000000","uploader":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"ref":"refs/changes/92/491592/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/92/491592/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/92/491592/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/92/491592/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/92/491592/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/92/491592/1"}}},"commit":{"parents":[{"commit":"5d0c29fc912caf18e78e6e153d3af4e554dfb0de","subject":"Merge \"Update reno for stable/pike\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/5d0c29fc912caf18e78e6e153d3af4e554dfb0de"}]}],"author":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2017-08-07 20:13:31.000000000","tz":-420},"committer":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2017-08-07 20:14:55.000000000","tz":-420},"subject":"Remove use of positional decorator","message":"Remove use of positional decorator\n\nThe positional decorator results in poorly maintainable code in\na misguided effort to emulate python3\u0027s key-word-arg only notation\nand functionality. This patch removes keystoneclient\u0027s dependance\non the positional decorator.\n\nChange-Id: I9e691cc8b0c04992f4a8dabd67e1b413d3220d23\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/4a43aa02b86e3203bb6614382ef598926a1464cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/4a43aa02b86e3203bb6614382ef598926a1464cb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}