)]}'
{"keystoneclient/session.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2b502c5dd7339b2610ed163c11c9baa0902d234f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        if header[0].lower() in secure_headers:"},{"line_number":172,"context_line":"            # hashlib.sha1() bandit nosec, as it is HMAC-SHA1 in"},{"line_number":173,"context_line":"            # keystone, which is considered secure (unlike just sha1)"},{"line_number":174,"context_line":"            token_hasher \u003d hashlib.sha1()  # nosec(lhinds)"},{"line_number":175,"context_line":"            token_hasher.update(header[1].encode(\u0027utf-8\u0027))"},{"line_number":176,"context_line":"            token_hash \u003d token_hasher.hexdigest()"},{"line_number":177,"context_line":"            return (header[0], \u0027{SHA1}%s\u0027 % token_hash)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_773dbe8c","line":174,"updated":"2017-09-07 18:05:07.000000000","message":"So this doesn\u0027t need to be fixed in the future?","commit_id":"b29f478f28c4989156cfe87392cbd308e3f55c1e"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"5b12eb3a634ee4eb9752c4abfe7ddc03eb761e8a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        if header[0].lower() in secure_headers:"},{"line_number":172,"context_line":"            # hashlib.sha1() bandit nosec, as it is HMAC-SHA1 in"},{"line_number":173,"context_line":"            # keystone, which is considered secure (unlike just sha1)"},{"line_number":174,"context_line":"            token_hasher \u003d hashlib.sha1()  # nosec(lhinds)"},{"line_number":175,"context_line":"            token_hasher.update(header[1].encode(\u0027utf-8\u0027))"},{"line_number":176,"context_line":"            token_hash \u003d token_hasher.hexdigest()"},{"line_number":177,"context_line":"            return (header[0], \u0027{SHA1}%s\u0027 % token_hash)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_d700f204","line":174,"in_reply_to":"7f287b81_773dbe8c","updated":"2017-09-07 18:34:48.000000000","message":"This is fine for now unless HMAC-SHA1 becomes vulnerable in the future.","commit_id":"b29f478f28c4989156cfe87392cbd308e3f55c1e"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"aca8463a3f0f0c667dc34394527cc119b9f65da3","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        if header[0].lower() in secure_headers:"},{"line_number":172,"context_line":"            # hashlib.sha1() bandit nosec, as it is HMAC-SHA1 in"},{"line_number":173,"context_line":"            # keystone, which is considered secure (unlike just sha1)"},{"line_number":174,"context_line":"            token_hasher \u003d hashlib.sha1()  # nosec(lhinds)"},{"line_number":175,"context_line":"            token_hasher.update(header[1].encode(\u0027utf-8\u0027))"},{"line_number":176,"context_line":"            token_hash \u003d token_hasher.hexdigest()"},{"line_number":177,"context_line":"            return (header[0], \u0027{SHA1}%s\u0027 % token_hash)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_07ad8587","line":174,"in_reply_to":"7f287b81_773dbe8c","updated":"2017-09-12 20:31:00.000000000","message":"This needs to be fixed by removing this whole session object.","commit_id":"b29f478f28c4989156cfe87392cbd308e3f55c1e"}]}