)]}'
{"id":"openstack%2Fpython-keystoneclient~524882","triplet_id":"openstack%2Fpython-keystoneclient~master~I52ca7561abee158285c2c98ba63d84c62e12360f","project":"openstack/python-keystoneclient","branch":"master","topic":"rm-tox_install","hashtags":[],"change_id":"I52ca7561abee158285c2c98ba63d84c62e12360f","subject":"Handle UTC+00:00 in datetime strings","status":"MERGED","created":"2017-12-02 17:15:32.000000000","updated":"2017-12-05 22:29:51.000000000","submitted":"2017-12-05 22:29:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"524882-1512512991761-2ead3318","meta_rev_id":"fa1a2c7cec0d1072a836bba04ee556025bfd1270","_number":524882,"virtual_id_number":524882,"owner":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":2,"date":"2017-12-05 22:29:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"all":[{"value":2,"date":"2017-12-03 09:52:25.000000000","_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":1,"date":"2017-12-05 16:03:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":2,"date":"2017-12-05 21:16:05.000000000","_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":1,"date":"2017-12-05 21:16:05.000000000","_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-12-03 09:52:25.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"},{"updated":"2017-12-05 16:03:28.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2017-12-05 21:16:05.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2017-12-05 22:29:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"656e01c79526bbe5a2570364772a111e5e4d14e6","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2017-12-02 17:15:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2e72dbfadbcab56c6a267498d8701ee6f319daf5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-02 19:54:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/82/524882/1/check/openstack-tox-pep8/77dbc64/ : SUCCESS in 3m 45s\n- openstack-tox-py27 http://logs.openstack.org/82/524882/1/check/openstack-tox-py27/f6ab255/ : SUCCESS in 8m 08s\n- openstack-tox-py35 http://logs.openstack.org/82/524882/1/check/openstack-tox-py35/d9048e8/ : SUCCESS in 4m 52s\n- build-openstack-sphinx-docs http://logs.openstack.org/82/524882/1/check/build-openstack-sphinx-docs/8ffe608/html/ : SUCCESS in 4m 07s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/82/524882/1/check/legacy-tempest-dsvm-neutron-src/253a014/ : SUCCESS in 1h 21m 11s\n- legacy-keystoneclient-dsvm-functional http://logs.openstack.org/82/524882/1/check/legacy-keystoneclient-dsvm-functional/9459b96/ : SUCCESS in 25m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9c1f46975f656183cf0677d7fa60347007b167c6","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2017-12-03 09:52:25.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c3d553c71be49d1d815cf90b0e7a60a8b14aff08","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2017-12-05 16:03:28.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e31b955cfd625b3e8e75fff1bd5a83fd7cf1be0e","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2017-12-05 21:16:05.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9e3d14a35f7b50bbde45acfc48ee9052e19b90d4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-05 21:16:16.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"01883f53f5eea0c289b7e1d5ff52e70502ee3f2b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-05 22:29:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"f14ac6f1dc3fb9a24946e1a3e9901c726469e15a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-05 22:29:51.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/82/524882/1/gate/openstack-tox-pep8/1e74e91/ : SUCCESS in 2m 53s\n- openstack-tox-py27 http://logs.openstack.org/82/524882/1/gate/openstack-tox-py27/47bf0af/ : SUCCESS in 3m 13s\n- openstack-tox-py35 http://logs.openstack.org/82/524882/1/gate/openstack-tox-py35/aada0e1/ : SUCCESS in 3m 02s\n- build-openstack-sphinx-docs http://logs.openstack.org/82/524882/1/gate/build-openstack-sphinx-docs/ac7d904/html/ : SUCCESS in 3m 09s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/82/524882/1/gate/legacy-tempest-dsvm-neutron-src/d3d9acc/ : SUCCESS in 1h 10m 50s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f0c9b20e0fd512e4eaa3f041a02afd80b871fe75","revisions":{"f0c9b20e0fd512e4eaa3f041a02afd80b871fe75":{"kind":"REWORK","_number":1,"created":"2017-12-02 17:15:32.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/82/524882/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/82/524882/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/82/524882/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/82/524882/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/82/524882/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/82/524882/1"}}},"commit":{"parents":[{"commit":"789301a388ba7e190de21e54300b0bb8e0ed6d18","subject":"Merge \"Remove functional tests for v2.0 API\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/789301a388ba7e190de21e54300b0bb8e0ed6d18"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2017-12-02 17:11:23.000000000","tz":-360},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2017-12-02 17:15:26.000000000","tz":-360},"subject":"Handle UTC+00:00 in datetime strings","message":"Handle UTC+00:00 in datetime strings\n\nIn some cases, the following:\n\n  datetime.datetime.now(tz\u003diso8601.iso8601.UTC).tzinfo.tzname()\n\nreturns:\n\n  \u0027UTC+00:00\u0027\n\nrather than:\n\n  \u0027UTC\u0027\n\nresulting in strings that look like:\n\n  2013-03-04T12:00:01.000000UTC+00:00\n\nThat is just flatly invalid. The code here accounts for a tzname of\n\"UTC\" and normalizes to to being a trailing Z as-per the ISO 8601 spec,\nbut it does not account for UTC+00:00. Add support for that so that we\ndon\u0027t produce invalid date strings.\n\nMost of this can be avoided by replacing use of this function with the\nisoformat method of datetime instead.\n\n  datetime.datetime.now(tz\u003diso8601.iso8601.UTC).isoformat()\n\nProduces\n\n  2013-03-04T12:00:01.000000+00:00\n\nWhich while different from\n\n  2013-03-04T12:00:01.000000Z\n\nis still a valid iso8601 string.\n\nChange-Id: I52ca7561abee158285c2c98ba63d84c62e12360f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f0c9b20e0fd512e4eaa3f041a02afd80b871fe75"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f0c9b20e0fd512e4eaa3f041a02afd80b871fe75"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
