)]}'
{"keystoneclient/v3/registered_limits.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"cc5a54fc5fc3af4774f46107016cfeed9bdc5d79","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    collection_key \u003d \u0027registered_limits\u0027"},{"line_number":36,"context_line":"    key \u003d \u0027registered_limits\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create(self, service_id, resource_name, default_limit, region_id\u003dNone):"},{"line_number":39,"context_line":"        \"\"\"Create a registered limit."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param service_id: a UUID that identifies the service for the limit."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_49062789","line":38,"updated":"2018-01-26 03:06:06.000000000","message":"I suppose administrator will call this function through openstack client to create registered limits. So there are two question here:\n1. should this function support to create more than one registered limits in one request?\n2. If yes, what the openstack client command looks like? It seems a little hard to create a batch of limits in one command.","commit_id":"adf6061e4a21ebb269816f6d112cd4e925d2fb98"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a61bf8e08152bcdaec4d39a8e3ff3c59e935c735","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    collection_key \u003d \u0027registered_limits\u0027"},{"line_number":36,"context_line":"    key \u003d \u0027registered_limits\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create(self, service_id, resource_name, default_limit, region_id\u003dNone):"},{"line_number":39,"context_line":"        \"\"\"Create a registered limit."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param service_id: a UUID that identifies the service for the limit."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_a9456bb5","line":38,"in_reply_to":"5f93b717_49062789","updated":"2018-01-26 03:08:40.000000000","message":"I just wrote an example in openstack client to create single registered limit. http://paste.openstack.org/show/653533/\nFor mutli limits case, I have no idea now. Perhaps we can read the input from a file?","commit_id":"adf6061e4a21ebb269816f6d112cd4e925d2fb98"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1a27b224dfd5fc59fa36d295ac295ad2cb3ee49e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    collection_key \u003d \u0027registered_limits\u0027"},{"line_number":36,"context_line":"    key \u003d \u0027registered_limits\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create(self, service_id, resource_name, default_limit, region_id\u003dNone):"},{"line_number":39,"context_line":"        \"\"\"Create a registered limit."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param service_id: a UUID that identifies the service for the limit."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_78b8a7e4","line":38,"in_reply_to":"5f93b717_a9456bb5","updated":"2018-06-04 20:15:31.000000000","message":"\u003e I just wrote an example in openstack client to create single\n \u003e registered limit. http://paste.openstack.org/show/653533/\n \u003e For mutli limits case, I have no idea now. Perhaps we can read the\n \u003e input from a file?\n\nYeah - that\u0027s what I was going to suggest. I\u0027d be fine implementing this without multi-limit create support at least initially. We could add that later once we have a better idea of what that should look like?","commit_id":"adf6061e4a21ebb269816f6d112cd4e925d2fb98"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"8da57809936e90ebbe9e6ab2cf235eda32e5f7fc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        :param region: a UUID that identifies the region for the limit."},{"line_number":52,"context_line":"        :type region: str"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :returns: a list of all registered limits from the server."},{"line_number":55,"context_line":"        :rtype: list of"},{"line_number":56,"context_line":"                :class:`keystoneclient.v3.registered_limits.RegisteredLimit`"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_6b411363","line":54,"range":{"start_line":54,"start_character":18,"end_line":54,"end_character":66},"updated":"2018-06-12 01:43:31.000000000","message":"a reference of the created limit.","commit_id":"77271a9c2dc81e0240b9363e6b3ce305077ea96f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"432bd29e5a409ad4ef006e9d457a713b62205b61","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        :param region: a UUID that identifies the region for the limit."},{"line_number":52,"context_line":"        :type region: str"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :returns: a list of all registered limits from the server."},{"line_number":55,"context_line":"        :rtype: list of"},{"line_number":56,"context_line":"                :class:`keystoneclient.v3.registered_limits.RegisteredLimit`"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_d9ccae62","line":54,"range":{"start_line":54,"start_character":18,"end_line":54,"end_character":66},"in_reply_to":"5f7c97a3_6b411363","updated":"2018-06-12 18:32:35.000000000","message":"++ good catch","commit_id":"77271a9c2dc81e0240b9363e6b3ce305077ea96f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"8da57809936e90ebbe9e6ab2cf235eda32e5f7fc","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        :param region: a UUID that identifies the region for the limit."},{"line_number":89,"context_line":"        :type region: str"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        :returns: a list of all registered limits from the server."},{"line_number":92,"context_line":"        :rtype: list of"},{"line_number":93,"context_line":"                :class:`keystoneclient.v3.registered_limits.RegisteredLimit`"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_6b36f304","line":91,"range":{"start_line":91,"start_character":18,"end_line":91,"end_character":66},"updated":"2018-06-12 01:43:31.000000000","message":"ditto, only returns the updated one","commit_id":"77271a9c2dc81e0240b9363e6b3ce305077ea96f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"432bd29e5a409ad4ef006e9d457a713b62205b61","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        :param region: a UUID that identifies the region for the limit."},{"line_number":89,"context_line":"        :type region: str"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        :returns: a list of all registered limits from the server."},{"line_number":92,"context_line":"        :rtype: list of"},{"line_number":93,"context_line":"                :class:`keystoneclient.v3.registered_limits.RegisteredLimit`"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_d9f58e84","line":91,"range":{"start_line":91,"start_character":18,"end_line":91,"end_character":66},"in_reply_to":"5f7c97a3_6b36f304","updated":"2018-06-12 18:32:35.000000000","message":"Done","commit_id":"77271a9c2dc81e0240b9363e6b3ce305077ea96f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"8da57809936e90ebbe9e6ab2cf235eda32e5f7fc","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            registered_limit_id \u003d base.getid(registered_limit)"},{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            registered_limit_id \u003d id"},{"line_number":155,"context_line":"        # Using delete() from CrudManager doesn\u0027t really work because the"},{"line_number":156,"context_line":"        # self.key (limit) is different than the collection key"},{"line_number":157,"context_line":"        # (registered_limits)"},{"line_number":158,"context_line":"        url \u003d \u0027%s/%s\u0027 % (self.collection_key, registered_limit_id)"},{"line_number":159,"context_line":"        return self.client.delete(url)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_865a66ef","line":157,"range":{"start_line":155,"start_character":0,"end_line":157,"end_character":29},"updated":"2018-06-12 01:43:31.000000000","message":"I\u0027m not very understand this comment. why the CrudManager doesn\u0027t work?\n\nsuper(RegisteredLimitManager, self).delete(registered_limit_id\u003dregistered_limit_id)","commit_id":"77271a9c2dc81e0240b9363e6b3ce305077ea96f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"432bd29e5a409ad4ef006e9d457a713b62205b61","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            registered_limit_id \u003d base.getid(registered_limit)"},{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            registered_limit_id \u003d id"},{"line_number":155,"context_line":"        # Using delete() from CrudManager doesn\u0027t really work because the"},{"line_number":156,"context_line":"        # self.key (limit) is different than the collection key"},{"line_number":157,"context_line":"        # (registered_limits)"},{"line_number":158,"context_line":"        url \u003d \u0027%s/%s\u0027 % (self.collection_key, registered_limit_id)"},{"line_number":159,"context_line":"        return self.client.delete(url)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_597dfee4","line":157,"range":{"start_line":155,"start_character":0,"end_line":157,"end_character":29},"in_reply_to":"5f7c97a3_865a66ef","updated":"2018-06-12 18:32:35.000000000","message":"This was left over cruft from the first iteration. Good catch.","commit_id":"77271a9c2dc81e0240b9363e6b3ce305077ea96f"}]}
