)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"2785af15dcbfa54a01871be19a2e5a81b7d3c8dc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use auth_url as mgmt_url if not admin identity"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When admin identity endpoint is not found from the returned service catalog,"},{"line_number":10,"context_line":"the given message error is “Unable to authorize user” by shell.py, therefore"},{"line_number":11,"context_line":"this is a weak feedback to the real problem that is happening, given who"},{"line_number":12,"context_line":"raised this error is httpclient.py (AuthorizationFailure Exception) with a"},{"line_number":13,"context_line":"better message “Current authorization does not have a known management url”"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2Bwm4%3D","line":10,"updated":"2013-11-20 15:33:30.000000000","message":"\"tjherefore\" makes this sentence confusing.\n\n“Unable to authorize user” by shell.py.  This is weak feedback....","commit_id":"d69ea26754479494a596482aeaa7a477e83c4e5d"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"2785af15dcbfa54a01871be19a2e5a81b7d3c8dc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When admin identity endpoint is not found from the returned service catalog,"},{"line_number":10,"context_line":"the given message error is “Unable to authorize user” by shell.py, therefore"},{"line_number":11,"context_line":"this is a weak feedback to the real problem that is happening, given who"},{"line_number":12,"context_line":"raised this error is httpclient.py (AuthorizationFailure Exception) with a"},{"line_number":13,"context_line":"better message “Current authorization does not have a known management url”"},{"line_number":14,"context_line":"but this one is suppressed by the message in shell.py, so to solve this bug"},{"line_number":15,"context_line":"is possible to attempt to use the auth_url as management_url."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2Bwms%3D","line":12,"updated":"2013-11-20 15:33:30.000000000","message":"again, this doesn\u0027t quite parse...can\u0027t really tell what you are saying here:  break it up into shorter sentences.","commit_id":"d69ea26754479494a596482aeaa7a477e83c4e5d"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"2785af15dcbfa54a01871be19a2e5a81b7d3c8dc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"but this one is suppressed by the message in shell.py, so to solve this bug"},{"line_number":15,"context_line":"is possible to attempt to use the auth_url as management_url."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Bug: #1208991 https://bugs.launchpad.net/python-keystoneclient/+bug/1208991"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I5440b94b40acd1cd0f207913a21cfab22f7d4c87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2BwnU%3D","line":17,"updated":"2013-11-20 15:33:30.000000000","message":"Change to\n\nFixes Bug #1208991\n\nAnd drop the link.","commit_id":"d69ea26754479494a596482aeaa7a477e83c4e5d"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"c0410867b8160f768d4ae4c48fa7faf1d66735ba","unresolved":false,"context_lines":[{"line_number":14,"context_line":"but this one is suppressed by the message in shell.py, so to solve this bug"},{"line_number":15,"context_line":"is possible to attempt to use the auth_url as management_url."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Bug: #1208991 https://bugs.launchpad.net/python-keystoneclient/+bug/1208991"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I5440b94b40acd1cd0f207913a21cfab22f7d4c87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2Bvp4%3D","line":17,"in_reply_to":"AAAATn%2F%2BwnU%3D","updated":"2013-11-20 19:19:56.000000000","message":"The preferred syntax has been revised to be the following in the same block as the Change-Id (part of the footer):\n\n  Closes-Bug: 1208991","commit_id":"d69ea26754479494a596482aeaa7a477e83c4e5d"}],"keystoneclient/httpclient.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"2785af15dcbfa54a01871be19a2e5a81b7d3c8dc","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        if is_management:"},{"line_number":641,"context_line":"            if self.management_url is not None:"},{"line_number":642,"context_line":"                url_to_use \u003d self.management_url"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        kwargs.setdefault(\u0027headers\u0027, {})"},{"line_number":645,"context_line":"        if self.auth_token:"},{"line_number":646,"context_line":"            kwargs[\u0027headers\u0027][\u0027X-Auth-Token\u0027] \u003d self.auth_token"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Bwlo%3D","line":643,"updated":"2013-11-20 15:33:30.000000000","message":"A little confusing.  how about collapsing this block (from like 636) to:\n\nif kwargs.pop(\u0027management\u0027, True) and self.management_url is not None:\n    url_to_use \u003d self.management_url\nelse\n    url_to_use \u003d self.auth_url","commit_id":"d69ea26754479494a596482aeaa7a477e83c4e5d"}],"keystoneclient/tests/test_http.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f9ec9b35008f9b8179a5a36a6b029bf3ce1ea8b7","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def get_client():"},{"line_number":29,"context_line":"    cl \u003d httpclient.HTTPClient(username\u003d\"username\", password\u003d\"password\","},{"line_number":30,"context_line":"                               tenant_id\u003d\"tenant\", auth_url\u003d\"127.0.0.1\")"},{"line_number":31,"context_line":"    return cl"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9%2BaE%3D","line":30,"updated":"2013-12-03 21:21:31.000000000","message":"why not put an actual URL here?","commit_id":"8184c193466df137b7880542438dc0cf94fdb963"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f9ec9b35008f9b8179a5a36a6b029bf3ce1ea8b7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    return cl"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def get_authed_client_auth_url_as_management_url():"},{"line_number":42,"context_line":"    cl \u003d get_client()"},{"line_number":43,"context_line":"    cl.auth_url \u003d \"http://\" + cl.auth_url + \":5000\""},{"line_number":44,"context_line":"    cl.auth_token \u003d \"token\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9%2BWY%3D","line":41,"updated":"2013-12-03 21:21:31.000000000","message":"don\u0027t just copy paste -- wrap the existing function or parameterize it\u0027s behavior","commit_id":"8184c193466df137b7880542438dc0cf94fdb963"}]}