)]}'
{"id":"openstack%2Fpython-keystoneclient~575234","triplet_id":"openstack%2Fpython-keystoneclient~master~I31d54c2c9294989f2693d0d83f4929ba500a5813","project":"openstack/python-keystoneclient","branch":"master","hashtags":[],"change_id":"I31d54c2c9294989f2693d0d83f4929ba500a5813","subject":"Need to pass through domain_id when domain is provided","status":"ABANDONED","created":"2018-06-13 21:05:38.000000000","updated":"2022-03-04 16:47:16.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"904ee005f89ae14688585c7ef682fa5019f797f6","_number":575234,"virtual_id_number":575234,"owner":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2018-06-15 01:49:35.000000000","_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":1,"date":"2018-06-14 01:40:33.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":-1,"date":"2018-06-14 13:18:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2018-06-14 08:29:17.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-06-14 01:40:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-06-14 08:29:17.000000000","updated_by":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"reviewer":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"state":"REVIEWER"},{"updated":"2018-06-14 13:18:45.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"}],"messages":[{"id":"64c3e26c00aa8940484f7ea29a2114cde9f8f1f8","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2018-06-13 21:05:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9421df07653601bf3bdd4ebbb435b88143a9dc26","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-14 01:40:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/34/575234/1/check/openstack-tox-pep8/4e265c7/ : SUCCESS in 4m 07s\n- openstack-tox-py27 http://logs.openstack.org/34/575234/1/check/openstack-tox-py27/6a7120f/ : SUCCESS in 4m 23s\n- openstack-tox-py35 http://logs.openstack.org/34/575234/1/check/openstack-tox-py35/1f9d514/ : SUCCESS in 4m 38s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/575234/1/check/build-openstack-sphinx-docs/97ccf74/html/ : SUCCESS in 4m 01s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/575234/1/check/legacy-tempest-dsvm-neutron-src/465f3dc/ : SUCCESS in 1h 29m 33s\n- legacy-keystoneclient-dsvm-functional http://logs.openstack.org/34/575234/1/check/legacy-keystoneclient-dsvm-functional/834517c/ : SUCCESS in 25m 51s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/34/575234/1/check/openstack-tox-lower-constraints/8dbcf63/ : SUCCESS in 5m 18s","accounts_in_message":[],"_revision_number":1},{"id":"6b60573c9a9bde905f96a3b58f5fe24bb38ea3b6","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2018-06-14 08:29:17.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"dcca9d47130a71e657d0bc9525f9660a07ac92ba","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2018-06-14 13:18:45.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"76e7c2198954307effce70ddb03cb2685b319d65","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2018-06-15 01:49:35.000000000","message":"Patch Set 1:\n\n@colleen Sure I can open bug.\n\n@wangxiyuan yes I have done that as a hack; though I don\u0027t understand the history comment you provided or what it has to do with this situation.","accounts_in_message":[],"_revision_number":1},{"id":"a0a29af14328bfaee88cdc2d8361eb0a91670b2b","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2018-06-15 02:11:28.000000000","message":"Patch Set 1:\n\n\u003e @colleen Sure I can open bug.\n \u003e \n \u003e @wangxiyuan yes I have done that as a hack; though I don\u0027t\n \u003e understand the history comment you provided or what it has to do\n \u003e with this situation.\n\nemm, I mean for history reason, the \"domain\" here is only used for role assignment list. So If you changed its meaning in this patch, the docstring should be updated, the backward compatibility should be considered, the usage in openstack client should be considered as well.\n\nActually I like your change for solving the obsolete problem , but I think it should not be so simple.","accounts_in_message":[],"_revision_number":1},{"id":"52eea3dc1b45a4ab757c3243fc4b77bef71a88ec","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2018-10-19 17:48:56.000000000","message":"Patch Set 1: Code-Review-1\n\nTagging so i can follow up. Mostly this should be encoded into SDK if it is not, and we should focus on getting folks to SDK.","accounts_in_message":[],"_revision_number":1},{"id":"043e5894b9ce6be98a6f9cf76d5c0f2c80f49cf7","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2020-01-28 17:17:57.000000000","message":"Removed reviewer Morgan Fainberg with the following votes:\n\n* Code-Review-1 by Morgan Fainberg \u003cmorgan.fainberg@gmail.com\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"904ee005f89ae14688585c7ef682fa5019f797f6","tag":"autogenerated:gerrit:abandon","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2022-03-04 16:47:16.000000000","message":"Abandoned\n\nThere hasn\u0027t been any updates to this in quite some time, feel free to restore this if you wish to continue the work.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4dfe9666fb0f2a1fa1aaddcd1a5c3987868506fc","revisions":{"4dfe9666fb0f2a1fa1aaddcd1a5c3987868506fc":{"kind":"REWORK","_number":1,"created":"2018-06-13 21:05:38.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/34/575234/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/34/575234/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/34/575234/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/34/575234/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/34/575234/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/34/575234/1"}}},"commit":{"parents":[{"commit":"41e44e61dc8f31ee0d012194f0b1d6e7bb08ae77","subject":"Merge \"fix tox python3 overrides\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/41e44e61dc8f31ee0d012194f0b1d6e7bb08ae77"}]}],"author":{"name":"Joshua Harlow","email":"jxharlow@godaddy.com","date":"2018-06-13 21:04:56.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"jxharlow@godaddy.com","date":"2018-06-13 21:05:36.000000000","tz":-420},"subject":"Need to pass through domain_id when domain is provided","message":"Need to pass through domain_id when domain is provided\n\nRole listing without a user or group (ie to list all the\nroles in a domain) is not actually passing the domain_id through\nto list the roles of a domain; this makes things not work out.\n\nChange-Id: I31d54c2c9294989f2693d0d83f4929ba500a5813\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/4dfe9666fb0f2a1fa1aaddcd1a5c3987868506fc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/4dfe9666fb0f2a1fa1aaddcd1a5c3987868506fc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}