)]}'
{"id":"openstack%2Fpython-keystoneclient~57585","triplet_id":"openstack%2Fpython-keystoneclient~master~Ic19f56c7d975257f58dccf34d780b99f237e813d","project":"openstack/python-keystoneclient","branch":"master","hashtags":[],"change_id":"Ic19f56c7d975257f58dccf34d780b99f237e813d","subject":"Avoid returning stale token via auth_token property","status":"ABANDONED","created":"2013-11-21 02:02:04.000000000","updated":"2013-11-26 09:19:24.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d0a2a7d8bb5d0ca54ec91f3be463a076ddc6f8e8","_number":57585,"virtual_id_number":57585,"owner":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2013-11-21 02:57:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2013-11-22 22:20:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":-1,"date":"2013-11-21 02:11:56.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2013-11-22 22:20:08.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"date":"2013-11-21 02:02:04.000000000","_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-11-21 02:02:04.000000000","updated_by":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"reviewer":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"state":"REVIEWER"},{"updated":"2013-11-21 02:11:56.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2013-11-21 02:57:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-11-22 22:20:08.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"}],"messages":[{"id":"6b00939a6123813253bb6d9c222c95c834654ede","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-11-21 02:11:56.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nSteve and I have discussed this and it can be done but it requires differentiating (and supporting) the endpoint/token and the auth_url/token schemes or we will change the existing behaviour of endpoint/token authentication.","accounts_in_message":[],"_revision_number":1},{"id":"6a6d626fb7a1e20873ef2ddbb2798a62405fcadb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-21 02:57:40.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/85/57585/1/check/gate-python-keystoneclient-pep8/9405726 : SUCCESS in 57s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/85/57585/1/check/gate-python-keystoneclient-docs/c08b3a3/doc/build/html/ : SUCCESS in 1m 44s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/85/57585/1/check/gate-python-keystoneclient-python26/d62aa0b : SUCCESS in 1m 06s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/85/57585/1/check/gate-python-keystoneclient-python27/c6247df : SUCCESS in 46s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/85/57585/1/check/gate-python-keystoneclient-python33/86c2afe : FAILURE in 4m 45s (non-voting)\n- check-tempest-devstack-vm-full http://logs.openstack.org/85/57585/1/check/check-tempest-devstack-vm-full/9c85475 : SUCCESS in 36m 00s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/85/57585/1/check/check-tempest-devstack-vm-postgres-full/da0eaa6 : FAILURE in 55m 21s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/85/57585/1/check/check-tempest-devstack-vm-neutron/9cc5c89 : SUCCESS in 37m 22s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/85/57585/1/check/gate-tempest-devstack-vm-large-ops/fb6990c : SUCCESS in 14m 36s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/85/57585/1/check/gate-tempest-devstack-vm-neutron-large-ops/6659b19 : SUCCESS in 16m 32s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/85/57585/1/check/check-grenade-devstack-vm/0f7782d : SUCCESS in 25m 31s\n","accounts_in_message":[],"_revision_number":1},{"id":"9683d81d91b99ff8c78d459f22e74acc9bb8c6d3","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-11-21 02:58:33.000000000","message":"Patch Set 1:\n\nI noticed tempest failed, I think you hit bug(s): https://bugs.launchpad.net/bugs/1251920","accounts_in_message":[],"_revision_number":1},{"id":"c96c010569dfea3156ad9c641b0494ce5b004f91","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-11-22 22:20:08.000000000","message":"Patch Set 1: Do not merge\n\nAbandon, or track against a different bug \u0026 Change-Id if there\u0027s anything here that should still merge?","accounts_in_message":[],"_revision_number":1},{"id":"9fb186ae97d4042e365fb6b451cf5420673bed35","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2013-11-26 06:22:32.000000000","message":"Patch Set 1: Abandoned\n\nThe was a re-posting of the review that I reverted.  It doesn\u0027t look like there is any interest in fixing so I\u0027m going to abandon.","accounts_in_message":[],"_revision_number":1},{"id":"867cf161fcc4a4c4f985d45764602e170235b71d","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-11-26 09:19:24.000000000","message":"Patch Set 1:\n\nAgreed, we can abandon this, as I think it should be obsoleted by https://review.openstack.org/#/c/57803/, which presumably won\u0027t break things the way my patch did ;)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c9b52b90bca601762548c7e1ede43c2684598ee3","revisions":{"c9b52b90bca601762548c7e1ede43c2684598ee3":{"kind":"REWORK","_number":1,"created":"2013-11-21 02:02:04.000000000","uploader":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"ref":"refs/changes/85/57585/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/85/57585/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/85/57585/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/85/57585/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/85/57585/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/85/57585/1"}}},"commit":{"parents":[{"commit":"eacd13062dc13126520f7c6071dc5a059c712659","subject":"Revert \"Merge \"Avoid returning stale token via auth_token property\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/eacd13062dc13126520f7c6071dc5a059c712659"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-10-25 14:40:57.000000000","tz":60},"committer":{"name":"David Stanek","email":"dstanek@dstanek.com","date":"2013-11-21 02:00:35.000000000","tz":0},"subject":"Avoid returning stale token via auth_token property","message":"Avoid returning stale token via auth_token property\n\nThe auth_ref token should take precedence over the user provided\ntoken, since any call to authenticate() will update the auth_ref,\nrendering the auth_token_from_user stale.\n\nChange-Id: Ic19f56c7d975257f58dccf34d780b99f237e813d\nCloses-Bug: #1244675\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c9b52b90bca601762548c7e1ede43c2684598ee3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c9b52b90bca601762548c7e1ede43c2684598ee3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}