)]}'
{"id":"openstack%2Fpython-keystoneclient~61046","triplet_id":"openstack%2Fpython-keystoneclient~master~I0858e8c39653477eb554ee9d15fb4f2dde2b195c","project":"openstack/python-keystoneclient","branch":"master","hashtags":[],"change_id":"I0858e8c39653477eb554ee9d15fb4f2dde2b195c","subject":"Fix error in v3 credentials create/update","status":"MERGED","created":"2013-12-10 08:54:16.000000000","updated":"2014-01-07 13:36:00.000000000","submitted":"2014-01-07 13:36:00.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c78c7566aea26022e9ea3da1f02283eb6de65ae7","_number":61046,"virtual_id_number":61046,"owner":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-01-07 13:36:00.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-01-06 20:16:00.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2013-12-20 16:41:48.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-01-06 20:16:00.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"date":"2013-12-20 16:41:48.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-12-11 16:16:13.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2013-12-15 23:46:08.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2013-12-18 21:22:54.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2013-12-20 16:41:48.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2014-01-06 20:16:00.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2014-01-07 13:36:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e8d84dab041d006994998409f8ebdac2bf5bba23","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-10 09:27:14.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-pep8/55d0ebf : SUCCESS in 1m 09s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/46/61046/1/check/gate-python-keystoneclient-docs/04adce9/doc/build/html/ : SUCCESS in 58s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-python26/7e30943 : SUCCESS in 1m 06s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-python27/1d8426a : SUCCESS in 1m 03s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-python33/9006e35 : FAILURE in 4m 34s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/46/61046/1/check/check-tempest-dsvm-full/7d5bd6e : SUCCESS in 32m 53s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/61046/1/check/check-tempest-dsvm-postgres-full/3ba279e : SUCCESS in 32m 24s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/61046/1/check/check-tempest-dsvm-neutron/dc34c0f : FAILURE in 29m 00s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/61046/1/check/gate-tempest-dsvm-large-ops/80a2c2a : SUCCESS in 12m 02s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/61046/1/check/gate-tempest-dsvm-neutron-large-ops/03c8315 : SUCCESS in 18m 57s\n- check-grenade-dsvm http://logs.openstack.org/46/61046/1/check/check-grenade-dsvm/2da47ad : SUCCESS in 23m 39s\n","accounts_in_message":[],"_revision_number":1},{"id":"4242c92bbaf471001a8250a747258e61374e249a","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-12-10 09:27:27.000000000","message":"Patch Set 1:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1249065\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1249065\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1249065","accounts_in_message":[],"_revision_number":1},{"id":"e432272041468ca926b26228747bc31556b42a17","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-12-10 14:50:25.000000000","message":"Patch Set 1:\n\nrecheck bug 1249065","accounts_in_message":[],"_revision_number":1},{"id":"462e688b8de770884f9efdc0c5a1ad500b94507b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-10 15:29:36.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-pep8/d97bd9a : SUCCESS in 56s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/46/61046/1/check/gate-python-keystoneclient-docs/ffc6ed0/doc/build/html/ : SUCCESS in 59s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-python26/9e0ad0e : SUCCESS in 46s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-python27/cf671d1 : SUCCESS in 50s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-python33/164fbf2 : FAILURE in 4m 42s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/46/61046/1/check/check-tempest-dsvm-full/187f17f : FAILURE in 39m 04s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/61046/1/check/check-tempest-dsvm-postgres-full/483cdf4 : SUCCESS in 34m 48s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/61046/1/check/check-tempest-dsvm-neutron/4f46c38 : SUCCESS in 31m 40s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/61046/1/check/gate-tempest-dsvm-large-ops/c139693 : SUCCESS in 15m 47s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/61046/1/check/gate-tempest-dsvm-neutron-large-ops/e8c41fa : SUCCESS in 14m 00s\n- check-grenade-dsvm http://logs.openstack.org/46/61046/1/check/check-grenade-dsvm/73f080a : SUCCESS in 28m 27s\n","accounts_in_message":[],"_revision_number":1},{"id":"9a031494316b9404163e8edc0a7ce2cce66576e6","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-12-10 17:11:42.000000000","message":"Patch Set 1:\n\nrecheck bug 1213215","accounts_in_message":[],"_revision_number":1},{"id":"b73991180b11747e97cba1ae89ace7184b3dd444","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-10 17:45:08.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-pep8/c7107c3 : SUCCESS in 1m 13s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/46/61046/1/check/gate-python-keystoneclient-docs/a3ca05c/doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-python26/479f0fe : SUCCESS in 1m 09s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-python27/fead8c5 : SUCCESS in 54s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-python33/46c3852 : FAILURE in 4m 34s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/46/61046/1/check/check-tempest-dsvm-full/9a9cb27 : SUCCESS in 32m 47s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/61046/1/check/check-tempest-dsvm-postgres-full/8d36415 : SUCCESS in 33m 16s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/61046/1/check/check-tempest-dsvm-neutron/64353a8 : FAILURE in 28m 52s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/61046/1/check/gate-tempest-dsvm-large-ops/c033c02 : SUCCESS in 13m 25s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/61046/1/check/gate-tempest-dsvm-neutron-large-ops/d099fdc : SUCCESS in 13m 57s\n- check-grenade-dsvm http://logs.openstack.org/46/61046/1/check/check-grenade-dsvm/a08ecca : SUCCESS in 29m 57s\n","accounts_in_message":[],"_revision_number":1},{"id":"e6f8b227cc691d1e8bb73ee33426278f17c38a88","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-12-10 17:45:22.000000000","message":"Patch Set 1:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1249065\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1249065\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1249065","accounts_in_message":[],"_revision_number":1},{"id":"cb1a372389a09b212d51c9259ff91afd7160acfa","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-12-10 18:15:23.000000000","message":"Patch Set 1:\n\nrecheck bug 1249065","accounts_in_message":[],"_revision_number":1},{"id":"c3c6b8a2812abe40abce6afd8412e041a3dab250","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-10 18:51:12.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-pep8/d20ec11 : SUCCESS in 1m 00s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/46/61046/1/check/gate-python-keystoneclient-docs/47e7bec/doc/build/html/ : SUCCESS in 1m 07s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-python26/7c98b7f : SUCCESS in 1m 09s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-python27/48d5028 : SUCCESS in 1m 06s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/46/61046/1/check/gate-python-keystoneclient-python33/6151ff3 : FAILURE in 4m 37s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/46/61046/1/check/check-tempest-dsvm-full/f3e2c74 : SUCCESS in 35m 42s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/61046/1/check/check-tempest-dsvm-postgres-full/742edec : SUCCESS in 34m 23s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/61046/1/check/check-tempest-dsvm-neutron/75b53a8 : SUCCESS in 29m 53s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/61046/1/check/gate-tempest-dsvm-large-ops/f8843aa : SUCCESS in 13m 18s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/61046/1/check/gate-tempest-dsvm-neutron-large-ops/092d553 : SUCCESS in 14m 38s\n- check-grenade-dsvm http://logs.openstack.org/46/61046/1/check/check-grenade-dsvm/7c58de1 : SUCCESS in 27m 41s\n","accounts_in_message":[],"_revision_number":1},{"id":"1d55ef0e61f5247739c56413ff5b500a378fb7bd","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2013-12-11 01:02:30.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\ngood catch!","accounts_in_message":[],"_revision_number":1},{"id":"c838269ca44acafc48fa12cc80ee4e2bf44365a6","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-12-11 03:41:21.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI don\u0027t think anyone uses it because they would be getting broken behaviour but that change is backward incompatible.\n\nI think you would change data -\u003e blob then add data in at the end as a kwarg. In the function say \"blob \u003d blob or data\" and put a comment about why we are keeping the broken kwarg.\n\nThat probably requires duplicating the test as well to make sure that it works the same when using the blob or data kwargs.","accounts_in_message":[],"_revision_number":1},{"id":"83bb654880fa6c7dbf876a055fdca210616d318d","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-12-11 03:42:16.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"77e3b427b42ff98ffb27b58de768e0c2a88bafe1","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-12-11 10:34:32.000000000","message":"Patch Set 1:\n\n@Jamie Lennox: Yeah I started doing a backwards compatible change, but it complicates the tests, and as you say, I\u0027m not sure how anyone can be using this as it doesn\u0027t work.  I suppose folks using something other than type\u003d\u0027ec2\u0027 could conceivably be impacted I suppose, so I\u0027ll do as you suggest and update with both data and blob.","accounts_in_message":[],"_revision_number":1},{"id":"c0c2a0252592510cd3fbc19bb979a2694a58fdcd","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-12-11 11:51:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e9f512352a316789bbc48a825191dbec96f0ade9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-11 12:40:40.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/46/61046/2/check/gate-python-keystoneclient-pep8/d7020a7 : SUCCESS in 1m 17s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/46/61046/2/check/gate-python-keystoneclient-docs/ebd8c2b/doc/build/html/ : SUCCESS in 1m 17s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/46/61046/2/check/gate-python-keystoneclient-python26/6700bd9 : SUCCESS in 1m 04s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/46/61046/2/check/gate-python-keystoneclient-python27/7026605 : SUCCESS in 1m 11s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/46/61046/2/check/gate-python-keystoneclient-python33/7f1ab94 : FAILURE in 4m 37s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/46/61046/2/check/check-tempest-dsvm-full/71bb619 : SUCCESS in 38m 14s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/61046/2/check/check-tempest-dsvm-postgres-full/1623b40 : SUCCESS in 49m 04s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/61046/2/check/check-tempest-dsvm-neutron/36cf41a : SUCCESS in 33m 54s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/61046/2/check/gate-tempest-dsvm-large-ops/4ba68e5 : SUCCESS in 12m 37s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/61046/2/check/gate-tempest-dsvm-neutron-large-ops/50bff3a : SUCCESS in 14m 02s\n- check-grenade-dsvm http://logs.openstack.org/46/61046/2/check/check-grenade-dsvm/413162b : SUCCESS in 31m 39s\n","accounts_in_message":[],"_revision_number":2},{"id":"1befdf739468b3a6f25f04c185771e08bc628026","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2013-12-11 16:16:13.000000000","message":"Patch Set 2:\n\nI don\u0027t believe this ever worked as \u0027blob\u0027 is a required field. If anyone ever use it, they\u0027ll know its broken right away. I don\u0027t think we need to add the optional \u0027data\u0027 parameter. It never worked before so there\u0027s no backward compatibility concern.","accounts_in_message":[],"_revision_number":2},{"id":"61bf279d2ace288b6951eadcb61a882a24a3e8cd","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-12-11 22:06:09.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n(2 inline comments)\n\na couple nits inline","accounts_in_message":[],"_revision_number":2},{"id":"9292e212fea1a6623b381a263e6ecd58532a5e0e","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-12-12 05:14:40.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nYea, it\u0027s not pretty and it\u0027s probably for nothing. But if we\u0027re going to be pedantic about backwards compat we may as well do it everywhere.","accounts_in_message":[],"_revision_number":2},{"id":"40a6c52c09502fa09fc75dc8b89d260beb89a35c","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2013-12-12 05:49:20.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nk, if adding the optional data param makes Jamie a happier man, then its all good! :)","accounts_in_message":[],"_revision_number":2},{"id":"0700be8355366f4b13f9640e53d169b544b2070b","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-12-12 18:05:56.000000000","message":"Patch Set 2: (2 inline comments)\n\nQuestion for dolphm re the deprecated method comment","accounts_in_message":[],"_revision_number":2},{"id":"87be9e39befa29bc73d2b591645ee5bb0b34da6d","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-12-13 00:17:35.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"5a0adfd78f39c67c5770eb7e72a3329a1cf875cf","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-12-13 10:37:42.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e6a14e27218d53a6b67976a19311429b69c9c1b7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-13 11:44:10.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-pep8/e5e62f9 : SUCCESS in 1m 49s\n- gate-python-keystoneclient-docs http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-docs/6268ae5 : FAILURE in 24s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-python26/e5d9604 : SUCCESS in 2m 08s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-python27/18ad1a6 : SUCCESS in 1m 55s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-python33/3f19578 : FAILURE in 5m 31s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/46/61046/3/check/check-tempest-dsvm-full/8b9a44d : SUCCESS in 42m 32s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/61046/3/check/check-tempest-dsvm-postgres-full/a9e1a87 : SUCCESS in 41m 43s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/61046/3/check/check-tempest-dsvm-neutron/bbca48d : FAILURE in 45m 49s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/61046/3/check/gate-tempest-dsvm-large-ops/489d90a : SUCCESS in 15m 21s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/61046/3/check/gate-tempest-dsvm-neutron-large-ops/cbe3c57 : SUCCESS in 24m 06s\n- check-grenade-dsvm http://logs.openstack.org/46/61046/3/check/check-grenade-dsvm/1e978b9 : SUCCESS in 41m 30s\n","accounts_in_message":[],"_revision_number":3},{"id":"c04c10b759c36fe8992b4f2a1e320f93bed446a4","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-12-13 11:47:07.000000000","message":"Patch Set 3:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1253896\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1253896\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1253896","accounts_in_message":[],"_revision_number":3},{"id":"9fb7809c18b319ebd7088db2544d08dee87ed12d","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-12-13 13:28:30.000000000","message":"Patch Set 3:\n\nrecheck bug 1253896","accounts_in_message":[],"_revision_number":3},{"id":"1553c6e2fa835bb95150972ea6ff71d45b7fd895","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-13 14:10:28.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-pep8/1e8a752 : SUCCESS in 1m 03s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/46/61046/3/check/gate-python-keystoneclient-docs/82cfa8c/doc/build/html/ : SUCCESS in 1m 34s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-python26/a0a29e6 : SUCCESS in 1m 24s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-python27/190f373 : FAILURE in 10s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-python33/86d107b : FAILURE in 4m 45s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/46/61046/3/check/check-tempest-dsvm-full/6492b63 : SUCCESS in 36m 49s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/61046/3/check/check-tempest-dsvm-postgres-full/975c8ee : SUCCESS in 35m 41s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/61046/3/check/check-tempest-dsvm-neutron/dc22647 : SUCCESS in 33m 31s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/61046/3/check/gate-tempest-dsvm-large-ops/d5c2bde : SUCCESS in 16m 43s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/61046/3/check/gate-tempest-dsvm-neutron-large-ops/e3684e6 : SUCCESS in 22m 43s\n- check-grenade-dsvm http://logs.openstack.org/46/61046/3/check/check-grenade-dsvm/f2c7cb1 : FAILURE in 33m 04s\n","accounts_in_message":[],"_revision_number":3},{"id":"77509e182cb32e5452e6e17ed69f9b868f6ef9cf","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-12-13 16:55:18.000000000","message":"Patch Set 3:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":3},{"id":"218782c403cee6d08cfa28ed2a737afb5ff7d7aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-13 18:12:33.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-pep8/cb6e63a : SUCCESS in 1m 06s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/46/61046/3/check/gate-python-keystoneclient-docs/68bd0df/doc/build/html/ : SUCCESS in 1m 27s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-python26/bad94c4 : SUCCESS in 1m 01s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-python27/5bbae8d : SUCCESS in 58s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/46/61046/3/check/gate-python-keystoneclient-python33/e682164 : FAILURE in 4m 47s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/46/61046/3/check/check-tempest-dsvm-full/66ffb28 : SUCCESS in 41m 46s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/61046/3/check/check-tempest-dsvm-postgres-full/f1e1a46 : SUCCESS in 41m 55s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/61046/3/check/check-tempest-dsvm-neutron/fa8d4d3 : SUCCESS in 40m 12s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/61046/3/check/gate-tempest-dsvm-large-ops/b842363 : SUCCESS in 16m 46s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/61046/3/check/gate-tempest-dsvm-neutron-large-ops/df4bb67 : SUCCESS in 15m 30s\n- check-grenade-dsvm http://logs.openstack.org/46/61046/3/check/check-grenade-dsvm/e235fde : SUCCESS in 37m 36s\n","accounts_in_message":[],"_revision_number":3},{"id":"0800c3091dc9db2aaa31f89d2d4bdd7596bae500","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-12-15 23:46:08.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"6d275e13716e4bb714ae07d82ded22567ed49289","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-12-18 21:22:54.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"a4efde3b7b77c51e509e3dd425083962e5bd817b","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-12-20 16:06:25.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"988a2cfa47f9b0b79f63884c0527d4ac26a3e012","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-12-20 16:27:49.000000000","message":"Patch Set 3: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"625ff6c8f3015149c242770411bc3b0ad425130b","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2013-12-20 16:36:49.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"7227e322e31cd4f96d76bc434ede899ef819c2b2","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-12-20 16:41:48.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\nMy comments were addressed.","accounts_in_message":[],"_revision_number":4},{"id":"94b46240169369d434b62f69acd6eafcd171bd8f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-20 17:18:35.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/46/61046/4/check/gate-python-keystoneclient-pep8/299cc2e : SUCCESS in 1m 29s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/46/61046/4/check/gate-python-keystoneclient-docs/ae71176/doc/build/html/ : SUCCESS in 1m 18s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/46/61046/4/check/gate-python-keystoneclient-python26/5bd372d : SUCCESS in 1m 21s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/46/61046/4/check/gate-python-keystoneclient-python27/5c43dab : SUCCESS in 1m 23s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/46/61046/4/check/gate-python-keystoneclient-python33/54517ba : FAILURE in 4m 51s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/46/61046/4/check/check-tempest-dsvm-full/ce9e84b : SUCCESS in 37m 31s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/46/61046/4/check/check-tempest-dsvm-postgres-full/7e536d4 : SUCCESS in 41m 26s\n- check-tempest-dsvm-neutron http://logs.openstack.org/46/61046/4/check/check-tempest-dsvm-neutron/7c7b3d1 : SUCCESS in 37m 49s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/61046/4/check/gate-tempest-dsvm-large-ops/f12d6a4 : SUCCESS in 14m 49s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/61046/4/check/gate-tempest-dsvm-neutron-large-ops/30215d0 : SUCCESS in 15m 32s\n- check-grenade-dsvm http://logs.openstack.org/46/61046/4/check/check-grenade-dsvm/be9147a : SUCCESS in 34m 53s\n","accounts_in_message":[],"_revision_number":4},{"id":"390268809a1bc9bc60f6255fd14f3da7969a5da9","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2014-01-06 20:16:00.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":4},{"id":"8144c31e077fd0d7abaf12cf3e557d5962b8071f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-06 20:16:01.000000000","message":"Patch Set 4: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"87caaefe18f1a93de1fe0283ed5393ebdc291011","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-07 13:36:00.000000000","message":"Patch Set 4: Verified\n\nBuild succeeded.\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/46/61046/4/gate/gate-python-keystoneclient-docs/feea1d3/doc/build/html/ : SUCCESS in 1m 20s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/46/61046/4/gate/gate-python-keystoneclient-pep8/d08f838 : SUCCESS in 59s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/46/61046/4/gate/gate-python-keystoneclient-python26/c225581 : SUCCESS in 1m 01s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/46/61046/4/gate/gate-python-keystoneclient-python27/095fbe0 : SUCCESS in 56s\n- gate-tempest-dsvm-full http://logs.openstack.org/46/61046/4/gate/gate-tempest-dsvm-full/863b87c : SUCCESS in 46m 19s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/46/61046/4/gate/gate-tempest-dsvm-postgres-full/5966cbc : SUCCESS in 47m 53s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/46/61046/4/gate/gate-tempest-dsvm-neutron/9fdee2d : SUCCESS in 39m 17s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/46/61046/4/gate/gate-tempest-dsvm-large-ops/2bafafc : SUCCESS in 21m 55s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/46/61046/4/gate/gate-tempest-dsvm-neutron-large-ops/3fa0455 : SUCCESS in 25m 12s\n- gate-grenade-dsvm http://logs.openstack.org/46/61046/4/gate/gate-grenade-dsvm/d3c2deb : SUCCESS in 35m 21s\n","accounts_in_message":[],"_revision_number":4},{"id":"c78c7566aea26022e9ea3da1f02283eb6de65ae7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-07 13:36:00.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"045e03d85284f4b0f5fffc656d90b922fb348b42","revisions":{"99ed640a0702a152b80cee44ee5555b0607e1f6e":{"kind":"REWORK","_number":1,"created":"2013-12-10 08:54:16.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/46/61046/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/46/61046/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/1"}}},"commit":{"parents":[{"commit":"49eb40ecf19cddd2dd2e193bc2ca0187c6965708","subject":"Merge \"use six.StringIO for compatibility with io.StringIO in python3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/49eb40ecf19cddd2dd2e193bc2ca0187c6965708"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-12-10 08:51:52.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-12-10 08:51:52.000000000","tz":0},"subject":"Fix error in v3 credentials create/update","message":"Fix error in v3 credentials create/update\n\nThe v3 credentials passes data associated with the credential in\na \"data\" key, but the underlying API expects \"blob\", which is also\nwhat is documented in the API spec.\n\nCurrently any attempt to create a credential with a type of \u0027ec2\u0027\nwill fail with \u0027Invalid blob in credential\u0027 So s/data/blob to fix.\n\nChange-Id: I0858e8c39653477eb554ee9d15fb4f2dde2b195c\nCloses-Bug: #1259461\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/99ed640a0702a152b80cee44ee5555b0607e1f6e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/99ed640a0702a152b80cee44ee5555b0607e1f6e"}]},"branch":"refs/heads/master"},"e010e3d2eabf05afdd4235f6f4bec1e79d829d8f":{"kind":"REWORK","_number":2,"created":"2013-12-11 11:51:29.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/46/61046/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/46/61046/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/2"}}},"commit":{"parents":[{"commit":"581265448cf40caddb71678a52335f8f0f49d45d","subject":"Merge \"Properly handle Regions in keystoneclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/581265448cf40caddb71678a52335f8f0f49d45d"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-12-10 08:51:52.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-12-11 11:51:19.000000000","tz":0},"subject":"Fix error in v3 credentials create/update","message":"Fix error in v3 credentials create/update\n\nThe v3 credentials passes data associated with the credential in\na \"data\" key, but the underlying API expects \"blob\", which is also\nwhat is documented in the API spec.\n\nCurrently any attempt to create a credential with a type of \u0027ec2\u0027\nwill fail with \u0027Invalid blob in credential\u0027 So s/data/blob to fix.\n\nChange-Id: I0858e8c39653477eb554ee9d15fb4f2dde2b195c\nCloses-Bug: #1259461\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e010e3d2eabf05afdd4235f6f4bec1e79d829d8f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e010e3d2eabf05afdd4235f6f4bec1e79d829d8f"}]},"branch":"refs/heads/master"},"cd17443134077e98204ff8884e2e6594b94ba96c":{"kind":"REWORK","_number":3,"created":"2013-12-13 10:37:42.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/46/61046/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/46/61046/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/3"}}},"commit":{"parents":[{"commit":"581265448cf40caddb71678a52335f8f0f49d45d","subject":"Merge \"Properly handle Regions in keystoneclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/581265448cf40caddb71678a52335f8f0f49d45d"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-12-10 08:51:52.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-12-13 10:37:33.000000000","tz":0},"subject":"Fix error in v3 credentials create/update","message":"Fix error in v3 credentials create/update\n\nThe v3 credentials passes data associated with the credential in\na \"data\" key, but the underlying API expects \"blob\", which is also\nwhat is documented in the API spec.\n\nCurrently any attempt to create a credential with a type of \u0027ec2\u0027\nwill fail with \u0027Invalid blob in credential\u0027 So s/data/blob to fix.\n\nChange-Id: I0858e8c39653477eb554ee9d15fb4f2dde2b195c\nCloses-Bug: #1259461\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/cd17443134077e98204ff8884e2e6594b94ba96c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/cd17443134077e98204ff8884e2e6594b94ba96c"}]},"branch":"refs/heads/master"},"045e03d85284f4b0f5fffc656d90b922fb348b42":{"kind":"REWORK","_number":4,"created":"2013-12-20 16:36:49.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/46/61046/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/46/61046/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/61046/4"}}},"commit":{"parents":[{"commit":"bb606a441a016d7f0b709012bba1597448cebfc7","subject":"Merge \"Rename instead of writing directly to revoked file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/bb606a441a016d7f0b709012bba1597448cebfc7"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-12-10 08:51:52.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2013-12-20 16:36:38.000000000","tz":0},"subject":"Fix error in v3 credentials create/update","message":"Fix error in v3 credentials create/update\n\nThe v3 credentials passes data associated with the credential in\na \"data\" key, but the underlying API expects \"blob\", which is also\nwhat is documented in the API spec.\n\nCurrently any attempt to create a credential with a type of \u0027ec2\u0027\nwill fail with \u0027Invalid blob in credential\u0027 So s/data/blob to fix.\n\nChange-Id: I0858e8c39653477eb554ee9d15fb4f2dde2b195c\nCloses-Bug: #1259461\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/045e03d85284f4b0f5fffc656d90b922fb348b42"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/045e03d85284f4b0f5fffc656d90b922fb348b42"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
