)]}'
{"keystoneclient/contrib/ec2/utils.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"51ea653c297b617e4b76efc693567fc3108168bf","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def _calc_signature_1(self, params):"},{"line_number":118,"context_line":"        \"\"\"Generate AWS signature version 1 string.\"\"\""},{"line_number":119,"context_line":"        keys \u003d list(params)"},{"line_number":120,"context_line":"        keys.sort(key\u003dsix.text_type.lower)"},{"line_number":121,"context_line":"        for key in keys:"},{"line_number":122,"context_line":"            self.hmac.update(key)"},{"line_number":123,"context_line":"            val \u003d self._get_utf8_value(params[key])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9W8U%3D","line":120,"updated":"2013-12-12 09:36:32.000000000","message":"The code is not the same if keys contains other types than six.text_type. It looks like python 2.6 and 2.7 tests passed, I don\u0027t know for Python 3.3.\n\n(Otherwise, use \"key\u003dlambda text: text.lower()\". But it doesn\u0027t seem necessary here.)","commit_id":"a61a2997f646b92739c64672f4f4474b80321222"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"40ed82dfbe8e7e51298beadf67581c726178e7fd","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def _calc_signature_1(self, params):"},{"line_number":118,"context_line":"        \"\"\"Generate AWS signature version 1 string.\"\"\""},{"line_number":119,"context_line":"        keys \u003d list(params)"},{"line_number":120,"context_line":"        keys.sort(key\u003dsix.text_type.lower)"},{"line_number":121,"context_line":"        for key in keys:"},{"line_number":122,"context_line":"            self.hmac.update(key)"},{"line_number":123,"context_line":"            val \u003d self._get_utf8_value(params[key])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9WVw%3D","line":120,"in_reply_to":"AAAATn%2F9W8U%3D","updated":"2013-12-12 12:05:15.000000000","message":"Yes it seems to be enough. When manually running test_ec2_utils, I get one less error, so I think it\u0027s ok :)","commit_id":"a61a2997f646b92739c64672f4f4474b80321222"}]}