)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97556c12ca1c594de5838511e54bbf516c4b6c41","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Cyril Roelandt \u003ccyril.roelandt@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-16 15:52:24 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not try to call decode() on a string"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fixes a call to \u0027isinstance\u0027 that only worked on Python2."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9IHY%3D","line":7,"updated":"2013-12-16 15:17:08.000000000","message":"You should mention Python 3, because the change is only for Python 3. You should also avoid \"string\", write \"text string\", \"bytes string\" or \"Unicode string\".","commit_id":"5a42d77202bd9fad3baf42a6f6c61a0eabceade6"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ca55bf6b2e7a5aa4b8cc780533449941add3e439","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Cyril Roelandt \u003ccyril.roelandt@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-16 15:52:24 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not try to call decode() on a string"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fixes a call to \u0027isinstance\u0027 that only worked on Python2."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2F3S0%3D","line":7,"in_reply_to":"AAAATn%2F9IHY%3D","updated":"2013-12-29 19:43:30.000000000","message":"I agree that this change would be easier to understand if the commit message was changed to mention python3 strings.","commit_id":"5a42d77202bd9fad3baf42a6f6c61a0eabceade6"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ca55bf6b2e7a5aa4b8cc780533449941add3e439","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Do not try to call decode() on a string"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fixes a call to \u0027isinstance\u0027 that only worked on Python2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I886da95f1ad2a8314de92be8aecb354ee3124e6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2F3S8%3D","line":10,"updated":"2013-12-29 19:43:30.000000000","message":"the commit message should reference the bug that this is fixing.","commit_id":"5a42d77202bd9fad3baf42a6f6c61a0eabceade6"}],"keystoneclient/utils.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ca55bf6b2e7a5aa4b8cc780533449941add3e439","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # finally try to find entity by name"},{"line_number":103,"context_line":"    try:"},{"line_number":104,"context_line":"        if isinstance(name_or_id, six.binary_type):"},{"line_number":105,"context_line":"            name_or_id \u003d name_or_id.decode(\u0027utf-8\u0027, \u0027strict\u0027)"},{"line_number":106,"context_line":"        return manager.find(name\u003dname_or_id)"},{"line_number":107,"context_line":"    except exceptions.NotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F3TA%3D","line":104,"updated":"2013-12-29 19:43:30.000000000","message":"note to reviewers: here\u0027s the docs: http://pythonhosted.org/six/#six.binary_type\n\nso this shouldn\u0027t change anything for python2.","commit_id":"5a42d77202bd9fad3baf42a6f6c61a0eabceade6"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"02061fb4063219c10d183565de5b432e8da83c38","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # finally try to find entity by name"},{"line_number":103,"context_line":"    try:"},{"line_number":104,"context_line":"        if isinstance(name_or_id, six.binary_type):"},{"line_number":105,"context_line":"            name_or_id \u003d name_or_id.decode(\u0027utf-8\u0027, \u0027strict\u0027)"},{"line_number":106,"context_line":"        return manager.find(name\u003dname_or_id)"},{"line_number":107,"context_line":"    except exceptions.NotFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2Fqio%3D","line":104,"updated":"2014-01-03 21:10:44.000000000","message":"note to reviewers: here\u0027s the docs: http://pythonhosted.org/six/#six.binary_type\n\nso this shouldn\u0027t change anything for python2.","commit_id":"f9e3b7adc980ae6722dfa59f8785ccaa4dc45c04"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"2545be74891f6db8f4089ad2781eeaa531081047","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # finally try to find entity by name"},{"line_number":103,"context_line":"    try:"},{"line_number":104,"context_line":"        if isinstance(name_or_id, six.binary_type):"},{"line_number":105,"context_line":"            name_or_id \u003d name_or_id.decode(\u0027utf-8\u0027, \u0027strict\u0027)"},{"line_number":106,"context_line":"        return manager.find(name\u003dname_or_id)"},{"line_number":107,"context_line":"    except exceptions.NotFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fw7k%3D","line":104,"in_reply_to":"AAAAT3%2F%2Fqio%3D","updated":"2014-01-08 18:30:28.000000000","message":"thanks!","commit_id":"f9e3b7adc980ae6722dfa59f8785ccaa4dc45c04"}]}