)]}'
{"id":"openstack%2Fpython-keystoneclient~62770","triplet_id":"openstack%2Fpython-keystoneclient~master~I990a2ba28d9a2a1d01300dcd33266956d059afa3","project":"openstack/python-keystoneclient","branch":"master","topic":"rename-revoke-file","hashtags":[],"change_id":"I990a2ba28d9a2a1d01300dcd33266956d059afa3","subject":"Rename instead of writing directly to revoked file","status":"MERGED","created":"2013-12-17 22:16:22.000000000","updated":"2013-12-20 15:49:18.000000000","submitted":"2013-12-20 15:49:18.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0a50a6e995a0d3449c7f3de1af54d0576f5862b7","_number":62770,"virtual_id_number":62770,"owner":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2013-12-20 15:49:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"value":0,"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2013-12-20 14:10:08.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":2,"date":"2013-12-20 14:57:02.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":1,"date":"2013-12-20 14:02:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"value":0,"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"date":"2013-12-20 14:10:08.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":1,"date":"2013-12-20 14:57:02.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"value":0,"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-12-17 22:18:07.000000000","updated_by":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"reviewer":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"state":"REVIEWER"},{"updated":"2013-12-19 17:02:38.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2013-12-19 23:02:39.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2013-12-19 23:04:45.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-12-20 00:10:09.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2013-12-20 14:02:59.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2013-12-20 14:10:08.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2013-12-20 14:57:02.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2013-12-20 15:49:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2939871ddae75d60acbb8605279041c2542fbedd","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-12-17 22:17:45.000000000","message":"Patch Set 1:\n\nI haven\u0027t added a test for that since this is same behaviour for the tests (and cover proves it). I can test if we properly did some rename if a reviewer think it\u0027s useful?","accounts_in_message":[],"_revision_number":1},{"id":"0c9ce693e64652b9f1ae059375be58401a88a076","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-17 23:01:27.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/70/62770/1/check/gate-python-keystoneclient-pep8/ae8a2e9 : SUCCESS in 53s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/70/62770/1/check/gate-python-keystoneclient-docs/2fe09db/doc/build/html/ : SUCCESS in 1m 09s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/70/62770/1/check/gate-python-keystoneclient-python26/06c7a05 : SUCCESS in 1m 26s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/70/62770/1/check/gate-python-keystoneclient-python27/5033b33 : SUCCESS in 1m 18s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/70/62770/1/check/gate-python-keystoneclient-python33/197788b : FAILURE in 4m 36s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/70/62770/1/check/check-tempest-dsvm-full/3dc9e9d : SUCCESS in 44m 54s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/70/62770/1/check/check-tempest-dsvm-postgres-full/5fbe8a5 : SUCCESS in 44m 42s\n- check-tempest-dsvm-neutron http://logs.openstack.org/70/62770/1/check/check-tempest-dsvm-neutron/d8a7207 : SUCCESS in 33m 58s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/70/62770/1/check/gate-tempest-dsvm-large-ops/58fa40b : SUCCESS in 14m 16s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/70/62770/1/check/gate-tempest-dsvm-neutron-large-ops/5ccebb4 : SUCCESS in 15m 22s\n- check-grenade-dsvm http://logs.openstack.org/70/62770/1/check/check-grenade-dsvm/f47d877 : SUCCESS in 33m 39s\n","accounts_in_message":[],"_revision_number":1},{"id":"8dc96d858cb925fefaa6d4c2772bf79508a9aabf","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-12-19 01:32:33.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nSo mkstemp returns an open fd and a filename. So if you use this method you should use the fd like: \n\nfd, file_name \u003d tempfile.mkstemp()\nos.write(fd, value)\nos.close(fd)\nos.fsync(fd)\nos.rename(temp_file, self.revoked_file_name) \n\notherwise use the tempfile.NamedTemporaryFile to use the higher level file interfaces.","accounts_in_message":[],"_revision_number":1},{"id":"056bd4c8736517522a58d01ca18149cb00431369","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-12-19 15:19:22.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bde8c4dfc91e48912e99b06ddb9c01428f022471","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-12-19 15:26:13.000000000","message":"Patch Set 2:\n\n@jamie i don\u0027t think that change much but well let\u0027s do it this way.","accounts_in_message":[],"_revision_number":2},{"id":"c63f0df1dc330a31e8c27212f2348e5e5c4f8c74","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-19 16:01:26.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/70/62770/2/check/gate-python-keystoneclient-pep8/2af2c13 : SUCCESS in 59s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/70/62770/2/check/gate-python-keystoneclient-docs/933be87/doc/build/html/ : SUCCESS in 1m 14s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/70/62770/2/check/gate-python-keystoneclient-python26/42de85e : SUCCESS in 1m 02s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/70/62770/2/check/gate-python-keystoneclient-python27/275e193 : SUCCESS in 59s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/70/62770/2/check/gate-python-keystoneclient-python33/58137fc : FAILURE in 4m 41s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/70/62770/2/check/check-tempest-dsvm-full/0e03053 : SUCCESS in 38m 36s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/70/62770/2/check/check-tempest-dsvm-postgres-full/3579601 : SUCCESS in 36m 55s\n- check-tempest-dsvm-neutron http://logs.openstack.org/70/62770/2/check/check-tempest-dsvm-neutron/0b9ae46 : SUCCESS in 38m 57s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/70/62770/2/check/gate-tempest-dsvm-large-ops/2e517ef : SUCCESS in 17m 11s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/70/62770/2/check/gate-tempest-dsvm-neutron-large-ops/910134c : SUCCESS in 17m 01s\n- check-grenade-dsvm http://logs.openstack.org/70/62770/2/check/check-grenade-dsvm/3e1b9e4 : SUCCESS in 32m 44s\n","accounts_in_message":[],"_revision_number":2},{"id":"0c84e5662da0c63e48c8e0b4e52c19c78492e16a","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2013-12-19 17:02:38.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"c4139edbb7abb9408f0d9ee7de4aee7de9a6e758","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-12-19 17:09:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4a9750e6c4ba86729664da84b7112bbe8bf30570","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-19 17:55:19.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/70/62770/3/check/gate-python-keystoneclient-pep8/fe3693a : SUCCESS in 47s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/70/62770/3/check/gate-python-keystoneclient-docs/7930e0e/doc/build/html/ : SUCCESS in 1m 21s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/70/62770/3/check/gate-python-keystoneclient-python26/7b06c0d : SUCCESS in 1m 14s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/70/62770/3/check/gate-python-keystoneclient-python27/e64ecb0 : SUCCESS in 1m 04s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/70/62770/3/check/gate-python-keystoneclient-python33/8fa2908 : FAILURE in 4m 41s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/70/62770/3/check/check-tempest-dsvm-full/28dd662 : FAILURE in 37m 55s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/70/62770/3/check/check-tempest-dsvm-postgres-full/314add9 : SUCCESS in 40m 20s\n- check-tempest-dsvm-neutron http://logs.openstack.org/70/62770/3/check/check-tempest-dsvm-neutron/2c72e80 : SUCCESS in 35m 52s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/70/62770/3/check/gate-tempest-dsvm-large-ops/f2eb2b8 : SUCCESS in 16m 09s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/70/62770/3/check/gate-tempest-dsvm-neutron-large-ops/69dd243 : SUCCESS in 15m 09s\n- check-grenade-dsvm http://logs.openstack.org/70/62770/3/check/check-grenade-dsvm/242112f : SUCCESS in 29m 10s\n","accounts_in_message":[],"_revision_number":3},{"id":"5cea0d810671df7ecf4950aec2ce1115a3052ee7","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-12-19 17:55:37.000000000","message":"Patch Set 3:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1254890\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1254890\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1254890","accounts_in_message":[],"_revision_number":3},{"id":"eea154b3aa0e2a84ad24e41a791fe73b21a107c1","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-12-19 21:42:20.000000000","message":"Patch Set 3:\n\nrecheck bug 1254890","accounts_in_message":[],"_revision_number":3},{"id":"d1458731de7057f02d0664d3bff7520b61dd0c61","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-12-19 21:43:19.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"d02f0aed49078cda84ea2cbc1b1ef29b38ec8585","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-12-19 21:43:27.000000000","message":"Patch Set 4:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":4},{"id":"f6c55575e5df87c710efd5a0221882203dfba76a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-19 22:23:52.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/70/62770/4/check/gate-python-keystoneclient-pep8/e6a8f87 : SUCCESS in 1m 03s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/70/62770/4/check/gate-python-keystoneclient-docs/90a41ee/doc/build/html/ : SUCCESS in 1m 08s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/70/62770/4/check/gate-python-keystoneclient-python26/b576b5a : SUCCESS in 1m 18s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/70/62770/4/check/gate-python-keystoneclient-python27/c8cbc73 : SUCCESS in 1m 17s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/70/62770/4/check/gate-python-keystoneclient-python33/99e13ad : FAILURE in 4m 42s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/70/62770/4/check/check-tempest-dsvm-full/6910bfb : SUCCESS in 39m 19s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/70/62770/4/check/check-tempest-dsvm-postgres-full/b0fb396 : SUCCESS in 40m 20s\n- check-tempest-dsvm-neutron http://logs.openstack.org/70/62770/4/check/check-tempest-dsvm-neutron/eb3c339 : SUCCESS in 39m 58s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/70/62770/4/check/gate-tempest-dsvm-large-ops/d75d272 : SUCCESS in 16m 06s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/70/62770/4/check/gate-tempest-dsvm-neutron-large-ops/d5f6251 : FAILURE in 10m 59s\n- check-grenade-dsvm http://logs.openstack.org/70/62770/4/check/check-grenade-dsvm/825d2df : SUCCESS in 38m 13s\n","accounts_in_message":[],"_revision_number":4},{"id":"3b60e2288a1ff61f018d24269c73a88b829e4443","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-12-19 22:36:55.000000000","message":"Patch Set 4:\n\nrecheck bug 1254890","accounts_in_message":[],"_revision_number":4},{"id":"2b795b35cd0e65dbc13f48b97b3b787bb854a85f","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-12-19 23:04:45.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\ni think patchset 1 would have leaked file descriptors, as \"_\" is never closed... this looks a lot better","accounts_in_message":[],"_revision_number":4},{"id":"c41885e63172745bb5db06c9fbf896e42fed8062","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-12-19 23:12:13.000000000","message":"Patch Set 4:\n\nAh I just read through the documentation of mkstemp again and you guys are right, thanks.","accounts_in_message":[],"_revision_number":4},{"id":"ba61e02d2adb12d372fb871a48f73eabeb89e66d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-19 23:21:29.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/70/62770/4/check/gate-python-keystoneclient-pep8/c431579 : SUCCESS in 59s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/70/62770/4/check/gate-python-keystoneclient-docs/eecd644/doc/build/html/ : SUCCESS in 56s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/70/62770/4/check/gate-python-keystoneclient-python26/d7c8fb9 : SUCCESS in 1m 05s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/70/62770/4/check/gate-python-keystoneclient-python27/690c2f9 : SUCCESS in 1m 12s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/70/62770/4/check/gate-python-keystoneclient-python33/4ad99d8 : FAILURE in 4m 39s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/70/62770/4/check/check-tempest-dsvm-full/68349aa : SUCCESS in 36m 45s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/70/62770/4/check/check-tempest-dsvm-postgres-full/44a5f24 : SUCCESS in 40m 06s\n- check-tempest-dsvm-neutron http://logs.openstack.org/70/62770/4/check/check-tempest-dsvm-neutron/c857476 : SUCCESS in 43m 42s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/70/62770/4/check/gate-tempest-dsvm-large-ops/fa118e7 : SUCCESS in 14m 32s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/70/62770/4/check/gate-tempest-dsvm-neutron-large-ops/0333600 : SUCCESS in 16m 00s\n- check-grenade-dsvm http://logs.openstack.org/70/62770/4/check/check-grenade-dsvm/795ae54 : SUCCESS in 37m 33s\n","accounts_in_message":[],"_revision_number":4},{"id":"65b8d08b8f3bd3c17693e9786e9aff1273183289","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2013-12-20 00:10:09.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"34a3c78256f6be805473cb66644f4eb7a2a1dd15","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-12-20 01:35:58.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"44e651299517707fc34c3140d25d989d903d1edf","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-12-20 12:33:29.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"4903f3784f191046782f01152e3c9e0c2b79724d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-20 13:28:00.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/70/62770/5/check/gate-python-keystoneclient-pep8/fe40e02 : SUCCESS in 1m 01s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/70/62770/5/check/gate-python-keystoneclient-docs/1a3ef66/doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/70/62770/5/check/gate-python-keystoneclient-python26/c8a5357 : SUCCESS in 1m 02s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/70/62770/5/check/gate-python-keystoneclient-python27/3e1780b : SUCCESS in 48s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/70/62770/5/check/gate-python-keystoneclient-python33/a66f678 : FAILURE in 4m 40s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/70/62770/5/check/check-tempest-dsvm-full/127246f : SUCCESS in 54m 21s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/70/62770/5/check/check-tempest-dsvm-postgres-full/9dc0e9a : SUCCESS in 39m 09s\n- check-tempest-dsvm-neutron http://logs.openstack.org/70/62770/5/check/check-tempest-dsvm-neutron/c18cc29 : SUCCESS in 38m 12s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/70/62770/5/check/gate-tempest-dsvm-large-ops/f76ccb2 : SUCCESS in 16m 19s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/70/62770/5/check/gate-tempest-dsvm-neutron-large-ops/fea90f8 : SUCCESS in 22m 13s\n- check-grenade-dsvm http://logs.openstack.org/70/62770/5/check/check-grenade-dsvm/f26324a : SUCCESS in 27m 30s\n","accounts_in_message":[],"_revision_number":5},{"id":"176efb9df42bc541518168b41330879625a663b5","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2013-12-20 14:02:59.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\nI think the code looks good.  The only thing that\u0027s going to be a little weird here is that a sysadmin may find hundreds of temp files spring up and almost immediately disappear in the same directory that stores keys.  May be something worth documenting.","accounts_in_message":[],"_revision_number":5},{"id":"6e7a955090abdea6023bed296cb5be6df48eeaff","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-12-20 14:10:08.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\nmy comment was addressed.","accounts_in_message":[],"_revision_number":5},{"id":"378b3e0b63dcce401f2313e1ab3f801527cc2afd","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-12-20 14:57:02.000000000","message":"Patch Set 5: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":5},{"id":"d875a9c6b229b77d4ed828f3abdc3c7f050748d4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-20 14:57:03.000000000","message":"Patch Set 5: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"21f6c41af70f5e5ef960bf45b5cf59afbcb0f66c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-20 15:49:18.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5},{"id":"5787bbc8778be5c002b75e6ebabd00c3146ab837","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-20 15:49:18.000000000","message":"Patch Set 5: Verified\n\nBuild succeeded.\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/70/62770/5/gate/gate-python-keystoneclient-docs/7014522/doc/build/html/ : SUCCESS in 59s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/70/62770/5/gate/gate-python-keystoneclient-pep8/14baaf6 : SUCCESS in 1m 03s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/70/62770/5/gate/gate-python-keystoneclient-python26/eaefae1 : SUCCESS in 1m 03s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/70/62770/5/gate/gate-python-keystoneclient-python27/3710172 : SUCCESS in 50s\n- gate-tempest-dsvm-full http://logs.openstack.org/70/62770/5/gate/gate-tempest-dsvm-full/cb3b301 : SUCCESS in 52m 07s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/70/62770/5/gate/gate-tempest-dsvm-postgres-full/0caefac : SUCCESS in 37m 05s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/70/62770/5/gate/gate-tempest-dsvm-neutron/757500a : SUCCESS in 34m 29s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/70/62770/5/gate/gate-tempest-dsvm-large-ops/de10ea0 : SUCCESS in 14m 43s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/70/62770/5/gate/gate-tempest-dsvm-neutron-large-ops/b636d40 : SUCCESS in 15m 27s\n- gate-grenade-dsvm http://logs.openstack.org/70/62770/5/gate/gate-grenade-dsvm/e4c2239 : SUCCESS in 31m 19s\n","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"8acc3b45868096c27ed43b22f5fa1b2d9aec38f4","revisions":{"e18575ece592255dfab4a0628f80c8ae52d103f9":{"kind":"REWORK","_number":1,"created":"2013-12-17 22:16:22.000000000","uploader":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"ref":"refs/changes/70/62770/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/70/62770/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/1"}}},"commit":{"parents":[{"commit":"8339aec3e86fde7c6e211ad26dd12892a8847e78","subject":"Merge \"Fix --debug handling in the shell\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8339aec3e86fde7c6e211ad26dd12892a8847e78"}]}],"author":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-12-17 22:05:12.000000000","tz":60},"committer":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-12-17 22:05:12.000000000","tz":60},"subject":"Rename instead of writing directly to revoked file","message":"Rename instead of writing directly to revoked file\n\nMake the operation more atomic with multiple writters.\n\nChange-Id: I990a2ba28d9a2a1d01300dcd33266956d059afa3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e18575ece592255dfab4a0628f80c8ae52d103f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e18575ece592255dfab4a0628f80c8ae52d103f9"}]},"branch":"refs/heads/master"},"ee6286a2fd996931f291221fbe9328f891fc56a8":{"kind":"REWORK","_number":2,"created":"2013-12-19 15:19:22.000000000","uploader":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"ref":"refs/changes/70/62770/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/70/62770/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/2"}}},"commit":{"parents":[{"commit":"8339aec3e86fde7c6e211ad26dd12892a8847e78","subject":"Merge \"Fix --debug handling in the shell\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8339aec3e86fde7c6e211ad26dd12892a8847e78"}]}],"author":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-12-17 22:05:12.000000000","tz":60},"committer":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-12-19 15:19:06.000000000","tz":60},"subject":"Rename instead of writing directly to revoked file","message":"Rename instead of writing directly to revoked file\n\nMake the operation more atomic with multiple writters.\n\nChange-Id: I990a2ba28d9a2a1d01300dcd33266956d059afa3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ee6286a2fd996931f291221fbe9328f891fc56a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ee6286a2fd996931f291221fbe9328f891fc56a8"}]},"branch":"refs/heads/master"},"ac5e3f8f67ee74931832f6f1ec71b23f17d36105":{"kind":"REWORK","_number":3,"created":"2013-12-19 17:09:06.000000000","uploader":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"ref":"refs/changes/70/62770/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/70/62770/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/3"}}},"commit":{"parents":[{"commit":"8339aec3e86fde7c6e211ad26dd12892a8847e78","subject":"Merge \"Fix --debug handling in the shell\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8339aec3e86fde7c6e211ad26dd12892a8847e78"}]}],"author":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-12-17 22:05:12.000000000","tz":60},"committer":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-12-19 17:08:56.000000000","tz":60},"subject":"Rename instead of writing directly to revoked file","message":"Rename instead of writing directly to revoked file\n\nMake the operation more atomic with multiple writters.\n\nChange-Id: I990a2ba28d9a2a1d01300dcd33266956d059afa3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ac5e3f8f67ee74931832f6f1ec71b23f17d36105"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ac5e3f8f67ee74931832f6f1ec71b23f17d36105"}]},"branch":"refs/heads/master"},"97dd8fc1d1d77fb3d2699ba2fbed0982fd897b91":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2013-12-19 21:43:19.000000000","uploader":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"ref":"refs/changes/70/62770/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/70/62770/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/4"}}},"commit":{"parents":[{"commit":"8339aec3e86fde7c6e211ad26dd12892a8847e78","subject":"Merge \"Fix --debug handling in the shell\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8339aec3e86fde7c6e211ad26dd12892a8847e78"}]}],"author":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-12-17 22:05:12.000000000","tz":60},"committer":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-12-19 21:42:59.000000000","tz":60},"subject":"Rename instead of writing directly to revoked file","message":"Rename instead of writing directly to revoked file\n\nMake the operation more atomic with multiple writters.\n\nCloses-Bug: 1261554\nChange-Id: I990a2ba28d9a2a1d01300dcd33266956d059afa3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/97dd8fc1d1d77fb3d2699ba2fbed0982fd897b91"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/97dd8fc1d1d77fb3d2699ba2fbed0982fd897b91"}]},"branch":"refs/heads/master"},"8acc3b45868096c27ed43b22f5fa1b2d9aec38f4":{"kind":"REWORK","_number":5,"created":"2013-12-20 12:33:29.000000000","uploader":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"ref":"refs/changes/70/62770/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/70/62770/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/62770/5"}}},"commit":{"parents":[{"commit":"8339aec3e86fde7c6e211ad26dd12892a8847e78","subject":"Merge \"Fix --debug handling in the shell\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8339aec3e86fde7c6e211ad26dd12892a8847e78"}]}],"author":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-12-17 22:05:12.000000000","tz":60},"committer":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-12-20 12:33:11.000000000","tz":60},"subject":"Rename instead of writing directly to revoked file","message":"Rename instead of writing directly to revoked file\n\nMake the operation more atomic with multiple writers.\n\nCloses-Bug: 1261554\nChange-Id: I990a2ba28d9a2a1d01300dcd33266956d059afa3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8acc3b45868096c27ed43b22f5fa1b2d9aec38f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8acc3b45868096c27ed43b22f5fa1b2d9aec38f4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}