)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"027271dce5e127b1b232550cf886f6485bc494ea","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\u0027Token authorization failed\u0027) is not meaning clearly. So modified it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaad2b955cef6be7319e4d92af8ba06098e8e047e"},{"line_number":14,"context_line":"Closes-Bug:#1164452"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAT3%2F%2F3AM%3D","line":14,"updated":"2013-12-30 01:31:20.000000000","message":"I don\u0027t see how the change fixes the bug... is the backtrace generated depending on the exception text?","commit_id":"6b4bec228fcc9ee44ee88428ca6ccbab5e5fa80d"},{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"5c50512884f811c5ea32b72f3009319bb2cb4589","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\u0027Token authorization failed\u0027) is not meaning clearly. So modified it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaad2b955cef6be7319e4d92af8ba06098e8e047e"},{"line_number":14,"context_line":"Closes-Bug:#1164452"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAT3%2F%2F27U%3D","line":14,"in_reply_to":"AAAAT3%2F%2F3AM%3D","updated":"2013-12-30 02:20:58.000000000","message":"Yes. The backtrack message contains the exception text, but it\u0027s not meaning clearly.","commit_id":"6b4bec228fcc9ee44ee88428ca6ccbab5e5fa80d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5200274565b76760024ad68072688f32b21e1fa3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     llg8212 \u003clilinguo@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-30 11:30:35 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the nasty backtrack of invalid token"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In method verify_uuid_token in python-keystoneclient/keystoneclient/"},{"line_number":10,"context_line":"middleware/auth_token.py, the backtrack message \u0027Token authorization failed\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAT3%2F%2F0KE%3D","line":7,"updated":"2013-12-30 23:10:27.000000000","message":"change \"backtrack\" to \"backtrace\".\n\nalso, what\u0027s nasty about it?","commit_id":"0d09f56d3046cf7114abc974f23e8973d4a5e9ff"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5200274565b76760024ad68072688f32b21e1fa3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Modify the nasty backtrack of invalid token"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In method verify_uuid_token in python-keystoneclient/keystoneclient/"},{"line_number":10,"context_line":"middleware/auth_token.py, the backtrack message \u0027Token authorization failed\u0027"},{"line_number":11,"context_line":" is not meaning clearly. So modified it to \u0027Token not found or invalid\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaad2b955cef6be7319e4d92af8ba06098e8e047e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAT3%2F%2F0KA%3D","line":10,"updated":"2013-12-30 23:10:27.000000000","message":"change \"backtrack\" to \"backtrace\"","commit_id":"0d09f56d3046cf7114abc974f23e8973d4a5e9ff"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5200274565b76760024ad68072688f32b21e1fa3","unresolved":false,"context_lines":[{"line_number":11,"context_line":" is not meaning clearly. So modified it to \u0027Token not found or invalid\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaad2b955cef6be7319e4d92af8ba06098e8e047e"},{"line_number":14,"context_line":"Closes-Bug:#1164452"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAT3%2F%2F0KI%3D","line":14,"updated":"2013-12-30 23:10:27.000000000","message":"I still don\u0027t see how this fixes the bug. The bug is \"A bad token invalidated by auth_token niddleware shows a backtrace\" -- how does this change make it so that there\u0027s no backtrace?","commit_id":"0d09f56d3046cf7114abc974f23e8973d4a5e9ff"},{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"5259d5d8950900c48d180769d127f4eb26c0c2a2","unresolved":false,"context_lines":[{"line_number":11,"context_line":" is not meaning clearly. So modified it to \u0027Token not found or invalid\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaad2b955cef6be7319e4d92af8ba06098e8e047e"},{"line_number":14,"context_line":"Closes-Bug:#1164452"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAT3%2F%2FxGI%3D","line":14,"in_reply_to":"AAAAT3%2F%2F0KI%3D","updated":"2014-01-02 01:45:23.000000000","message":"Before modified, we can\u0027t know what\u0027s wrong happened by the backtrace information, so we have to position in the code.  After modified, we need not to look the code too.","commit_id":"0d09f56d3046cf7114abc974f23e8973d4a5e9ff"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0bb76665f1097d6ffa0cb4468a0163ab86577ef7","unresolved":false,"context_lines":[{"line_number":11,"context_line":" is not meaning clearly. So modified it to \u0027Token not found or invalid\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaad2b955cef6be7319e4d92af8ba06098e8e047e"},{"line_number":14,"context_line":"Closes-Bug:#1164452"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUH%2F%2F%2BT4%3D","line":14,"updated":"2014-01-06 00:28:08.000000000","message":"I don\u0027t think this fixes the bug. The bug is \"A bad token invalidated by auth_token niddleware shows a backtrace\" -- how does this change make it so that there\u0027s no backtrace?","commit_id":"e8294432d2d8fb8a9601c0aae028039c2b4a5d88"},{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"d9d9091250ab3880da4c99b8e17ee2349c1a364c","unresolved":false,"context_lines":[{"line_number":11,"context_line":" is not meaning clearly. So modified it to \u0027Token not found or invalid\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaad2b955cef6be7319e4d92af8ba06098e8e047e"},{"line_number":14,"context_line":"Closes-Bug:#1164452"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUH%2F%2FvGA%3D","line":14,"in_reply_to":"AAAAUH%2F%2F%2BT4%3D","updated":"2014-01-09 01:52:26.000000000","message":"Hi Brant Knudson,\nThere should be backtrace too, but from the backtrace we can easily to know what caused the problem by log without the code.","commit_id":"e8294432d2d8fb8a9601c0aae028039c2b4a5d88"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"91389193287d40d6a4ee4136713641819ae6ed83","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     llg8212 \u003clilinguo@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-14 11:00:52 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the nasty backtrace of invalid token"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The backtrace message \u0027Token authorization failed\u0027 is not meaning"},{"line_number":10,"context_line":"clearly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAUH%2F%2FZ3E%3D","line":7,"updated":"2014-01-14 03:57:54.000000000","message":"It\u0027s not nasty - it\u0027s just a backtrace. They all look like that.","commit_id":"b118076ed9ca9204d5130932ad171b6137bbfa12"}],"keystoneclient/middleware/auth_token.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"e3b792f341be427de58cffe0e290ef0e55f02ea8","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"            return data"},{"line_number":1118,"context_line":"        if response.status_code \u003d\u003d 404:"},{"line_number":1119,"context_line":"            self.LOG.warn(\"Not found token %s\", user_token)"},{"line_number":1120,"context_line":"            raise InvalidUserToken(\u0027Not found token %s\u0027 % user_token)"},{"line_number":1121,"context_line":"        if response.status_code \u003d\u003d 401:"},{"line_number":1122,"context_line":"            self.LOG.info("},{"line_number":1123,"context_line":"                \u0027Keystone rejected admin token %s, resetting\u0027, headers)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F8rl8%3D","line":1120,"updated":"2013-12-23 10:00:57.000000000","message":"Suggest do as following:\nerror_msg \u003d \"Not found token %s\" % user_token\n\nThen use error_msg in both log message and exception\n\nAlso seems I18N was not supportted, but does not relate to this patch.","commit_id":"8c247c70aa6ebdb8b22da4c10229171facc8a661"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"cb5df9aa7ba5076e43d0f11275a76e442f24cb02","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"            return data"},{"line_number":1118,"context_line":"        if response.status_code \u003d\u003d 404:"},{"line_number":1119,"context_line":"            self.LOG.warn(\"Not found token %s\", user_token)"},{"line_number":1120,"context_line":"            raise InvalidUserToken(\u0027Not found token %s\u0027 % user_token)"},{"line_number":1121,"context_line":"        if response.status_code \u003d\u003d 401:"},{"line_number":1122,"context_line":"            self.LOG.info("},{"line_number":1123,"context_line":"                \u0027Keystone rejected admin token %s, resetting\u0027, headers)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F7CA%3D","line":1120,"in_reply_to":"AAAATn%2F8rPw%3D","updated":"2013-12-27 03:23:20.000000000","message":"I think \"invalid\" might be better.\n\n\"Token not found or invalid: %s\"","commit_id":"8c247c70aa6ebdb8b22da4c10229171facc8a661"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"4cc6d1cc343dddd34ed13aac449389670621b3cf","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"            return data"},{"line_number":1118,"context_line":"        if response.status_code \u003d\u003d 404:"},{"line_number":1119,"context_line":"            self.LOG.warn(\"Not found token %s\", user_token)"},{"line_number":1120,"context_line":"            raise InvalidUserToken(\u0027Not found token %s\u0027 % user_token)"},{"line_number":1121,"context_line":"        if response.status_code \u003d\u003d 401:"},{"line_number":1122,"context_line":"            self.LOG.info("},{"line_number":1123,"context_line":"                \u0027Keystone rejected admin token %s, resetting\u0027, headers)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F8rPw%3D","line":1120,"in_reply_to":"AAAATn%2F8rl8%3D","updated":"2013-12-23 11:41:34.000000000","message":"I would rephrase it by :\n\n\"Token not found or invalidated: %s\"","commit_id":"8c247c70aa6ebdb8b22da4c10229171facc8a661"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4cec6c54416f4a2adf733bec4932d0859151d954","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"        if response.status_code \u003d\u003d 200:"},{"line_number":1117,"context_line":"            return data"},{"line_number":1118,"context_line":"        if response.status_code \u003d\u003d 404:"},{"line_number":1119,"context_line":"            error_msg \u003d \"Token not found or invalid: %s\" % user_token"},{"line_number":1120,"context_line":"            self.LOG.warn(error_msg)"},{"line_number":1121,"context_line":"            raise InvalidUserToken(error_msg)"},{"line_number":1122,"context_line":"        if response.status_code \u003d\u003d 401:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2Fwq4%3D","line":1119,"updated":"2014-01-08 19:21:05.000000000","message":"maybe:\n\n  Token not found (likely either invalid, revoked or expired)","commit_id":"e8294432d2d8fb8a9601c0aae028039c2b4a5d88"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"67949e7b4f10c5d6721ed7a4cf7b91fff98d6b3a","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"        if response.status_code \u003d\u003d 200:"},{"line_number":1117,"context_line":"            return data"},{"line_number":1118,"context_line":"        if response.status_code \u003d\u003d 404:"},{"line_number":1119,"context_line":"            error_msg \u003d \"Token not found or invalid: %s\" % user_token"},{"line_number":1120,"context_line":"            self.LOG.warn(error_msg)"},{"line_number":1121,"context_line":"            raise InvalidUserToken(error_msg)"},{"line_number":1122,"context_line":"        if response.status_code \u003d\u003d 401:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2Bo0Y%3D","line":1119,"in_reply_to":"AAAAUH%2F%2FvJM%3D","updated":"2014-01-23 17:11:26.000000000","message":"IMO \"invalid\" implies it was never valid at all. \"A\" is an invalid token, for example. revoked and expired are states that a previously-valid token can enter.","commit_id":"e8294432d2d8fb8a9601c0aae028039c2b4a5d88"},{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"d9d9091250ab3880da4c99b8e17ee2349c1a364c","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"        if response.status_code \u003d\u003d 200:"},{"line_number":1117,"context_line":"            return data"},{"line_number":1118,"context_line":"        if response.status_code \u003d\u003d 404:"},{"line_number":1119,"context_line":"            error_msg \u003d \"Token not found or invalid: %s\" % user_token"},{"line_number":1120,"context_line":"            self.LOG.warn(error_msg)"},{"line_number":1121,"context_line":"            raise InvalidUserToken(error_msg)"},{"line_number":1122,"context_line":"        if response.status_code \u003d\u003d 401:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FvJM%3D","line":1119,"in_reply_to":"AAAAUH%2F%2Fwq4%3D","updated":"2014-01-09 01:52:26.000000000","message":"Hi Dolph Mathews,\nI think \u0027revoked\u0027 and \u0027expired\u0027 are a situation of invalid but the token exits in db. What\u0027s your opinion? Thank you.","commit_id":"e8294432d2d8fb8a9601c0aae028039c2b4a5d88"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4cec6c54416f4a2adf733bec4932d0859151d954","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"            return data"},{"line_number":1118,"context_line":"        if response.status_code \u003d\u003d 404:"},{"line_number":1119,"context_line":"            error_msg \u003d \"Token not found or invalid: %s\" % user_token"},{"line_number":1120,"context_line":"            self.LOG.warn(error_msg)"},{"line_number":1121,"context_line":"            raise InvalidUserToken(error_msg)"},{"line_number":1122,"context_line":"        if response.status_code \u003d\u003d 401:"},{"line_number":1123,"context_line":"            self.LOG.info("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FwrM%3D","line":1120,"updated":"2014-01-08 19:21:05.000000000","message":"perhaps outside the scope of this change, but i think this should be reduced from a warning to just info","commit_id":"e8294432d2d8fb8a9601c0aae028039c2b4a5d88"},{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"d9d9091250ab3880da4c99b8e17ee2349c1a364c","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"            return data"},{"line_number":1118,"context_line":"        if response.status_code \u003d\u003d 404:"},{"line_number":1119,"context_line":"            error_msg \u003d \"Token not found or invalid: %s\" % user_token"},{"line_number":1120,"context_line":"            self.LOG.warn(error_msg)"},{"line_number":1121,"context_line":"            raise InvalidUserToken(error_msg)"},{"line_number":1122,"context_line":"        if response.status_code \u003d\u003d 401:"},{"line_number":1123,"context_line":"            self.LOG.info("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FvJI%3D","line":1120,"in_reply_to":"AAAAUH%2F%2FwrM%3D","updated":"2014-01-09 01:52:26.000000000","message":"I don\u0027t think we should reduce the warning because it\u0027s a problem should be paid attention and we can easily locate the problem by incoming parameters. Do you think so? Thank you.","commit_id":"e8294432d2d8fb8a9601c0aae028039c2b4a5d88"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"91389193287d40d6a4ee4136713641819ae6ed83","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"        if response.status_code \u003d\u003d 200:"},{"line_number":1117,"context_line":"            return data"},{"line_number":1118,"context_line":"        if response.status_code \u003d\u003d 404:"},{"line_number":1119,"context_line":"            error_msg \u003d \"Token not found or invalid: %s\" % user_token"},{"line_number":1120,"context_line":"            self.LOG.warn(error_msg)"},{"line_number":1121,"context_line":"            raise InvalidUserToken(error_msg)"},{"line_number":1122,"context_line":"        if response.status_code \u003d\u003d 401:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FZ3c%3D","line":1119,"updated":"2014-01-14 03:57:54.000000000","message":"use \u0027 instead of \" for strings. \n\nThis shouldn\u0027t be logged like this because it can\u0027t be localized. You should use the original warn(message, user_token) format. You can then use raise InvalidUserToken(message % user_token).","commit_id":"b118076ed9ca9204d5130932ad171b6137bbfa12"}]}