)]}'
{"id":"openstack%2Fpython-keystoneclient~64555","triplet_id":"openstack%2Fpython-keystoneclient~master~I21ff81419313f4205ebe552556e27b86135fd096","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1265190-2","hashtags":[],"change_id":"I21ff81419313f4205ebe552556e27b86135fd096","subject":"Fix auth_token middleware test invalid cross-device link issue","status":"MERGED","created":"2013-12-31 15:28:01.000000000","updated":"2014-01-10 17:31:08.000000000","submitted":"2014-01-10 17:31:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"23aff0498bb42517580dbc1afba1834c5eca2daa","_number":64555,"virtual_id_number":64555,"owner":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-01-10 17:31:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},{"value":0,"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-01-07 13:25:54.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},{"value":0,"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},{"value":2,"date":"2014-01-07 15:58:20.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2014-01-10 01:15:38.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":1,"date":"2014-01-09 15:04:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},{"value":0,"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},{"value":0,"date":"2014-01-07 15:58:20.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":1,"date":"2014-01-10 01:15:38.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-06 09:40:39.000000000","updated_by":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"reviewer":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"state":"REVIEWER"},{"updated":"2014-01-07 15:58:20.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2014-01-09 15:04:42.000000000","updated_by":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"reviewer":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"state":"REVIEWER"},{"updated":"2014-01-10 01:15:38.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2014-01-10 17:31:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6e075d0009f734818a504524f0b4eeb122670ef1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-31 16:08:33.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/55/64555/1/check/gate-python-keystoneclient-pep8/9bd716a : SUCCESS in 1m 08s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/55/64555/1/check/gate-python-keystoneclient-docs/361fe6a/doc/build/html/ : SUCCESS in 46s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/55/64555/1/check/gate-python-keystoneclient-python26/72a9164 : SUCCESS in 1m 08s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/55/64555/1/check/gate-python-keystoneclient-python27/70e417e : SUCCESS in 1m 02s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/55/64555/1/check/gate-python-keystoneclient-python33/fde7444 : FAILURE in 4m 40s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/55/64555/1/check/check-tempest-dsvm-full/c0b1e8d : SUCCESS in 40m 25s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/55/64555/1/check/check-tempest-dsvm-postgres-full/e11d7f6 : SUCCESS in 36m 56s\n- check-tempest-dsvm-neutron http://logs.openstack.org/55/64555/1/check/check-tempest-dsvm-neutron/6fb533d : SUCCESS in 38m 58s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/55/64555/1/check/gate-tempest-dsvm-large-ops/519763d : SUCCESS in 14m 19s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/55/64555/1/check/gate-tempest-dsvm-neutron-large-ops/8ab6053 : SUCCESS in 17m 46s\n- check-grenade-dsvm http://logs.openstack.org/55/64555/1/check/check-grenade-dsvm/27288b7 : SUCCESS in 29m 40s\n","accounts_in_message":[],"_revision_number":1},{"id":"a1624d088799090efa4aea4628c0fa4f384471df","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-01-06 00:25:28.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\ncode looks fine, but commit message needs updating so that we\u0027ll know why this changed.","accounts_in_message":[],"_revision_number":1},{"id":"e2a045de1695e0ac3e51f52e3ae22bdcf275459f","author":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"date":"2014-01-06 09:22:53.000000000","message":"Patch Set 1: (3 inline comments)\n\nThanks for the feedback","accounts_in_message":[],"_revision_number":1},{"id":"ec4fda618838ce9640638c419d59a2f91a722b06","author":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"date":"2014-01-06 09:28:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3ca596cd9214202be23183d6b3cd6a3908795a3a","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2014-01-06 09:28:55.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"3c4a30647534ff8261cb396ab00a175afc572816","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-06 09:40:39.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nThanks for the fix! Looks good to me.","accounts_in_message":[],"_revision_number":2},{"id":"4a4e0b2a223c0ebaf62c80063072869eb1dfe82f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-06 10:39:47.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/55/64555/2/check/gate-python-keystoneclient-pep8/b294b9b : SUCCESS in 1m 05s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/55/64555/2/check/gate-python-keystoneclient-docs/63534a7/doc/build/html/ : SUCCESS in 48s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/55/64555/2/check/gate-python-keystoneclient-python26/30c6d41 : SUCCESS in 57s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/55/64555/2/check/gate-python-keystoneclient-python27/b714d58 : SUCCESS in 1m 09s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/55/64555/2/check/gate-python-keystoneclient-python33/4abb242 : FAILURE in 4m 40s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/55/64555/2/check/check-tempest-dsvm-full/6debe7a : SUCCESS in 46m 34s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/55/64555/2/check/check-tempest-dsvm-postgres-full/ddd15a4 : SUCCESS in 48m 14s\n- check-tempest-dsvm-neutron http://logs.openstack.org/55/64555/2/check/check-tempest-dsvm-neutron/3441945 : FAILURE in 39m 54s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/55/64555/2/check/gate-tempest-dsvm-large-ops/3a91bcd : SUCCESS in 16m 37s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/55/64555/2/check/gate-tempest-dsvm-neutron-large-ops/3a3db2d : SUCCESS in 14m 53s\n- check-grenade-dsvm http://logs.openstack.org/55/64555/2/check/check-grenade-dsvm/3565bf8 : SUCCESS in 35m 17s\n","accounts_in_message":[],"_revision_number":2},{"id":"050dd0eca0bf5c6b6d956d8f9bed86fa63f90799","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-06 10:40:43.000000000","message":"Patch Set 2:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1253896\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1253896\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1253896","accounts_in_message":[],"_revision_number":2},{"id":"38744222db0815a21dd06b40114e8f33a410588a","author":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"date":"2014-01-06 10:49:26.000000000","message":"Patch Set 2:\n\nrecheck bug 1253896","accounts_in_message":[],"_revision_number":2},{"id":"7e9c528c6a886834c2d3dca3d20353ddb39bd6f2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-06 11:35:31.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/55/64555/2/check/gate-python-keystoneclient-pep8/29ac1bf : SUCCESS in 1m 12s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/55/64555/2/check/gate-python-keystoneclient-docs/ac72d5b/doc/build/html/ : SUCCESS in 1m 17s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/55/64555/2/check/gate-python-keystoneclient-python26/f69ccd2 : SUCCESS in 1m 07s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/55/64555/2/check/gate-python-keystoneclient-python27/a06bac8 : SUCCESS in 56s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/55/64555/2/check/gate-python-keystoneclient-python33/9fa72b2 : FAILURE in 4m 42s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/55/64555/2/check/check-tempest-dsvm-full/951ff17 : SUCCESS in 44m 36s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/55/64555/2/check/check-tempest-dsvm-postgres-full/fed0c3a : SUCCESS in 44m 19s\n- check-tempest-dsvm-neutron http://logs.openstack.org/55/64555/2/check/check-tempest-dsvm-neutron/2e25539 : SUCCESS in 40m 08s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/55/64555/2/check/gate-tempest-dsvm-large-ops/2c3118b : SUCCESS in 16m 27s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/55/64555/2/check/gate-tempest-dsvm-neutron-large-ops/78bb863 : SUCCESS in 20m 07s\n- check-grenade-dsvm http://logs.openstack.org/55/64555/2/check/check-grenade-dsvm/2c402a6 : SUCCESS in 29m 30s\n","accounts_in_message":[],"_revision_number":2},{"id":"ab01b34584ce614e31bb3fbad456ba529700e81c","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-01-06 18:28:29.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nMy comments were addressed. Thanks!","accounts_in_message":[],"_revision_number":2},{"id":"11fe653b0256dddf6849bdfea5b778486fa895d2","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-01-06 20:28:47.000000000","message":"Patch Set 2: No score\n\n","accounts_in_message":[],"_revision_number":2},{"id":"85a43f2bc37a96abc9c14cf97de666e5142710ff","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-01-06 20:29:57.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nI ran this locally and it generated a bunch of files that show up in \"git status\":\n\n $ git status\n # On branch review/florent_flament/bug/1265190-2\n # Untracked files:\n #   (use \"git add \u003cfile\u003e...\" to include in what will be committed)\n #\n #       examples/pki/certs/tmp0JQjVr\n #       examples/pki/certs/tmp1O8qJH\n\nSo this change needs to either clean these files up or add to .gitignore.","accounts_in_message":[],"_revision_number":2},{"id":"6a97b6c80db6a73f23d622a047442b6f32596a92","author":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"date":"2014-01-06 21:37:18.000000000","message":"Patch Set 2:\n\nTrue, some temporary files are not cleaned... I\u0027ll have a look at how I can remove them.","accounts_in_message":[],"_revision_number":2},{"id":"fa240473b600816606df55ecbbf9a9880bc31858","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-01-06 21:56:25.000000000","message":"Patch Set 2:\n\nI pushed a change that should help with temp file deletion: https://review.openstack.org/#/c/65160/\n\nWe still might want to add the temp files to .gitignore just in case they don\u0027t get deleted automatically.","accounts_in_message":[],"_revision_number":2},{"id":"45533a7991624e79c0b48f372f1c46d715f77321","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-07 00:08:04.000000000","message":"Patch Set 2: (1 inline comment)\n\nBrant, it\u0027s not so much the cleanup\u0027s fault. On my system /tmp is on a different partition to my home dir and so the move fails (i don\u0027t know why it just started now though, rather than be obvious when that fix was committed).\n\nThe leaked file descriptor needs to be cleaned up, but it\u0027s not worse than the current solution.","accounts_in_message":[],"_revision_number":2},{"id":"322a98b41df3a4f61f64479ec814a10ec22b3d9c","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-07 00:08:13.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"2dff4193b4bcddefbf7c1f1a75cb30afbf9d5b47","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-01-07 00:32:15.000000000","message":"Patch Set 2:\n\nJamie / Florent - I submitted a change to close the temp file descriptor here: https://review.openstack.org/#/c/65184/","accounts_in_message":[],"_revision_number":2},{"id":"dba4f92b58e991204c1c334e53e9dfa5014c28b3","author":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"date":"2014-01-07 13:18:37.000000000","message":"Patch Set 2: (1 inline comment)\n\nThanks for the patch, however it didn\u0027t fix the issue of temporary files not being removed:\nhttp://paste.openstack.org/show/60627/","accounts_in_message":[],"_revision_number":2},{"id":"790ca066cfda4b0b68b3a83dd1f586f613c8357e","author":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"date":"2014-01-07 13:23:19.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"249b1267da77c4083c0056b4ad7cdc5a9b180c4e","author":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"date":"2014-01-07 13:25:54.000000000","message":"Patch Set 3:\n\nIn the mean time, I added the temporary files generated to the .gitignore file, to be sure that they won\u0027t be commited. The patch still fixes the cross-device link issue.","accounts_in_message":[],"_revision_number":3},{"id":"568af6012267c8c7c80f2f204681d07cc2ae3cff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-07 14:35:41.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/55/64555/3/check/gate-python-keystoneclient-pep8/26888b6 : SUCCESS in 2m 23s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/55/64555/3/check/gate-python-keystoneclient-docs/f53540c/doc/build/html/ : SUCCESS in 2m 16s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/55/64555/3/check/gate-python-keystoneclient-python26/093718e : SUCCESS in 2m 35s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/55/64555/3/check/gate-python-keystoneclient-python27/41db92d : SUCCESS in 2m 27s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/55/64555/3/check/gate-python-keystoneclient-python33/c38c3f9 : FAILURE in 6m 01s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/55/64555/3/check/check-tempest-dsvm-full/f31fae2 : SUCCESS in 54m 53s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/55/64555/3/check/check-tempest-dsvm-postgres-full/6fdbda0 : SUCCESS in 52m 03s\n- check-tempest-dsvm-neutron http://logs.openstack.org/55/64555/3/check/check-tempest-dsvm-neutron/c051844 : SUCCESS in 53m 48s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/55/64555/3/check/gate-tempest-dsvm-large-ops/76da2b1 : SUCCESS in 24m 03s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/55/64555/3/check/gate-tempest-dsvm-neutron-large-ops/504fbc9 : SUCCESS in 33m 55s\n- check-grenade-dsvm http://logs.openstack.org/55/64555/3/check/check-grenade-dsvm/a08d86d : SUCCESS in 52m 16s\n","accounts_in_message":[],"_revision_number":3},{"id":"7c519de4af8384d3d817157a93267f1b3055d440","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-01-07 15:58:20.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nMy comments were addressed. Thanks!","accounts_in_message":[],"_revision_number":3},{"id":"927c922c2363e12d90bb831f1e86b163490ed87a","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-07 19:04:53.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nI\u0027ll +1 this and Brant\u0027s cleanup so somebody has a rebase in their future, but they both solve different problems.","accounts_in_message":[],"_revision_number":3},{"id":"0d7a7e8e280b2a70901b5bd75bdc392e15cc8969","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-09 15:04:42.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nI was getting the Invalid cross-device link error running tests, and cherry-picking this fixes it, lgtm","accounts_in_message":[],"_revision_number":3},{"id":"47f1bffc43864d6cf8d33b8bf8146c1480bed491","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-10 01:15:38.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\nWith the expectation that: https://review.openstack.org/#/c/65160 will come through and actually cleanup those files","accounts_in_message":[],"_revision_number":3},{"id":"6ef3c9288f2148ad8f400dbe3b9baf2372d90470","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-10 01:15:39.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"a3de7d6fc1d7b3fefae6d9df68a31d6505de2abf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-10 17:31:07.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/55/64555/3/gate/gate-python-keystoneclient-docs/41cf958/doc/build/html/ : SUCCESS in 1m 04s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/55/64555/3/gate/gate-python-keystoneclient-pep8/8fed743 : SUCCESS in 1m 05s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/55/64555/3/gate/gate-python-keystoneclient-python26/f95eef2 : SUCCESS in 1m 08s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/55/64555/3/gate/gate-python-keystoneclient-python27/0b0a9b0 : SUCCESS in 1m 01s\n- gate-tempest-dsvm-full http://logs.openstack.org/55/64555/3/gate/gate-tempest-dsvm-full/b374666 : SUCCESS in 46m 39s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/55/64555/3/gate/gate-tempest-dsvm-postgres-full/3daab42 : SUCCESS in 1h 13m 06s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/55/64555/3/gate/gate-tempest-dsvm-neutron/1747a1c : SUCCESS in 39m 09s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/55/64555/3/gate/gate-tempest-dsvm-large-ops/329e138 : SUCCESS in 13m 08s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/55/64555/3/gate/gate-tempest-dsvm-neutron-large-ops/c09dbd0 : SUCCESS in 13m 39s\n- gate-grenade-dsvm http://logs.openstack.org/55/64555/3/gate/gate-grenade-dsvm/5783cd5 : SUCCESS in 30m 22s\n","accounts_in_message":[],"_revision_number":3},{"id":"695758a8a723aa090878c77401afc85ba524bdbe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-10 17:31:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6157dd57e732b12455cb64f85894037f2672d6d6","revisions":{"3a30cf604f19174b34fd2849b114ec7e234125d3":{"kind":"REWORK","_number":1,"created":"2013-12-31 15:28:01.000000000","uploader":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"ref":"refs/changes/55/64555/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/55/64555/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/64555/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/64555/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/64555/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/64555/1"}}},"commit":{"parents":[{"commit":"ce6c54de91f7c129cea11a7648f8668b2f24bca9","subject":"Merge \"Make _get_utf8_value Python3 compliant\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ce6c54de91f7c129cea11a7648f8668b2f24bca9"}]}],"author":{"name":"Florent Flament","email":"florent.flament-ext@cloudwatt.com","date":"2013-12-31 15:23:43.000000000","tz":60},"committer":{"name":"Florent Flament","email":"florent.flament-ext@cloudwatt.com","date":"2013-12-31 15:23:43.000000000","tz":60},"subject":"Fixes Invalid cross-device link issue","message":"Fixes Invalid cross-device link issue\n\nFixes path of temporary files, which weren\u0027t in the appropriate\ndirectory. File renaming now works properly since source and\ndestination files are in the same directory, and therefore on the same\npartition.\n\nRelated to preview abandonned patch:\nhttps://review.openstack.org/#/c/64544/\n\nChange-Id: I21ff81419313f4205ebe552556e27b86135fd096\nCloses-Bug: #1265190\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3a30cf604f19174b34fd2849b114ec7e234125d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3a30cf604f19174b34fd2849b114ec7e234125d3"}]},"branch":"refs/heads/master"},"02a7a2c81843c7077c907a02db2b09c5af9dde87":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2014-01-06 09:28:49.000000000","uploader":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"ref":"refs/changes/55/64555/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/55/64555/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/64555/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/64555/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/64555/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/64555/2"}}},"commit":{"parents":[{"commit":"ce6c54de91f7c129cea11a7648f8668b2f24bca9","subject":"Merge \"Make _get_utf8_value Python3 compliant\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ce6c54de91f7c129cea11a7648f8668b2f24bca9"}]}],"author":{"name":"Florent Flament","email":"florent.flament-ext@cloudwatt.com","date":"2013-12-31 15:23:43.000000000","tz":60},"committer":{"name":"Florent Flament","email":"florent.flament-ext@cloudwatt.com","date":"2014-01-06 09:26:23.000000000","tz":60},"subject":"Fix auth_token middleware test invalid cross-device link issue","message":"Fix auth_token middleware test invalid cross-device link issue\n\nFixes path of temporary files, containing token revocation lists,\nwhich weren\u0027t in the appropriate directory. File renaming now works\nproperly since source and destination files are in the same directory,\nand therefore on the same partition.\n\nChange-Id: I21ff81419313f4205ebe552556e27b86135fd096\nCloses-Bug: #1265190\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/02a7a2c81843c7077c907a02db2b09c5af9dde87"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/02a7a2c81843c7077c907a02db2b09c5af9dde87"}]},"branch":"refs/heads/master"},"6157dd57e732b12455cb64f85894037f2672d6d6":{"kind":"REWORK","_number":3,"created":"2014-01-07 13:23:19.000000000","uploader":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"ref":"refs/changes/55/64555/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/55/64555/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/64555/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/64555/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/64555/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/64555/3"}}},"commit":{"parents":[{"commit":"ce6c54de91f7c129cea11a7648f8668b2f24bca9","subject":"Merge \"Make _get_utf8_value Python3 compliant\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ce6c54de91f7c129cea11a7648f8668b2f24bca9"}]}],"author":{"name":"Florent Flament","email":"florent.flament-ext@cloudwatt.com","date":"2013-12-31 15:23:43.000000000","tz":60},"committer":{"name":"Florent Flament","email":"florent.flament-ext@cloudwatt.com","date":"2014-01-07 13:24:07.000000000","tz":60},"subject":"Fix auth_token middleware test invalid cross-device link issue","message":"Fix auth_token middleware test invalid cross-device link issue\n\nFixes path of temporary files, containing token revocation lists,\nwhich weren\u0027t in the appropriate directory. File renaming now works\nproperly since source and destination files are in the same directory,\nand therefore on the same partition.\n\nAdded to .gitignore temporary files generated during tests, that are\nnot being removed at the end of test.\n\nChange-Id: I21ff81419313f4205ebe552556e27b86135fd096\nCloses-Bug: #1265190\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6157dd57e732b12455cb64f85894037f2672d6d6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6157dd57e732b12455cb64f85894037f2672d6d6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}