)]}'
{"id":"openstack%2Fpython-keystoneclient~65044","triplet_id":"openstack%2Fpython-keystoneclient~master~I78a7563fbbde70cfd98cf1bd7a5a4eec5370d31d","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1263940","hashtags":[],"change_id":"I78a7563fbbde70cfd98cf1bd7a5a4eec5370d31d","subject":"Use install_venv from oslo to fix no post_process issue","status":"MERGED","created":"2014-01-06 08:43:33.000000000","updated":"2014-01-12 08:15:03.000000000","submitted":"2014-01-12 08:15:02.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"837c2994db1c3a11a4e58b472010502e290b142f","_number":65044,"virtual_id_number":65044,"owner":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-01-12 08:15:02.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-01-12 03:57:27.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},{"value":2,"date":"2014-01-10 22:07:26.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2014-01-10 05:07:53.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"date":"2014-01-12 04:37:36.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":1,"date":"2014-01-10 09:50:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},{"value":1,"date":"2014-01-10 22:07:26.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"date":"2014-01-10 05:07:53.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"date":"2014-01-12 04:37:36.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-10 05:07:53.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2014-01-10 09:50:32.000000000","updated_by":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"reviewer":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"state":"REVIEWER"},{"updated":"2014-01-10 22:07:26.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2014-01-12 04:37:36.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2014-01-12 08:15:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d29d4412a096d6b63421da3462e7246dcf184b33","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-06 08:48:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"487a01c7d939318b2307177fbd75163b7fbd84e9","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2014-01-06 08:48:07.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"b10dcf0a30d5284e6d679ef030a603b7b48308c7","author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"date":"2014-01-06 09:58:38.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"43a6fc3d82a09c88f4a491a7186fa3364229c88a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-06 10:20:55.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/44/65044/2/check/gate-python-keystoneclient-pep8/fb8e884 : SUCCESS in 1m 11s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/44/65044/2/check/gate-python-keystoneclient-docs/39c8403/doc/build/html/ : SUCCESS in 59s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/44/65044/2/check/gate-python-keystoneclient-python26/5c1ff8a : SUCCESS in 2m 04s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/44/65044/2/check/gate-python-keystoneclient-python27/021d9bb : SUCCESS in 55s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/44/65044/2/check/gate-python-keystoneclient-python33/e2c3f50 : FAILURE in 4m 39s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/44/65044/2/check/check-tempest-dsvm-full/1eca8ee : SUCCESS in 48m 24s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/44/65044/2/check/check-tempest-dsvm-postgres-full/b574548 : SUCCESS in 1h 05m 19s\n- check-tempest-dsvm-neutron http://logs.openstack.org/44/65044/2/check/check-tempest-dsvm-neutron/b4fba8a : SUCCESS in 41m 33s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/44/65044/2/check/gate-tempest-dsvm-large-ops/0322db8 : SUCCESS in 17m 11s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/44/65044/2/check/gate-tempest-dsvm-neutron-large-ops/f714d28 : SUCCESS in 20m 17s\n- check-grenade-dsvm http://logs.openstack.org/44/65044/2/check/check-grenade-dsvm/9f135fa : SUCCESS in 31m 55s\n","accounts_in_message":[],"_revision_number":2},{"id":"bff842ed3217ca2c2bb97c4450e67d3ae6538e39","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2014-01-08 19:16:00.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"97dfb32f1020c8f7e6835f1b69ca477e060739be","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-09 01:40:10.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nIsn\u0027t this an OSLO thing?","accounts_in_message":[],"_revision_number":2},{"id":"fca3c6353e693519c736b60d4cb14744103de6e1","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-09 01:41:45.000000000","message":"Patch Set 2:\n\nNo, I dont\u0027 think so. Only install_venv_common.py comes from oslo, but not install_venv.py","accounts_in_message":[],"_revision_number":2},{"id":"6fd613a382ec02cd62da060af8523f170b1effe2","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-09 02:00:11.000000000","message":"Patch Set 2:\n\nHmm, i wonder why? Anyway OSLO\u0027s instaLL_venv.py looks a lot simpler and doesn\u0027t have the post_process command. Can we just sync across from there/","accounts_in_message":[],"_revision_number":2},{"id":"1eb38b5cc9f60ac33620c7a1a575ade425072d7a","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-09 02:08:33.000000000","message":"Patch Set 2:\n\nI don\u0027t know the history here. But the information I get from the install_venv.py source file, seems it is the place to handle distro specific logic for installing venv, which is not in oslo/tools/install_venv yet?","accounts_in_message":[],"_revision_number":2},{"id":"5a69d66b9b31ead654f92b3061707dd0eadeea9e","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-09 05:05:35.000000000","message":"Patch Set 2:\n\nMy point was more is that stuff still needed? there seems to be some extra debian and Suse stuff in our install_venv that oslo doesn\u0027t have - and i\u0027d put money on the fact that that code wasn\u0027t written purposefully for keystoneclient.\n\nIf this file is copied around it should be in oslo and i\u0027m very suspicious of the differences between our file and theres.","accounts_in_message":[],"_revision_number":2},{"id":"98fe5f6714cf6385155218bc74f1614830dddb4d","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-09 08:19:15.000000000","message":"Patch Set 2:\n\nSeems you\u0027re right. I just checked python-novaclient and python-cinder, they all had this distro code before and removed when introducing install_venv_common from oslo.\n\nThe distro code here in keystoneclient was left behind when introducing install_venv_common. So I think approach here, is to fix original issue (no \u0027post_process\u0027 attribute) by using install_venv from oslo. I\u0027ll upload another patchset soon.\n\nIf any distro specific logic we need, it probably should be fixed at oslo side. Agree?","accounts_in_message":[],"_revision_number":2},{"id":"cbc64649aa23387b4cf3c192d46293ddb14d3891","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-09 08:51:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"8f01a07ef0ed4cff7f9c2a0988162f7bcb7d5a94","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-09 10:35:37.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/44/65044/3/check/gate-python-keystoneclient-pep8/de0b799 : SUCCESS in 1m 04s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/44/65044/3/check/gate-python-keystoneclient-docs/8b9eafb/doc/build/html/ : SUCCESS in 1m 06s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/44/65044/3/check/gate-python-keystoneclient-python26/5bcac7e : SUCCESS in 1m 03s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/44/65044/3/check/gate-python-keystoneclient-python27/fbfe0cc : SUCCESS in 47s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/44/65044/3/check/gate-python-keystoneclient-python33/cb66e12 : FAILURE in 4m 39s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/44/65044/3/check/check-tempest-dsvm-full/2b07632 : SUCCESS in 57m 25s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/44/65044/3/check/check-tempest-dsvm-postgres-full/44e2239 : SUCCESS in 45m 20s\n- check-tempest-dsvm-neutron http://logs.openstack.org/44/65044/3/check/check-tempest-dsvm-neutron/cd4e981 : SUCCESS in 41m 57s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/44/65044/3/check/gate-tempest-dsvm-large-ops/971a08a : FAILURE in 16m 29s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/44/65044/3/check/gate-tempest-dsvm-neutron-large-ops/420c9fc : SUCCESS in 14m 49s\n- check-grenade-dsvm http://logs.openstack.org/44/65044/3/check/check-grenade-dsvm/129db4f : SUCCESS in 29m 38s\n","accounts_in_message":[],"_revision_number":3},{"id":"110ad5883eb07cd3cc9b7d749113c4ffbe1f0ff6","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-09 11:06:54.000000000","message":"Patch Set 3:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1257626\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1257626\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1257626","accounts_in_message":[],"_revision_number":3},{"id":"7cad88d88964f677526e18ac900017eaf9fcf14f","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-09 11:52:23.000000000","message":"Patch Set 3:\n\nrecheck bug 1257626","accounts_in_message":[],"_revision_number":3},{"id":"24e6542d3b214f7946ce7796789daf14e4ed01e0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-09 13:10:13.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/44/65044/3/check/gate-python-keystoneclient-pep8/0ce3189 : SUCCESS in 54s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/44/65044/3/check/gate-python-keystoneclient-docs/08eab74/doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/44/65044/3/check/gate-python-keystoneclient-python26/211ca08 : SUCCESS in 1m 04s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/44/65044/3/check/gate-python-keystoneclient-python27/22cb738 : SUCCESS in 44s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/44/65044/3/check/gate-python-keystoneclient-python33/69909aa : FAILURE in 4m 37s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/44/65044/3/check/check-tempest-dsvm-full/09321f1 : SUCCESS in 39m 03s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/44/65044/3/check/check-tempest-dsvm-postgres-full/176b26f : SUCCESS in 36m 16s\n- check-tempest-dsvm-neutron http://logs.openstack.org/44/65044/3/check/check-tempest-dsvm-neutron/7b56469 : SUCCESS in 38m 22s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/44/65044/3/check/gate-tempest-dsvm-large-ops/0ce8f83 : FAILURE in 14m 35s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/44/65044/3/check/gate-tempest-dsvm-neutron-large-ops/f407779 : SUCCESS in 16m 57s\n- check-grenade-dsvm http://logs.openstack.org/44/65044/3/check/check-grenade-dsvm/cad2993 : SUCCESS in 30m 18s\n","accounts_in_message":[],"_revision_number":3},{"id":"9acc545b589ef4df53250af192fd190e2cadaec5","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-09 14:34:59.000000000","message":"Patch Set 3:\n\nrecheck bug 1250168","accounts_in_message":[],"_revision_number":3},{"id":"b98517660499b4ba23d72fda55f2b1b407d239f1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-09 16:05:10.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/44/65044/3/check/gate-python-keystoneclient-pep8/0a7e48b : SUCCESS in 1m 11s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/44/65044/3/check/gate-python-keystoneclient-docs/6e0c880/doc/build/html/ : SUCCESS in 1m 12s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/44/65044/3/check/gate-python-keystoneclient-python26/1d01387 : SUCCESS in 1m 03s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/44/65044/3/check/gate-python-keystoneclient-python27/57432b4 : SUCCESS in 1m 16s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/44/65044/3/check/gate-python-keystoneclient-python33/c590941 : FAILURE in 4m 42s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/44/65044/3/check/check-tempest-dsvm-full/1e2adf1 : SUCCESS in 44m 24s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/44/65044/3/check/check-tempest-dsvm-postgres-full/7c26886 : SUCCESS in 43m 02s\n- check-tempest-dsvm-neutron http://logs.openstack.org/44/65044/3/check/check-tempest-dsvm-neutron/ac6fe0c : SUCCESS in 34m 18s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/44/65044/3/check/gate-tempest-dsvm-large-ops/1131c7a : SUCCESS in 13m 25s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/44/65044/3/check/gate-tempest-dsvm-neutron-large-ops/164d993 : SUCCESS in 14m 37s\n- check-grenade-dsvm http://logs.openstack.org/44/65044/3/check/check-grenade-dsvm/d468d29 : SUCCESS in 28m 03s\n","accounts_in_message":[],"_revision_number":3},{"id":"f756165a329afc6677916f19fca67826700f7c9b","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-10 00:42:36.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nAgree.\n\nYou\u0027ll need to add install_venv to the openstack-common.conf","accounts_in_message":[],"_revision_number":3},{"id":"c31c43a9fc780d5f5572a88031836120675b400d","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-10 00:44:05.000000000","message":"Patch Set 3: No score\n\nAh, i obviously didn\u0027t sufficiently read the Note at the bottom. I\u0027m not following what you mean there.","accounts_in_message":[],"_revision_number":3},{"id":"b1e72d62ceb5c8388cf16695b15386daae4251f1","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-10 00:49:15.000000000","message":"Patch Set 3:\n\nhttps://review.openstack.org/#/c/65044/3/tools/install_venv.py\nLine 60: project \u003d \u0027python-keystoneclient\u0027\n\nI mean it is not a exact sync from oslo, since we still need to modify this line at keystoneclient side to match the project name.\n\nNot quite sure we should install install_venv to openstack-common.conf in this case. So far I learned from other projects, no one has installed openstack-common.conf even they used oslo code. So I chose to follow the same pattern, but I could be wrong.","accounts_in_message":[],"_revision_number":3},{"id":"6f44bf5e0826abaccff14a00c2014f0aeeca2a25","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-10 00:50:14.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nTried it myself and adding it to openstack-common.conf works for me","accounts_in_message":[],"_revision_number":3},{"id":"2fdfbcbfbb2fb2c9cb3ed9668b4350d08122cebc","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-10 01:20:47.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"c1e40cb23fdd9529ea33e46c4f106f27ac74e467","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-10 02:09:43.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\nOk, i\u0027ve had a look through some of the other projects and for whatever reason you are correct that they bring in install_venv_common but install_venv is just copied across. That seems dumb to me - i thought that oslo would update the project\u003d but apparently not. \n\nWhat i meant before was that if i did a straight sync from oslo of install_venv then having run_tests.sh create the virtual env worked just fine. The only place in install_venv_common where project appears to be used is in an error message. \n\nIf the file is not a straight sync from oslo then it shouldn\u0027t go into openstack-common as it will just get overwritten later.I don\u0027t really care about that project variable and am happy to have the error message slightly wrong and try to fix oslo later if it means we are tracking the common code.\n\nUp to you, i would go the straight sync - if there is reasons beyond project \u003d that we shouldn\u0027t do that (none of the other projects sync it) then that\u0027s fair too.","accounts_in_message":[],"_revision_number":4},{"id":"0b396bd763994cfc1abeafa0fed7c97c3aeab80e","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-10 02:16:42.000000000","message":"Patch Set 4:\n\nWell, I prefer not to include it in openstack-common.conf. Since it is a common practice of other projects, it might be a good idea to keep in line with them.\n\nIf that is OK with you, I will update and restore to patchset 3\u0027s status.","accounts_in_message":[],"_revision_number":4},{"id":"534ef2c2438f399494e57dbe59f3437f3fb77f4d","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-10 02:39:17.000000000","message":"Patch Set 4:\n\nsure, that\u0027s fine","accounts_in_message":[],"_revision_number":4},{"id":"4cb0e9d154688f3cd286bf67551d01a2dfed0b5c","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-10 02:45:10.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"6eb0852e7598d255213c69b68d23b0f3d449203b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-10 04:16:15.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/44/65044/5/check/gate-python-keystoneclient-pep8/5b47380 : SUCCESS in 1m 15s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/44/65044/5/check/gate-python-keystoneclient-docs/d92a83e/doc/build/html/ : SUCCESS in 1m 04s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/44/65044/5/check/gate-python-keystoneclient-python26/4f64a16 : SUCCESS in 1m 25s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/44/65044/5/check/gate-python-keystoneclient-python27/d63eba1 : SUCCESS in 48s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/44/65044/5/check/gate-python-keystoneclient-python33/26fe505 : FAILURE in 4m 41s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/44/65044/5/check/check-tempest-dsvm-full/e6926d7 : SUCCESS in 57m 51s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/44/65044/5/check/check-tempest-dsvm-postgres-full/22df8d6 : SUCCESS in 42m 13s\n- check-tempest-dsvm-neutron http://logs.openstack.org/44/65044/5/check/check-tempest-dsvm-neutron/70e028c : SUCCESS in 35m 08s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/44/65044/5/check/gate-tempest-dsvm-large-ops/b8f41de : SUCCESS in 10m 36s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/44/65044/5/check/gate-tempest-dsvm-neutron-large-ops/96106dd : SUCCESS in 13m 49s\n- check-grenade-dsvm http://logs.openstack.org/44/65044/5/check/check-grenade-dsvm/c3dd138 : SUCCESS in 29m 41s\n","accounts_in_message":[],"_revision_number":5},{"id":"93344210fa66f4fd60cb7b62217c638dec00297c","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-10 05:07:53.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"dba72e88ce1d40041f926d54d0b29fb5969f6165","author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"date":"2014-01-10 09:50:32.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":5},{"id":"83cc675db57cc3462f0b63342be731d3809140e2","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2014-01-10 22:07:26.000000000","message":"Patch Set 5: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":5},{"id":"d19555a5b6b68dd974d0d360a6f63b8bea7c6a47","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-10 23:10:50.000000000","message":"Patch Set 5: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"feee74af4470d48be6d1aa63354982cda54108e4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-11 20:26:31.000000000","message":"Patch Set 5: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/44/65044/5/gate/gate-python-keystoneclient-docs/04f56bb/doc/build/html/ : SUCCESS in 1m 10s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/44/65044/5/gate/gate-python-keystoneclient-pep8/a97c579 : SUCCESS in 1m 11s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/44/65044/5/gate/gate-python-keystoneclient-python26/efb5ee8 : SUCCESS in 1m 08s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/44/65044/5/gate/gate-python-keystoneclient-python27/c222104 : SUCCESS in 57s\n- gate-tempest-dsvm-full http://logs.openstack.org/44/65044/5/gate/gate-tempest-dsvm-full/efc71e2 : SUCCESS in 44m 57s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/44/65044/5/gate/gate-tempest-dsvm-postgres-full/d5ebf10 : FAILURE in 45m 21s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/44/65044/5/gate/gate-tempest-dsvm-neutron/4b2aaa9 : SUCCESS in 36m 43s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/44/65044/5/gate/gate-tempest-dsvm-large-ops/c240893 : SUCCESS in 12m 33s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/44/65044/5/gate/gate-tempest-dsvm-neutron-large-ops/6b970b5 : SUCCESS in 16m 16s\n- gate-grenade-dsvm http://logs.openstack.org/44/65044/5/gate/gate-grenade-dsvm/d2a4a53 : SUCCESS in 32m 11s\n","accounts_in_message":[],"_revision_number":5},{"id":"05981c0c404f7f036607e4b2e5de31e3123fed47","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-11 20:26:49.000000000","message":"Patch Set 5:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1254872\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1254872\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1254872","accounts_in_message":[],"_revision_number":5},{"id":"17c3c4bbff2b64a94f877c2547dc534a36dddabe","author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"date":"2014-01-12 03:57:27.000000000","message":"Patch Set 5:\n\nrecheck bug 1254872","accounts_in_message":[],"_revision_number":5},{"id":"2514f767df6fdafadd66ad1849ca4f51abaea3fa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-12 04:37:36.000000000","message":"Patch Set 5: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"77608136358859bb18392dc5fac3eac83c7d9367","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-01-12 04:37:36.000000000","message":"Patch Set 5:\n\nreverify bug 1254872","accounts_in_message":[],"_revision_number":5},{"id":"584d5907ab5c6f2fe01d283d20e2b987387585f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-12 04:45:56.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/44/65044/5/check/gate-python-keystoneclient-pep8/bc5b4e5 : SUCCESS in 51s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/44/65044/5/check/gate-python-keystoneclient-docs/5ff3f51/doc/build/html/ : SUCCESS in 1m 13s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/44/65044/5/check/gate-python-keystoneclient-python26/5613f61 : SUCCESS in 1m 12s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/44/65044/5/check/gate-python-keystoneclient-python27/a791b85 : SUCCESS in 1m 04s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/44/65044/5/check/gate-python-keystoneclient-python33/7e75dd3 : FAILURE in 4m 47s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/44/65044/5/check/check-tempest-dsvm-full/c6bbcb2 : SUCCESS in 48m 19s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/44/65044/5/check/check-tempest-dsvm-postgres-full/338af69 : SUCCESS in 40m 13s\n- check-tempest-dsvm-neutron http://logs.openstack.org/44/65044/5/check/check-tempest-dsvm-neutron/fb60b46 : SUCCESS in 40m 18s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/44/65044/5/check/gate-tempest-dsvm-large-ops/bb6f49d : SUCCESS in 11m 18s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/44/65044/5/check/gate-tempest-dsvm-neutron-large-ops/7ee7780 : SUCCESS in 12m 44s\n- check-grenade-dsvm http://logs.openstack.org/44/65044/5/check/check-grenade-dsvm/ea20767 : SUCCESS in 30m 18s\n","accounts_in_message":[],"_revision_number":5},{"id":"76985d80c206ddf572b96aa4a34ec86c8b7f5afc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-12 08:15:02.000000000","message":"Patch Set 5: Verified\n\nBuild succeeded.\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/44/65044/5/gate/gate-python-keystoneclient-docs/fce6c01/doc/build/html/ : SUCCESS in 1m 04s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/44/65044/5/gate/gate-python-keystoneclient-pep8/27bee26 : SUCCESS in 1m 19s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/44/65044/5/gate/gate-python-keystoneclient-python26/c49bda2 : SUCCESS in 1m 11s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/44/65044/5/gate/gate-python-keystoneclient-python27/f86923e : SUCCESS in 1m 24s\n- gate-tempest-dsvm-full http://logs.openstack.org/44/65044/5/gate/gate-tempest-dsvm-full/4e0064f : SUCCESS in 44m 56s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/44/65044/5/gate/gate-tempest-dsvm-postgres-full/47e01ed : SUCCESS in 49m 25s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/44/65044/5/gate/gate-tempest-dsvm-neutron/2fe231f : SUCCESS in 35m 02s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/44/65044/5/gate/gate-tempest-dsvm-large-ops/9eb56f5 : SUCCESS in 11m 19s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/44/65044/5/gate/gate-tempest-dsvm-neutron-large-ops/facbcca : SUCCESS in 12m 49s\n- gate-grenade-dsvm http://logs.openstack.org/44/65044/5/gate/gate-grenade-dsvm/e3a97da : SUCCESS in 28m 51s\n","accounts_in_message":[],"_revision_number":5},{"id":"7f08b85105a1722125345583c675944fd883b4d1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-12 08:15:03.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"7a71e1b90ebf1c58fb47d823aa9a7be2406eae17","revisions":{"704026d90db6ef2bdddcab4885f39f6809f832b3":{"kind":"REWORK","_number":1,"created":"2014-01-06 08:43:33.000000000","uploader":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"ref":"refs/changes/44/65044/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/44/65044/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/1"}}},"commit":{"parents":[{"commit":"6cd7b4b26ecfaef53efdaac2dd685c23c49cd502","subject":"Merge \"Update requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6cd7b4b26ecfaef53efdaac2dd685c23c49cd502"}]}],"author":{"name":"Qiu Yu","email":"qiuyu@ebaysf.com","date":"2014-01-06 08:35:10.000000000","tz":480},"committer":{"name":"Qiu Yu","email":"qiuyu@ebaysf.com","date":"2014-01-06 08:43:29.000000000","tz":480},"subject":"Fix no attribute \u0027post_process\u0027 error when creating venv","message":"Fix no attribute \u0027post_process\u0027 error when creating venv\n\nIn a recent oslo sync commit Ieb73d5f799423fa8abf71634c86601ba6d32df2f,\npost_process() has been removed from tools/install_venv_common.py. This\nchange removes post_process() call from tools/install_venv.py to fix\n\u0027InstallVenv\u0027 object has no attribute \u0027post_process\u0027 issue when creating\nvenv.\n\nChange-Id: I78a7563fbbde70cfd98cf1bd7a5a4eec5370d31d\nCloses-Bug: #1263940\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/704026d90db6ef2bdddcab4885f39f6809f832b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/704026d90db6ef2bdddcab4885f39f6809f832b3"}]},"branch":"refs/heads/master"},"c97b7332641ffb6b8258cdcb677d024726f02a86":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2014-01-06 08:48:01.000000000","uploader":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"ref":"refs/changes/44/65044/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/44/65044/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/2"}}},"commit":{"parents":[{"commit":"6cd7b4b26ecfaef53efdaac2dd685c23c49cd502","subject":"Merge \"Update requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6cd7b4b26ecfaef53efdaac2dd685c23c49cd502"}]}],"author":{"name":"Qiu Yu","email":"qiuyu@ebaysf.com","date":"2014-01-06 08:35:10.000000000","tz":480},"committer":{"name":"Qiu Yu","email":"qiuyu@ebaysf.com","date":"2014-01-06 08:47:44.000000000","tz":480},"subject":"Fix no attribute \u0027post_process\u0027 error when creating venv","message":"Fix no attribute \u0027post_process\u0027 error when creating venv\n\nIn a recent oslo sync commit Ieb73d5f799423fa8abf71634c86601ba6d32df2f\npost_process() has been removed from tools/install_venv_common.py. This\nchange removes post_process() call from tools/install_venv.py to fix\n\u0027InstallVenv\u0027 object has no attribute \u0027post_process\u0027 issue when creating\nvenv.\n\nChange-Id: I78a7563fbbde70cfd98cf1bd7a5a4eec5370d31d\nCloses-Bug: #1263940\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c97b7332641ffb6b8258cdcb677d024726f02a86"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c97b7332641ffb6b8258cdcb677d024726f02a86"}]},"branch":"refs/heads/master"},"f8c3647492ae40f0d3304d110260c3f87a81c410":{"kind":"REWORK","_number":3,"created":"2014-01-09 08:51:45.000000000","uploader":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"ref":"refs/changes/44/65044/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/44/65044/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/3"}}},"commit":{"parents":[{"commit":"0b25aa7c80e1686be848b8dbde3b7a02d53b0a72","subject":"Merge \"Whitelist external netaddr requirement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0b25aa7c80e1686be848b8dbde3b7a02d53b0a72"}]}],"author":{"name":"Qiu Yu","email":"qiuyu@ebaysf.com","date":"2014-01-06 08:35:10.000000000","tz":480},"committer":{"name":"Qiu Yu","email":"qiuyu@ebaysf.com","date":"2014-01-09 08:50:57.000000000","tz":480},"subject":"Use install_venv from oslo to fix no post_process issue","message":"Use install_venv from oslo to fix no post_process issue\n\nIn a recent oslo sync commit Ieb73d5f799423fa8abf71634c86601ba6d32df2f\npost_process() has been removed from tools/install_venv_common.py, which\nis still called in tools/install_venv.py\n\nFurther investigation shows install_venv.py has some legacy distro\nspecific code, which should be removed at the time introducing\ninstall_venv_common from oslo.\n\nThis change switch tools/install_venv.py to use oslo code to align the\neffort as well as fixing original no \u0027post_process\u0027 issue.\n\nChanges being pulled into in install_venv are:\n12bcdb7 - 2013-11-25 12:16:11 +0800 - Remove vim header\nb5cca99 - 2013-10-09 21:34:00 +0100 - Remove obsolete\nredhat-eventlet.patch\n9378d3c - 2013-08-13 18:06:11 +0300 - Move `./run_tests.sh` to Oslo\n\nNote: openstack-common.conf is not updated, because the project name\nvariable still need to be modified per project base.\n\nChange-Id: I78a7563fbbde70cfd98cf1bd7a5a4eec5370d31d\nCloses-Bug: #1263940\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f8c3647492ae40f0d3304d110260c3f87a81c410"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f8c3647492ae40f0d3304d110260c3f87a81c410"}]},"branch":"refs/heads/master"},"1d569e834ca6b5be21b13a84b1867c749ab98b58":{"kind":"REWORK","_number":4,"created":"2014-01-10 01:20:47.000000000","uploader":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"ref":"refs/changes/44/65044/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/44/65044/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/4"}}},"commit":{"parents":[{"commit":"0b25aa7c80e1686be848b8dbde3b7a02d53b0a72","subject":"Merge \"Whitelist external netaddr requirement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0b25aa7c80e1686be848b8dbde3b7a02d53b0a72"}]}],"author":{"name":"Qiu Yu","email":"qiuyu@ebaysf.com","date":"2014-01-06 08:35:10.000000000","tz":480},"committer":{"name":"Qiu Yu","email":"qiuyu@ebaysf.com","date":"2014-01-10 01:20:21.000000000","tz":480},"subject":"Use install_venv from oslo to fix no post_process issue","message":"Use install_venv from oslo to fix no post_process issue\n\nIn a recent oslo sync commit Ieb73d5f799423fa8abf71634c86601ba6d32df2f\npost_process() has been removed from tools/install_venv_common.py, which\nis still called in tools/install_venv.py\n\nFurther investigation shows install_venv.py has some legacy distro\nspecific code, which should be removed at the time introducing\ninstall_venv_common from oslo.\n\nThis change switch tools/install_venv.py to use oslo code to align the\neffort as well as fixing original no \u0027post_process\u0027 issue.\n\nChanges being pulled into in install_venv are:\n12bcdb7 - 2013-11-25 12:16:11 +0800 - Remove vim header\nb5cca99 - 2013-10-09 21:34:00 +0100 - Remove obsolete\nredhat-eventlet.patch\n9378d3c - 2013-08-13 18:06:11 +0300 - Move `./run_tests.sh` to Oslo\n\nNote: openstack-common.conf is also updated for install_venv module, but\nthe project name in install_venv is changed to python-keystoneclient\nafter syncing.\n\nChange-Id: I78a7563fbbde70cfd98cf1bd7a5a4eec5370d31d\nCloses-Bug: #1263940\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1d569e834ca6b5be21b13a84b1867c749ab98b58"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1d569e834ca6b5be21b13a84b1867c749ab98b58"}]},"branch":"refs/heads/master"},"7a71e1b90ebf1c58fb47d823aa9a7be2406eae17":{"kind":"REWORK","_number":5,"created":"2014-01-10 02:45:10.000000000","uploader":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"ref":"refs/changes/44/65044/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/44/65044/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/65044/5"}}},"commit":{"parents":[{"commit":"0b25aa7c80e1686be848b8dbde3b7a02d53b0a72","subject":"Merge \"Whitelist external netaddr requirement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0b25aa7c80e1686be848b8dbde3b7a02d53b0a72"}]}],"author":{"name":"Qiu Yu","email":"qiuyu@ebaysf.com","date":"2014-01-06 08:35:10.000000000","tz":480},"committer":{"name":"Qiu Yu","email":"qiuyu@ebaysf.com","date":"2014-01-10 02:40:28.000000000","tz":480},"subject":"Use install_venv from oslo to fix no post_process issue","message":"Use install_venv from oslo to fix no post_process issue\n\nIn a recent oslo sync commit Ieb73d5f799423fa8abf71634c86601ba6d32df2f\npost_process() has been removed from tools/install_venv_common.py, which\nis still called in tools/install_venv.py\n\nFurther investigation shows install_venv.py has some legacy distro\nspecific code, which should be removed at the time introducing\ninstall_venv_common from oslo.\n\nThis change switch tools/install_venv.py to use oslo code to align the\neffort as well as fixing original no \u0027post_process\u0027 issue.\n\nChanges being pulled into in install_venv are:\n12bcdb7 - 2013-11-25 12:16:11 +0800 - Remove vim header\nb5cca99 - 2013-10-09 21:34:00 +0100 - Remove obsolete\nredhat-eventlet.patch\n9378d3c - 2013-08-13 18:06:11 +0300 - Move `./run_tests.sh` to Oslo\n\nNote: openstack-common.conf is not updated, because the project name\nvariable in install_venv has to be modified after syncing from oslo.\nThat makes it not an exact sync but modification after sync. Besides\nother openstack projects using install_venv from oslo also don\u0027t change\nopenstack-common.conf. So this patch simply follow the common practice\nhere.\n\nChange-Id: I78a7563fbbde70cfd98cf1bd7a5a4eec5370d31d\nCloses-Bug: #1263940\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/7a71e1b90ebf1c58fb47d823aa9a7be2406eae17"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/7a71e1b90ebf1c58fb47d823aa9a7be2406eae17"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}