)]}'
{"id":"openstack%2Fpython-keystoneclient~65381","triplet_id":"openstack%2Fpython-keystoneclient~master~I64e11bcf3797eb84e4695605daea9749259d78ec","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1047867","hashtags":[],"change_id":"I64e11bcf3797eb84e4695605daea9749259d78ec","subject":"Consistently support kwargs across all v3 CRUD Manager ops","status":"MERGED","created":"2014-01-07 21:48:07.000000000","updated":"2014-01-28 02:02:53.000000000","submitted":"2014-01-28 02:02:53.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":12,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2da4107a8d934da1ddaad47bb22a95f9d8ffc476","_number":65381,"virtual_id_number":65381,"owner":{"_account_id":901,"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","username":"divyesh-khandeshi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-01-28 02:02:53.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":901,"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","username":"divyesh-khandeshi"},{"value":0,"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},{"value":0,"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},{"value":0,"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},{"value":0,"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"recommended":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":901,"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","username":"divyesh-khandeshi"},{"value":1,"date":"2014-01-23 22:30:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},{"value":2,"date":"2014-01-28 00:06:34.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":1,"date":"2014-01-24 15:39:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":2,"date":"2014-01-23 21:58:19.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":1,"date":"2014-01-24 06:20:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},{"value":0,"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},{"value":1,"date":"2014-01-24 15:08:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},{"value":0,"date":"2014-01-22 12:41:38.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":901,"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","username":"divyesh-khandeshi"},{"value":0,"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},{"value":1,"date":"2014-01-28 00:06:34.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"date":"2014-01-23 18:08:23.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},{"value":0,"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},{"value":0,"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},{"value":0,"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},{"_account_id":901,"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","username":"divyesh-khandeshi"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-10 15:28:02.000000000","updated_by":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"reviewer":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"state":"REVIEWER"},{"updated":"2014-01-13 18:37:46.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2014-01-13 19:36:21.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2014-01-22 12:41:38.000000000","updated_by":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"reviewer":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"state":"REVIEWER"},{"updated":"2014-01-23 18:08:23.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2014-01-23 22:30:09.000000000","updated_by":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"reviewer":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"state":"REVIEWER"},{"updated":"2014-01-24 06:20:51.000000000","updated_by":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"reviewer":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"state":"REVIEWER"},{"updated":"2014-01-24 15:08:53.000000000","updated_by":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"reviewer":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"state":"REVIEWER"},{"updated":"2014-01-24 15:39:03.000000000","updated_by":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"reviewer":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"state":"REVIEWER"},{"updated":"2014-01-28 00:06:34.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2014-01-28 02:02:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3c9b053e8f38b1e00f19b2670c8f2b95f3d9ab15","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-07 23:33:44.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/81/65381/1/check/gate-python-keystoneclient-pep8/e4469d3 : SUCCESS in 2m 48s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/81/65381/1/check/gate-python-keystoneclient-docs/f17c10e/doc/build/html/ : SUCCESS in 2m 52s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/81/65381/1/check/gate-python-keystoneclient-python26/6b8ad8a : SUCCESS in 2m 14s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/81/65381/1/check/gate-python-keystoneclient-python27/721dce4 : SUCCESS in 3m 06s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/81/65381/1/check/gate-python-keystoneclient-python33/2f2484e : FAILURE in 6m 40s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/81/65381/1/check/check-tempest-dsvm-full/b9489ee : SUCCESS in 59m 17s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/81/65381/1/check/check-tempest-dsvm-postgres-full/cc87860 : SUCCESS in 57m 33s\n- check-tempest-dsvm-neutron http://logs.openstack.org/81/65381/1/check/check-tempest-dsvm-neutron/6aae72c : SUCCESS in 51m 50s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/81/65381/1/check/gate-tempest-dsvm-large-ops/86f18f5 : SUCCESS in 31m 40s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/81/65381/1/check/gate-tempest-dsvm-neutron-large-ops/1bc7b89 : SUCCESS in 33m 45s\n- check-grenade-dsvm http://logs.openstack.org/81/65381/1/check/check-grenade-dsvm/6e7b841 : FAILURE in 1h 05m 14s\n","accounts_in_message":[],"_revision_number":1},{"id":"461949fde72e807780c851a0fa3d645f7bbefc36","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-08 00:35:45.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\nRevert all the whitespace changes. There are more than those i commented on.\n\nHappy with the idea though.","accounts_in_message":[],"_revision_number":1},{"id":"db3c21c53f0680c5a679b9d03c0da258a46f7924","author":{"_account_id":901,"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","username":"divyesh-khandeshi"},"date":"2014-01-08 15:01:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"62e271aa0687728c3b9c573f4f41933d68220ff5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-08 16:26:06.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/81/65381/2/check/gate-python-keystoneclient-pep8/52c293f : SUCCESS in 1m 22s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/81/65381/2/check/gate-python-keystoneclient-docs/05b0575/doc/build/html/ : SUCCESS in 1m 10s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/81/65381/2/check/gate-python-keystoneclient-python26/2324ce6 : SUCCESS in 1m 18s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/81/65381/2/check/gate-python-keystoneclient-python27/b963c8b : SUCCESS in 1m 08s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/81/65381/2/check/gate-python-keystoneclient-python33/46430a8 : FAILURE in 4m 44s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/81/65381/2/check/check-tempest-dsvm-full/af50228 : SUCCESS in 41m 00s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/81/65381/2/check/check-tempest-dsvm-postgres-full/2f02b40 : SUCCESS in 44m 26s\n- check-tempest-dsvm-neutron http://logs.openstack.org/81/65381/2/check/check-tempest-dsvm-neutron/df71930 : SUCCESS in 38m 20s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/81/65381/2/check/gate-tempest-dsvm-large-ops/872a570 : SUCCESS in 13m 33s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/81/65381/2/check/gate-tempest-dsvm-neutron-large-ops/2a8e1e6 : SUCCESS in 15m 48s\n- check-grenade-dsvm http://logs.openstack.org/81/65381/2/check/check-grenade-dsvm/bb3a670 : SUCCESS in 37m 10s\n","accounts_in_message":[],"_revision_number":2},{"id":"bec781a438da2e7a26d9da1c6efdd10379936286","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-09 01:14:58.000000000","message":"Patch Set 2:\n\nAlso see: https://review.openstack.org/#/c/60654","accounts_in_message":[],"_revision_number":2},{"id":"863a505db6945b330018e268ea31f2ed321ee13a","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-09 01:18:46.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nI like. \n\nIt needs some testing though. Hava a look at the patch i linked above - i don\u0027t mind how they get sorted out (but sajuptpm was first).\n\nI *think* there might be a way to cover testing for all the managers in keystoneclient/tests/v3/utils.py CrudTests that or a similar strategy so they don\u0027t need to be written for everything.","accounts_in_message":[],"_revision_number":2},{"id":"71f12ffd79d70e5f2102d08288c106aadd0aad6d","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-09 14:48:36.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"885b2d9ee0f6bd36bc673e5cca4b63ee62a2a7ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-09 16:05:14.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/81/65381/3/check/gate-python-keystoneclient-pep8/b4bd6ee : SUCCESS in 44s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/81/65381/3/check/gate-python-keystoneclient-docs/bedcc5a/doc/build/html/ : SUCCESS in 1m 04s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/81/65381/3/check/gate-python-keystoneclient-python26/a842a92 : SUCCESS in 51s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/81/65381/3/check/gate-python-keystoneclient-python27/d92b955 : SUCCESS in 58s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/81/65381/3/check/gate-python-keystoneclient-python33/48002c7 : FAILURE in 4m 39s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/81/65381/3/check/check-tempest-dsvm-full/ba09bc8 : SUCCESS in 43m 31s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/81/65381/3/check/check-tempest-dsvm-postgres-full/391b48f : SUCCESS in 41m 33s\n- check-tempest-dsvm-neutron http://logs.openstack.org/81/65381/3/check/check-tempest-dsvm-neutron/f138cd8 : SUCCESS in 45m 41s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/81/65381/3/check/gate-tempest-dsvm-large-ops/f058f35 : SUCCESS in 13m 51s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/81/65381/3/check/gate-tempest-dsvm-neutron-large-ops/8fe97a2 : SUCCESS in 15m 34s\n- check-grenade-dsvm http://logs.openstack.org/81/65381/3/check/check-grenade-dsvm/6d70afb : SUCCESS in 31m 09s\n","accounts_in_message":[],"_revision_number":3},{"id":"512ed89215f1cb3041313591807ee2f6a51f1704","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-09 23:54:29.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nSo the only one i see you missing is contrib/trusts.py.\n\nI think the uuid param entry can just be moved to the super class CrudTests new_ref, every crud manager should be able to handle that. \n\nThere is also no testing that the value is transmitted on a create or list call just that it accepts a kwarg. We also need to check that if an arbitrary parameter is received from a call that it becomes a part of the object. \n\nAll these resource classes inherit from CrudTests so anything you put there should be automatically run for all the resource types so it shouldn\u0027t (but maybe will) require something in every file.","accounts_in_message":[],"_revision_number":3},{"id":"5d3a9cc8b1e6a7c7ad01c6a12adb8e9fb91bbd05","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-09 23:59:38.000000000","message":"Patch Set 3:\n\nAlso link the bug report with \n    Closes-Bug: 1047867\n\nin the commit message.\n\nThis is also enough to put your name in the commit (because it will belong to divyesh who created it) so you can do \n\n   Co-Authored-By: Saju Madhavan \u003csajuptpm@gmail.com\u003e\n\nI\u0027m not sure what: extensible-crud-manager-operations is if it\u0027s a blueprint you have to use the word blueprint to get that link. So perhaps: \n\n    Blueprint: extensible-crud-manager-operations\n    or\n    Implements: blueprint extensible-crud-manager-operations","accounts_in_message":[],"_revision_number":3},{"id":"a7919d5e1206a41f03028fb643006237679046ee","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-10 13:51:27.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"7efe98ae5860a3f433782a4450741350eff198d0","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-10 14:00:37.000000000","message":"Patch Set 4:\n\n@Jamie Lennox\nThere is also no testing that the value is transmitted on a create or list call just that it accepts a kwarg. We also need to check that if an arbitrary parameter is received from a call that it becomes a part of the object. \n\nReply:\n\nThat checks already there in the base class methods, right?\nFor example, in method test_create of class CrudTests, you can see a loop like.\n        self.assertTrue(isinstance(returned, self.model))\n        for attr in ref:\n            self.assertEqual(\n                getattr(returned, attr),\n                ref[attr],\n                \u0027Expected different %s\u0027 % attr)","accounts_in_message":[],"_revision_number":4},{"id":"930320f029d7e79f1b5d117a294e408474bc6e8f","author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"date":"2014-01-10 14:19:27.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nI agree.  Where a property is added to the new_ref it is expected to be found in the requests payload (unless specifially excluded).  I don\u0027t think any further testing is necessary.  It seems a little odd this; like testing an objet against itself, but I conducted some tests and if you fiddle with the args values in between the test initialisation and the assertions the tests will fail properly.\n\nI\u0027ve just suggested a change to the comments in domains.py and policies.py because they make claims that the client cannnot fulfil.","accounts_in_message":[],"_revision_number":4},{"id":"f177c80820586776fe03c147578142fc52a9e3c1","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-10 14:32:23.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"c3ce5900cceb80d0a25c87f593933e26f0a3034a","author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"date":"2014-01-10 15:28:02.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":5},{"id":"bede9d0dfefa3916ffc8d2e013c3b1171b9cf576","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-10 15:49:30.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/81/65381/5/check/gate-python-keystoneclient-pep8/d78c3d1 : SUCCESS in 1m 07s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/81/65381/5/check/gate-python-keystoneclient-docs/4dd32b2/doc/build/html/ : SUCCESS in 1m 21s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/81/65381/5/check/gate-python-keystoneclient-python26/5c2f3f1 : SUCCESS in 1m 16s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/81/65381/5/check/gate-python-keystoneclient-python27/7e8ddbb : SUCCESS in 1m 05s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/81/65381/5/check/gate-python-keystoneclient-python33/100da60 : FAILURE in 4m 41s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/81/65381/5/check/check-tempest-dsvm-full/c74b749 : SUCCESS in 45m 24s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/81/65381/5/check/check-tempest-dsvm-postgres-full/75c1dc9 : SUCCESS in 42m 09s\n- check-tempest-dsvm-neutron http://logs.openstack.org/81/65381/5/check/check-tempest-dsvm-neutron/92fe24e : SUCCESS in 36m 21s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/81/65381/5/check/gate-tempest-dsvm-large-ops/f7fe3d8 : SUCCESS in 11m 44s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/81/65381/5/check/gate-tempest-dsvm-neutron-large-ops/4a9fa77 : SUCCESS in 14m 24s\n- check-grenade-dsvm http://logs.openstack.org/81/65381/5/check/check-grenade-dsvm/bfd48ac : SUCCESS in 29m 34s\n","accounts_in_message":[],"_revision_number":5},{"id":"b102923cf07bc1533e04f8c12ec4375d8e7208bc","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-13 01:17:29.000000000","message":"Patch Set 5: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nSo test_list is similar to new_ref - if all the models do it you should be able to move it up to the super class and just have a new test for it. eg: http://paste.openstack.org/show/61059/ \n\nThere are problems with that test. assertQueryString isn\u0027t very good. Have a look at the changes in https://review.openstack.org/#/c/65728 and my comment there on a way to fix this up.","accounts_in_message":[],"_revision_number":5},{"id":"6e9b18897d03b84a122d4716e20008d76a9e92bc","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-13 01:18:14.000000000","message":"Patch Set 5: (3 inline comments)\n\nnits","accounts_in_message":[],"_revision_number":5},{"id":"4b9ebb0ddaee8f16b5b72b7970ebf71219b6b988","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-13 11:06:05.000000000","message":"Patch Set 5:\n\nI moved the method test_list to base class.\nBut the test failed for TrustManager\n\nPlease check following links\n\nDiff:\nhttp://paste.openstack.org/show/61089/\n\nError:\nhttp://paste.openstack.org/show/61090/","accounts_in_message":[],"_revision_number":5},{"id":"6b85c73b2cfccce91cf9fdb24597b5ed31d188ec","author":{"_account_id":901,"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","username":"divyesh-khandeshi"},"date":"2014-01-13 16:06:28.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"a2c4f8c1a9680f9cb7ef505413abb13e41d6cc29","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2014-01-13 16:06:38.000000000","message":"Patch Set 6:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":6},{"id":"07d63c3930b73381aa759ac8ab1a36773a5ef385","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-13 17:33:56.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/81/65381/6/check/gate-python-keystoneclient-pep8/e2c8b5d : SUCCESS in 1m 23s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/81/65381/6/check/gate-python-keystoneclient-docs/5779cd5/doc/build/html/ : SUCCESS in 52s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/81/65381/6/check/gate-python-keystoneclient-python26/bb3ce97 : SUCCESS in 1m 06s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/81/65381/6/check/gate-python-keystoneclient-python27/3d2738b : SUCCESS in 1m 25s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/81/65381/6/check/gate-python-keystoneclient-python33/31a2814 : FAILURE in 4m 42s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/81/65381/6/check/check-tempest-dsvm-full/d8e3eb1 : SUCCESS in 49m 27s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/81/65381/6/check/check-tempest-dsvm-postgres-full/58876d1 : SUCCESS in 1h 12m 24s\n- check-tempest-dsvm-neutron http://logs.openstack.org/81/65381/6/check/check-tempest-dsvm-neutron/12156f6 : SUCCESS in 37m 16s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/81/65381/6/check/gate-tempest-dsvm-large-ops/69209bb : SUCCESS in 11m 09s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/81/65381/6/check/gate-tempest-dsvm-neutron-large-ops/4d3e7d6 : SUCCESS in 14m 21s\n- check-grenade-dsvm http://logs.openstack.org/81/65381/6/check/check-grenade-dsvm/07735b8 : SUCCESS in 39m 28s\n","accounts_in_message":[],"_revision_number":6},{"id":"441d809306c213564115e5e443e2dc1d209179fd","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-13 18:10:57.000000000","message":"Patch Set 6:\n\nNote, Test failed for TrustManager when I moved the method \u0027test_list\u0027 to the base class CrudTest, So I think, we should remove **kwargs from the method \"list\" of TrustManager.","accounts_in_message":[],"_revision_number":6},{"id":"a5b27511106b9d6baed867c1b11aab6ec5c8321b","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2014-01-13 18:37:46.000000000","message":"Patch Set 6: I would prefer that you didn\u0027t merge this\n\nSounds like the test failure from the last comment should be addressed before merging","accounts_in_message":[],"_revision_number":6},{"id":"9ad2e397fa37a2ceac4cc3d73ebf7446c039b935","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-13 19:00:56.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"bf64ce13907217970a9e2f6692d3c911ab152326","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2014-01-13 19:18:19.000000000","message":"Patch Set 7: I would prefer that you didn\u0027t merge this\n\nno tests for update()?","accounts_in_message":[],"_revision_number":7},{"id":"8a84d32e5fc6dc6b88c23bff165699aa06c6ca75","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-13 19:28:42.000000000","message":"Patch Set 7:\n\n@guang-yee\nTest for create and update are there in the base class CrudTests.\nsee keystoneclient/tests/v3/utils.py","accounts_in_message":[],"_revision_number":7},{"id":"fff58b30e6672899287d6c7fb9bf170cfbc76f4b","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2014-01-13 19:53:56.000000000","message":"Patch Set 7: No score\n\nah, I see both create and update are using new_ref().","accounts_in_message":[],"_revision_number":7},{"id":"e84b96452da11b9461379c4cb1733097dc82760d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-13 19:59:12.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/81/65381/7/check/gate-python-keystoneclient-pep8/7ee851c : SUCCESS in 1m 13s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/81/65381/7/check/gate-python-keystoneclient-docs/1c4bbc1/doc/build/html/ : SUCCESS in 1m 27s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/81/65381/7/check/gate-python-keystoneclient-python26/9a6cb37 : SUCCESS in 1m 08s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/81/65381/7/check/gate-python-keystoneclient-python27/d7a21ed : SUCCESS in 1m 03s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/81/65381/7/check/gate-python-keystoneclient-python33/4c70d6c : FAILURE in 4m 41s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/81/65381/7/check/check-tempest-dsvm-full/8b6dcf6 : SUCCESS in 49m 44s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/81/65381/7/check/check-tempest-dsvm-postgres-full/7c53e57 : SUCCESS in 51m 54s\n- check-tempest-dsvm-neutron http://logs.openstack.org/81/65381/7/check/check-tempest-dsvm-neutron/b0474f8 : SUCCESS in 38m 53s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/81/65381/7/check/gate-tempest-dsvm-large-ops/55e0526 : SUCCESS in 12m 27s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/81/65381/7/check/gate-tempest-dsvm-neutron-large-ops/95e90ee : SUCCESS in 19m 54s\n- check-grenade-dsvm http://logs.openstack.org/81/65381/7/check/check-grenade-dsvm/db626ab : SUCCESS in 33m 01s\n","accounts_in_message":[],"_revision_number":7},{"id":"b62b11bca2ca488089eb1cac2a08c2fd0ac2c9cb","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-14 03:45:08.000000000","message":"Patch Set 7: I would prefer that you didn\u0027t merge this\n\nOk, so that error would imply that trust manager is not correctly handling listing then. And looking it doesn\u0027t. \n\nMy additions: http://paste.openstack.org/show/61158/\n\nSquashing that patch on top of this works for me and tests all the managers simultaneously. It does however replicate a whole lot of work done by steve hardy.","accounts_in_message":[],"_revision_number":7},{"id":"c259b93609eed9f5ad33fe5aabfb79946377950f","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-14 03:47:44.000000000","message":"Patch Set 7:\n\nAlso make sure to rebase for the next patch.","accounts_in_message":[],"_revision_number":7},{"id":"a987458ad2c14e34c9b2f85c75ce7b38440fad19","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-15 12:42:59.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"ec4fce38d97766f183c2bdc6efc67edf6175427c","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-15 12:44:46.000000000","message":"Patch Set 8:\n\ndone rebase","accounts_in_message":[],"_revision_number":8},{"id":"5ac27a0d2ef440e6e7bfa56a17784c5b600ee5f6","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-15 12:46:02.000000000","message":"Patch Set 8:\n\nremoved **kwargs from trust list.\nand done rebase","accounts_in_message":[],"_revision_number":8},{"id":"b880f8ed139efec174876d5a1ad695ca1cfdd248","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-15 14:02:39.000000000","message":"Patch Set 8: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/81/65381/8/check/gate-python-keystoneclient-pep8/e012877 : SUCCESS in 1m 21s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/81/65381/8/check/gate-python-keystoneclient-docs/003dfa6/doc/build/html/ : SUCCESS in 1m 14s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/81/65381/8/check/gate-python-keystoneclient-python26/feb7ae9 : SUCCESS in 1m 09s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/81/65381/8/check/gate-python-keystoneclient-python27/f348ae8 : SUCCESS in 57s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/81/65381/8/check/gate-python-keystoneclient-python33/024a3b3 : FAILURE in 4m 43s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/81/65381/8/check/check-tempest-dsvm-full/fc7247f : SUCCESS in 47m 15s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/81/65381/8/check/check-tempest-dsvm-postgres-full/2a608cc : FAILURE in 47m 33s\n- check-tempest-dsvm-neutron http://logs.openstack.org/81/65381/8/check/check-tempest-dsvm-neutron/bee547a : SUCCESS in 36m 40s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/81/65381/8/check/gate-tempest-dsvm-large-ops/37e5027 : SUCCESS in 13m 31s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/81/65381/8/check/gate-tempest-dsvm-neutron-large-ops/51e3043 : SUCCESS in 13m 40s\n- check-grenade-dsvm http://logs.openstack.org/81/65381/8/check/check-grenade-dsvm/4d3af33 : SUCCESS in 34m 35s\n","accounts_in_message":[],"_revision_number":8},{"id":"44a06349b943378ba417c1c60296741c0512cdb0","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-15 21:21:00.000000000","message":"Patch Set 8:\n\nRebased","accounts_in_message":[],"_revision_number":8},{"id":"ee9a96d206b0f0662222556e8e783cb4e26e1054","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-15 21:26:56.000000000","message":"Patch Set 8:\n\nrecheck bug 1269284","accounts_in_message":[],"_revision_number":8},{"id":"1eacb1914573291e5de60324f577d5c34be5eb7c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-15 23:09:58.000000000","message":"Patch Set 8: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/81/65381/8/check/gate-python-keystoneclient-pep8/1deb8c4 : SUCCESS in 55s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/81/65381/8/check/gate-python-keystoneclient-docs/f931a8c/doc/build/html/ : SUCCESS in 1m 06s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/81/65381/8/check/gate-python-keystoneclient-python26/42bdc41 : SUCCESS in 1m 12s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/81/65381/8/check/gate-python-keystoneclient-python27/ebd31e3 : SUCCESS in 1m 02s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/81/65381/8/check/gate-python-keystoneclient-python33/b0ad182 : FAILURE in 4m 46s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/81/65381/8/check/check-tempest-dsvm-full/15c337f : SUCCESS in 56m 05s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/81/65381/8/check/check-tempest-dsvm-postgres-full/3b6cebb : SUCCESS in 49m 53s\n- check-tempest-dsvm-neutron http://logs.openstack.org/81/65381/8/check/check-tempest-dsvm-neutron/bcf1168 : SUCCESS in 50m 08s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/81/65381/8/check/gate-tempest-dsvm-large-ops/bb10bb1 : SUCCESS in 16m 12s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/81/65381/8/check/gate-tempest-dsvm-neutron-large-ops/85b8364 : SUCCESS in 12m 42s\n- check-grenade-dsvm http://logs.openstack.org/81/65381/8/check/check-grenade-dsvm/0d9377a : SUCCESS in 32m 08s\n","accounts_in_message":[],"_revision_number":8},{"id":"3f669d35a7a4a78487b38d67c46fef2bf80f37f6","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-15 23:51:37.000000000","message":"Patch Set 8: I would prefer that you didn\u0027t merge this\n\nYou still missed trusts.list then you can get rid of all the list tests in favour of one generic test. (see patch)","accounts_in_message":[],"_revision_number":8},{"id":"ad57ec8335e3ac4bd42b1118c0bc2047742e23ed","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-16 09:07:45.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"31db888d49c79da4697389d98130a77ec0aab4a3","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-16 09:09:54.000000000","message":"Patch Set 9:\n\nDone changes and rebased","accounts_in_message":[],"_revision_number":9},{"id":"001751202a6b9474e3df5224b18c667bafac343a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-16 12:51:05.000000000","message":"Patch Set 9: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/81/65381/9/check/gate-python-keystoneclient-pep8/d2997e0 : SUCCESS in 45s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/81/65381/9/check/gate-python-keystoneclient-docs/7bf6df3/doc/build/html/ : SUCCESS in 45s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/81/65381/9/check/gate-python-keystoneclient-python26/d392e7b : SUCCESS in 1m 17s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/81/65381/9/check/gate-python-keystoneclient-python27/98b78bd : SUCCESS in 57s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/81/65381/9/check/gate-python-keystoneclient-python33/7ccbbfa : FAILURE in 4m 45s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/81/65381/9/check/check-tempest-dsvm-full/f56dc5c : SUCCESS in 54m 36s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/81/65381/9/check/check-tempest-dsvm-postgres-full/d68d6ee : SUCCESS in 51m 46s\n- check-tempest-dsvm-neutron http://logs.openstack.org/81/65381/9/check/check-tempest-dsvm-neutron/76c1890 : SUCCESS in 39m 26s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/81/65381/9/check/gate-tempest-dsvm-large-ops/b27a172 : SUCCESS in 13m 24s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/81/65381/9/check/gate-tempest-dsvm-neutron-large-ops/ba5b7e6 : SUCCESS in 17m 56s\n- check-grenade-dsvm http://logs.openstack.org/81/65381/9/check/check-grenade-dsvm/822e00d : SUCCESS in 34m 01s\n","accounts_in_message":[],"_revision_number":9},{"id":"91eb48875c05907a780b987e45b1e4a4ae936e98","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-17 00:57:47.000000000","message":"Patch Set 9: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\nA lot of methods become redundant here - but i think it\u0027s best to leave them for now and clean up as a seperate patch.\n\nI\u0027m doing +1 as i had so much of a hand in guiding it i don\u0027t think i should +2.","accounts_in_message":[],"_revision_number":9},{"id":"f878b27a1f4e7988a74a24f6c19e0022bdd02e6e","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-21 17:41:22.000000000","message":"Patch Set 9: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":9},{"id":"0ef8197b805d8c316cc71bc77c566446870c3dcc","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-21 19:19:28.000000000","message":"Patch Set 9: No score\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":9},{"id":"c9e3ce7c8a24d84fd0f0df23b875ca91b216dd82","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-22 12:39:36.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"15d01272ddb1b385381066a621eceb697dead60e","author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"date":"2014-01-22 12:41:38.000000000","message":"Patch Set 10:\n\n* Fixed the issues in the file keystoneclient/v3/contrib/trusts.py\n*Also done rebase","accounts_in_message":[],"_revision_number":10},{"id":"d9aab596492869fb4c3e3817dbcd5a6c3f7c71aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-22 16:36:29.000000000","message":"Patch Set 10: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/81/65381/10/check/gate-python-keystoneclient-pep8/188b43f : SUCCESS in 1m 12s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/81/65381/10/check/gate-python-keystoneclient-docs/22a77c2/doc/build/html/ : SUCCESS in 59s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/81/65381/10/check/gate-python-keystoneclient-python26/1486560 : SUCCESS in 1m 07s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/81/65381/10/check/gate-python-keystoneclient-python27/6082dbe : SUCCESS in 1m 00s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/81/65381/10/check/gate-python-keystoneclient-python33/ed8c9ec : FAILURE in 4m 42s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/81/65381/10/check/check-tempest-dsvm-full/f88ff4c : FAILURE in 58m 22s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/81/65381/10/check/check-tempest-dsvm-postgres-full/8a52a1f : SUCCESS in 57m 05s\n- check-tempest-dsvm-neutron http://logs.openstack.org/81/65381/10/check/check-tempest-dsvm-neutron/e5ecd5d : SUCCESS in 32m 01s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/81/65381/10/check/gate-tempest-dsvm-large-ops/e1631b4 : SUCCESS in 13m 11s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/81/65381/10/check/gate-tempest-dsvm-neutron-large-ops/4f43e4c : SUCCESS in 14m 15s\n- check-grenade-dsvm http://logs.openstack.org/81/65381/10/check/check-grenade-dsvm/67ebc3e : SUCCESS in 33m 41s\n","accounts_in_message":[],"_revision_number":10},{"id":"9cf129792b356b00bd3ad9232cce1e1aee53cf1d","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-22 16:37:06.000000000","message":"Patch Set 10:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1254872\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1254872\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1254872","accounts_in_message":[],"_revision_number":10},{"id":"8a1c5746991004bcaa0234a5f01a778783ccaae3","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2014-01-23 18:08:23.000000000","message":"Patch Set 10:\n\nrecheck bug 1254872","accounts_in_message":[],"_revision_number":10},{"id":"74a165848e1c9e2e9d0589f14cb42e821d608b2c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-23 19:25:32.000000000","message":"Patch Set 10: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/81/65381/10/check/gate-python-keystoneclient-pep8/1504ff1 : SUCCESS in 1m 11s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/81/65381/10/check/gate-python-keystoneclient-docs/470b75c/doc/build/html/ : SUCCESS in 1m 13s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/81/65381/10/check/gate-python-keystoneclient-python26/a906dc4 : SUCCESS in 1m 13s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/81/65381/10/check/gate-python-keystoneclient-python27/08e60b7 : SUCCESS in 59s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/81/65381/10/check/gate-python-keystoneclient-python33/fec2f3f : FAILURE in 4m 45s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/81/65381/10/check/check-tempest-dsvm-full/49708db : SUCCESS in 1h 04m 47s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/81/65381/10/check/check-tempest-dsvm-postgres-full/7c06568 : SUCCESS in 1h 03m 00s\n- check-tempest-dsvm-neutron http://logs.openstack.org/81/65381/10/check/check-tempest-dsvm-neutron/e770aff : SUCCESS in 32m 31s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/81/65381/10/check/gate-tempest-dsvm-large-ops/21a2824 : SUCCESS in 12m 57s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/81/65381/10/check/gate-tempest-dsvm-neutron-large-ops/318d55c : SUCCESS in 13m 07s\n- check-grenade-dsvm http://logs.openstack.org/81/65381/10/check/check-grenade-dsvm/f1f7648 : SUCCESS in 36m 29s\n","accounts_in_message":[],"_revision_number":10},{"id":"2ca2d980b59581f91c6a3b994f7811b256b9e31a","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2014-01-23 21:58:19.000000000","message":"Patch Set 10: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":10},{"id":"471d8ee600f3bd5401f84d41d53fde6d16f90e2c","author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"date":"2014-01-23 22:30:09.000000000","message":"Patch Set 10: Looks good to me, but someone else must approve\n\nThis is a manageable approach, and the code looks good.","accounts_in_message":[],"_revision_number":10},{"id":"2f8ac941a8939647beb7f45bacb5d5365779e187","author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"date":"2014-01-24 06:20:51.000000000","message":"Patch Set 10: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":10},{"id":"f55aea6b8a54dbecdcb44dd1790699a42e2dcb8c","author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"date":"2014-01-24 15:08:53.000000000","message":"Patch Set 10: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":10},{"id":"bb611db5857df3b1782ebb40518d440dda146e66","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-24 15:39:03.000000000","message":"Patch Set 10: Looks good to me, but someone else must approve\n\nLooks good, and my trusts.list issue from the previous patch has been addressed.","accounts_in_message":[],"_revision_number":10},{"id":"6f0237a043013fd1c9a4bfdc03c63a4afeed46bd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-28 00:06:34.000000000","message":"Patch Set 10: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":10},{"id":"4b969d69916493b00d28dc7ecdbe04a677936467","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-28 00:06:34.000000000","message":"Patch Set 10: Looks good to me (core reviewer); Approved\n\nGood work guys.","accounts_in_message":[],"_revision_number":10},{"id":"d071dc1a6570818ba08a1517611e846f7231ed45","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-28 02:02:53.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":10},{"id":"67df83485e16ee2a545e88784236e987911f0ad4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-28 02:02:53.000000000","message":"Patch Set 10: Verified\n\nBuild succeeded.\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/81/65381/10/gate/gate-python-keystoneclient-docs/f980f04/doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/81/65381/10/gate/gate-python-keystoneclient-pep8/15fdec0 : SUCCESS in 1m 10s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/81/65381/10/gate/gate-python-keystoneclient-python26/8b32067 : SUCCESS in 1m 16s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/81/65381/10/gate/gate-python-keystoneclient-python27/d889c52 : SUCCESS in 43s\n- gate-tempest-dsvm-full http://logs.openstack.org/81/65381/10/gate/gate-tempest-dsvm-full/8c507d8 : SUCCESS in 57m 21s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/81/65381/10/gate/gate-tempest-dsvm-postgres-full/8549bdb : SUCCESS in 58m 12s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/81/65381/10/gate/gate-tempest-dsvm-neutron/d56ca97 : SUCCESS in 28m 59s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/81/65381/10/gate/gate-tempest-dsvm-large-ops/431eb19 : SUCCESS in 11m 43s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/81/65381/10/gate/gate-tempest-dsvm-neutron-large-ops/d46162d : SUCCESS in 11m 43s\n- gate-grenade-dsvm http://logs.openstack.org/81/65381/10/gate/gate-grenade-dsvm/009d3aa : SUCCESS in 30m 24s\n","accounts_in_message":[],"_revision_number":10}],"current_revision_number":10,"current_revision":"6cb1cd8c5a334406027c8859ba9b5a3abc07cca7","revisions":{"46f3ef00dbe744c72e001e453d2d52a06677594c":{"kind":"REWORK","_number":1,"created":"2014-01-07 21:48:07.000000000","uploader":{"_account_id":901,"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","username":"divyesh-khandeshi"},"ref":"refs/changes/81/65381/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/81/65381/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/1"}}},"commit":{"parents":[{"commit":"8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6","subject":"Merge \"v3 test utils, don\u0027t modify input parameter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6"}]}],"author":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-07 21:41:17.000000000","tz":-300},"committer":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-07 21:47:56.000000000","tz":-300},"subject":"Consistently support kwargs across all v3 CRUD Manager ops","message":"Consistently support kwargs across all v3 CRUD Manager ops\n\nImplements: extensible-crud-manager-operations\n\nChange-Id: I64e11bcf3797eb84e4695605daea9749259d78ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/46f3ef00dbe744c72e001e453d2d52a06677594c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/46f3ef00dbe744c72e001e453d2d52a06677594c"}]},"branch":"refs/heads/master"},"b606e9bb19bf9f2208bdac15353f8f1abd461cf9":{"kind":"REWORK","_number":2,"created":"2014-01-08 15:01:34.000000000","uploader":{"_account_id":901,"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","username":"divyesh-khandeshi"},"ref":"refs/changes/81/65381/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/81/65381/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/2"}}},"commit":{"parents":[{"commit":"8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6","subject":"Merge \"v3 test utils, don\u0027t modify input parameter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6"}]}],"author":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-07 21:41:17.000000000","tz":-300},"committer":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-08 15:01:14.000000000","tz":-300},"subject":"Consistently support kwargs across all v3 CRUD Manager ops","message":"Consistently support kwargs across all v3 CRUD Manager ops\n\nImplements: extensible-crud-manager-operations\n\nChange-Id: I64e11bcf3797eb84e4695605daea9749259d78ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b606e9bb19bf9f2208bdac15353f8f1abd461cf9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b606e9bb19bf9f2208bdac15353f8f1abd461cf9"}]},"branch":"refs/heads/master"},"d47f26378608a629df33f8472e02272381ae1b23":{"kind":"REWORK","_number":3,"created":"2014-01-09 14:48:36.000000000","uploader":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"ref":"refs/changes/81/65381/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/81/65381/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/3"}}},"commit":{"parents":[{"commit":"8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6","subject":"Merge \"v3 test utils, don\u0027t modify input parameter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6"}]}],"author":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-07 21:41:17.000000000","tz":-300},"committer":{"name":"Saju Madhavan","email":"sajuptpm@gmail.com","date":"2014-01-09 14:46:31.000000000","tz":330},"subject":"Consistently support kwargs across all v3 CRUD Manager ops","message":"Consistently support kwargs across all v3 CRUD Manager ops\n\nImplements: extensible-crud-manager-operations\n\nChange-Id: I64e11bcf3797eb84e4695605daea9749259d78ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d47f26378608a629df33f8472e02272381ae1b23"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d47f26378608a629df33f8472e02272381ae1b23"}]},"branch":"refs/heads/master"},"207c4ffb0d5a1322dee17aaa73f79fac28a0f7e0":{"kind":"REWORK","_number":4,"created":"2014-01-10 13:51:27.000000000","uploader":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"ref":"refs/changes/81/65381/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/81/65381/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/4"}}},"commit":{"parents":[{"commit":"8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6","subject":"Merge \"v3 test utils, don\u0027t modify input parameter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6"}]}],"author":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-07 21:41:17.000000000","tz":-300},"committer":{"name":"Saju Madhavan","email":"sajuptpm@gmail.com","date":"2014-01-10 13:49:28.000000000","tz":330},"subject":"Consistently support kwargs across all v3 CRUD Manager ops","message":"Consistently support kwargs across all v3 CRUD Manager ops\n\nCo-Authored-By: Saju Madhavan \u003csajuptpm@gmail.com\u003e\n\nCloses-Bug: 1047867\n\nImplements: extensible-crud-manager-operations\n\nChange-Id: I64e11bcf3797eb84e4695605daea9749259d78ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/207c4ffb0d5a1322dee17aaa73f79fac28a0f7e0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/207c4ffb0d5a1322dee17aaa73f79fac28a0f7e0"}]},"branch":"refs/heads/master"},"71e1e55a4a8e4cae62f46e5d4caa64eed53191b8":{"kind":"REWORK","_number":5,"created":"2014-01-10 14:32:23.000000000","uploader":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"ref":"refs/changes/81/65381/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/81/65381/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/5"}}},"commit":{"parents":[{"commit":"8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6","subject":"Merge \"v3 test utils, don\u0027t modify input parameter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6"}]}],"author":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-07 21:41:17.000000000","tz":-300},"committer":{"name":"Saju Madhavan","email":"sajuptpm@gmail.com","date":"2014-01-10 14:32:04.000000000","tz":330},"subject":"Consistently support kwargs across all v3 CRUD Manager ops","message":"Consistently support kwargs across all v3 CRUD Manager ops\n\nCo-Authored-By: Saju Madhavan \u003csajuptpm@gmail.com\u003e\n\nCloses-Bug: 1047867\n\nImplements: extensible-crud-manager-operations\n\nChange-Id: I64e11bcf3797eb84e4695605daea9749259d78ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/71e1e55a4a8e4cae62f46e5d4caa64eed53191b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/71e1e55a4a8e4cae62f46e5d4caa64eed53191b8"}]},"branch":"refs/heads/master"},"1d82769a0711180af26f10cc0bcb12bf606d698e":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2014-01-13 16:06:28.000000000","uploader":{"_account_id":901,"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","username":"divyesh-khandeshi"},"ref":"refs/changes/81/65381/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/81/65381/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/6"}}},"commit":{"parents":[{"commit":"8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6","subject":"Merge \"v3 test utils, don\u0027t modify input parameter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6"}]}],"author":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-07 21:41:17.000000000","tz":-300},"committer":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-13 16:04:32.000000000","tz":-300},"subject":"Consistently support kwargs across all v3 CRUD Manager ops","message":"Consistently support kwargs across all v3 CRUD Manager ops\n\nCo-Authored-By: Saju Madhavan \u003csajuptpm@gmail.com\u003e\nCloses-Bug: 1047867\nImplements: blueprint extensible-crud-manager-operations\nChange-Id: I64e11bcf3797eb84e4695605daea9749259d78ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1d82769a0711180af26f10cc0bcb12bf606d698e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1d82769a0711180af26f10cc0bcb12bf606d698e"}]},"branch":"refs/heads/master"},"d3ae1a23bf1d050e3bc718f11a0af8ac23c10b81":{"kind":"REWORK","_number":7,"created":"2014-01-13 19:00:56.000000000","uploader":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"ref":"refs/changes/81/65381/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/81/65381/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/7"}}},"commit":{"parents":[{"commit":"8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6","subject":"Merge \"v3 test utils, don\u0027t modify input parameter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6"}]}],"author":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-07 21:41:17.000000000","tz":-300},"committer":{"name":"Saju Madhavan","email":"sajuptpm@gmail.com","date":"2014-01-13 19:00:22.000000000","tz":330},"subject":"Consistently support kwargs across all v3 CRUD Manager ops","message":"Consistently support kwargs across all v3 CRUD Manager ops\n\nCo-Authored-By: Saju Madhavan \u003csajuptpm@gmail.com\u003e\nCloses-Bug: 1047867\nImplements: blueprint extensible-crud-manager-operations\nChange-Id: I64e11bcf3797eb84e4695605daea9749259d78ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d3ae1a23bf1d050e3bc718f11a0af8ac23c10b81"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d3ae1a23bf1d050e3bc718f11a0af8ac23c10b81"}]},"branch":"refs/heads/master"},"169e92b70a6eeea89c8b8e1da3a0418cb257b77a":{"kind":"REWORK","_number":8,"created":"2014-01-15 12:42:59.000000000","uploader":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"ref":"refs/changes/81/65381/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/81/65381/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/8"}}},"commit":{"parents":[{"commit":"8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6","subject":"Merge \"v3 test utils, don\u0027t modify input parameter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8c73dd2e49f5b4322f5dc372e4715a8ab9480ee6"}]}],"author":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-07 21:41:17.000000000","tz":-300},"committer":{"name":"Saju Madhavan","email":"sajuptpm@gmail.com","date":"2014-01-15 12:42:13.000000000","tz":330},"subject":"Consistently support kwargs across all v3 CRUD Manager ops","message":"Consistently support kwargs across all v3 CRUD Manager ops\n\nCo-Authored-By: Saju Madhavan \u003csajuptpm@gmail.com\u003e\nCloses-Bug: 1047867\nImplements: blueprint extensible-crud-manager-operations\nChange-Id: I64e11bcf3797eb84e4695605daea9749259d78ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/169e92b70a6eeea89c8b8e1da3a0418cb257b77a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/169e92b70a6eeea89c8b8e1da3a0418cb257b77a"}]},"branch":"refs/heads/master"},"442a89fae398982fbdfb9322f1e9be4085ed6ff3":{"kind":"REWORK","_number":9,"created":"2014-01-16 09:07:45.000000000","uploader":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"ref":"refs/changes/81/65381/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/81/65381/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/9"}}},"commit":{"parents":[{"commit":"8a118718c70c9f32ad155d9f5a0a86f233c7b063","subject":"Merge \"Fix incorrect assertTrue usage\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8a118718c70c9f32ad155d9f5a0a86f233c7b063"}]}],"author":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-07 21:41:17.000000000","tz":-300},"committer":{"name":"Saju Madhavan","email":"sajuptpm@gmail.com","date":"2014-01-16 09:06:05.000000000","tz":330},"subject":"Consistently support kwargs across all v3 CRUD Manager ops","message":"Consistently support kwargs across all v3 CRUD Manager ops\n\nCo-Authored-By: Saju Madhavan \u003csajuptpm@gmail.com\u003e\nCloses-Bug: 1047867\nImplements: blueprint extensible-crud-manager-operations\nChange-Id: I64e11bcf3797eb84e4695605daea9749259d78ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/442a89fae398982fbdfb9322f1e9be4085ed6ff3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/442a89fae398982fbdfb9322f1e9be4085ed6ff3"}]},"branch":"refs/heads/master"},"6cb1cd8c5a334406027c8859ba9b5a3abc07cca7":{"kind":"REWORK","_number":10,"created":"2014-01-22 12:39:36.000000000","uploader":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"ref":"refs/changes/81/65381/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/81/65381/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/81/65381/10"}}},"commit":{"parents":[{"commit":"19d0396224b5a83ef9a22b42e8292e2921136e14","subject":"Merge \"auth_token tests close temp file descriptor\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/19d0396224b5a83ef9a22b42e8292e2921136e14"}]}],"author":{"name":"Divyesh Khandeshi","email":"divyesh.khandeshi@hp.com","date":"2014-01-07 21:41:17.000000000","tz":-300},"committer":{"name":"Saju Madhavan","email":"sajuptpm@gmail.com","date":"2014-01-22 12:39:04.000000000","tz":330},"subject":"Consistently support kwargs across all v3 CRUD Manager ops","message":"Consistently support kwargs across all v3 CRUD Manager ops\n\nCo-Authored-By: Saju Madhavan \u003csajuptpm@gmail.com\u003e\nCloses-Bug: 1047867\nImplements: blueprint extensible-crud-manager-operations\nChange-Id: I64e11bcf3797eb84e4695605daea9749259d78ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6cb1cd8c5a334406027c8859ba9b5a3abc07cca7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6cb1cd8c5a334406027c8859ba9b5a3abc07cca7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}