)]}'
{"id":"openstack%2Fpython-keystoneclient~65728","triplet_id":"openstack%2Fpython-keystoneclient~master~I290b73bbbdac88487c225063fd3775ab7dd8bb89","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1267530","hashtags":[],"change_id":"I290b73bbbdac88487c225063fd3775ab7dd8bb89","subject":"Test query-string for list actions with filter arguments","status":"MERGED","created":"2014-01-09 17:13:44.000000000","updated":"2014-02-20 04:29:41.000000000","submitted":"2014-02-20 04:29:41.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"10f89fcd78314be9c0b07a1dad818483d57ce9d3","_number":65728,"virtual_id_number":65728,"owner":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-02-20 04:29:41.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-02-20 02:00:13.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2014-02-19 05:56:03.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-02-20 02:00:13.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"date":"2014-02-19 05:56:03.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-13 12:46:40.000000000","updated_by":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"reviewer":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"state":"REVIEWER"},{"updated":"2014-02-18 00:06:48.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2014-02-19 05:56:03.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2014-02-20 02:00:13.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2014-02-20 04:29:41.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"cad36ab68d2f5972766eee7c8760fd90955cbfb7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-09 18:40:20.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/28/65728/1/check/gate-python-keystoneclient-pep8/1018277 : SUCCESS in 1m 10s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/28/65728/1/check/gate-python-keystoneclient-docs/566ae3c/doc/build/html/ : SUCCESS in 50s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/28/65728/1/check/gate-python-keystoneclient-python26/8d1a6d5 : SUCCESS in 1m 06s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/28/65728/1/check/gate-python-keystoneclient-python27/64b411f : SUCCESS in 1m 13s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/28/65728/1/check/gate-python-keystoneclient-python33/72edd65 : FAILURE in 4m 39s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/28/65728/1/check/check-tempest-dsvm-full/f434d1a : SUCCESS in 44m 07s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/28/65728/1/check/check-tempest-dsvm-postgres-full/d41cf55 : SUCCESS in 49m 34s\n- check-tempest-dsvm-neutron http://logs.openstack.org/28/65728/1/check/check-tempest-dsvm-neutron/edfebf7 : SUCCESS in 39m 46s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/28/65728/1/check/gate-tempest-dsvm-large-ops/1785bb8 : FAILURE in 14m 12s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/28/65728/1/check/gate-tempest-dsvm-neutron-large-ops/8d34ae9 : SUCCESS in 15m 26s\n- check-grenade-dsvm http://logs.openstack.org/28/65728/1/check/check-grenade-dsvm/7203e45 : SUCCESS in 29m 06s\n","accounts_in_message":[],"_revision_number":1},{"id":"2e732b0c8f6e6d6f9fae725646b3a0ad0ce5ac78","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-09 18:40:54.000000000","message":"Patch Set 1:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1257626\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1257626\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1257626","accounts_in_message":[],"_revision_number":1},{"id":"4b6742445acc56435a3c541d3c915976663b910d","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-10 00:34:56.000000000","message":"Patch Set 1:\n\nrecheck bug 1257626","accounts_in_message":[],"_revision_number":1},{"id":"a9bd5ea212cf27aea124f10d8707865393193ba4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-10 02:30:06.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/28/65728/1/check/gate-python-keystoneclient-pep8/0a71c78 : SUCCESS in 1m 08s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/28/65728/1/check/gate-python-keystoneclient-docs/e83d6d1/doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/28/65728/1/check/gate-python-keystoneclient-python26/66d4dfa : SUCCESS in 52s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/28/65728/1/check/gate-python-keystoneclient-python27/8c718a1 : SUCCESS in 50s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/28/65728/1/check/gate-python-keystoneclient-python33/697fe34 : FAILURE in 4m 38s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/28/65728/1/check/check-tempest-dsvm-full/d442621 : SUCCESS in 44m 01s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/28/65728/1/check/check-tempest-dsvm-postgres-full/2d4304c : SUCCESS in 39m 58s\n- check-tempest-dsvm-neutron http://logs.openstack.org/28/65728/1/check/check-tempest-dsvm-neutron/4921f27 : SUCCESS in 35m 37s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/28/65728/1/check/gate-tempest-dsvm-large-ops/22a732d : SUCCESS in 14m 17s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/28/65728/1/check/gate-tempest-dsvm-neutron-large-ops/decfd38 : SUCCESS in 15m 29s\n- check-grenade-dsvm http://logs.openstack.org/28/65728/1/check/check-grenade-dsvm/b58cc91 : SUCCESS in 32m 06s\n","accounts_in_message":[],"_revision_number":1},{"id":"f0c308d2079ba4b8ad6bfe59ef7b4083a710261c","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-10 03:52:19.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"d719c799bedeb1ec39f45bf72f81a4413d772f36","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-10 11:18:51.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f33876bfa9e9a0888b462192ae27a211dcb8bb1d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-10 12:39:21.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/28/65728/2/check/gate-python-keystoneclient-pep8/6456e14 : SUCCESS in 59s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/28/65728/2/check/gate-python-keystoneclient-docs/7846920/doc/build/html/ : SUCCESS in 1m 15s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/28/65728/2/check/gate-python-keystoneclient-python26/cb1e1cf : SUCCESS in 1m 09s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/28/65728/2/check/gate-python-keystoneclient-python27/836b731 : SUCCESS in 1m 22s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/28/65728/2/check/gate-python-keystoneclient-python33/a86083b : FAILURE in 4m 44s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/28/65728/2/check/check-tempest-dsvm-full/49de5b0 : SUCCESS in 40m 12s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/28/65728/2/check/check-tempest-dsvm-postgres-full/f58775a : SUCCESS in 48m 30s\n- check-tempest-dsvm-neutron http://logs.openstack.org/28/65728/2/check/check-tempest-dsvm-neutron/e8a9fd8 : SUCCESS in 46m 59s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/28/65728/2/check/gate-tempest-dsvm-large-ops/6ec2286 : SUCCESS in 11m 26s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/28/65728/2/check/gate-tempest-dsvm-neutron-large-ops/f26db3e : SUCCESS in 13m 22s\n- check-grenade-dsvm http://logs.openstack.org/28/65728/2/check/check-grenade-dsvm/90c5950 : SUCCESS in 39m 45s\n","accounts_in_message":[],"_revision_number":2},{"id":"c3733bf6ae22fcc357fe125b8331d1bb08e07c2c","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-13 00:46:05.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"efb34c8dadf6d56f43126accc3ed4e72463c758d","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-13 01:17:09.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nCan you take the core of that change and instead fix the assertQueryString method (or make a new one that is similar). I\u0027m looking at another review now that would appreciate not having to deal with the list values.\n\nThat way you wouldn\u0027t need the expected_qs argument on test_list you could do that in the test_trust location where i think it makes more sense.\n\nAlso see: https://review.openstack.org/#/c/65381 for a more generic version of what you are looking at. I\u0027d be happy with taking your fix for assertQueryString and there solution (or the one i offered: http://paste.openstack.org/show/61059/ ) to list parameter checking.","accounts_in_message":[],"_revision_number":2},{"id":"4d14e6cdb47f921463fd81ece357a3dbde3c95e0","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-13 10:56:34.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e28f643252a7ab3368394ce8aaccfc3cd99b4ade","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-13 11:01:34.000000000","message":"Patch Set 3:\n\n@Jamie Lennox:  I\u0027ve done as you asked, and created https://review.openstack.org/#/c/66302/ which fixes up assertQueryStringIs to work in a more intuitive way.\n\nI have left the capability (via the original expected_path interface) to specify a non-default query-string (something which differs from the filter_kwargs) because this is required in both the trusts tests and the domain test later in this patch series.","accounts_in_message":[],"_revision_number":3},{"id":"b3ef37f678e2df2970fe97379afbe64e750f77b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-13 11:57:23.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/28/65728/3/check/gate-python-keystoneclient-pep8/8ca28ea : SUCCESS in 1m 13s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/28/65728/3/check/gate-python-keystoneclient-docs/dbed2eb/doc/build/html/ : SUCCESS in 1m 24s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/28/65728/3/check/gate-python-keystoneclient-python26/93df1b8 : SUCCESS in 1m 06s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/28/65728/3/check/gate-python-keystoneclient-python27/fede488 : SUCCESS in 1m 03s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/28/65728/3/check/gate-python-keystoneclient-python33/8b6437f : FAILURE in 4m 42s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/28/65728/3/check/check-tempest-dsvm-full/13ba2de : SUCCESS in 1h 00m 29s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/28/65728/3/check/check-tempest-dsvm-postgres-full/14b3d56 : SUCCESS in 43m 08s\n- check-tempest-dsvm-neutron http://logs.openstack.org/28/65728/3/check/check-tempest-dsvm-neutron/6cbc273 : SUCCESS in 39m 40s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/28/65728/3/check/gate-tempest-dsvm-large-ops/deb15be : SUCCESS in 12m 28s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/28/65728/3/check/gate-tempest-dsvm-neutron-large-ops/716a1df : SUCCESS in 16m 23s\n- check-grenade-dsvm http://logs.openstack.org/28/65728/3/check/check-grenade-dsvm/9d5b1e8 : SUCCESS in 27m 36s\n","accounts_in_message":[],"_revision_number":3},{"id":"9ddb6d9457038926bea8e5ee21def25b6be80e92","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2014-01-13 19:55:11.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"36f1e020813b9da3e79be519719f1aa298188468","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-13 21:07:36.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"07df7938b7aea6e15ade15ce95738bb396e5897d","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2014-01-13 21:07:43.000000000","message":"Patch Set 4:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":4},{"id":"4e71acc8ea7e0f96135fb46f03bc233b2a54bd2f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-13 22:31:25.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/28/65728/4/check/gate-python-keystoneclient-pep8/b99305d : SUCCESS in 49s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/28/65728/4/check/gate-python-keystoneclient-docs/c3c689c/doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/28/65728/4/check/gate-python-keystoneclient-python26/653f31b : SUCCESS in 1m 02s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/28/65728/4/check/gate-python-keystoneclient-python27/1bc3f01 : SUCCESS in 1m 11s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/28/65728/4/check/gate-python-keystoneclient-python33/27070f9 : FAILURE in 4m 42s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/28/65728/4/check/check-tempest-dsvm-full/99a956d : SUCCESS in 1h 08m 45s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/28/65728/4/check/check-tempest-dsvm-postgres-full/2ef9868 : SUCCESS in 1h 23m 40s\n- check-tempest-dsvm-neutron http://logs.openstack.org/28/65728/4/check/check-tempest-dsvm-neutron/1c88a7b : SUCCESS in 37m 09s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/28/65728/4/check/gate-tempest-dsvm-large-ops/3817d82 : SUCCESS in 11m 53s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/28/65728/4/check/gate-tempest-dsvm-neutron-large-ops/5c4a1dd : SUCCESS in 13m 49s\n- check-grenade-dsvm http://logs.openstack.org/28/65728/4/check/check-grenade-dsvm/6519f2c : SUCCESS in 33m 56s\n","accounts_in_message":[],"_revision_number":4},{"id":"c5c389a714dc3d1bab702b2bb3e0a1b3798ee6e8","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-14 03:47:27.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\nSo this whole chain will be fixed by: https://review.openstack.org/#/c/65381/\n\nI\u0027m -1 this in favour of that as it tests across all resource\u0027s list methods.","accounts_in_message":[],"_revision_number":4},{"id":"410b71558349d1b908d4c567d7f4e80b1352d47a","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-14 08:20:13.000000000","message":"Patch Set 4:\n\n\u003e So this whole chain will be fixed by: https://review.openstack.org/#/c/65381/\nI\u0027m -1 this in favour of that as it tests across all resource\u0027s list methods.\n\nWTF?  Why didn\u0027t you say that in your review on the 13th, instead of wasting my time with requests for review rework related to fixing assertQueryStringIs?\n\nPoor review etiquette IMO :(","accounts_in_message":[],"_revision_number":4},{"id":"39ffdab5eac126fa5dcb2aa941e1143adc63f3cd","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-14 08:34:36.000000000","message":"Patch Set 4:\n\nAdditionally, I don\u0027t think the case where the query string differs from the controller kwargs is catered for by https://review.openstack.org/#/c/65381/, so we still need this patch, or something like it AFAICS:\n\nCheck out this: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/tests/v3/test_trusts.py#L91 (and the following test)\n\nWe pass a filter kwarg of trustor_user and the querystring is expected to be trustor_user_id, and this querystring is currently untested - I don\u0027t see how the patch you referenced addresses that at all.\n\nAlso check out this patch further in my series https://review.openstack.org/#/c/65730/4/keystoneclient/tests/v3/test_domains.py\n\nIn that case, we have to convert enabled\u003dFalse into enabled\u003d0, or keystoneclient will return the wrong results with any keystone not containing the (yet to be merged) https://review.openstack.org/#/c/65725/ fix for bug #1267530\n\nPing me on IRC and we can discuss, but I don\u0027t see why we can\u0027t merge both my patches and the one you references, because they address different problems AFAICT.","accounts_in_message":[],"_revision_number":4},{"id":"dd6ab7519dfff25e00cc8ad470ace64f24578a2b","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-01-16 00:54:33.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"83d32c0f8b9aa7b0105e3b853c6c714d6fb02339","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-01-16 01:09:09.000000000","message":"Patch Set 4:\n\nI agree with Steven\u0027s analysis here that this is being used to test something different than the other review for extra args to functions.","accounts_in_message":[],"_revision_number":4},{"id":"663b000bd6d5c38068e4f32da8a5c6f0b342b2e9","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-16 05:50:41.000000000","message":"Patch Set 4:\n\n@Brant: Agreed, we talked about it on IRC the other day and steven is correct. We discussed though rebasing it on https://review.openstack.org/#/c/65381/ when it is ready as there is some overlap.","accounts_in_message":[],"_revision_number":4},{"id":"80bad274ff4ccf1ad8d4a535670fd1fd35342141","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-16 23:50:01.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"8c0da37250cae3b031e448b1845d2cfbbcdc0849","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-01-16 23:56:41.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"a62b8809808c35de1ce0f26793ba397cc9e3af3f","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-17 08:38:31.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"0a0e3d3c0871d79427efe8623a0e6870b408e577","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-01-17 21:28:40.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"181eb1119a5eda0f14d77b62b4667299efdeb7a9","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-01-17 21:40:13.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"97be86a648ae84eea9c263681c5d0fe6e59d12b5","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-25 06:03:08.000000000","message":"Patch Set 4:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":4},{"id":"ad5525d86f19d3595d1755286d107ed509a08669","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-25 06:03:08.000000000","message":"Patch Set 4: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":4},{"id":"0627b8fc5bf6f98f42b8f1424c9be3c224bb55fb","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-02-16 07:54:31.000000000","message":"Patch Set 4: Restored\n\nrestoring","accounts_in_message":[],"_revision_number":4},{"id":"72e9ed4db6a212c945214a7f1123794e8647d866","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-16 07:54:33.000000000","message":"Patch Set 4: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"7b96882b4c2c2ad2175c2a9624a03c94eda6d628","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-16 07:54:34.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":4},{"id":"ae4444056ca2eef487b83f4461b49f8afce1c1c4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-16 07:54:41.000000000","message":"Patch Set 5:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"55f1d4ffbe39fcdc6e389b50ca050b20c55509c9","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-02-16 07:54:41.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"315bfe00787f7a3c8359a408ff50afbfa2e7a181","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-16 08:45:06.000000000","message":"Patch Set 5: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/28/65728/5/check/gate-python-keystoneclient-pep8/1dc19d7 : SUCCESS in 1m 05s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/28/65728/5/check/gate-python-keystoneclient-docs/dfa3635/doc/build/html/ : SUCCESS in 1m 08s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/28/65728/5/check/gate-python-keystoneclient-python26/0b7704d : SUCCESS in 1m 11s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/28/65728/5/check/gate-python-keystoneclient-python27/1b9fae4 : SUCCESS in 56s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/28/65728/5/check/gate-python-keystoneclient-python33/12f2887 : FAILURE in 4m 49s\n- check-devstack-dsvm-cells http://logs.openstack.org/28/65728/5/check/check-devstack-dsvm-cells/616b4d6 : SUCCESS in 9m 44s\n- check-tempest-dsvm-full http://logs.openstack.org/28/65728/5/check/check-tempest-dsvm-full/41b4a1a : SUCCESS in 50m 22s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/28/65728/5/check/check-tempest-dsvm-postgres-full/22622c2 : SUCCESS in 45m 12s\n- check-tempest-dsvm-neutron http://logs.openstack.org/28/65728/5/check/check-tempest-dsvm-neutron/22201ff : SUCCESS in 37m 55s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/28/65728/5/check/gate-tempest-dsvm-large-ops/e7010f3 : SUCCESS in 11m 56s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/28/65728/5/check/gate-tempest-dsvm-neutron-large-ops/d746ae1 : SUCCESS in 12m 17s\n- check-grenade-dsvm http://logs.openstack.org/28/65728/5/check/check-grenade-dsvm/a0be792 : SUCCESS in 25m 56s\n","accounts_in_message":[],"_revision_number":5},{"id":"57f9f4763c0c42cdadd99a978da003048a6f30de","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-02-17 02:34:31.000000000","message":"Patch Set 5: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"1a1ac4bdeedd761e22df8419e63beb6cd84e18da","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-02-17 11:42:01.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"bf8e5dca12175786a35676bbef6a1a0afba3936a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-17 11:42:02.000000000","message":"Patch Set 6:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"2e8f7e60918b375f670d6f668cff62a14806cc58","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-17 12:14:52.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/28/65728/6/check/gate-python-keystoneclient-pep8/20ca14f : SUCCESS in 1m 01s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/28/65728/6/check/gate-python-keystoneclient-docs/55b088b/doc/build/html/ : SUCCESS in 53s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/28/65728/6/check/gate-python-keystoneclient-python26/6f14185 : SUCCESS in 1m 07s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/28/65728/6/check/gate-python-keystoneclient-python27/6f18389 : SUCCESS in 1m 16s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/28/65728/6/check/gate-python-keystoneclient-python33/9c4eb84 : SUCCESS in 4m 52s\n- check-devstack-dsvm-cells http://logs.openstack.org/28/65728/6/check/check-devstack-dsvm-cells/95c56c2 : SUCCESS in 9m 11s\n- check-tempest-dsvm-full http://logs.openstack.org/28/65728/6/check/check-tempest-dsvm-full/082de11 : SUCCESS in 32m 47s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/28/65728/6/check/check-tempest-dsvm-postgres-full/c949961 : SUCCESS in 32m 00s\n- check-tempest-dsvm-neutron http://logs.openstack.org/28/65728/6/check/check-tempest-dsvm-neutron/763c8d4 : SUCCESS in 31m 33s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/28/65728/6/check/gate-tempest-dsvm-large-ops/da73676 : SUCCESS in 12m 49s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/28/65728/6/check/gate-tempest-dsvm-neutron-large-ops/6f72a8f : SUCCESS in 11m 39s\n- check-grenade-dsvm http://logs.openstack.org/28/65728/6/check/check-grenade-dsvm/69d627f : SUCCESS in 31m 46s\n","accounts_in_message":[],"_revision_number":6},{"id":"a445ff86d00b0ed1e698eb745952be66c7b465ae","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-02-18 00:06:48.000000000","message":"Patch Set 6: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"9f3336d055f709f98a7e4c7aa88df1933b46ee4d","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-02-18 09:55:53.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"666fb225e4679728c94a16e165a815889f11259a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-18 09:55:54.000000000","message":"Patch Set 7:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"6df69cddc50333989f2bd14b14533f3e9ada9020","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-18 11:08:45.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/28/65728/7/check/gate-python-keystoneclient-pep8/5eb5c52 : SUCCESS in 1m 19s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/28/65728/7/check/gate-python-keystoneclient-docs/2246976/doc/build/html/ : SUCCESS in 1m 13s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/28/65728/7/check/gate-python-keystoneclient-python26/704e338 : SUCCESS in 1m 43s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/28/65728/7/check/gate-python-keystoneclient-python27/ce66649 : SUCCESS in 1m 22s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/28/65728/7/check/gate-python-keystoneclient-python33/6276b62 : SUCCESS in 4m 51s\n- check-devstack-dsvm-cells http://logs.openstack.org/28/65728/7/check/check-devstack-dsvm-cells/1301ae7 : SUCCESS in 11m 27s\n- check-tempest-dsvm-full http://logs.openstack.org/28/65728/7/check/check-tempest-dsvm-full/d6f3e28 : SUCCESS in 41m 35s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/28/65728/7/check/check-tempest-dsvm-postgres-full/5b776c1 : SUCCESS in 49m 49s\n- check-tempest-dsvm-neutron http://logs.openstack.org/28/65728/7/check/check-tempest-dsvm-neutron/6191029 : SUCCESS in 30m 33s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/28/65728/7/check/gate-tempest-dsvm-large-ops/3d05d08 : SUCCESS in 15m 13s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/28/65728/7/check/gate-tempest-dsvm-neutron-large-ops/e32c9b6 : SUCCESS in 14m 00s\n- check-grenade-dsvm http://logs.openstack.org/28/65728/7/check/check-grenade-dsvm/ad439c3 : SUCCESS in 34m 56s\n","accounts_in_message":[],"_revision_number":7},{"id":"a3a05fb71a07d98a403b8bfdfac0f12e0063ffae","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-02-19 05:56:03.000000000","message":"Patch Set 7: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"0e951176072142d2e1063c23d4a4755ab2846654","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2014-02-20 02:00:13.000000000","message":"Patch Set 7: Looks good to me (core reviewer); Approved\n\nnice!","accounts_in_message":[],"_revision_number":7},{"id":"f397231249b5c2ffd978f9aefce21918a583b237","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-20 02:00:14.000000000","message":"Patch Set 7: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"989bd421b9dccd281960e4962bd75f13a0bf05e2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-20 02:52:52.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/28/65728/7/check/gate-python-keystoneclient-pep8/6fa4a84 : SUCCESS in 1m 04s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/28/65728/7/check/gate-python-keystoneclient-docs/8f17264/doc/build/html/ : SUCCESS in 1m 23s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/28/65728/7/check/gate-python-keystoneclient-python26/a6e2131 : SUCCESS in 1m 06s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/28/65728/7/check/gate-python-keystoneclient-python27/ce865bc : SUCCESS in 1m 09s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/28/65728/7/check/gate-python-keystoneclient-python33/b05583b : SUCCESS in 4m 58s\n- check-devstack-dsvm-cells http://logs.openstack.org/28/65728/7/check/check-devstack-dsvm-cells/27f0fa6 : SUCCESS in 10m 50s\n- check-tempest-dsvm-full http://logs.openstack.org/28/65728/7/check/check-tempest-dsvm-full/93996a0 : SUCCESS in 42m 28s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/28/65728/7/check/check-tempest-dsvm-postgres-full/3e051da : SUCCESS in 52m 36s\n- check-tempest-dsvm-neutron http://logs.openstack.org/28/65728/7/check/check-tempest-dsvm-neutron/192fbd4 : SUCCESS in 34m 03s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/28/65728/7/check/gate-tempest-dsvm-large-ops/d5dcb21 : SUCCESS in 15m 40s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/28/65728/7/check/gate-tempest-dsvm-neutron-large-ops/058c44f : SUCCESS in 12m 58s\n- check-grenade-dsvm http://logs.openstack.org/28/65728/7/check/check-grenade-dsvm/9b273d6 : SUCCESS in 32m 47s\n","accounts_in_message":[],"_revision_number":7},{"id":"85e5db37f3c81d4014828e5ffa241b6fd58c4495","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-20 02:52:53.000000000","message":"Patch Set 7: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"614c616334adeb045aba0643c4bb08d8f28f141f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-20 04:29:41.000000000","message":"Patch Set 7: Verified\n\nBuild succeeded.\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/28/65728/7/gate/gate-python-keystoneclient-docs/9ace4e0/doc/build/html/ : SUCCESS in 1m 15s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/28/65728/7/gate/gate-python-keystoneclient-pep8/6877a33 : SUCCESS in 1m 05s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/28/65728/7/gate/gate-python-keystoneclient-python26/0022911 : SUCCESS in 1m 18s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/28/65728/7/gate/gate-python-keystoneclient-python27/deb2f47 : SUCCESS in 1m 20s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/28/65728/7/gate/gate-python-keystoneclient-python33/636070e : SUCCESS in 4m 46s\n- gate-devstack-dsvm-cells http://logs.openstack.org/28/65728/7/gate/gate-devstack-dsvm-cells/51f9dac : SUCCESS in 9m 30s\n- gate-tempest-dsvm-full http://logs.openstack.org/28/65728/7/gate/gate-tempest-dsvm-full/4871a4b : SUCCESS in 1h 01m 08s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/28/65728/7/gate/gate-tempest-dsvm-postgres-full/a2c02ba : SUCCESS in 53m 24s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/28/65728/7/gate/gate-tempest-dsvm-neutron/b893522 : SUCCESS in 30m 14s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/28/65728/7/gate/gate-tempest-dsvm-large-ops/8b1e54c : SUCCESS in 14m 56s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/28/65728/7/gate/gate-tempest-dsvm-neutron-large-ops/2abc8a3 : SUCCESS in 13m 33s\n- gate-grenade-dsvm http://logs.openstack.org/28/65728/7/gate/gate-grenade-dsvm/f9c998a : SUCCESS in 33m 25s\n","accounts_in_message":[],"_revision_number":7},{"id":"d4865153ae92b9b6c66dc57d0b98746e25157e1b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-20 04:29:41.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"1c744bb266a9844dc56a296f88eb42e959a446e2","revisions":{"a1cbc2029c7c3b100ba5815186837ca4191b43ce":{"kind":"REWORK","_number":1,"created":"2014-01-09 17:13:44.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/28/65728/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/28/65728/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/1"}}},"commit":{"parents":[{"commit":"0b25aa7c80e1686be848b8dbde3b7a02d53b0a72","subject":"Merge \"Whitelist external netaddr requirement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0b25aa7c80e1686be848b8dbde3b7a02d53b0a72"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-01-09 15:02:19.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-01-09 17:13:27.000000000","tz":0},"subject":"Test query-string for list actions with filter arguments","message":"Test query-string for list actions with filter arguments\n\nhttpretty.register_uri only matches the path, not the query\nstring, so the test_list will pass even if the query string\npassed by the manager doesn\u0027t match that passed as part of\nexpected_path.\n\nTo solve this, we use last_request() to obtain the\nquerystring which contains a dict of the actual arguments\npassed by the manager, then assert that the request\nmatches the filter arguments, or optionally a specified\ndict of expected args.\n\nChange-Id: I290b73bbbdac88487c225063fd3775ab7dd8bb89\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a1cbc2029c7c3b100ba5815186837ca4191b43ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a1cbc2029c7c3b100ba5815186837ca4191b43ce"}]},"branch":"refs/heads/master"},"53572b5f3a98de62601d8e2626e32dc685661485":{"kind":"REWORK","_number":2,"created":"2014-01-10 11:18:51.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/28/65728/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/28/65728/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/2"}}},"commit":{"parents":[{"commit":"0b25aa7c80e1686be848b8dbde3b7a02d53b0a72","subject":"Merge \"Whitelist external netaddr requirement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0b25aa7c80e1686be848b8dbde3b7a02d53b0a72"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-01-09 15:02:19.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-01-10 11:18:37.000000000","tz":0},"subject":"Test query-string for list actions with filter arguments","message":"Test query-string for list actions with filter arguments\n\nhttpretty.register_uri only matches the path, not the query\nstring, so the test_list will pass even if the query string\npassed by the manager doesn\u0027t match that passed as part of\nexpected_path.\n\nTo solve this, we use last_request() to obtain the\nquerystring which contains a dict of the actual arguments\npassed by the manager, then assert that the request\nmatches the filter arguments, or optionally a specified\ndict of expected args.\n\nChange-Id: I290b73bbbdac88487c225063fd3775ab7dd8bb89\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/53572b5f3a98de62601d8e2626e32dc685661485"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/53572b5f3a98de62601d8e2626e32dc685661485"}]},"branch":"refs/heads/master"},"197736c7a05d7217204a634288cf07b1f0430faa":{"kind":"REWORK","_number":3,"created":"2014-01-13 10:56:34.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/28/65728/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/28/65728/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/3"}}},"commit":{"parents":[{"commit":"1619e9a44546c48bd1a2362c556753ab77871e61","subject":"Make assertQueryStringIs usage simpler","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1619e9a44546c48bd1a2362c556753ab77871e61"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-01-09 15:02:19.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-01-13 10:44:31.000000000","tz":0},"subject":"Test query-string for list actions with filter arguments","message":"Test query-string for list actions with filter arguments\n\nhttpretty.register_uri only matches the path, not the query\nstring, so the test_list will pass even if the query string\npassed by the manager doesn\u0027t match that passed as part of\nexpected_path.\n\nTo solve this, we use last_request() to obtain the\nquerystring which contains a dict of the actual arguments\npassed by the manager, then assert that the request\nmatches the filter arguments, or optionally a specified\ndict of expected args.\n\nChange-Id: I290b73bbbdac88487c225063fd3775ab7dd8bb89\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/197736c7a05d7217204a634288cf07b1f0430faa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/197736c7a05d7217204a634288cf07b1f0430faa"}]},"branch":"refs/heads/master"},"1a6ee99d24a345d8c234f8e49c6886365780eae1":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2014-01-13 21:07:36.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/28/65728/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/28/65728/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/4"}}},"commit":{"parents":[{"commit":"1619e9a44546c48bd1a2362c556753ab77871e61","subject":"Make assertQueryStringIs usage simpler","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1619e9a44546c48bd1a2362c556753ab77871e61"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-01-09 15:02:19.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-01-13 21:06:15.000000000","tz":0},"subject":"Test query-string for list actions with filter arguments","message":"Test query-string for list actions with filter arguments\n\nhttpretty.register_uri only matches the path, not the query\nstring, so the test_list will pass even if the query string\npassed by the manager doesn\u0027t match that passed as part of\nexpected_path.\n\nTo solve this, we use assertQueryStringIs to check the\nquerystring matches what is expected.\n\nChange-Id: I290b73bbbdac88487c225063fd3775ab7dd8bb89\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1a6ee99d24a345d8c234f8e49c6886365780eae1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1a6ee99d24a345d8c234f8e49c6886365780eae1"}]},"branch":"refs/heads/master"},"1e9de371e5a8223ea1db413ffe285251ae5f7df0":{"kind":"REWORK","_number":5,"created":"2014-02-16 07:54:41.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/28/65728/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/28/65728/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/5"}}},"commit":{"parents":[{"commit":"8b0c5eea3c76db63d3646d5d8ccc23461539d07e","subject":"Merge \"Using common method \u0027bool_from_string\u0027 from oslo strutils\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8b0c5eea3c76db63d3646d5d8ccc23461539d07e"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-02-15 08:55:44.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-02-16 07:51:02.000000000","tz":0},"subject":"Test query-string for list actions with filter arguments","message":"Test query-string for list actions with filter arguments\n\nhttpretty.register_uri only matches the path, not the query\nstring, so the test_list will pass even if the query string\npassed by the manager doesn\u0027t match that passed as part of\nexpected_path.\n\nSo add a test for the query component of all list requests,\nand a way to override the expected query, which is needed in\nthe trusts list filter tests where the query string doesn\u0027t\nexactly match the kwargs passed to the client API.\n\nChange-Id: I290b73bbbdac88487c225063fd3775ab7dd8bb89\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1e9de371e5a8223ea1db413ffe285251ae5f7df0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1e9de371e5a8223ea1db413ffe285251ae5f7df0"}]},"branch":"refs/heads/master"},"0f51a84e4c26e8856ec5c909d983163ee7b99fe2":{"kind":"REWORK","_number":6,"created":"2014-02-17 11:42:01.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/28/65728/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/28/65728/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/6"}}},"commit":{"parents":[{"commit":"8b0c5eea3c76db63d3646d5d8ccc23461539d07e","subject":"Merge \"Using common method \u0027bool_from_string\u0027 from oslo strutils\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8b0c5eea3c76db63d3646d5d8ccc23461539d07e"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-02-15 08:55:44.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-02-17 11:41:34.000000000","tz":0},"subject":"Test query-string for list actions with filter arguments","message":"Test query-string for list actions with filter arguments\n\nhttpretty.register_uri only matches the path, not the query\nstring, so the test_list will pass even if the query string\npassed by the manager doesn\u0027t match that passed as part of\nexpected_path.\n\nSo add a test for the query component of all list requests,\nand a way to override the expected query, which is needed in\nthe trusts list filter tests where the query string doesn\u0027t\nexactly match the kwargs passed to the client API.\n\nChange-Id: I290b73bbbdac88487c225063fd3775ab7dd8bb89\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0f51a84e4c26e8856ec5c909d983163ee7b99fe2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0f51a84e4c26e8856ec5c909d983163ee7b99fe2"}]},"branch":"refs/heads/master"},"1c744bb266a9844dc56a296f88eb42e959a446e2":{"kind":"REWORK","_number":7,"created":"2014-02-18 09:55:53.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/28/65728/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/28/65728/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/28/65728/7"}}},"commit":{"parents":[{"commit":"4917f1347a6cf4708e320e822ee523d1ee6f61f2","subject":"Merge \"Fix references to auth_token in middlewarearchitecture doc\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/4917f1347a6cf4708e320e822ee523d1ee6f61f2"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-02-15 08:55:44.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-02-18 09:55:41.000000000","tz":0},"subject":"Test query-string for list actions with filter arguments","message":"Test query-string for list actions with filter arguments\n\nhttpretty.register_uri only matches the path, not the query\nstring, so the test_list will pass even if the query string\npassed by the manager doesn\u0027t match that passed as part of\nexpected_path.\n\nSo add a test for the query component of all list requests,\nand a way to override the expected query, which is needed in\nthe trusts list filter tests where the query string doesn\u0027t\nexactly match the kwargs passed to the client API.\n\nChange-Id: I290b73bbbdac88487c225063fd3775ab7dd8bb89\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1c744bb266a9844dc56a296f88eb42e959a446e2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1c744bb266a9844dc56a296f88eb42e959a446e2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}