)]}'
{"id":"openstack%2Fpython-keystoneclient~65995","triplet_id":"openstack%2Fpython-keystoneclient~master~I99c307339ccd045a4c5b71824f3b7d91e2908154","project":"openstack/python-keystoneclient","branch":"master","topic":"role_validation_msg1","hashtags":[],"change_id":"I99c307339ccd045a4c5b71824f3b7d91e2908154","subject":"Clarify roles validation error messages","status":"MERGED","created":"2014-01-10 16:02:32.000000000","updated":"2014-01-17 15:33:25.000000000","submitted":"2014-01-17 15:33:25.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8e7a3dc521a846b87ecca4557b92dbc3f2dc1f56","_number":65995,"virtual_id_number":65995,"owner":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":994,"name":"Arvind Tiwari","email":"arvindt7@gmail.com","username":"arvind-tiwari"},{"value":2,"date":"2014-01-17 15:33:25.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"value":0,"date":"2014-01-14 18:31:08.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":994,"name":"Arvind Tiwari","email":"arvindt7@gmail.com","username":"arvind-tiwari"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-01-15 03:55:42.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"date":"2014-01-16 08:55:20.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":2,"date":"2014-01-15 06:19:03.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"all":[{"value":0,"_account_id":994,"name":"Arvind Tiwari","email":"arvindt7@gmail.com","username":"arvind-tiwari"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-01-15 03:55:42.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"date":"2014-01-14 09:09:16.000000000","_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":1,"date":"2014-01-15 06:19:03.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":994,"name":"Arvind Tiwari","email":"arvindt7@gmail.com","username":"arvind-tiwari"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-14 18:31:08.000000000","updated_by":{"_account_id":994,"name":"Arvind Tiwari","email":"arvindt7@gmail.com","username":"arvind-tiwari"},"reviewer":{"_account_id":994,"name":"Arvind Tiwari","email":"arvindt7@gmail.com","username":"arvind-tiwari"},"state":"REVIEWER"},{"updated":"2014-01-15 03:55:42.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2014-01-15 06:19:03.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2014-01-17 15:33:25.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"71f5cd5863adb7ac66432d53f1353fdd1b8b7e5c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-10 17:43:45.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/95/65995/1/check/gate-python-keystoneclient-pep8/a3744a7 : SUCCESS in 1m 05s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/95/65995/1/check/gate-python-keystoneclient-docs/10fcf2b/doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/95/65995/1/check/gate-python-keystoneclient-python26/681b071 : SUCCESS in 1m 12s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/95/65995/1/check/gate-python-keystoneclient-python27/8ea6fbd : SUCCESS in 55s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/95/65995/1/check/gate-python-keystoneclient-python33/f6bea4f : FAILURE in 4m 42s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/95/65995/1/check/check-tempest-dsvm-full/627ebed : SUCCESS in 46m 52s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/95/65995/1/check/check-tempest-dsvm-postgres-full/f40dd1d : SUCCESS in 46m 44s\n- check-tempest-dsvm-neutron http://logs.openstack.org/95/65995/1/check/check-tempest-dsvm-neutron/fa25db6 : SUCCESS in 34m 34s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/95/65995/1/check/gate-tempest-dsvm-large-ops/905684d : SUCCESS in 14m 03s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/95/65995/1/check/gate-tempest-dsvm-neutron-large-ops/3b97056 : SUCCESS in 11m 44s\n- check-grenade-dsvm http://logs.openstack.org/95/65995/1/check/check-grenade-dsvm/b8c9a92 : SUCCESS in 30m 40s\n","accounts_in_message":[],"_revision_number":1},{"id":"eb3811ba2137948f0341495f57b916283acbc7bd","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-14 04:39:14.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nthis can probably be rebased directly onto master right?","accounts_in_message":[],"_revision_number":1},{"id":"126515553b4fcfd683df8e23120a13bbb7fc3850","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-14 09:09:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bebf6601ff7f158e3fb48b13dc8c6e090615e3c0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-14 17:24:41.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/95/65995/2/check/gate-python-keystoneclient-pep8/1ed377b : SUCCESS in 41s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/95/65995/2/check/gate-python-keystoneclient-docs/bb6e120/doc/build/html/ : SUCCESS in 59s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/95/65995/2/check/gate-python-keystoneclient-python26/533e179 : SUCCESS in 1m 06s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/95/65995/2/check/gate-python-keystoneclient-python27/5770000 : SUCCESS in 47s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/95/65995/2/check/gate-python-keystoneclient-python33/787d69a : FAILURE in 4m 41s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/95/65995/2/check/check-tempest-dsvm-full/f6fbbcd : SUCCESS in 46m 58s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/95/65995/2/check/check-tempest-dsvm-postgres-full/71f0415 : SUCCESS in 56m 11s\n- check-tempest-dsvm-neutron http://logs.openstack.org/95/65995/2/check/check-tempest-dsvm-neutron/f5a8f20 : SUCCESS in 34m 47s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/95/65995/2/check/gate-tempest-dsvm-large-ops/15e2897 : SUCCESS in 12m 14s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/95/65995/2/check/gate-tempest-dsvm-neutron-large-ops/940dfb4 : SUCCESS in 13m 59s\n- check-grenade-dsvm http://logs.openstack.org/95/65995/2/check/check-grenade-dsvm/e0d67f9 : SUCCESS in 36m 50s\n","accounts_in_message":[],"_revision_number":2},{"id":"89cb11b57c9412ce10a9b6fcbe277da092c9d758","author":{"_account_id":994,"name":"Arvind Tiwari","email":"arvindt7@gmail.com","username":"arvind-tiwari"},"date":"2014-01-14 18:31:08.000000000","message":"Patch Set 2:\n\nLooks good. \n\nare we suppose to fix \ngate-python-keystoneclient-python33 FAILURE in 4m 41s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"cc480d5bf0f374d7422aa84f0d0d36b2ddd8a693","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-01-15 03:55:42.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nArvind: python3 is broken so that\u0027s not a fault of this patch","accounts_in_message":[],"_revision_number":2},{"id":"9f36a3d3b4bd049d6963ff2ed9842d5bd09056c4","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2014-01-15 06:19:03.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a95e461699144df8af589d8a0a08f450a5eac3b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-15 06:22:22.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"10ab7be9352ceb38abb4c8aa1b74d1333ed720c4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-16 02:20:36.000000000","message":"Patch Set 2: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/95/65995/2/gate/gate-python-keystoneclient-docs/b3e2f33/doc/build/html/ : SUCCESS in 1m 23s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/95/65995/2/gate/gate-python-keystoneclient-pep8/84e8b3b : SUCCESS in 1m 15s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/95/65995/2/gate/gate-python-keystoneclient-python26/6b210c3 : SUCCESS in 1m 05s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/95/65995/2/gate/gate-python-keystoneclient-python27/a337425 : SUCCESS in 59s\n- gate-tempest-dsvm-full http://logs.openstack.org/95/65995/2/gate/gate-tempest-dsvm-full/7a9f8ff : FAILURE in 1h 33m 31s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/95/65995/2/gate/gate-tempest-dsvm-postgres-full/c34c53a : SUCCESS in 46m 17s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/95/65995/2/gate/gate-tempest-dsvm-neutron/195bc21 : SUCCESS in 35m 04s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/95/65995/2/gate/gate-tempest-dsvm-large-ops/e3db5d6 : SUCCESS in 17m 08s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/95/65995/2/gate/gate-tempest-dsvm-neutron-large-ops/190ff47 : SUCCESS in 18m 17s\n- gate-grenade-dsvm http://logs.openstack.org/95/65995/2/gate/gate-grenade-dsvm/16126b6 : SUCCESS in 43m 40s\n","accounts_in_message":[],"_revision_number":2},{"id":"8b4154e313bff4b65a138efc7f6f442dbb303797","author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"date":"2014-01-16 08:55:20.000000000","message":"Patch Set 2:\n\nreverify bug #1269687","accounts_in_message":[],"_revision_number":2},{"id":"66d2c4f9f926d93fe1dd3c821aabf9db7800d32a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-16 09:20:01.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"33baad664d5ccf0a051387c5ee49876c5ca4fb6c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-17 15:33:25.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/95/65995/2/gate/gate-python-keystoneclient-docs/60f3795/doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/95/65995/2/gate/gate-python-keystoneclient-pep8/0d1fb4d : SUCCESS in 1m 20s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/95/65995/2/gate/gate-python-keystoneclient-python26/dc070ac : SUCCESS in 53s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/95/65995/2/gate/gate-python-keystoneclient-python27/15bd00f : SUCCESS in 1m 23s\n- gate-tempest-dsvm-full http://logs.openstack.org/95/65995/2/gate/gate-tempest-dsvm-full/4acaf9f : SUCCESS in 58m 45s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/95/65995/2/gate/gate-tempest-dsvm-postgres-full/2555530 : SUCCESS in 58m 07s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/95/65995/2/gate/gate-tempest-dsvm-neutron/d68ccbb : SUCCESS in 35m 59s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/95/65995/2/gate/gate-tempest-dsvm-large-ops/5e8654d : SUCCESS in 12m 20s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/95/65995/2/gate/gate-tempest-dsvm-neutron-large-ops/7153dcf : SUCCESS in 14m 03s\n- gate-grenade-dsvm http://logs.openstack.org/95/65995/2/gate/gate-grenade-dsvm/0183cfe : SUCCESS in 35m 19s\n","accounts_in_message":[],"_revision_number":2},{"id":"da2a5ece646f2b29980f30032cc8a7c0bfbaf07f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-17 15:33:25.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"29d98739471ca90dbecc381bcccc5d4b8e1f165b","revisions":{"3adad07cc26d609632bf334538945ab768cbab3f":{"kind":"REWORK","_number":1,"created":"2014-01-10 16:02:32.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/95/65995/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/95/65995/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/95/65995/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/95/65995/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/95/65995/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/95/65995/1"}}},"commit":{"parents":[{"commit":"f8978ec0fa24c724f082b579cee8ed930135f423","subject":"Enable filtering list roles by name","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f8978ec0fa24c724f082b579cee8ed930135f423"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-01-10 16:00:43.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-01-10 16:00:43.000000000","tz":0},"subject":"Clarify roles validation error messages","message":"Clarify roles validation error messages\n\nWhen doing the xor validation tests, we should differentiate between\nthe case where the user passed both arguments vs passing neither,\notherwise the error message is confusing when you don\u0027t pass either.\n\nChange-Id: I99c307339ccd045a4c5b71824f3b7d91e2908154\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3adad07cc26d609632bf334538945ab768cbab3f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3adad07cc26d609632bf334538945ab768cbab3f"}]},"branch":"refs/heads/master"},"29d98739471ca90dbecc381bcccc5d4b8e1f165b":{"kind":"REWORK","_number":2,"created":"2014-01-14 09:09:16.000000000","uploader":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"ref":"refs/changes/95/65995/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/95/65995/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/95/65995/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/95/65995/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/95/65995/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/95/65995/2"}}},"commit":{"parents":[{"commit":"dfd76c86cf9eeb0d1dd452a9f5f6aadd30765697","subject":"Merge \"Make assertQueryStringIs usage simpler\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/dfd76c86cf9eeb0d1dd452a9f5f6aadd30765697"}]}],"author":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-01-10 16:00:43.000000000","tz":0},"committer":{"name":"Steven Hardy","email":"shardy@redhat.com","date":"2014-01-14 09:08:51.000000000","tz":0},"subject":"Clarify roles validation error messages","message":"Clarify roles validation error messages\n\nWhen doing the xor validation tests, we should differentiate between\nthe case where the user passed both arguments vs passing neither,\notherwise the error message is confusing when you don\u0027t pass either.\n\nChange-Id: I99c307339ccd045a4c5b71824f3b7d91e2908154\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/29d98739471ca90dbecc381bcccc5d4b8e1f165b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/29d98739471ca90dbecc381bcccc5d4b8e1f165b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}