)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"24b2c3ac209889cac8c993dff5e2d1b6f617f42c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"invalid to check that the logger output does NOT contain"},{"line_number":11,"context_line":"request url."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also, fix url passed to reuqest mock as now it requires"},{"line_number":14,"context_line":"complete url is passed"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://github.com/jamielennox/requests-mock/pull/93"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_91c23fe9","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":32},"updated":"2019-09-06 09:06:35.000000000","message":"NIT: request","commit_id":"aa313a60f59b100d7a157f41ad13b2e70b4719a6"}],"keystoneclient/tests/unit/v3/test_role_assignments.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d83c80b3904fd75ca9e77901c7d3b73aad8160f6","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        ref_list \u003d self.TEST_ALL_RESPONSE_LIST"},{"line_number":266,"context_line":"        self.stub_entity(\u0027GET\u0027,"},{"line_number":267,"context_line":"                         [self.collection_key,"},{"line_number":268,"context_line":"                          \u0027?include_names\u003dTrue\u0027],"},{"line_number":269,"context_line":"                         entity\u003dref_list)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        returned_list \u003d self.manager.list(include_names\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_939a3ec3","line":268,"updated":"2019-09-06 14:04:21.000000000","message":"Is this related to the requests-mock change? I didn\u0027t notice this fail locally.","commit_id":"27d4376ea57be9944ee5eb0601157f8996de077f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b2c39e724c9412420c2ea908c777a381144920f8","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        ref_list \u003d self.TEST_ALL_RESPONSE_LIST"},{"line_number":266,"context_line":"        self.stub_entity(\u0027GET\u0027,"},{"line_number":267,"context_line":"                         [self.collection_key,"},{"line_number":268,"context_line":"                          \u0027?include_names\u003dTrue\u0027],"},{"line_number":269,"context_line":"                         entity\u003dref_list)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        returned_list \u003d self.manager.list(include_names\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_293509db","line":268,"in_reply_to":"5faad753_27cd405d","updated":"2019-09-07 16:46:11.000000000","message":"We can see the failure which Colleen shows in current gate jobs.\n\nI\u0027ve not yet have a deep look about it, but I guess the failures is cased because of the following change which changes how requests-mock handles empty query value.\n\nhttps://github.com/jamielennox/requests-mock/issues/101\nhttps://github.com/jamielennox/requests-mock/commit/9210dfc1c831c4afdd698dcd9ac637ee36019439","commit_id":"27d4376ea57be9944ee5eb0601157f8996de077f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e6b487de4a4daa92db035837fcfd2c9a92ec2f31","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        ref_list \u003d self.TEST_ALL_RESPONSE_LIST"},{"line_number":266,"context_line":"        self.stub_entity(\u0027GET\u0027,"},{"line_number":267,"context_line":"                         [self.collection_key,"},{"line_number":268,"context_line":"                          \u0027?include_names\u003dTrue\u0027],"},{"line_number":269,"context_line":"                         entity\u003dref_list)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        returned_list \u003d self.manager.list(include_names\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_262e8243","line":268,"in_reply_to":"5faad753_293509db","updated":"2019-09-09 16:04:19.000000000","message":"Nice catch, I didn\u0027t realized we were duplicating these tests across keystoneauth and python-keystoneclient :(","commit_id":"27d4376ea57be9944ee5eb0601157f8996de077f"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"4a6f1eb0a33c7918763a9aa6d8b1a1b5a891251d","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        ref_list \u003d self.TEST_ALL_RESPONSE_LIST"},{"line_number":266,"context_line":"        self.stub_entity(\u0027GET\u0027,"},{"line_number":267,"context_line":"                         [self.collection_key,"},{"line_number":268,"context_line":"                          \u0027?include_names\u003dTrue\u0027],"},{"line_number":269,"context_line":"                         entity\u003dref_list)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        returned_list \u003d self.manager.list(include_names\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_27cd405d","line":268,"in_reply_to":"5faad753_939a3ec3","updated":"2019-09-06 17:06:09.000000000","message":"It fails without this for me -\n\n requests_mock.exceptions.NoMockAddress: No mock address: GET http://127.0.0.1:5000/v3/role_assignments?include_names\u003dTrue\u0027\n\nIt\u0027s also mentioned in the commit message though it\u0027s not clear what changed that makes this needed.","commit_id":"27d4376ea57be9944ee5eb0601157f8996de077f"}]}
