)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a021e7c4009aafebdf5fe8ef4ed30b992e3ad299","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Andrey Kurilin \u003cakurilin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-02-14 13:23:10 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync latest code and reuse exceptions from Oslo."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Modules exceptions from oslo common code and keystoneclient are similar."},{"line_number":10,"context_line":"In case of unification openstack clients, we should use modules from Oslo."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAAUX%2F%2FIag%3D","line":7,"updated":"2014-02-16 16:55:50.000000000","message":"suggest split these into separate commits.","commit_id":"bfe0e1f5667d0050816ea6d2ffcddaeb60028787"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e77a699beba2e6a6939898d423e83dffd51373ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reuse module `exceptions` from Oslo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Modules exceptions from oslo common code and keystoneclient are similar."},{"line_number":10,"context_line":"In case of unification openstack clients, we should use modules from Oslo."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Changes of this patch:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"AAAAWH%2F%2BFoQ%3D","line":9,"updated":"2014-03-30 16:10:32.000000000","message":"change \"Modules exceptions from\" to \"The exception module in\"","commit_id":"62f0349d02af564081c555bf9c6f2ef035d6e851"}],"keystoneclient/apiclient/__init__.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a021e7c4009aafebdf5fe8ef4ed30b992e3ad299","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import warnings"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# NOTE(akurilin): Module \u0027keystoneclient.apiclient\u0027 contains only exceptions"},{"line_number":19,"context_line":"# which is deprecated, so this module must also be deprecated which help"},{"line_number":20,"context_line":"# to report \u0027deprecated\u0027 status of exceptions for next kind of imports"},{"line_number":21,"context_line":"#       from keystoneclient.apiclient import exceptions"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUX%2F%2FIZ4%3D","line":19,"updated":"2014-02-16 16:55:50.000000000","message":"change \"is deprecated\" to \"are deprecated\"\n\nchange \"help\" to \"helps\"","commit_id":"bfe0e1f5667d0050816ea6d2ffcddaeb60028787"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a021e7c4009aafebdf5fe8ef4ed30b992e3ad299","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# to report \u0027deprecated\u0027 status of exceptions for next kind of imports"},{"line_number":21,"context_line":"#       from keystoneclient.apiclient import exceptions"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"warnings.warn(\"The \u0027keystoneclient.apiclient\u0027 module is deprecated.\","},{"line_number":24,"context_line":"              DeprecationWarning)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"__all__ \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUX%2F%2FIaY%3D","line":23,"updated":"2014-02-16 16:55:50.000000000","message":"Include in the message what should be used instead.\n\nAlso, document in which release this module is deprecated so that we know when it can be removed.","commit_id":"bfe0e1f5667d0050816ea6d2ffcddaeb60028787"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"68e524ec4b2fa5757214f7d2b28a5c551e8ac8e7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#       from keystoneclient.apiclient import exceptions"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"warnings.warn(\"The \u0027keystoneclient.apiclient\u0027 module is deprecated since \""},{"line_number":24,"context_line":"              \"Icehouse. Use \u0027keystoneclient.exceptions\u0027 instead of this \""},{"line_number":25,"context_line":"              \"module.\", DeprecationWarning)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"__all__ \u003d ["}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2BLEs%3D","line":24,"updated":"2014-03-28 16:30:17.000000000","message":"the client doesn\u0027t have named releases -- refer to an actual client version instead","commit_id":"2f6e1636cf6b1e2bd47a9f0bf57969d67fbb37ac"}],"keystoneclient/apiclient/exceptions.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"eb87da959ff5f0fdfdc5d8200156ebc1b0ca6516","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# NOTE(akurilin): This module used in tempest. When patch to tempest comes,"},{"line_number":26,"context_line":"# we will be in able to remove this module at all."},{"line_number":27,"context_line":"from keystoneclient.openstack.common.apiclient.exceptions import *  # noqa"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2Fdro%3D","line":26,"updated":"2014-02-13 01:20:42.000000000","message":"removing this module would not be backwards compatible. We\u0027d have to deprecate it first.","commit_id":"781439b0a00c2cfa07fc37ccc97862bce7cd2f40"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3b277b2daaab2ba69e89613e2afd1ff68a2048a0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# NOTE(akurilin): This module used in tempest. When patch to tempest comes,"},{"line_number":26,"context_line":"# we will be in able to remove this module at all."},{"line_number":27,"context_line":"from keystoneclient.openstack.common.apiclient.exceptions import *  # noqa"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2Fbyk%3D","line":26,"in_reply_to":"AAAAUX%2F%2Fdro%3D","updated":"2014-02-13 08:51:40.000000000","message":"If I\u0027m not mistaken, module `keystoneclient.exceptions` is imported instead of `keystoneclient.apiclient.exceptions` in all projects and only one module in tempest have had wrong import(already fixed - https://review.openstack.org/#/c/70949 ), so now we can remove this module at all.","commit_id":"781439b0a00c2cfa07fc37ccc97862bce7cd2f40"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a021e7c4009aafebdf5fe8ef4ed30b992e3ad299","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"Exception definitions."},{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import warnings"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUX%2F%2FIZ0%3D","line":20,"updated":"2014-02-16 16:55:50.000000000","message":"Update the docstring to also say this this module is deprecated.","commit_id":"bfe0e1f5667d0050816ea6d2ffcddaeb60028787"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a021e7c4009aafebdf5fe8ef4ed30b992e3ad299","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"warnings.warn(\"The \u0027keystoneclient.apiclient.exceptions\u0027 module is deprecated.\""},{"line_number":29,"context_line":"              \"Use must use keystoneclient.exceptions instead of this module\","},{"line_number":30,"context_line":"              DeprecationWarning)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUX%2F%2FIaU%3D","line":29,"updated":"2014-02-16 16:55:50.000000000","message":"Change \"Use must use\" to \"Use\".\n\nAlso, put the release where the module was deprecated in the message so that we know when we can remove it.\n\nAlso, add a space after the .","commit_id":"bfe0e1f5667d0050816ea6d2ffcddaeb60028787"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"6678b907c36b57868c575d2e3bbe98cc576210f3","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import warnings"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from keystoneclient.exceptions import *     # noqa"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"warnings.warn(\"The \u0027keystoneclient.apiclient.exceptions\u0027 module is deprecated \""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWn%2F%2F6MM%3D","line":28,"updated":"2014-04-08 15:07:50.000000000","message":"two spaces before the #","commit_id":"61544f01d4237e34a415a4b2879d4c1a4891c968"}],"keystoneclient/exceptions.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"2bd92f2b47760904242ec643da5b995846011fcc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"#flake8: noqa"},{"line_number":22,"context_line":"from keystoneclient.openstack.common.apiclient.exceptions import *"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class CertificateConfigError(Exception):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Bjig%3D","line":22,"updated":"2014-01-24 12:46:08.000000000","message":"can you please remove this ugly \"import *\" ?","commit_id":"6bbb648c54544f7aa4a226f21b88f6cf316c8693"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"adfd3cfb42c4ccd0b1f4dad36ffee8a4a1ebddb2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"#flake8: noqa"},{"line_number":22,"context_line":"from keystoneclient.openstack.common.apiclient.exceptions import *"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class CertificateConfigError(Exception):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Befs%3D","line":22,"in_reply_to":"AAAAUH%2F%2Bjig%3D","updated":"2014-01-25 10:14:19.000000000","message":"I agree with you about beauty of this import.\nBut this import provides not ideal code line in one module and more clear code throughout in all others modules, because we need to import one module instead of two.","commit_id":"6bbb648c54544f7aa4a226f21b88f6cf316c8693"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a021e7c4009aafebdf5fe8ef4ed30b992e3ad299","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#flake8: noqa"},{"line_number":20,"context_line":"from keystoneclient.openstack.common.apiclient.exceptions import *"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# NOTE(akurilin): This alias should be left here for supporting backwards"},{"line_number":23,"context_line":"# compatible until we will be sure in correctness of usage this exceptions"},{"line_number":24,"context_line":"# in projects."},{"line_number":25,"context_line":"ConnectionError \u003d ConnectionRefused"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUX%2F%2FIaA%3D","line":22,"updated":"2014-02-16 16:55:50.000000000","message":"change \"for supporting\" to \"to support\"","commit_id":"bfe0e1f5667d0050816ea6d2ffcddaeb60028787"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a021e7c4009aafebdf5fe8ef4ed30b992e3ad299","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient.openstack.common.apiclient.exceptions import *"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# NOTE(akurilin): This alias should be left here for supporting backwards"},{"line_number":23,"context_line":"# compatible until we will be sure in correctness of usage this exceptions"},{"line_number":24,"context_line":"# in projects."},{"line_number":25,"context_line":"ConnectionError \u003d ConnectionRefused"},{"line_number":26,"context_line":"HTTPNotImplemented \u003d HttpNotImplemented"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUX%2F%2FIZ8%3D","line":23,"updated":"2014-02-16 16:55:50.000000000","message":"change \"compatible\" to \"compatibility\"","commit_id":"bfe0e1f5667d0050816ea6d2ffcddaeb60028787"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"e5ffda5ca1c940092d0a9fa92deeceee1daa9923","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# in projects."},{"line_number":25,"context_line":"ConnectionError \u003d ConnectionRefused"},{"line_number":26,"context_line":"HTTPNotImplemented \u003d HttpNotImplemented"},{"line_number":27,"context_line":"Timeout \u003d RequestTimeout"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class CertificateConfigError(Exception):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2Bxpc%3D","line":27,"updated":"2014-02-19 06:07:03.000000000","message":"I hope these didn\u0027t go there for the ones in this class - I can see no reason that we need these in every client. Some things really are specific to keystone - and i was not expecting these to be synced back to all the clients.","commit_id":"547314bc38d2830f389de0d742c246f69640d955"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e77a699beba2e6a6939898d423e83dffd51373ad","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient.openstack.common.apiclient.exceptions import *"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# NOTE(akurilin): This alias should be left here to support backwards"},{"line_number":23,"context_line":"# compatibility until we will be sure in correctness of usage this exceptions"},{"line_number":24,"context_line":"# in projects."},{"line_number":25,"context_line":"ConnectionError \u003d ConnectionRefused"},{"line_number":26,"context_line":"HTTPNotImplemented \u003d HttpNotImplemented"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2BFn4%3D","line":23,"updated":"2014-03-30 16:10:32.000000000","message":"change \"this exceptions\" to \"of these exceptions\"","commit_id":"62f0349d02af564081c555bf9c6f2ef035d6e851"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8933e321733c53143444fda03d5ae3f92cdb5e9b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient.openstack.common.apiclient.exceptions import *"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# NOTE(akurilin): This alias should be left here to support backwards"},{"line_number":23,"context_line":"# compatibility until we will be sure that usage of these exceptions in "},{"line_number":24,"context_line":"# projects is correct."},{"line_number":25,"context_line":"ConnectionError \u003d ConnectionRefused"},{"line_number":26,"context_line":"HTTPNotImplemented \u003d HttpNotImplemented"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAWH%2F99oY%3D","line":23,"updated":"2014-03-31 21:57:20.000000000","message":"change \"until we will be sure that\" to \"until we are sure that\"\n\nremove whitespace at end of line.","commit_id":"6e461c59c883ab14212336f01d1b928e17b3a43a"}],"keystoneclient/session.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"e5ffda5ca1c940092d0a9fa92deeceee1daa9923","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            raise exceptions.SSLError(msg)"},{"line_number":224,"context_line":"        except requests.exceptions.Timeout:"},{"line_number":225,"context_line":"            msg \u003d \u0027Request to %s timed out\u0027 % url"},{"line_number":226,"context_line":"            raise exceptions.Timeout(msg)"},{"line_number":227,"context_line":"        except requests.exceptions.ConnectionError:"},{"line_number":228,"context_line":"            msg \u003d \u0027Unable to establish connection to %s\u0027 % url"},{"line_number":229,"context_line":"            raise exceptions.ConnectionError(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2BxmM%3D","side":"PARENT","line":226,"updated":"2014-02-19 06:07:03.000000000","message":"mmm, why? these were created specifically for the session object. This *object* will be shared so there is no point syncing the exceptions because they will always come from keystone.","commit_id":"37d965ce9b0900b3064ce986e5482ac4213f82f2"}],"keystoneclient/tests/v3/test_trusts.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"eb87da959ff5f0fdfdc5d8200156ebc1b0ca6516","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_update(self):"},{"line_number":101,"context_line":"        # Update not supported for the OS-TRUST API"},{"line_number":102,"context_line":"        self.assertRaises(exceptions.HttpNotImplemented, self.manager.update)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2Fdqc%3D","line":102,"updated":"2014-02-13 01:20:42.000000000","message":"This is showing us that this change isn\u0027t backwards compatible.","commit_id":"781439b0a00c2cfa07fc37ccc97862bce7cd2f40"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3b277b2daaab2ba69e89613e2afd1ff68a2048a0","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_update(self):"},{"line_number":101,"context_line":"        # Update not supported for the OS-TRUST API"},{"line_number":102,"context_line":"        self.assertRaises(exceptions.HttpNotImplemented, self.manager.update)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FbsE%3D","line":102,"in_reply_to":"AAAAUX%2F%2Fdqc%3D","updated":"2014-02-13 08:51:40.000000000","message":"If it needed, the alias can be added in `keystoneclient.exceptions` to support backwards compatible.","commit_id":"781439b0a00c2cfa07fc37ccc97862bce7cd2f40"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a021e7c4009aafebdf5fe8ef4ed30b992e3ad299","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_update(self):"},{"line_number":99,"context_line":"        # Update not supported for the OS-TRUST API"},{"line_number":100,"context_line":"        self.assertRaises(exceptions.HttpNotImplemented, self.manager.update)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUX%2F%2FIZk%3D","line":100,"updated":"2014-02-16 16:55:50.000000000","message":"I\u0027d rather the tests were not changed in this commit... submit a separate commit to update the tests to not use the deprecated name.","commit_id":"bfe0e1f5667d0050816ea6d2ffcddaeb60028787"}]}