)]}'
{"keystoneclient/middleware/s3_token.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"c6e77789f11c4bef798a175166012b48632df417","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            # FIXME(jamielennox): This is a bad default! This behaviour is kept"},{"line_number":126,"context_line":"            # because it\u0027s compatible with the original httplib implementation"},{"line_number":127,"context_line":"            # but it should be corrected as soon as possible."},{"line_number":128,"context_line":"            self.verify \u003d False"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def deny_request(self, code):"},{"line_number":131,"context_line":"        error_table \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9ya0%3D","line":128,"updated":"2014-02-03 22:57:22.000000000","message":"could use add a setting for it at least like  conf.get(\u0027verify\u0027)?","commit_id":"8a667e8eee088bd57069e64ba9fefa04d2720638"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"47c29d46d21a940633dd19f7a2c65eeb72a4b5b7","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            # FIXME(jamielennox): This is a bad default! This behaviour is kept"},{"line_number":126,"context_line":"            # because it\u0027s compatible with the original httplib implementation"},{"line_number":127,"context_line":"            # but it should be corrected as soon as possible."},{"line_number":128,"context_line":"            self.verify \u003d False"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def deny_request(self, code):"},{"line_number":131,"context_line":"        error_table \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9yFw%3D","line":128,"in_reply_to":"AAAAUH%2F9ya0%3D","updated":"2014-02-04 00:52:52.000000000","message":"let\u0027s just do it. We had the same problem with auth_token and got away with it.","commit_id":"8a667e8eee088bd57069e64ba9fefa04d2720638"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"c6e77789f11c4bef798a175166012b48632df417","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            return resp(environ, start_response)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        self.logger.debug(\u0027Keystone Reply: Status: %d, Output: %s\u0027 % ("},{"line_number":236,"context_line":"                          resp.status_code, resp.text))"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        try:"},{"line_number":239,"context_line":"            identity_info \u003d jsonutils.loads(resp.text)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9ybI%3D","line":236,"updated":"2014-02-03 22:57:22.000000000","message":"isn\u0027t that supposed to be resp.content?","commit_id":"8a667e8eee088bd57069e64ba9fefa04d2720638"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"47c29d46d21a940633dd19f7a2c65eeb72a4b5b7","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            return resp(environ, start_response)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        self.logger.debug(\u0027Keystone Reply: Status: %d, Output: %s\u0027 % ("},{"line_number":236,"context_line":"                          resp.status_code, resp.text))"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        try:"},{"line_number":239,"context_line":"            identity_info \u003d jsonutils.loads(resp.text)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9yGo%3D","line":236,"in_reply_to":"AAAAUH%2F9ybI%3D","updated":"2014-02-04 00:52:52.000000000","message":"So text is just the unicode version of content. I *guess* it makes sense to use content here for the bytes - but i\u0027m not sure one way or the other.","commit_id":"8a667e8eee088bd57069e64ba9fefa04d2720638"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"43121ae8d7356f2dbc4dd638f7fea8842ae23d83","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            response \u003d requests.post(\u0027%s/v2.0/s3tokens\u0027 % self.request_uri,"},{"line_number":148,"context_line":"                                     headers\u003dheaders, data\u003dcreds_json,"},{"line_number":149,"context_line":"                                     allow_redirects\u003dFalse, verify\u003dself.verify)"},{"line_number":150,"context_line":"        except requests.exceptions.RequestException as e:"},{"line_number":151,"context_line":"            self.logger.info(\u0027HTTP connection exception: %s\u0027 % e)"},{"line_number":152,"context_line":"            resp \u003d self.deny_request(\u0027InvalidURI\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9wpM%3D","line":149,"updated":"2014-02-04 09:16:20.000000000","message":"why allow_redirects\u003dFalse, AFAIK requests have a weird behaviour with redirects only with DELETE.","commit_id":"717cdbc5653d009a90bd0aceceb75374c66ff159"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"8d3727f4b99c927fedc10190aa5fdadc15ce92c1","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            response \u003d requests.post(\u0027%s/v2.0/s3tokens\u0027 % self.request_uri,"},{"line_number":148,"context_line":"                                     headers\u003dheaders, data\u003dcreds_json,"},{"line_number":149,"context_line":"                                     allow_redirects\u003dFalse, verify\u003dself.verify)"},{"line_number":150,"context_line":"        except requests.exceptions.RequestException as e:"},{"line_number":151,"context_line":"            self.logger.info(\u0027HTTP connection exception: %s\u0027 % e)"},{"line_number":152,"context_line":"            resp \u003d self.deny_request(\u0027InvalidURI\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9rOo%3D","line":149,"in_reply_to":"AAAAUH%2F9wpM%3D","updated":"2014-02-05 03:59:40.000000000","message":"Done","commit_id":"717cdbc5653d009a90bd0aceceb75374c66ff159"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"43121ae8d7356f2dbc4dd638f7fea8842ae23d83","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                          resp.status_code, resp.content))"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        try:"},{"line_number":239,"context_line":"            identity_info \u003d jsonutils.loads(resp.text)"},{"line_number":240,"context_line":"            token_id \u003d str(identity_info[\u0027access\u0027][\u0027token\u0027][\u0027id\u0027])"},{"line_number":241,"context_line":"            tenant \u003d identity_info[\u0027access\u0027][\u0027token\u0027][\u0027tenant\u0027]"},{"line_number":242,"context_line":"        except (ValueError, KeyError):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9wpA%3D","line":239,"updated":"2014-02-04 09:16:20.000000000","message":"can\u0027t you just do identity_info \u003d resp.json() ?","commit_id":"717cdbc5653d009a90bd0aceceb75374c66ff159"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"8d3727f4b99c927fedc10190aa5fdadc15ce92c1","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                          resp.status_code, resp.content))"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        try:"},{"line_number":239,"context_line":"            identity_info \u003d jsonutils.loads(resp.text)"},{"line_number":240,"context_line":"            token_id \u003d str(identity_info[\u0027access\u0027][\u0027token\u0027][\u0027id\u0027])"},{"line_number":241,"context_line":"            tenant \u003d identity_info[\u0027access\u0027][\u0027token\u0027][\u0027tenant\u0027]"},{"line_number":242,"context_line":"        except (ValueError, KeyError):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9rOs%3D","line":239,"in_reply_to":"AAAAUH%2F9wpA%3D","updated":"2014-02-05 03:59:40.000000000","message":"Done","commit_id":"717cdbc5653d009a90bd0aceceb75374c66ff159"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"591208b45f988bf63e7a27e63bf375bb3b6beca6","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        auth_port \u003d int(conf.get(\u0027auth_port\u0027, 35357))"},{"line_number":112,"context_line":"        auth_protocol \u003d conf.get(\u0027auth_protocol\u0027, \u0027https\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        self.request_uri \u003d \u0027%s://%s:%s\u0027 % (auth_protocol, auth_host, auth_port)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # SSL"},{"line_number":117,"context_line":"        insecure \u003d conf.get(\u0027insecure\u0027, False)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9qcw%3D","line":114,"updated":"2014-02-05 08:33:00.000000000","message":"FYI: i have added bug #1275962 for that","commit_id":"9fda5add290365809e847a2a9c4dba47c1e94a4f"}]}
