)]}'
{"id":"openstack%2Fpython-keystoneclient~71729","triplet_id":"openstack%2Fpython-keystoneclient~master~I668b187ba8ed00ad6d55ec487af623b79b21589d","project":"openstack/python-keystoneclient","branch":"master","topic":"universal_newlines","hashtags":[],"change_id":"I668b187ba8ed00ad6d55ec487af623b79b21589d","subject":"cms: Use universal_newlines\u003dTrue in subprocess.Popen()","status":"MERGED","created":"2014-02-07 03:40:40.000000000","updated":"2014-02-10 02:25:11.000000000","submitted":"2014-02-10 02:25:11.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0644663169ea7886811ba2967d4f3f40f7edf65d","_number":71729,"virtual_id_number":71729,"owner":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":2,"date":"2014-02-10 02:25:11.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"recommended":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"all":[{"value":1,"date":"2014-02-07 10:46:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2014-02-08 01:18:48.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":2,"date":"2014-02-08 21:39:27.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"date":"2014-02-10 00:49:48.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"all":[{"value":0,"date":"2014-02-07 03:41:03.000000000","_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-02-07 03:41:10.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"date":"2014-02-07 03:40:59.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"date":"2014-02-07 03:40:54.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":1,"date":"2014-02-08 21:39:27.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"date":"2014-02-07 03:41:23.000000000","_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-02-07 03:40:54.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2014-02-07 03:40:59.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2014-02-07 03:41:03.000000000","updated_by":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"reviewer":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"state":"REVIEWER"},{"updated":"2014-02-07 03:41:10.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2014-02-07 03:41:23.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2014-02-08 21:39:27.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2014-02-10 02:25:11.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d7e8831cb3ed18bcea3be00305613b45df0dba44","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-07 03:40:44.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"584956ed610c02ec5ca73a8521e97af477411f70","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-07 04:28:04.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/29/71729/1/check/gate-python-keystoneclient-pep8/656ebbf : SUCCESS in 59s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/29/71729/1/check/gate-python-keystoneclient-docs/d3e720e/doc/build/html/ : SUCCESS in 47s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/29/71729/1/check/gate-python-keystoneclient-python26/9295008 : SUCCESS in 1m 13s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/29/71729/1/check/gate-python-keystoneclient-python27/db2fe37 : SUCCESS in 1m 18s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/29/71729/1/check/gate-python-keystoneclient-python33/85a1633 : FAILURE in 4m 50s (non-voting)\n- check-devstack-dsvm-cells http://logs.openstack.org/29/71729/1/check/check-devstack-dsvm-cells/9fb43d4 : SUCCESS in 10m 09s\n- check-tempest-dsvm-full http://logs.openstack.org/29/71729/1/check/check-tempest-dsvm-full/3fe28a0 : SUCCESS in 42m 47s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/29/71729/1/check/check-tempest-dsvm-postgres-full/0edf704 : SUCCESS in 47m 11s\n- check-tempest-dsvm-neutron http://logs.openstack.org/29/71729/1/check/check-tempest-dsvm-neutron/da0c560 : SUCCESS in 26m 16s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/29/71729/1/check/gate-tempest-dsvm-large-ops/15696f7 : SUCCESS in 12m 20s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/29/71729/1/check/gate-tempest-dsvm-neutron-large-ops/2ccf91d : SUCCESS in 14m 08s\n- check-grenade-dsvm http://logs.openstack.org/29/71729/1/check/check-grenade-dsvm/6178845 : SUCCESS in 27m 24s\n","accounts_in_message":[],"_revision_number":1},{"id":"655b6211c958ccc48862cb39b99c546ceb298875","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2014-02-07 10:46:37.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"6e96ae15895a7ef74477c191942fa5cb21d3b2eb","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-02-08 01:18:48.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"ca6ddcd97b7d0a565397f6e952475296e419a286","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2014-02-08 21:37:25.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nHold off on this.  Some changes are coming to CMS.  It is not going to be a string anymore in the future, as we might be signing data as well.","accounts_in_message":[],"_revision_number":1},{"id":"c250cc908bf96515e833bdb279b9755d838deb74","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-08 21:39:27.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"fd215c8f27eeb6272c95e47662ceb8734d8205e5","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2014-02-08 21:39:27.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\nOK, just checked the incoming code:  we might be Producing binary (signing in DER format instead of PEM) but we will still be signing incoming text.","accounts_in_message":[],"_revision_number":1},{"id":"2c42e766a100f8b30d8e1fc3ab526895a8296a52","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-08 22:31:01.000000000","message":"Patch Set 1: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/29/71729/1/gate/gate-python-keystoneclient-docs/e5aced3/doc/build/html/ : SUCCESS in 1m 06s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/29/71729/1/gate/gate-python-keystoneclient-pep8/5e78f57 : SUCCESS in 1m 05s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/29/71729/1/gate/gate-python-keystoneclient-python26/5bdcf46 : SUCCESS in 1m 07s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/29/71729/1/gate/gate-python-keystoneclient-python27/8dbd547 : SUCCESS in 1m 09s\n- gate-devstack-dsvm-cells http://logs.openstack.org/29/71729/1/gate/gate-devstack-dsvm-cells/39569f6 : SUCCESS in 9m 40s\n- gate-tempest-dsvm-full http://logs.openstack.org/29/71729/1/gate/gate-tempest-dsvm-full/b95aa41 : FAILURE in 51m 27s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/29/71729/1/gate/gate-tempest-dsvm-postgres-full/886f580 : SUCCESS in 51m 06s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/29/71729/1/gate/gate-tempest-dsvm-neutron/2d6d969 : SUCCESS in 32m 55s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/29/71729/1/gate/gate-tempest-dsvm-large-ops/dcaec28 : SUCCESS in 13m 25s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/29/71729/1/gate/gate-tempest-dsvm-neutron-large-ops/a120012 : SUCCESS in 11m 31s\n- gate-grenade-dsvm http://logs.openstack.org/29/71729/1/gate/gate-grenade-dsvm/2bdbf46 : SUCCESS in 30m 48s\n","accounts_in_message":[],"_revision_number":1},{"id":"5e15dbf76559a2a44b0ae7020f353c4870d6dd39","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2014-02-10 00:49:48.000000000","message":"Patch Set 1:\n\nreverify bug 1240728","accounts_in_message":[],"_revision_number":1},{"id":"0aacbe23b20367c9a6f9f7c94d50c36a33b6b333","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-10 00:49:49.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"49a42d2abfa5d50f369776ddc8bafb110212a31b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-10 02:25:11.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/29/71729/1/gate/gate-python-keystoneclient-docs/b5e2134/doc/build/html/ : SUCCESS in 59s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/29/71729/1/gate/gate-python-keystoneclient-pep8/df61da9 : SUCCESS in 1m 19s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/29/71729/1/gate/gate-python-keystoneclient-python26/3746742 : SUCCESS in 1m 03s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/29/71729/1/gate/gate-python-keystoneclient-python27/72b1f25 : SUCCESS in 1m 13s\n- gate-devstack-dsvm-cells http://logs.openstack.org/29/71729/1/gate/gate-devstack-dsvm-cells/9727721 : SUCCESS in 15m 46s\n- gate-tempest-dsvm-full http://logs.openstack.org/29/71729/1/gate/gate-tempest-dsvm-full/85fad99 : SUCCESS in 54m 54s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/29/71729/1/gate/gate-tempest-dsvm-postgres-full/7175b49 : SUCCESS in 1h 05m 23s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/29/71729/1/gate/gate-tempest-dsvm-neutron/1218adf : SUCCESS in 33m 36s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/29/71729/1/gate/gate-tempest-dsvm-large-ops/a5df037 : SUCCESS in 11m 53s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/29/71729/1/gate/gate-tempest-dsvm-neutron-large-ops/cb46003 : SUCCESS in 16m 15s\n- gate-grenade-dsvm http://logs.openstack.org/29/71729/1/gate/gate-grenade-dsvm/8a4bb2c : SUCCESS in 37m 36s\n","accounts_in_message":[],"_revision_number":1},{"id":"ea7aaf7d33a369f59b94749ee01f966c1c708239","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-10 02:25:11.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1ee161e162ff9c50e18124eac47a434ff327f500","revisions":{"1ee161e162ff9c50e18124eac47a434ff327f500":{"kind":"REWORK","_number":1,"created":"2014-02-07 03:40:40.000000000","uploader":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"ref":"refs/changes/29/71729/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/29/71729/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/71729/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/71729/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/71729/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/29/71729/1"}}},"commit":{"parents":[{"commit":"3d0eacddf9a920b3bf8fb19dd522433fa771d6fb","subject":"Merge \"Use requests library in S3 middleware\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3d0eacddf9a920b3bf8fb19dd522433fa771d6fb"}]}],"author":{"name":"Cyril Roelandt","email":"cyril.roelandt@enovance.com","date":"2014-02-07 03:31:25.000000000","tz":60},"committer":{"name":"Cyril Roelandt","email":"cyril.roelandt@enovance.com","date":"2014-02-07 03:31:25.000000000","tz":60},"subject":"cms: Use universal_newlines\u003dTrue in subprocess.Popen()","message":"cms: Use universal_newlines\u003dTrue in subprocess.Popen()\n\nThe Python documentation states that \"the type of [the first argument of\nsubprocess.communicate()] must be bytes or, if universal_newlines was True, a\nstring\"[1]. Currently, in Python 3, a text string is given to\nsubprocess.communicate(), even though the process was created with\nuniversal_newlines\u003dFalse (the default value).\n\nRather than converting strings to bytes (and the other way around) everywhere\nin the code, just create the process with universal_newlines\u003dTrue. The side\neffect is that \u0027\\n\u0027, \u0027\\r\\n\u0027 and \u0027\\r\u0027 will be recognized as ending lines[2],\nwhich should not be an issue.\n\n[1] http://docs.python.org/3/library/subprocess.html?highlight\u003dpopen#subprocess.Popen.communicate\n[2] http://docs.python.org/3/glossary.html#term-universal-newlines\n\nChange-Id: I668b187ba8ed00ad6d55ec487af623b79b21589d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1ee161e162ff9c50e18124eac47a434ff327f500"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1ee161e162ff9c50e18124eac47a434ff327f500"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}