)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7b501dd20ef502a20dcfe19f3cf0a23e6783a33c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Discover should support other services"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most services don\u0027t provide a \u0027values\u0027 element for there version"},{"line_number":10,"context_line":"definitions, however are otherwise similar. Discovery should allow that"},{"line_number":11,"context_line":"case and continue on otherwise."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2FkCg%3D","line":9,"updated":"2014-03-17 00:41:48.000000000","message":"change \"there\" to \"their\"","commit_id":"263759a8de9959d12aaa273f11420dfb85078c24"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"42d8cf3914d0eeb2fd66a7b1a13ac61831b3c00e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Discover should support other services"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most services don\u0027t provide a \u0027values\u0027 element for there version"},{"line_number":10,"context_line":"definitions, however are otherwise similar. Discovery should allow that"},{"line_number":11,"context_line":"case and continue on otherwise."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2Fi7Q%3D","line":9,"in_reply_to":"AAAAWH%2F%2FkCg%3D","updated":"2014-03-17 07:00:24.000000000","message":"Done","commit_id":"263759a8de9959d12aaa273f11420dfb85078c24"}],"keystoneclient/discover.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"6817c32f290102fa239d13e59910ee3c68265c08","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        except (KeyError, TypeError):"},{"line_number":156,"context_line":"            pass"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # Most servers don\u0027t have a \u0027values\u0027 element so accept straight the"},{"line_number":159,"context_line":"        # base versions dict if available."},{"line_number":160,"context_line":"        try:"},{"line_number":161,"context_line":"            return body_resp[\u0027versions\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FQJE%3D","line":158,"updated":"2014-02-14 14:26:16.000000000","message":"remove \"the\"","commit_id":"9188097af0db3500bc7e3869d6336b91fe27767a"}],"keystoneclient/tests/test_discovery.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7b501dd20ef502a20dcfe19f3cf0a23e6783a33c","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            versions \u003d discover.available_versions(url)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"            for v in versions:"},{"line_number":263,"context_line":"                self.assertIn(\u0027id\u0027, v)"},{"line_number":264,"context_line":"                self.assertIn(\u0027status\u0027, v)"},{"line_number":265,"context_line":"                self.assertIn(\u0027links\u0027, v)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FkCQ%3D","line":263,"updated":"2014-03-17 00:41:48.000000000","message":"these asserts need to have to the path, ex, and version in the failure message since the traceback isn\u0027t going to be enough to know what the failure was.\n\nAlternatively, split up the test.","commit_id":"263759a8de9959d12aaa273f11420dfb85078c24"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"42d8cf3914d0eeb2fd66a7b1a13ac61831b3c00e","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            versions \u003d discover.available_versions(url)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"            for v in versions:"},{"line_number":263,"context_line":"                self.assertIn(\u0027id\u0027, v)"},{"line_number":264,"context_line":"                self.assertIn(\u0027status\u0027, v)"},{"line_number":265,"context_line":"                self.assertIn(\u0027links\u0027, v)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fi7Y%3D","line":263,"in_reply_to":"AAAAWH%2F%2FkCQ%3D","updated":"2014-03-17 07:00:24.000000000","message":"Done","commit_id":"263759a8de9959d12aaa273f11420dfb85078c24"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb1b10b86d60ca015466c8cd06db8696f69e3307","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        for v in versions:"},{"line_number":288,"context_line":"            self.assertIn(v[\u0027id\u0027], (\u0027v2.0\u0027, \u0027v3.0\u0027))"},{"line_number":289,"context_line":"            self.assertEqual(v[\u0027updated\u0027], UPDATED)"},{"line_number":290,"context_line":"            self.assertEqual(v[\u0027status\u0027], \u0027stable\u0027)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"            if v[\u0027id\u0027] \u003d\u003d \u0027v3.0\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2B12c%3D","line":289,"updated":"2014-03-23 14:39:45.000000000","message":"(nit) expected arg is first. this applies to several of these new assertEquals","commit_id":"ba530a44fbb6c591647a98405b27a64809f8b3c4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb1b10b86d60ca015466c8cd06db8696f69e3307","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            elif v[\u0027id\u0027] \u003d\u003d \u0027v2.0\u0027:"},{"line_number":307,"context_line":"                self.assertEqual(v[\u0027updated\u0027], \u00272012-11-21T11:33:21Z\u0027)"},{"line_number":308,"context_line":"            else:"},{"line_number":309,"context_line":"                self.fail(\"Invalid version found\")"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def test_available_glance_data(self):"},{"line_number":312,"context_line":"        body \u003d jsonutils.dumps(GLANCE_EXAMPLES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2B12s%3D","line":309,"updated":"2014-03-23 14:39:45.000000000","message":"print out the version that we got so we can figure out what the problem was.","commit_id":"ba530a44fbb6c591647a98405b27a64809f8b3c4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb1b10b86d60ca015466c8cd06db8696f69e3307","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        httpretty.register_uri(httpretty.GET, BASE_URL, status\u003d200, body\u003dbody)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        versions \u003d discover.available_versions(BASE_URL)"},{"line_number":316,"context_line":"        self.assertEqual(5, len(versions))"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        for v in versions:"},{"line_number":319,"context_line":"            if v[\u0027id\u0027] in (\u0027v2.2\u0027, \u0027v1.1\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2B12k%3D","line":316,"updated":"2014-03-23 14:39:45.000000000","message":"there\u0027s some duplicated code in these new tests so suggest create a function. (for lines 312-316 which are similar to 296-300 and 281-285)","commit_id":"ba530a44fbb6c591647a98405b27a64809f8b3c4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb1b10b86d60ca015466c8cd06db8696f69e3307","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            elif v[\u0027id\u0027] in (\u0027v2.1\u0027, \u0027v2.0\u0027, \u0027v1.0\u0027):"},{"line_number":322,"context_line":"                self.assertEqual(v[\u0027status\u0027], \u0027SUPPORTED\u0027)"},{"line_number":323,"context_line":"            else:"},{"line_number":324,"context_line":"                self.fail(\"Invalid version found\")"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"@httpretty.activate"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2B12g%3D","line":324,"updated":"2014-03-23 14:39:45.000000000","message":"print out the version that we got so we can figure out what the problem was.","commit_id":"ba530a44fbb6c591647a98405b27a64809f8b3c4"}]}
