)]}'
{"keystoneclient/auth/identity/base.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"373a545851e6b32a599cad9b1ac4a06ff3414f5e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        :returns AccessInfo: Token access information."},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_token(self, session, **kwargs):"},{"line_number":67,"context_line":"        \"\"\"Return a valid auth token."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        If a valid token is not present then a new one will be fetched using"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FGVI%3D","line":66,"updated":"2014-03-09 20:42:19.000000000","message":"the kwargs aren\u0027t used anymore. Suggest remove the argument.","commit_id":"7c644c699646239052bde6d7e52c276078da9ea0"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"f71a12715385b3a7688ff0621bb8e9cba7c03781","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        :returns AccessInfo: Token access information."},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_token(self, session, **kwargs):"},{"line_number":67,"context_line":"        \"\"\"Return a valid auth token."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        If a valid token is not present then a new one will be fetched using"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FGD4%3D","line":66,"in_reply_to":"AAAAVn%2F%2FGVI%3D","updated":"2014-03-09 22:13:15.000000000","message":"We need kwargs on these functions for future expansion.","commit_id":"7c644c699646239052bde6d7e52c276078da9ea0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"373a545851e6b32a599cad9b1ac4a06ff3414f5e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \"\"\"Return a valid auth token."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        If a valid token is not present then a new one will be fetched using"},{"line_number":70,"context_line":"        the session and kwargs."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        :raises HTTPError: An error from an invalid HTTP response."},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FGVA%3D","line":70,"updated":"2014-03-09 20:42:19.000000000","message":"kwargs isn\u0027t used.","commit_id":"7c644c699646239052bde6d7e52c276078da9ea0"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"f8675520a3766809fae3c50828d67176775bffc3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \"\"\"Return a valid auth token."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        If a valid token is not present then a new one will be fetched using"},{"line_number":70,"context_line":"        the session and kwargs."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        :raises HTTPError: An error from an invalid HTTP response."},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B3Uk%3D","line":70,"in_reply_to":"AAAAVn%2F%2FGVA%3D","updated":"2014-03-22 14:07:34.000000000","message":"Yeah, this should be updated.","commit_id":"7c644c699646239052bde6d7e52c276078da9ea0"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"f8675520a3766809fae3c50828d67176775bffc3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        :returns AccessInfo: Valid AccessInfo"},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        if (not self.auth_ref or"},{"line_number":89,"context_line":"                self.auth_ref.will_expire_soon(self.MIN_TOKEN_LIFE_SECONDS)):"},{"line_number":90,"context_line":"            self.auth_ref \u003d self.get_auth_ref(session, **kwargs)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        return self.auth_ref"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B3Us%3D","line":89,"updated":"2014-03-22 14:07:34.000000000","message":"Is kwargs expected in other calls to get_access or can this use be removed too?","commit_id":"7c644c699646239052bde6d7e52c276078da9ea0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b5206043c88797deec918b7ee8fd0f4b2df7711d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \"\"\"Return a valid auth token."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        If a valid token is not present then a new one will be fetched using"},{"line_number":70,"context_line":"        the session and kwargs."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        :raises HTTPError: An error from an invalid HTTP response."},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BsZM%3D","line":70,"updated":"2014-03-25 01:28:41.000000000","message":"I still think this doc is inaccurate. The plugin could ignore the seesion and kwargs just like this implementation ignores kwargs.\n\nremove \"using the session and kwargs\"","commit_id":"7c4c21677762f5dacc21cfa5da2fd6a55da007bf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b5206043c88797deec918b7ee8fd0f4b2df7711d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"\"\"Fetch or return a current AccessInfo object."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        If a valid AccessInfo is present then it is returned otherwise session"},{"line_number":82,"context_line":"        is used to fetch a new one."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        :raises HTTPError: An error from an invalid HTTP response."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BsYk%3D","line":82,"updated":"2014-03-25 01:28:41.000000000","message":"can this method be overridden in a plugin, too?\n\nif so, the plugin might not use the session, so suggest remove this paragraph, since the implementation could always fetch a new token if it felt like it, and ignore the session.\n\nif not, how is anyone supposed to know what methods can be overridden and which can\u0027t be?","commit_id":"7c4c21677762f5dacc21cfa5da2fd6a55da007bf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"549d98dfc91b27fd975e1d9a0084be550937a2e8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        :returns AccessInfo: Token access information."},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_token(self, session, **kwargs):"},{"line_number":67,"context_line":"        \"\"\"Return a valid auth token."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        If a valid token is not present then a new one will be fetched."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BmqE%3D","line":66,"updated":"2014-03-25 16:08:54.000000000","message":"do we need to have **kwargs now that we aren\u0027t using it at line 75?","commit_id":"8040085bd5b68a8ccb144054c4afe577bb91d691"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d8a9238257b087fef444009ef2aea43e208aa54e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        :returns AccessInfo: Token access information."},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_token(self, session, **kwargs):"},{"line_number":67,"context_line":"        \"\"\"Return a valid auth token."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        If a valid token is not present then a new one will be fetched."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BmaE%3D","line":66,"in_reply_to":"AAAAWH%2F%2BmqE%3D","updated":"2014-03-25 16:32:27.000000000","message":"i\u0027m not really a fan of kwargs here in the first place :-/\n\nbut it seems like they should be considered for removal in a separate change considering it\u0027s a public method signature","commit_id":"8040085bd5b68a8ccb144054c4afe577bb91d691"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"549d98dfc91b27fd975e1d9a0084be550937a2e8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        return self.get_access(session).auth_token"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_access(self, session, **kwargs):"},{"line_number":78,"context_line":"        \"\"\"Fetch or return a current AccessInfo object."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        If a valid AccessInfo is present then it is returned otherwise a new"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Bmps%3D","line":77,"updated":"2014-03-25 16:08:54.000000000","message":"same comment here.","commit_id":"8040085bd5b68a8ccb144054c4afe577bb91d691"}]}