)]}'
{"id":"openstack%2Fpython-keystoneclient~77443","triplet_id":"openstack%2Fpython-keystoneclient~master~I291acea95871734a30192c2e4564267326f9c0a7","project":"openstack/python-keystoneclient","branch":"master","topic":"improve-help","hashtags":[],"change_id":"I291acea95871734a30192c2e4564267326f9c0a7","subject":"Improve help strings","status":"MERGED","created":"2014-03-02 18:19:49.000000000","updated":"2014-03-07 19:57:35.000000000","submitted":"2014-03-07 19:57:34.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"053771d6784e91071ad51418943eed2e6d0ec7ff","_number":77443,"virtual_id_number":77443,"owner":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-03-07 19:57:34.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":2,"date":"2014-03-07 16:48:47.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":2,"date":"2014-03-07 19:04:51.000000000","_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"date":"2014-03-07 16:48:47.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":1,"date":"2014-03-07 19:04:51.000000000","_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-03-03 01:20:45.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2014-03-07 16:48:47.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2014-03-07 19:04:51.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2014-03-07 19:57:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1590c474beab05c056a189441f556a478b0c7f95","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-02 18:19:50.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"db45e019918c842061281ac2337b73e94ad87364","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-02 19:16:26.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/43/77443/1/check/gate-python-keystoneclient-pep8/4d0656d : SUCCESS in 1m 07s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/43/77443/1/check/gate-python-keystoneclient-docs/4a8e8af/doc/build/html/ : SUCCESS in 1m 17s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/43/77443/1/check/gate-python-keystoneclient-python26/6f4cab8 : SUCCESS in 1m 17s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/43/77443/1/check/gate-python-keystoneclient-python27/4af7520 : SUCCESS in 48s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/43/77443/1/check/gate-python-keystoneclient-python33/50f1776 : SUCCESS in 3m 25s\n- check-devstack-dsvm-cells http://logs.openstack.org/43/77443/1/check/check-devstack-dsvm-cells/48c2bcb : SUCCESS in 10m 44s\n- check-tempest-dsvm-full http://logs.openstack.org/43/77443/1/check/check-tempest-dsvm-full/5471179 : SUCCESS in 56m 34s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/43/77443/1/check/check-tempest-dsvm-postgres-full/c4c4449 : SUCCESS in 47m 30s\n- check-tempest-dsvm-neutron http://logs.openstack.org/43/77443/1/check/check-tempest-dsvm-neutron/4f96bd7 : SUCCESS in 49m 14s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/43/77443/1/check/check-tempest-dsvm-neutron-full/9d71f44 : SUCCESS in 55m 40s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/43/77443/1/check/gate-tempest-dsvm-large-ops/c0264e1 : SUCCESS in 14m 43s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/43/77443/1/check/gate-tempest-dsvm-neutron-large-ops/c36881e : SUCCESS in 14m 28s\n- check-grenade-dsvm http://logs.openstack.org/43/77443/1/check/check-grenade-dsvm/9106dd1 : SUCCESS in 32m 31s\n","accounts_in_message":[],"_revision_number":1},{"id":"9528aee7d54b4984709107daa3441e3342c65329","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-03-03 01:20:45.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"2e6d7cba80b4e4b976bd3df94cbdaf4c7edb4535","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-07 15:22:24.000000000","message":"Patch Set 1: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"6d58388eabbc7ab410b9c0e81c886195c0960c6e","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2014-03-07 15:22:24.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"5ccc7c8d41d1e984865123643811200018875703","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-03-07 15:36:06.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(4 inline comments)\n\nIt would be great if this also updated the keystone man page text.","accounts_in_message":[],"_revision_number":1},{"id":"45a2c224280ffe59cff1f4e9ed0b89269e373449","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2014-03-07 16:34:18.000000000","message":"Patch Set 1:\n\nBrant, thanks for the review. I\u0027ll make the suggested changes.\n\nRegarding the man page: I just reviewed it and did not see what you want to have updated. Could you give me a pointer, please?","accounts_in_message":[],"_revision_number":1},{"id":"4fc39fc0cd380f92622ac482e4ed9ce4dd3d0168","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2014-03-07 16:34:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5a35d01c16aeec101ef718dcb2c1d226a46fcca4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-07 16:34:37.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"4f9542401b465698333591baa7f96fc5873dc87b","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2014-03-07 16:48:47.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nMy comments were addressed. I checked the man page and we don\u0027t put the options there like we do with the keystone-all man page.","accounts_in_message":[],"_revision_number":2},{"id":"fe41c04f6402f49682d39302deebb26044f24bd0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-07 18:03:12.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/43/77443/2/check/gate-python-keystoneclient-pep8/55587a5 : SUCCESS in 1m 25s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/43/77443/2/check/gate-python-keystoneclient-docs/b188743/doc/build/html/ : SUCCESS in 1m 28s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/43/77443/2/check/gate-python-keystoneclient-python26/65e2f30 : SUCCESS in 1m 34s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/43/77443/2/check/gate-python-keystoneclient-python27/9dbad8a : SUCCESS in 1m 00s\n- check-grenade-dsvm http://logs.openstack.org/43/77443/2/check/check-grenade-dsvm/31aba9b : SUCCESS in 38m 01s\n- check-tempest-dsvm-full http://logs.openstack.org/43/77443/2/check/check-tempest-dsvm-full/044d70e : SUCCESS in 49m 58s\n- check-tempest-dsvm-neutron http://logs.openstack.org/43/77443/2/check/check-tempest-dsvm-neutron/132a6dc : SUCCESS in 1h 22m 57s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/43/77443/2/check/gate-python-keystoneclient-python33/db9cfcf : SUCCESS in 3m 17s\n- check-devstack-dsvm-cells http://logs.openstack.org/43/77443/2/check/check-devstack-dsvm-cells/22d7046 : SUCCESS in 14m 32s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/43/77443/2/check/check-tempest-dsvm-postgres-full/465a044 : SUCCESS in 58m 36s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/43/77443/2/check/check-tempest-dsvm-neutron-full/2642907 : SUCCESS in 52m 30s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/43/77443/2/check/gate-tempest-dsvm-large-ops/b15df40 : SUCCESS in 14m 56s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/43/77443/2/check/gate-tempest-dsvm-neutron-large-ops/906337b : SUCCESS in 18m 35s\n","accounts_in_message":[],"_revision_number":2},{"id":"8225fd55967651346cba0bb8027e50b943ac4096","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2014-03-07 19:04:51.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"7216fd5e587aa699cd447cb848ee0453c414e388","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-07 19:04:55.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"f340b56a4b8f1264f6aece823d88150cc5f85e2c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-07 19:57:34.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/43/77443/2/gate/gate-python-keystoneclient-docs/5470a49/doc/build/html/ : SUCCESS in 1m 27s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/43/77443/2/gate/gate-python-keystoneclient-pep8/5b434cf : SUCCESS in 1m 28s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/43/77443/2/gate/gate-python-keystoneclient-python26/73b9b86 : SUCCESS in 8m 30s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/43/77443/2/gate/gate-python-keystoneclient-python27/9c709c2 : SUCCESS in 1m 07s\n- gate-grenade-dsvm http://logs.openstack.org/43/77443/2/gate/gate-grenade-dsvm/ab9b2cc : SUCCESS in 28m 33s\n- gate-tempest-dsvm-full http://logs.openstack.org/43/77443/2/gate/gate-tempest-dsvm-full/925402b : SUCCESS in 51m 26s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/43/77443/2/gate/gate-tempest-dsvm-neutron/8ccd062 : SUCCESS in 39m 09s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/43/77443/2/gate/gate-python-keystoneclient-python33/b353e42 : SUCCESS in 3m 15s\n- gate-devstack-dsvm-cells http://logs.openstack.org/43/77443/2/gate/gate-devstack-dsvm-cells/1707d1c : SUCCESS in 10m 09s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/43/77443/2/gate/gate-tempest-dsvm-postgres-full/1563ab6 : SUCCESS in 49m 49s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/43/77443/2/gate/gate-tempest-dsvm-large-ops/4631bca : SUCCESS in 15m 43s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/43/77443/2/gate/gate-tempest-dsvm-neutron-large-ops/06d8515 : SUCCESS in 15m 45s\n","accounts_in_message":[],"_revision_number":2},{"id":"430525c045b954f76c1d2e5989a67a1421169466","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-07 19:57:35.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0ffd47266007c9d002f26829be527e3ebf2d6297","revisions":{"f1d5f7c196c14e0e7c554cf068504ed344ea9832":{"kind":"REWORK","_number":1,"created":"2014-03-02 18:19:49.000000000","uploader":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"ref":"refs/changes/43/77443/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/43/77443/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/43/77443/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/43/77443/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/43/77443/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/43/77443/1"}}},"commit":{"parents":[{"commit":"3a6d47c1540e9e5b75be064a2273eb52831192ec","subject":"Merge \"Remove redundant default value None for dict.get\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3a6d47c1540e9e5b75be064a2273eb52831192ec"}]}],"author":{"name":"Andreas Jaeger","email":"aj@suse.de","date":"2014-03-02 18:17:37.000000000","tz":60},"committer":{"name":"Andreas Jaeger","email":"aj@suse.de","date":"2014-03-02 18:19:06.000000000","tz":60},"subject":"Improve help strings","message":"Improve help strings\n\nImprove consistency of help strings:\n* Add \".\" at end of help strings and descriptions.\n* Improve descriptions.\n* Fix capitalization.\n\nChange-Id: I291acea95871734a30192c2e4564267326f9c0a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f1d5f7c196c14e0e7c554cf068504ed344ea9832"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f1d5f7c196c14e0e7c554cf068504ed344ea9832"}]},"branch":"refs/heads/master"},"0ffd47266007c9d002f26829be527e3ebf2d6297":{"kind":"REWORK","_number":2,"created":"2014-03-07 16:34:36.000000000","uploader":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"ref":"refs/changes/43/77443/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/43/77443/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/43/77443/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/43/77443/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/43/77443/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/43/77443/2"}}},"commit":{"parents":[{"commit":"b935741f6c93abae1c7aac41da92b475bbe14815","subject":"Atomic write of certificate files and revocation list","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b935741f6c93abae1c7aac41da92b475bbe14815"}]}],"author":{"name":"Andreas Jaeger","email":"aj@suse.de","date":"2014-03-02 18:17:37.000000000","tz":60},"committer":{"name":"Andreas Jaeger","email":"aj@suse.de","date":"2014-03-07 16:34:02.000000000","tz":60},"subject":"Improve help strings","message":"Improve help strings\n\nImprove consistency of help strings:\n* Add \".\" at end of help strings and descriptions.\n* Improve descriptions.\n* Fix capitalization.\n\nChange-Id: I291acea95871734a30192c2e4564267326f9c0a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0ffd47266007c9d002f26829be527e3ebf2d6297"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/0ffd47266007c9d002f26829be527e3ebf2d6297"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}