)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"736fa1e0104302e11f6ff4208559016a00979987","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact: auth_schema, auth_host, auth_port, auth_admin_prefix are all"},{"line_number":15,"context_line":"deprecated in favour of specifying the full url in the identity_uri"},{"line_number":16,"context_line":"property."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1f8f5064ea8028af60f167df9b97e215cdadba44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2BcnU%3D","line":16,"updated":"2014-03-26 18:09:55.000000000","message":"Bug or BP would be good.","commit_id":"8b081893435cfc8a11b4f9d70e67730b460f750c"}],"keystoneclient/middleware/auth_token.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"736fa1e0104302e11f6ff4208559016a00979987","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    cfg.StrOpt(\u0027auth_admin_prefix\u0027,"},{"line_number":202,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":203,"context_line":"               help\u003d\u0027Prefix to prepend at the beginning of the path. \u0027"},{"line_number":204,"context_line":"                    \u0027Deprecated, use identity_uri.\u0027),"},{"line_number":205,"context_line":"    cfg.StrOpt(\u0027auth_host\u0027,"},{"line_number":206,"context_line":"               default\u003d\u0027127.0.0.1\u0027,"},{"line_number":207,"context_line":"               help\u003d\u0027Host providing the admin Identity API endpoint. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BcnM%3D","line":204,"updated":"2014-03-26 18:09:55.000000000","message":"Shouldn\u0027t we be using the \"deprecated\" nomenclature in oslo.config? like how the oslo.db deprecated options.","commit_id":"8b081893435cfc8a11b4f9d70e67730b460f750c"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"ebc29d3c8f65760c11e8705fd51cbf67fdaddf90","unresolved":false,"context_lines":[{"line_number":221,"context_line":"               # accessible identity endpoint (see bug 1207517)"},{"line_number":222,"context_line":"               help\u003d\u0027Complete public Identity API endpoint\u0027),"},{"line_number":223,"context_line":"    cfg.StrOpt(\u0027identity_uri\u0027,"},{"line_number":224,"context_line":"               default\u003dNone,"},{"line_number":225,"context_line":"               help\u003d\u0027Complete admin Identity API endpoint. This should \u0027"},{"line_number":226,"context_line":"                    \u0027specify the unversioned root endpoint \u0027"},{"line_number":227,"context_line":"                    \u0027eg. https://localhost:35357/\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Bmeo%3D","line":224,"updated":"2014-03-25 16:28:43.000000000","message":"shouldn\u0027t this default to https://127.0.0.1:35357/ while the deprecated options default to None and raise warnings when they\u0027re set? (it seems like the deprecation approach here is backwards)","commit_id":"8b081893435cfc8a11b4f9d70e67730b460f750c"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"09e2dbfd8987f36e96c89cf8e635d79ec1c67859","unresolved":false,"context_lines":[{"line_number":221,"context_line":"               # accessible identity endpoint (see bug 1207517)"},{"line_number":222,"context_line":"               help\u003d\u0027Complete public Identity API endpoint\u0027),"},{"line_number":223,"context_line":"    cfg.StrOpt(\u0027identity_uri\u0027,"},{"line_number":224,"context_line":"               default\u003dNone,"},{"line_number":225,"context_line":"               help\u003d\u0027Complete admin Identity API endpoint. This should \u0027"},{"line_number":226,"context_line":"                    \u0027specify the unversioned root endpoint \u0027"},{"line_number":227,"context_line":"                    \u0027eg. https://localhost:35357/\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BlPQ%3D","line":224,"in_reply_to":"AAAAWH%2F%2Bmeo%3D","updated":"2014-03-25 18:40:01.000000000","message":"We are saying that if identity_url is set then we ignore everything in auth_host etc in favour of it. So we need a way to distinguish if it has been set by the user as opposed to picking up the default.","commit_id":"8b081893435cfc8a11b4f9d70e67730b460f750c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e0f7d02e669802343947e1eb4e08bacc17fe82dd","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                    \u0027eg. https://localhost:35357/\u0027),"},{"line_number":228,"context_line":"    cfg.StrOpt(\u0027auth_version\u0027,"},{"line_number":229,"context_line":"               default\u003dNone,"},{"line_number":230,"context_line":"               help\u003d\u0027API version of the admin Identity API endpoint\u0027),"},{"line_number":231,"context_line":"    cfg.BoolOpt(\u0027delay_auth_decision\u0027,"},{"line_number":232,"context_line":"                default\u003dFalse,"},{"line_number":233,"context_line":"                help\u003d\u0027Do not handle authorization requests within the\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Buug%3D","line":230,"updated":"2014-03-24 19:03:45.000000000","message":"shouldn\u0027t we be deprecating this one as well?","commit_id":"8b081893435cfc8a11b4f9d70e67730b460f750c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"11b3e1ae2f62df1ab889437c78607d2bc4384a11","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                    \u0027eg. https://localhost:35357/\u0027),"},{"line_number":228,"context_line":"    cfg.StrOpt(\u0027auth_version\u0027,"},{"line_number":229,"context_line":"               default\u003dNone,"},{"line_number":230,"context_line":"               help\u003d\u0027API version of the admin Identity API endpoint\u0027),"},{"line_number":231,"context_line":"    cfg.BoolOpt(\u0027delay_auth_decision\u0027,"},{"line_number":232,"context_line":"                default\u003dFalse,"},{"line_number":233,"context_line":"                help\u003d\u0027Do not handle authorization requests within the\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BlsU%3D","line":230,"in_reply_to":"AAAAWH%2F%2Btvw%3D","updated":"2014-03-25 17:50:05.000000000","message":"that\u0027s fine. You mentioned identity_uri should be unversioned above so I thought this property has no effect anyway.","commit_id":"8b081893435cfc8a11b4f9d70e67730b460f750c"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"d2a98483a6843b697ac1a638af4fa32e8cdff473","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                    \u0027eg. https://localhost:35357/\u0027),"},{"line_number":228,"context_line":"    cfg.StrOpt(\u0027auth_version\u0027,"},{"line_number":229,"context_line":"               default\u003dNone,"},{"line_number":230,"context_line":"               help\u003d\u0027API version of the admin Identity API endpoint\u0027),"},{"line_number":231,"context_line":"    cfg.BoolOpt(\u0027delay_auth_decision\u0027,"},{"line_number":232,"context_line":"                default\u003dFalse,"},{"line_number":233,"context_line":"                help\u003d\u0027Do not handle authorization requests within the\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Btvw%3D","line":230,"in_reply_to":"AAAAWH%2F%2Buug%3D","updated":"2014-03-24 21:46:38.000000000","message":"possibly later, however auth_version is not used as part of constructing the URL so it wouldn\u0027t be a part of this patch.","commit_id":"8b081893435cfc8a11b4f9d70e67730b460f750c"}],"keystoneclient/tests/test_auth_token_middleware.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e0f7d02e669802343947e1eb4e08bacc17fe82dd","unresolved":false,"context_lines":[{"line_number":465,"context_line":"    def test_valid_uuid_request_with_identity_uri(self):"},{"line_number":466,"context_line":"        for opt in [\u0027auth_host\u0027, \u0027auth_port\u0027, \u0027auth_protocol\u0027,"},{"line_number":467,"context_line":"                    \u0027auth_admin_prefix\u0027]:"},{"line_number":468,"context_line":"            del self.conf[opt]"},{"line_number":469,"context_line":"        self.conf[\u0027identity_uri\u0027] \u003d \\"},{"line_number":470,"context_line":"            \u0027https://keystone.example.com:1234/testadmin/\u0027"},{"line_number":471,"context_line":"        self.set_middleware()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BuuI%3D","line":468,"updated":"2014-03-24 19:03:45.000000000","message":"you can keep those options in there as they should be ignored anyway","commit_id":"8b081893435cfc8a11b4f9d70e67730b460f750c"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"022c228b12401d796b8305dfaf42c74f42328d4b","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        for opt in [\u0027auth_host\u0027, \u0027auth_port\u0027, \u0027auth_protocol\u0027,"},{"line_number":529,"context_line":"                    \u0027auth_admin_prefix\u0027]:"},{"line_number":530,"context_line":"            del self.conf[opt]"},{"line_number":531,"context_line":"        self.conf[\u0027identity_uri\u0027] \u003d \\"},{"line_number":532,"context_line":"            \u0027https://keystone.example.com:1234/testadmin/\u0027"},{"line_number":533,"context_line":"        self.set_middleware()"},{"line_number":534,"context_line":"        self.assert_valid_request_200(self.token_dict[\u0027uuid_token_default\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BFwU%3D","line":531,"updated":"2014-03-30 14:36:34.000000000","message":"use () to continue a line rather than \\","commit_id":"708886b2c6bdd150c4d3dae16fb8807c19f7403c"}]}